cmcmahon [Thu, 15 May 2014 17:40:01 +0000 (10:40 -0700)]
browser acceptance tests
Apropos of https://www.mediawiki.org/wiki/Wikimedia_Release_and_QA_Team/Quarterly_review,_April_2014#Action_items
Tests pass on a bare wiki install, beta enwiki, beta dewiki, beta hewiki
Bug: 66272
Ported create_account.feature and supporting files from /qa/browsertest without needing updates
Change-Id: I2b4bfa512a33ff31cc0369dfd9ec19cb875d5e36
Brad Jorsch [Wed, 28 May 2014 16:12:59 +0000 (12:12 -0400)]
Add release notes for Ie3f7273c
Change-Id: Id39c4d779d138493a2a7a1db2cc4388b125e5bb5
Jackmcbarn [Sat, 24 May 2014 23:21:33 +0000 (19:21 -0400)]
Allow filtering log entries by namespace (API)
Add parameter lenamespace to the API, allowing filtering of log entries by
namespace.
Change-Id: I53c4c6411e0b9e6383969afced0e4c193f1b64a1
Aaron Schulz [Tue, 27 May 2014 17:36:04 +0000 (10:36 -0700)]
Tweaked HTMLCacheUpdate immediate run treshold
Change-Id: I123c27862821e01fe232f55d984905fcda2a2498
Aaron Schulz [Tue, 27 May 2014 18:21:07 +0000 (11:21 -0700)]
Reduce Title::invalidateCache contention a bit
* Lots of deadlocks seems to happen on page deletion,
where the ID is likely 0 (this also has the worst locks)
bug: 37519
Change-Id: I028783a998946615b93e1425c6f69e00afd7b1bb
Bryan Davis [Fri, 21 Mar 2014 04:10:46 +0000 (22:10 -0600)]
Add Composer managed libraries
This is the initial step towards implementing the Structured logging RFC
[0].
The Psr\Log library is declared as a requirement in the composer.json
file and Monolog is suggested as a package that can enhance MediaWiki.
To use this in a local checkout:
* Install composer [1]
* `composer update`
* `composer require monolog/monolog 1.9.*`
* `composer dump-autoload --optimize`
* `git update-index --assume-unchanged composer.json`
Additional work will be needed to provide both the Psr\Log and Monolog
libraries available for deployment to the Wikimedia Foundation servers.
The Psr\Log library will also need to be packaged in the release
tarballs.
[0]: https://www.mediawiki.org/wiki/Requests_for_comment/Structured_logging
[1]: https://getcomposer.org/doc/00-intro.md#installation-nix
See also: I1431b24 (Monolithic implementation)
Change-Id: Ie667944416187cfd2ae6016c9e2fa28f4204bcd7
jenkins-bot [Wed, 28 May 2014 00:25:02 +0000 (00:25 +0000)]
Merge "Add missing possible errors to ApiRollback.php"
James D. Forrester [Tue, 27 May 2014 22:41:46 +0000 (15:41 -0700)]
Update OOjs UI to v0.1.0-pre (
7b283a9dcc)
New changes:
71d9671 Add more Agora dialogs styling
457a0ef Localisation updates from https://translatewiki.net.
c92ba96 Compute directionality for frame correctly
f3414b8 Localisation updates from https://translatewiki.net.
90fbb6f Localisation updates from https://translatewiki.net.
1d4d52a Localisation updates from https://translatewiki.net.
08d1c7b Add ability to put a header at the top of a toolGroup pop-up
Change-Id: I6f4adbca80abeec0931380233e0e45a9f45af330
Translation updater bot [Tue, 27 May 2014 19:50:28 +0000 (19:50 +0000)]
Localisation updates from https://translatewiki.net.
Change-Id: I1ac7593bbc66a78e74a62ea03bab4fd105728a28
jenkins-bot [Tue, 27 May 2014 19:17:49 +0000 (19:17 +0000)]
Merge "Remove Vector from the default LESS import path"
Daniel Friesen [Fri, 9 May 2014 15:18:45 +0000 (08:18 -0700)]
Remove Vector from the default LESS import path
When Ia193571a added Vector to core for VectorBeta's benefit it introduced
a regression that broke all skins that used imports like 'variables.less'
which happen to match a filename used by Vector.
These paths aren't supposed to be exposed anyway, and VectorBeta has been
fixed to no longer rely on this.
Bug: 64595
Change-Id: Iee47bdc23630e02ccfcbd28496ec5268892eb629
jenkins-bot [Tue, 27 May 2014 19:05:17 +0000 (19:05 +0000)]
Merge "Enable mediawiki.skinning.content.parsoid on Mobile target too"
jenkins-bot [Tue, 27 May 2014 18:54:09 +0000 (18:54 +0000)]
Merge "Remove "Help/Project" profile from Special:Search"
jenkins-bot [Tue, 27 May 2014 18:53:00 +0000 (18:53 +0000)]
Merge "Remove silly 'm' prefix from StubObject/DeprecatedGlobal members"
jenkins-bot [Tue, 27 May 2014 18:51:46 +0000 (18:51 +0000)]
Merge "Move Modern and CologneBlue out of core"
James D. Forrester [Tue, 27 May 2014 18:41:38 +0000 (11:41 -0700)]
Enable mediawiki.skinning.content.parsoid on Mobile target too
Bug: 65823
Change-Id: Iee2e3d00576556418c666d393e8935f75801326c
jenkins-bot [Tue, 27 May 2014 18:31:05 +0000 (18:31 +0000)]
Merge "Introduce ContentHandler::exportTransform()"
jrobson [Thu, 20 Mar 2014 22:10:05 +0000 (15:10 -0700)]
Move Modern and CologneBlue out of core
Import in the new repositories:
- Modern: I5348fedddf14affcee2688833f4e759e5af6499c
- CologneBlue: I9cc051f48074a033c684e5efa56a7b4dde51d366
Change-Id: I65768b4c29faf46895a7005a3090f43cf6e86258
jenkins-bot [Tue, 27 May 2014 18:26:19 +0000 (18:26 +0000)]
Merge "Introduce ContentHandler::importTransform."
jenkins-bot [Tue, 27 May 2014 18:17:02 +0000 (18:17 +0000)]
Merge "Cleaned up database reconnection logic"
jenkins-bot [Tue, 27 May 2014 18:15:37 +0000 (18:15 +0000)]
Merge "Installer: output css correctly when session errors occur"
jenkins-bot [Tue, 27 May 2014 17:39:08 +0000 (17:39 +0000)]
Merge "Use language from context in Skin::subPageSubtitle"
jenkins-bot [Tue, 27 May 2014 16:00:14 +0000 (16:00 +0000)]
Merge "Add ar_text to the list from Revision::selectArchiveFields(). It is checked later."
jenkins-bot [Tue, 27 May 2014 14:53:08 +0000 (14:53 +0000)]
Merge "Fix docs on File::getImageSize() they were very misleading"
jenkins-bot [Tue, 27 May 2014 14:50:51 +0000 (14:50 +0000)]
Merge "Revert more visibility changes in HistoryBlob.php"
jenkins-bot [Tue, 27 May 2014 14:50:29 +0000 (14:50 +0000)]
Merge "Don't use isset() to check for null"
Joerg [Tue, 27 May 2014 13:37:09 +0000 (09:37 -0400)]
Add ar_text to the list from Revision::selectArchiveFields(). It is checked later.
See Revision::newFromArchiveRow(). This is called from
populateRevisionLength.php's upgradeRow() which ultimately populates
$row from the fields returned by Revision::selectArchiveFields().
Revision::newFromArchiveRow() has the following condition:
if ( isset( $row->ar_text ) && !$row->ar_text_id ) {
And from the bug report:
> for old archived revisions, the rows in the archive table do _not_
> contain a pointer to the text in the text table, but that the text
> is stored in the archive table directly. Obviously the above code
> cannot handle this situation properly.
Credit goes to Joerg who found this and figured out the problem.
Bug: 65765
Change-Id: Iadcaae5e531d439780f5b6095286df78926ccaa7
jenkins-bot [Tue, 27 May 2014 10:55:04 +0000 (10:55 +0000)]
Merge "Change one Linker::formatSize call to Message::sizeParams"
jenkins-bot [Tue, 27 May 2014 10:46:18 +0000 (10:46 +0000)]
Merge "DBConnectionError: Expand {{SITENAME}} in pagetitle with Message::text()"
jenkins-bot [Tue, 27 May 2014 09:12:15 +0000 (09:12 +0000)]
Merge "Restructure Media related tests to avoid duplicated code"
Brian Wolff [Mon, 26 May 2014 20:16:07 +0000 (17:16 -0300)]
Restructure Media related tests to avoid duplicated code
Change-Id: I4428d38e0199b12255f3746e79f8093259a03da1
jenkins-bot [Tue, 27 May 2014 08:43:55 +0000 (08:43 +0000)]
Merge "Fix doc comments on get[General](Short|Long)Desc"
jenkins-bot [Tue, 27 May 2014 05:10:29 +0000 (05:10 +0000)]
Merge "SpecialRevisiondelete: Simplify if/elseif logic"
umherirrender [Mon, 26 May 2014 18:21:10 +0000 (20:21 +0200)]
SpecialRevisiondelete: Simplify if/elseif logic
This avoids checking $comment twice
by Krinkle on I3b21f66f84d68777a18e66e4e5f59886e55d7936
Change-Id: I39df27d3edb097024d136455145505429ccdbe39
jenkins-bot [Tue, 27 May 2014 04:23:35 +0000 (04:23 +0000)]
Merge "DerivativeContext::setConfig should take a Config object"
jenkins-bot [Tue, 27 May 2014 02:43:24 +0000 (02:43 +0000)]
Merge "Allow more flexibility in RC feeds"
Kunal Mehta [Tue, 27 May 2014 02:36:59 +0000 (19:36 -0700)]
DerivativeContext::setConfig should take a Config object
Change-Id: Icc16a9c206c57fac2d26547cb874e02ef09c0485
Follows-Up: I13baec0b6d4ea7badf20b9c5f9b40846348838e4
Kunal Mehta [Tue, 27 May 2014 00:50:11 +0000 (17:50 -0700)]
Allow more flexibility in RC feeds
The user can now specify which feeds to send to in
RecentChange::notifyFeeds if they don't want to use
$wgRCFeeds.
Additionally, the 'formatter' in $wgRCFeeds can now be an object
rather than just a class name.
Change-Id: Ibfdffc17a934e35223887c123331795563102752
jenkins-bot [Tue, 27 May 2014 01:43:39 +0000 (01:43 +0000)]
Merge "Make abstract Config class truly implementation-agnostic"
Translation updater bot [Mon, 26 May 2014 19:58:28 +0000 (19:58 +0000)]
Localisation updates from https://translatewiki.net.
Change-Id: Idab23e6c2f532b1aae67dc15e9138f6602c15a0f
umherirrender [Mon, 26 May 2014 19:09:25 +0000 (21:09 +0200)]
Use language from context in Skin::subPageSubtitle
Change-Id: Ia6cff8aa9e0b12215839f8b9c5a64a09150d4002
umherirrender [Mon, 26 May 2014 19:00:02 +0000 (21:00 +0200)]
Change one Linker::formatSize call to Message::sizeParams
Change-Id: I2a91f0ef1cf82360da2d17c7dc42633ae3e79100
Kevin Israel [Mon, 26 May 2014 17:40:34 +0000 (13:40 -0400)]
DBConnectionError: Expand {{SITENAME}} in pagetitle with Message::text()
Follows-up
485ff9ead94b by making the same change in DBConnectionError,
which overrides MWException::msg() to not use database messages.
Bug: 58447
Change-Id: Iafa9dd741f1f099a4a6cfb8cf655b7d5f504011a
Kunal Mehta [Sat, 10 May 2014 08:19:00 +0000 (01:19 -0700)]
Make abstract Config class truly implementation-agnostic
Follow up to I13baec0b6 ("Config: Add Config and GlobalConfig classes"):
Config:
* Rather than returning Status objects, Config::set will now throw an exception
if an error is encountered
* Config::factory was moved into it's own ConfigFactory class.
* Since there are no more functions in it, Config was turned into an interface.
GlobalConfig:
* Remove $prefix args from Config::set and ::get. The idea of having an
abstract Config class is to abstract some notion of configuration data from
the particular way in which it is currently implemented (global variables).
So the abstract base class has no business dealing with variable name
prefixes.
** Instead GlobalVarConfig's implementations of get and set call getWithPrefix
and setWithPrefix internally, which are now protected
* Rename GlobalConfig to GlobalVarConfig, which makes it clearer that it isn't
referring to the scope of the configuration value, but to the scope of the
variable name which provides it.
ConfigFactory:
* ConfigFactory is where Config objects are registered, and later constructed.
* Config objects are registered with a given name, and a callback factory function.
This allows for implementations to construct the object with the parameters they want,
and avoids the overhead of needing an entire class.
** The name 'main' is the default object returned by RequestContext::getConfig(),
and is intended to be used by core.
* This is a singleton class, the main instance can be obtained with:
ConfigFactory::getDefaultInstance()
In addition to the above:
* $wgConfigClass was removed, and $wgConfigRegistry was introduced, which
stores a name => callback. The name is to be what the Config instance is
registered with, and the callback should return an implementation of Config.
* Tests were written for the new ConfigFactory, and GlobalVarConfig's tests
were improved.
Co-Authored-By: Ori Livneh <ori@wikimedia.org>
Co-Authored-By: Chad Horohoe <chadh@wikimedia.org>
Co-Authored-By: Mattflaschen <mflaschen@wikimedia.org>
Co-Authored-By: Parent5446 <tylerromeo@gmail.com>
Co-Authored-By: Reedy <reedy@wikimedia.org>
Co-Authored-By: Daniel Kinzler <daniel.kinzler@wikimedia.de>
Change-Id: I5a5857fcfa07598ba4ce9ae5bbb4ce54a567d31e
jenkins-bot [Mon, 26 May 2014 08:57:48 +0000 (08:57 +0000)]
Merge "Return value directly when using getter"
jenkins-bot [Sun, 25 May 2014 23:36:31 +0000 (23:36 +0000)]
Merge "Revert "Pass phpcs-strict on includes/revisiondelete/""
Kevin Israel [Sun, 25 May 2014 13:12:00 +0000 (09:12 -0400)]
Revert more visibility changes in HistoryBlob.php
This follows-up
bebcf2c58381, which only fixed DiffHistoryBlob.
MediaWiki will fail to load some revisions if the following properties
do not unserialize correctly:
* HistoryBlobStub::$mOldId
* HistoryBlobStub::$mHash
* HistoryBlobCurStub::$mCurId
Visibility of HistoryBlobStub::$mRef is also restored; though the
property's value does not appear to be used after unserialization,
the property is nevertheless a serialized property.
Bug: 65665
Change-Id: I2724d15f9206d66d615d020117e60bb772048c19
Translation updater bot [Sun, 25 May 2014 19:24:39 +0000 (19:24 +0000)]
Localisation updates from https://translatewiki.net.
Change-Id: I5fcddad181c862b8f825611aa2aa3a17864e1b28
Pcoombe [Tue, 15 Apr 2014 14:58:51 +0000 (15:58 +0100)]
HTMLForm: fix double escaping of checkbox labels in vform
mLabel has already been escaped if required. It isn't run through htmlspecialchars()
in other display formats, so doesn't need to be done in vform.
Change-Id: I0b0feec408687cdadf01da5f2078980015538bb7
jenkins-bot [Sun, 25 May 2014 07:45:03 +0000 (07:45 +0000)]
Merge "Fix broken @return documentation"
jenkins-bot [Sun, 25 May 2014 06:28:53 +0000 (06:28 +0000)]
Merge "Removed double hook explanation AfterFinalPageOutput"
florianschmidtwelzow [Sun, 25 May 2014 06:23:02 +0000 (08:23 +0200)]
Removed double hook explanation AfterFinalPageOutput
Bug: 65690
Change-Id: I0990568875db854579974f611e7378bca0b0eaed
Brian Wolff [Sun, 25 May 2014 01:38:41 +0000 (01:38 +0000)]
Revert "Pass phpcs-strict on includes/revisiondelete/"
Causes fatal when using revdeleting an old image
This reverts commit
2e8ec52154ad33680f92c3bf49d3b35ed5a33153.
Bug: 65733
Change-Id: I948cbf0f9a60929020d8cd92f4264bee7a11104e
jenkins-bot [Sat, 24 May 2014 21:28:02 +0000 (21:28 +0000)]
Merge "jquery.makeCollapsible: Use .prop() for value attribute of list item"
Timo Tijhof [Sat, 24 May 2014 01:27:25 +0000 (03:27 +0200)]
jquery.makeCollapsible: Use .prop() for value attribute of list item
The issue with "value" attributes is popularised through form
fields (e.g. change <input> value with prop, because it doesn't work
with attribute, attributes only change the DOM, not the live rendering).
However the attribute/property issue isn't limited to form fields and the
typical value/selected/disabled properties . It applies to all properties
and for any element that affects active state (if it changes the display,
one should use a property, not an attribute).
As far as I know, unlike for form fields, browsers do actually synchronise
attributes in the many of those cases (including list items), so there is
no immediate danger. But since it's caught by jQuery Migrate and a good
practice regardless, change it to use prop() as well.
To test:
https://test.wikipedia.org/?oldid=199994#head-collapsible-ol
Change-Id: I246c26bd2958209feed73fc2ef31cf678b12fa3b
Thiemo Mättig [Sat, 24 May 2014 20:06:01 +0000 (22:06 +0200)]
Fix broken @return documentation
I found one of these in Wikibase and run a global search.
Change-Id: I76c1519a47d7222f136272c59ea454b650808a86
Brian Wolff [Sat, 24 May 2014 19:10:46 +0000 (16:10 -0300)]
Fix doc comments on get[General](Short|Long)Desc
Follow up
f3cc3980bc78afdb where somehow I managed to do this.
Change-Id: I25e5a01ddbecd1a991f6d121a7ac3f3598004b25
Brian Wolff [Sat, 24 May 2014 17:27:36 +0000 (14:27 -0300)]
Fix docs on File::getImageSize() they were very misleading
Change-Id: I2a3e1e8c10da7ade4ea713a561e05fd4ab9203c8
Translation updater bot [Sat, 24 May 2014 15:26:57 +0000 (15:26 +0000)]
Merge "Localisation updates from https://translatewiki.net."
jenkins-bot [Sat, 24 May 2014 15:06:02 +0000 (15:06 +0000)]
Merge "Revert "Restore search box tabindex""
Translation updater bot [Sat, 24 May 2014 15:03:00 +0000 (15:03 +0000)]
Localisation updates from https://translatewiki.net.
Change-Id: I978097374e44627aeb91f6fe740899be0ae29e97
Mattflaschen [Sat, 24 May 2014 14:54:42 +0000 (14:54 +0000)]
Revert "Restore search box tabindex"
This does not restore the same behavior as collapsibleNav.js had. That
used $( document ).lastTabIndex() + 1 in JavaScript. This means it
would dynamically put the search box's tabindex after other elements.
This commit specified an explicit value of 1. This is normally used
for forms. For example, 1 is the username field on Special:UserLogin.
Thus, this made tabbing from the username field take you to the search
input. It also caused issues with at least MassMessage.
Another solution is necessary, whether it's dynamically adding it with
JavaScript as before, using a different PHP-generated tabindex, both
(PHP-generated tabindex overridden by JavaScript), or something else.
In the meantime, this reverts to avoid the mentioned regressions.
This reverts commit
be76751e8c7a8c33b8a9f41faba78592a22ded09.
Bug: 29199
Bug: 65704
Change-Id: Iaea60834aa8f1564aca50c21ee62ae01f958cc65
Alexandre Emsenhuber [Sat, 24 May 2014 05:45:33 +0000 (07:45 +0200)]
Don't use isset() to check for null
Fixes in includes/specials
Change-Id: I6c382aeaa92372bc11220694c479006e3c658362
Alexandre Emsenhuber [Sat, 24 May 2014 05:32:16 +0000 (07:32 +0200)]
Remove not-working scripts in maintenance/language
Change-Id: Idd6b1d5dc93a5bd71f0ad7445ce2f6ddc4beeb33
Adam Roses Wight [Wed, 21 May 2014 08:01:36 +0000 (01:01 -0700)]
Correct a comment about updateRevisionOn
to reflect its compare-and-swap semantics.
Change-Id: I6a68e673195e0b6688f6fbc9199a8355b20c0da0
Jackmcbarn [Sat, 24 May 2014 04:18:53 +0000 (00:18 -0400)]
Check category-move-redirect-override in content language
When testing whether category-redirect-move-override is disabled, do it in
the content language rather than the user language.
Change-Id: Id1f03240c203f32a12953f49a075cfd5c25f0f31
jenkins-bot [Sat, 24 May 2014 04:01:22 +0000 (04:01 +0000)]
Merge "mediawiki.test.js: Suppress false postives for deprecated mw.* properties"
Roan Kattouw [Sat, 24 May 2014 03:02:16 +0000 (20:02 -0700)]
Followup
dd1c7f7fd7: fix LESSification errors in Parsoid styles
.mw-halign-right should probably have float: right;, not float: left;
Also, use & because .mw-halign-* are applied to <figure>, not its descendants.
Bug: 65596
Change-Id: I7cd00f0049523f064703d7355b80457a4ab5d0d0
Timo Tijhof [Sat, 24 May 2014 01:33:55 +0000 (03:33 +0200)]
mediawiki.test.js: Suppress false postives for deprecated mw.* properties
[qunit]
mediawiki.jscompat...OK
mediawiki - Initial check...
Use of "anonymous" is deprecated. Use mw.user.isAnon instead.
Use of "name" is deprecated. Use mw.user.getName instead.
Use of "jsMessage" is deprecated. Use mw.notify instead.
Use of "wikiGetlink" is deprecated. Use mw.util.getUrl instead.
OK
mediawiki - mw.Map...OK
mediawiki - mw.config...OK
mediawiki - mw.msg...OK
mediawiki - mw.loader...OK
Change-Id: I4a79bc64cc26c1237fefe1503504cde9d40a5087
James D. Forrester [Sat, 24 May 2014 00:28:10 +0000 (17:28 -0700)]
jquery.autoEllipsis.test: Swap $.browser for $.client for compatibility
Change-Id: I50d57371edebe7f93f01c83284c0a94fc2e7dbac
jenkins-bot [Fri, 23 May 2014 23:15:55 +0000 (23:15 +0000)]
Merge "Store page_id in logging table for deletions and make queryable"
jenkins-bot [Fri, 23 May 2014 22:47:03 +0000 (22:47 +0000)]
Merge "Make HTTPS port configurable"
jenkins-bot [Fri, 23 May 2014 21:39:37 +0000 (21:39 +0000)]
Merge "MagicWord: Fix an indent"
Bartosz Dziewoński [Fri, 23 May 2014 21:24:13 +0000 (23:24 +0200)]
MagicWord: Fix an indent
Change-Id: I3640fb7a783a68c43a1249b87ef04e587dd0cfd5
jenkins-bot [Fri, 23 May 2014 20:41:47 +0000 (20:41 +0000)]
Merge "Make sure DjVu files do not attempt metadata extraction repeatedly"
jenkins-bot [Fri, 23 May 2014 20:27:19 +0000 (20:27 +0000)]
Merge "Do not include user column on Special:MyUploads"
jenkins-bot [Fri, 23 May 2014 20:24:32 +0000 (20:24 +0000)]
Merge "Document ArticleUndelete change"
jenkins-bot [Fri, 23 May 2014 20:19:19 +0000 (20:19 +0000)]
Merge "Prevent deleteBatch.php deleting files from redirects"
jenkins-bot [Fri, 23 May 2014 18:59:55 +0000 (18:59 +0000)]
Merge "Revert visibility change on DiffHistoryBlob::$mCompressed"
jenkins-bot [Fri, 23 May 2014 18:52:59 +0000 (18:52 +0000)]
Merge "Made getName() in ArchivedFile work when loaded via sha1"
withoutaname [Fri, 9 May 2014 07:34:19 +0000 (00:34 -0700)]
Prevent deleteBatch.php deleting files from redirects
Previous behavior had the maintenance script deleteBatch.php
delete both the redirect in the file namespace and the file
from the target page the redirect is pointing to. This is
no longer the case, but it will still delete the redirect
page if it is still on the listfile.
Bug: 52587
Change-Id: I83374ddb98131f9f8f766bb2b444ab3e7cda7735
Brad Jorsch [Fri, 23 May 2014 15:06:06 +0000 (11:06 -0400)]
Revert visibility change on DiffHistoryBlob::$mCompressed
Changing the visibility from public to protected causes unserialization
to fail.
Bug: 65665
Change-Id: Id7ee2068749ff421fab4d1c9067763adf4b89563
Stephan Muggli [Fri, 23 May 2014 14:00:23 +0000 (16:00 +0200)]
Return value directly when using getter
It is not necessary to save the value in a variable
Change-Id: Ia58c94bb19e22476821451bddc2f66e556b773f6
Aaron Schulz [Fri, 23 May 2014 00:37:33 +0000 (17:37 -0700)]
Improved FileBackend failure logging a bit
* This partly follows up on
2cfce9f
Change-Id: I9d15f44d8000f52fd7b307d358c895452ee96a8d
Brian Wolff [Fri, 23 May 2014 00:00:21 +0000 (21:00 -0300)]
Make sure DjVu files do not attempt metadata extraction repeatedly
If a file is broken, we don't want to spend time trying to find
its metadata over and over again.
Bug: 41090
Change-Id: Iad63b8942af99e1ec44530599a43ec1d6b2b8a62
Sergio Santoro [Thu, 22 May 2014 22:17:23 +0000 (00:17 +0200)]
MediaWiki::performAction, return 404 on nosuchaction error
Nosuchaction error page was sending 200 as the HTTP status code,
which was misleading. Instead return 404.
Change-Id: I9b432c9e53caf0a13e9a0c798f78a7bd8a78443b
Aaron Schulz [Thu, 22 May 2014 20:46:13 +0000 (13:46 -0700)]
Made getName() in ArchivedFile work when loaded via sha1
Change-Id: I44e9c129f6c5841f8cbc9792aa9ff0f353bce6c0
jenkins-bot [Thu, 22 May 2014 20:16:38 +0000 (20:16 +0000)]
Merge "API: Enforce section=new constraint when using 'redirect' mode"
jenkins-bot [Thu, 22 May 2014 20:15:32 +0000 (20:15 +0000)]
Merge "format the tests/phpunit/TODO document for readability"
Adam Roses Wight [Sun, 18 May 2014 07:04:36 +0000 (00:04 -0700)]
API: Enforce section=new constraint when using 'redirect' mode
Finish implementation of the 'redirect' edit API parameter. This flag
should only be used as a convenience when adding a new section, appending,
or prepending. Any other usage must be done using the long-cut (fetch page,
determine if it is a redirect, follow redirects and edit the target page's
content).
This patch takes apart the "EditConflict_redirect" test, because it no
longer makes sense--unless you dear reader can figure out how to force an
edit conflict when only adding a section?
Bug: 24330
Change-Id: Ie3f7273c18e156da1e50e1a36aac2e5341710982
Translation updater bot [Thu, 22 May 2014 19:45:27 +0000 (19:45 +0000)]
Localisation updates from https://translatewiki.net.
Change-Id: I589dbdf292abaf998d18fe553b7afb4880cb40de
Brian Wolff [Thu, 22 May 2014 19:28:16 +0000 (16:28 -0300)]
Do not include user column on Special:MyUploads
If Special:ListFiles is being filtered to show only a specific
user, then there's not much point showing which user uploaded
the image, as they are all uploaded by the same user.
Bug: 30627
Change-Id: Ibe1be82cb8f3354889051ef00f3c0b9f9ea5180e
jenkins-bot [Thu, 22 May 2014 19:25:08 +0000 (19:25 +0000)]
Merge "wfDebugMem: Fix binary prefix and improve usability"
jenkins-bot [Thu, 22 May 2014 19:14:59 +0000 (19:14 +0000)]
Merge "Cached misses in getMulti should be omitted"
Matthias Mullie [Thu, 22 May 2014 13:48:20 +0000 (15:48 +0200)]
Cached misses in getMulti should be omitted
SqlBagOStuff::getMulti currently returns an array with false values for missed
cache keys.
Default BagOStuff::getMulti (and other specific implementations like memcached),
however, just omit missed values.
e.g.:
$cache->getMulti( array( 'goodkey' 'badkey' ) );
should return
array( 'goodkey' => 'value' );
instead of
array( 'goodkey' => 'value', 'badkey' => false );
Bug: 65637
Change-Id: Ib2de06a0f76421094707f7ad4218346087f4dc55
jenkins-bot [Thu, 22 May 2014 15:04:34 +0000 (15:04 +0000)]
Merge "Apply correct line-height to diffs"
Erwin Dokter [Sun, 18 May 2014 15:22:06 +0000 (15:22 +0000)]
Apply correct line-height to diffs
The typography refresh exposes a small shortcoming in the CSS used
for diff display; there is no line-height applied, causing inconsistent
display between skin (ie. too high in Vector). Adding line-height to the
diffs corrects this.
Bug: 64653
Change-Id: I59dfe3e887c68a7034ef78f6873127ffe88b0cc1
Sergio Santoro [Thu, 22 May 2014 14:22:12 +0000 (16:22 +0200)]
wfDebugMem: Fix binary prefix and improve usability
* Fix: wfDebugMem no longer reports kibibytes as kilobytes
* Usability: wfDebugMem now uses unit symbols (e.g. KiB)
Change-Id: I1ab8aa3ccdb0fdea307913ada4ed42964d7fe960
Federico Leva [Thu, 22 May 2014 13:12:46 +0000 (15:12 +0200)]
p-lang-list was removed
Contrite followup to I220057c799bef7e8c4d964f47d56f61ec120d8c2
Change-Id: I028880cfa9946e628832a303779d6b3ffcf16620
Alex Monk [Wed, 21 May 2014 15:16:44 +0000 (16:16 +0100)]
Restore search box tabindex
This was set by JS in collapsibleNav (wtf?) until I220057c7 nuked that module entirely.
A user needed this for accessibility reasons (details in OTRS#
2014051610008141)
Bug: 29199
Change-Id: I74725c01a2058be1151927661c22ce42a1463f91