From c3900f9f8ae920af79ddad588b68a49b9e11df19 Mon Sep 17 00:00:00 2001 From: Aaron Schulz Date: Thu, 8 Aug 2019 17:46:14 -0700 Subject: [PATCH] rdbms: make LBFactory close/rollback dangling handles like LoadBalancer The application is expected to call shutdown(), so do not commit if that never happens, which usually indicates some sort of severe error. This should avoid "already closed" errors that pile on top of uncaught errors. Bug: T225103 Bug: T230065 Change-Id: I1bdfe87c47bcc2537d0dfc518f7212c2c9bf21d2 --- includes/libs/rdbms/lbfactory/LBFactory.php | 1 - 1 file changed, 1 deletion(-) diff --git a/includes/libs/rdbms/lbfactory/LBFactory.php b/includes/libs/rdbms/lbfactory/LBFactory.php index 4426654ca2..77467f062a 100644 --- a/includes/libs/rdbms/lbfactory/LBFactory.php +++ b/includes/libs/rdbms/lbfactory/LBFactory.php @@ -160,7 +160,6 @@ abstract class LBFactory implements ILBFactory { } public function destroy() { - $this->shutdown( self::SHUTDOWN_NO_CHRONPROT ); $this->forEachLBCallMethod( 'disable' ); } -- 2.20.1