From eaac07ac27542f5304592a21fab42ed379ed40c9 Mon Sep 17 00:00:00 2001 From: Timo Tijhof Date: Wed, 24 Sep 2014 18:11:39 -0700 Subject: [PATCH] resourceloader: Clean up $localBasePath variable assignment No need to set a variable to value of itself. Also consistent with the way $remoteBasePath is set, already. Change-Id: I9b71322592a5ca2d85927fcf6732096f758847e9 --- includes/resourceloader/ResourceLoaderFileModule.php | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/includes/resourceloader/ResourceLoaderFileModule.php b/includes/resourceloader/ResourceLoaderFileModule.php index dc8b14a23e..a77e8f7193 100644 --- a/includes/resourceloader/ResourceLoaderFileModule.php +++ b/includes/resourceloader/ResourceLoaderFileModule.php @@ -304,7 +304,9 @@ class ResourceLoaderFileModule extends ResourceLoaderModule { // The different ways these checks are done, and their ordering, look very silly, // but were preserved for backwards-compatibility just in case. Tread lightly. - $localBasePath = $localBasePath === null ? $IP : $localBasePath; + if ( $localBasePath === null ) { + $localBasePath = $IP; + } if ( $remoteBasePath === null ) { $remoteBasePath = $wgResourceBasePath; } -- 2.20.1