From 4af0248a84dfec3c00a63334fa4cdd19b901f00e Mon Sep 17 00:00:00 2001 From: Alexandre Emsenhuber Date: Sun, 22 Jul 2012 22:14:21 +0200 Subject: [PATCH] Fix permissions check to show "hide" buttons. The 'deletedhistory' is needed to access Special:RevisionDelete and LogEventsList already checks for that right, but not Special:Log. This caused the user to see "Hide log entries" buttons when they had the 'deletelogentry' but not the 'deletedhistory', which was not correct. Change-Id: Ie6274b30ffb98e2376d14e6fcac525f901d14f3d --- includes/specials/SpecialLog.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/includes/specials/SpecialLog.php b/includes/specials/SpecialLog.php index 8e4205c7e1..8ab09768be 100644 --- a/includes/specials/SpecialLog.php +++ b/includes/specials/SpecialLog.php @@ -162,7 +162,7 @@ class SpecialLog extends SpecialPage { private function getRevisionButton( $formcontents ) { # If the user doesn't have the ability to delete log entries, don't bother showing him/her the button. - if ( !$this->getUser()->isAllowed( 'deletelogentry' ) ) { + if ( !$this->getUser()->isAllowedAll( 'deletedhistory', 'deletelogentry' ) ) { return $formcontents; } -- 2.20.1