From 0f1cc3bb6e7c3be9b86d2c8736f7458cd40588f2 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Bartosz=20Dziewo=C5=84ski?= Date: Fri, 15 Sep 2017 20:06:45 +0200 Subject: [PATCH] Xml: Fix Xml::fieldset() when $content is not given A function in the Xml class could generate unbalanced tags. How ironic. Why do we even have this instead of just the Html class? Change-Id: Ie119c92aa4936e2f8982163d4b00d08949f49264 --- includes/Xml.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/includes/Xml.php b/includes/Xml.php index 0091513125..eadc7d14de 100644 --- a/includes/Xml.php +++ b/includes/Xml.php @@ -615,9 +615,9 @@ class Xml { if ( $content !== false ) { $s .= $content . "\n"; - $s .= self::closeElement( 'fieldset' ) . "\n"; } + $s .= self::closeElement( 'fieldset' ) . "\n"; return $s; } -- 2.20.1