From: Antoine Musso <hashar@users.mediawiki.org>
Date: Wed, 9 Nov 2011 16:15:35 +0000 (+0000)
Subject: split getHooksFromDoc() function
X-Git-Tag: 1.31.0-rc.0~26621
X-Git-Url: https://git.cyclocoop.org/%7B%24www_url%7Dadmin/compta/banques/?a=commitdiff_plain;h=8ea7e28000418f2ab3adf0130f802da5564ba4d0;p=lhc%2Fweb%2Fwiklou.git

split getHooksFromDoc() function

if() { LOT OF CODE } else { LOT OF CODE } structures are hard to read
move the LOT OF CODE piece in its own function makes code easier to
understand.
---

diff --git a/maintenance/findHooks.php b/maintenance/findHooks.php
index 2fa898236a..cb58285715 100644
--- a/maintenance/findHooks.php
+++ b/maintenance/findHooks.php
@@ -107,6 +107,29 @@ class FindHooks extends Maintenance {
 	 */
 	private function getHooksFromDoc( $doc ) {
 		if ( $this->hasOption( 'online' ) ) {
+			return $this->getHooksFromOnlineDoc( );
+		} else {
+			return $this->getHooksFromLocalDoc( $doc );
+		}
+	}
+
+	/**
+	 * Get hooks from a local file (for example docs/hooks.txt)
+	 * @param $doc string: filename to look in
+	 * @return array of documented hooks
+	 */
+	private function getHooksFromLocalDoc( $doc ) {
+			$m = array();
+			$content = file_get_contents( $doc );
+			preg_match_all( "/\n'(.*?)'/", $content, $m );
+			return array_unique( $m[1] );
+	}
+
+	/**
+	 * Get hooks from www.mediawiki.org using the API
+	 * @return array of documented hooks
+	 */
+	private function getHooksFromOnlineDoc( ) {
 			// All hooks
 			$allhookdata = Http::get( 'http://www.mediawiki.org/w/api.php?action=query&list=categorymembers&cmtitle=Category:MediaWiki_hooks&cmlimit=500&format=php' );
 			$allhookdata = unserialize( $allhookdata );
@@ -130,12 +153,6 @@ class FindHooks extends Maintenance {
 				}
 			}
 			return array_diff( $allhooks, $removed );
-		} else {
-			$m = array();
-			$content = file_get_contents( $doc );
-			preg_match_all( "/\n'(.*?)'/", $content, $m );
-			return array_unique( $m[1] );
-		}
 	}
 
 	/**