From: Ilmari Karonen <vyznev@users.mediawiki.org>
Date: Wed, 9 May 2007 17:35:34 +0000 (+0000)
Subject: wisdom from IRC :)
X-Git-Tag: 1.31.0-rc.0~52998
X-Git-Url: https://git.cyclocoop.org/%7B%24www_url%7Dadmin/compta/banques/?a=commitdiff_plain;h=4d8b00bdf69c789b75192b0d90f9c53abb1ddca6;p=lhc%2Fweb%2Fwiklou.git

wisdom from IRC :)
---

diff --git a/includes/GlobalFunctions.php b/includes/GlobalFunctions.php
index 3c902ded61..949a45c931 100644
--- a/includes/GlobalFunctions.php
+++ b/includes/GlobalFunctions.php
@@ -449,6 +449,17 @@ function wfMsgWeirdKey ( $key ) {
 function wfMsgGetKey( $key, $useDB, $forContent = false, $transform = true ) {
 	global $wgParser, $wgContLang, $wgMessageCache, $wgLang;
 
+	/* <Vyznev> btw, is all that code in wfMsgGetKey() that check
+	 * if the message cache exists of not really necessary, or is
+	 * it just paranoia?
+	 * <TimStarling> Vyznev: it's probably not necessary
+	 * <TimStarling> I think I wrote it in an attempt to report DB
+	 * connection errors properly
+	 * <TimStarling> but eventually we gave up on using the
+	 * message cache for that and just hard-coded the strings
+	 * <TimStarling> it may have other uses, it's not mere paranoia
+	 */
+
 	if ( is_object( $wgMessageCache ) )
 		$transstat = $wgMessageCache->getTransform();