mw.loader: Don't create addScript() callback if we don't need one
authorTimo Tijhof <krinklemail@gmail.com>
Wed, 16 Jul 2014 02:12:12 +0000 (04:12 +0200)
committerOri.livneh <ori@wikimedia.org>
Sat, 19 Jul 2014 23:14:54 +0000 (23:14 +0000)
$.Deferred#always ($.Callbacks#add) ignores undefined/null. No
need to create an inline function that does nothing.

Change-Id: Ifd96ac13e03242279e7d584cf91d899adadfed91

resources/src/mediawiki/mediawiki.js

index b22e240..57838d4 100644 (file)
                                                crossDomain: true,
                                                cache: true,
                                                async: true
-                                       } ).always( function () {
-                                               if ( callback  ) {
-                                                       callback();
-                                               }
-                                       } );
+                                       } ).always( callback );
                                } else {
                                        /*jshint evil:true */
                                        document.write( mw.html.element( 'script', { 'src': src }, '' ) );