From c5fee4a6bafee19d1a92623b0512f82e49dcf7f0 Mon Sep 17 00:00:00 2001 From: Umherirrender Date: Wed, 20 Sep 2017 20:41:59 +0200 Subject: [PATCH] Set wgUseRCPatrol in ChangesListSpecialPageTest wgUseRCPatrol = false makes the tests fail Change-Id: I18965d33171137ff182800512c8c0e8e63de124e --- .../specialpage/AbstractChangesListSpecialPageTestCase.php | 5 ++++- .../includes/specialpage/ChangesListSpecialPageTest.php | 2 ++ 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/tests/phpunit/includes/specialpage/AbstractChangesListSpecialPageTestCase.php b/tests/phpunit/includes/specialpage/AbstractChangesListSpecialPageTestCase.php index b101857e5a..04b12e6378 100644 --- a/tests/phpunit/includes/specialpage/AbstractChangesListSpecialPageTestCase.php +++ b/tests/phpunit/includes/specialpage/AbstractChangesListSpecialPageTestCase.php @@ -19,7 +19,10 @@ abstract class AbstractChangesListSpecialPageTestCase extends MediaWikiTestCase global $wgGroupPermissions; parent::setUp(); - $this->setMwGlobals( 'wgRCWatchCategoryMembership', true ); + $this->setMwGlobals( [ + 'wgRCWatchCategoryMembership' => true, + 'wgUseRCPatrol' => true, + ] ); if ( isset( $wgGroupPermissions['patrollers'] ) ) { $this->oldPatrollersGroup = $wgGroupPermissions['patrollers']; diff --git a/tests/phpunit/includes/specialpage/ChangesListSpecialPageTest.php b/tests/phpunit/includes/specialpage/ChangesListSpecialPageTest.php index f494785b9c..fd7e0f116e 100644 --- a/tests/phpunit/includes/specialpage/ChangesListSpecialPageTest.php +++ b/tests/phpunit/includes/specialpage/ChangesListSpecialPageTest.php @@ -293,6 +293,7 @@ class ChangesListSpecialPageTest extends AbstractChangesListSpecialPageTestCase } public function testRcHidepatrolledDisabledFilter() { + $this->setMwGlobals( 'wgUseRCPatrol', false ); $user = $this->getTestUser()->getUser(); $this->assertConditions( [ # expected @@ -306,6 +307,7 @@ class ChangesListSpecialPageTest extends AbstractChangesListSpecialPageTestCase } public function testRcHideunpatrolledDisabledFilter() { + $this->setMwGlobals( 'wgUseRCPatrol', false ); $user = $this->getTestUser()->getUser(); $this->assertConditions( [ # expected -- 2.20.1