From: Ori Livneh <ori@wikimedia.org>
Date: Wed, 26 Aug 2015 01:13:14 +0000 (-0700)
Subject: Micro-optimize Language::isMultiByte()
X-Git-Tag: 1.31.0-rc.0~10275
X-Git-Url: https://git.cyclocoop.org/%7B%24www_url%7Dadmin/compta/banques/%7B%7B%20url_for%28%27admin_users%27%29%20%7D%7D?a=commitdiff_plain;h=92602fefda8a14b04e32ac12f279d4b47a5b5f23;p=lhc%2Fweb%2Fwiklou.git

Micro-optimize Language::isMultiByte()

The xenon logs on performance.wikimedia.org show this function as being on-CPU
about 1% of the time, making it a candidate for optimization. The version in
this patch is about 30-50% faster in my benchmarks.

Change-Id: I26385ade7600fc11965d94468b57e41ec257de51
---

diff --git a/languages/Language.php b/languages/Language.php
index b698bebf43..370e2ed8c8 100644
--- a/languages/Language.php
+++ b/languages/Language.php
@@ -2838,7 +2838,7 @@ class Language {
 	 * @return bool
 	 */
 	function isMultibyte( $str ) {
-		return (bool)preg_match( '/[\x80-\xff]/', $str );
+		return strlen( $str ) !== mb_strlen( $str );
 	}
 
 	/**