From: Gergő Tisza <tgr.huwiki@gmail.com>
Date: Tue, 14 Nov 2017 23:01:38 +0000 (-0800)
Subject: Remove $wgAuth usage from wrapOldPasswords.php
X-Git-Tag: 1.31.0-rc.0~1494^2
X-Git-Url: https://git.cyclocoop.org/%7B%24www_url%7Dadmin/compta/banques/%7B%7B%20url_for%28%27admin_users%27%29%20%7D%7D?a=commitdiff_plain;h=1fe65bd2ad2bc92c175273a8dfa9af4626d00509;p=lhc%2Fweb%2Fwiklou.git

Remove $wgAuth usage from wrapOldPasswords.php

AuthPlugin::allowSetLocalPassword() has been deprecated with no
real replacement. (Authentication providers largely describe things
from a client POV, so we can check whether the authentication system
is configured to use passwords but not whether it uses the
user_password field. We could check whether the auth providers include
LocalPasswordAuthenticationProvider but that's rather fragile.)

There does not seem to be much need, either; we can assume the site
admin has at least a basic knowledge of what they are using and would
not run wrapOldPasswords.php if the site wasn't using local passwords.

Bug: T180537
Change-Id: I34f2d8ad0d801b5460b768ad1d52b29b0a1b08db
---

diff --git a/maintenance/wrapOldPasswords.php b/maintenance/wrapOldPasswords.php
index 85fa7805e6..1dbad18485 100644
--- a/maintenance/wrapOldPasswords.php
+++ b/maintenance/wrapOldPasswords.php
@@ -43,12 +43,6 @@ class WrapOldPasswords extends Maintenance {
 	}
 
 	public function execute() {
-		global $wgAuth;
-
-		if ( !$wgAuth->allowSetLocalPassword() ) {
-			$this->error( '$wgAuth does not allow local passwords. Aborting.', true );
-		}
-
 		$passwordFactory = new PasswordFactory();
 		$passwordFactory->init( RequestContext::getMain()->getConfig() );