From: Timo Tijhof <krinklemail@gmail.com>
Date: Sun, 8 Jul 2018 06:48:35 +0000 (-0700)
Subject: resourceloader: Add coverage for StartupModule::getAllModuleHashes
X-Git-Tag: 1.34.0-rc.0~4849
X-Git-Url: https://git.cyclocoop.org/%7B%24www_url%7Dadmin/compta/banques/%22http:/wikimediafoundation.org/fundraising/%7B%7B%20url_for%28%27user_settings%27%2C%20userid=session.userid%29%20%7D%7D?a=commitdiff_plain;h=ea7101e6e469bdba88dad852d055c8371726da8c;p=lhc%2Fweb%2Fwiklou.git

resourceloader: Add coverage for StartupModule::getAllModuleHashes

Change-Id: I94551a938cd93152eb1bb0a4748e1c0155539c4c
---

diff --git a/tests/phpunit/includes/resourceloader/ResourceLoaderStartUpModuleTest.php b/tests/phpunit/includes/resourceloader/ResourceLoaderStartUpModuleTest.php
index 810d1fee62..86956f2602 100644
--- a/tests/phpunit/includes/resourceloader/ResourceLoaderStartUpModuleTest.php
+++ b/tests/phpunit/includes/resourceloader/ResourceLoaderStartUpModuleTest.php
@@ -589,4 +589,49 @@ mw.loader.register( [
 		);
 	}
 
+	/**
+	 * @covers ResourceLoaderStartupModule::getAllModuleHashes
+	 * @covers ResourceLoaderStartupModule::getDefinitionSummary
+	 */
+	public function testGetVersionHash_varyModule() {
+		$context1 = $this->getResourceLoaderContext();
+		$rl1 = $context1->getResourceLoader();
+		$rl1->register( [
+			'test.a' => new ResourceLoaderTestModule(),
+			'test.b' => new ResourceLoaderTestModule(),
+		] );
+		$module = new ResourceLoaderStartupModule();
+		$version1 = $module->getVersionHash( $context1 );
+
+		$context2 = $this->getResourceLoaderContext();
+		$rl2 = $context2->getResourceLoader();
+		$rl2->register( [
+			'test.b' => new ResourceLoaderTestModule(),
+			'test.c' => new ResourceLoaderTestModule(),
+		] );
+		$module = new ResourceLoaderStartupModule();
+		$version2 = $module->getVersionHash( $context2 );
+
+		$context3 = $this->getResourceLoaderContext();
+		$rl3 = $context3->getResourceLoader();
+		$rl3->register( [
+			'test.a' => new ResourceLoaderTestModule(),
+			'test.b' => new ResourceLoaderTestModule( [ 'script' => 'different' ] ),
+		] );
+		$module = new ResourceLoaderStartupModule();
+		$version3 = $module->getVersionHash( $context3 );
+
+		$this->assertEquals(
+			$version1,
+			$version2,
+			'Module name is insignificant'
+		);
+
+		$this->assertNotEquals(
+			$version1,
+			$version3,
+			'Hash change of any module impacts startup hash'
+		);
+	}
+
 }