From: daniel Date: Tue, 7 May 2019 14:49:28 +0000 (+0200) Subject: Log breaking change to WatchedItemQueryServiceExtension X-Git-Tag: 1.34.0-rc.0~1778^2 X-Git-Url: https://git.cyclocoop.org/%7B%24www_url%7Dadmin/compta/banques/%22http:/wikimediafoundation.org/fundraising/%7B%7B%20url_for%28%27user_settings%27%2C%20userid=session.userid%29%20%7D%7D?a=commitdiff_plain;h=ba1ab18b4ecc7d7983f9b31e0d199ca0c588ee23;p=lhc%2Fweb%2Fwiklou.git Log breaking change to WatchedItemQueryServiceExtension The WatchedItemQueryServiceExtension interface was changed in Iadbf7bc31a49 to hint against UserIdentity instead of User. This is a breaking change that requires extensions implementing this interface to be updated. This once again shows why interfaces make bad extension points, see T193613 for discussion of the topic. There just is no good way to make this kind of change backwards-compatible. Bug: T222677 Change-Id: Id9625824f7dec21a5b33ebf88e6f29d2a9333541 --- diff --git a/RELEASE-NOTES-1.34 b/RELEASE-NOTES-1.34 index 9059dc6ead..9231380f76 100644 --- a/RELEASE-NOTES-1.34 +++ b/RELEASE-NOTES-1.34 @@ -112,6 +112,9 @@ because of Phabricator reports. * wfArrayFilter() and wfArrayFilterByKey(), deprecated in 1.32, have been removed. * wfMakeUrlIndexes() function, deprecated in 1.33, have been removed. +* Method signatures in WatchedItemQueryServiceExtension have changed from taking + User objects to taking UserIdentity objects. Extensions implementing this + interface need to be changed accordingly. * User::getGroupPage() and ::makeGroupLinkHTML(), deprecated in 1.29, have been removed. Use UserGroupMembership::getGroupPage and ::getLink instead. * User::makeGroupLinkWiki(), deprecated in 1.29, has been removed. Use