jenkins-bot [Tue, 17 Nov 2015 22:54:29 +0000 (22:54 +0000)]
Merge "resourceloader: Reformat code around member grouping in ResourceLoaderContext"
jenkins-bot [Tue, 17 Nov 2015 22:33:56 +0000 (22:33 +0000)]
Merge "Have SquidUpdate::newFromTitles use getSquidURLs"
jenkins-bot [Tue, 17 Nov 2015 22:19:40 +0000 (22:19 +0000)]
Merge "Remove deprecated wgRateLimitLog"
Bryan Davis [Tue, 17 Nov 2015 21:55:42 +0000 (14:55 -0700)]
Remove deprecated wgRateLimitLog
Remove the backwards compatibility shims for $wgRateLimitLog which was
deprecated in 1.23 (I86131c4).
Change-Id: I771bbaff43b44d011bff81ddda4f35166ea5f77e
Timo Tijhof [Tue, 17 Nov 2015 21:14:17 +0000 (21:14 +0000)]
resourceloader: Reformat code around member grouping in ResourceLoaderContext
* No effective change. Only code reformatting.
* Logically group related members.
* Break up items one per line in getHash().
Change-Id: I8ccbe9d071a5c39f5c3d36d0d990574fb0ed8d72
Timo Tijhof [Tue, 17 Nov 2015 21:11:19 +0000 (21:11 +0000)]
resourceloader: Omit getDirection() ResourceLoaderContext hash
The direction is derived from the language code, which is included
already. The method was added for convenience to consuming code,
but including it in the cache key seems pointless.
Main rationale here is runtime performance. getDirection() incurs
Language::factory() and Language::getDir() which require loading
of LCStore files.
Change-Id: I397a1c483203ec2c4903046c9494cae1c9480f8c
jenkins-bot [Tue, 17 Nov 2015 21:04:29 +0000 (21:04 +0000)]
Merge "Make JobRunner::commitMasterChanges() check getServerCount()"
Translation updater bot [Tue, 17 Nov 2015 20:36:52 +0000 (20:36 +0000)]
Merge "Localisation updates from https://translatewiki.net."
Translation updater bot [Tue, 17 Nov 2015 20:35:11 +0000 (21:35 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: I7c40855393bce690629651b89a29842c231cc90d
Timo Tijhof [Tue, 17 Nov 2015 20:04:50 +0000 (20:04 +0000)]
Follows-up
3a252efa: Update docs around $wgUseLocalMessageCache
MessageCache had its "local server" cache converted from file-based
to using APC. For installs without APC, this setting no longer
does anything.
Change-Id: I1e284b56cadaa0206ca60ecdb6a55360e1fa1935
jenkins-bot [Tue, 17 Nov 2015 19:21:59 +0000 (19:21 +0000)]
Merge "Remove redundant null-handling for Title::newFromText"
jenkins-bot [Tue, 17 Nov 2015 19:11:44 +0000 (19:11 +0000)]
Merge "Extract file name from thumbnail only from first occurrence"
jenkins-bot [Tue, 17 Nov 2015 19:03:39 +0000 (19:03 +0000)]
Merge "MessageCache: Remove $ucfirst and clean up getMessageFromFallbackChain()"
Timo Tijhof [Tue, 17 Nov 2015 17:51:37 +0000 (17:51 +0000)]
MessageCache: Remove $ucfirst and clean up getMessageFromFallbackChain()
The $ucfirst and $wgContentLang variables are not used by get().
Keep these inside getMessageFromFallbackChain() instead.
Also add mark getMsgFromNamespace() as public since it is used
in other places in core and by extensions.
Change-Id: I83bf77c17aa46f3929f89c4af97693611761629b
Erik Bernhardson [Wed, 23 Sep 2015 23:37:06 +0000 (16:37 -0700)]
Add structured API request debug logging
Add a new "ApiRequest" PSR-3 logging channel for messages that describe
an Action API request as structured data. This logging channel can be
routed to a storage service to facilitate analysis of the requests.
The logging context is designed to match the following avro schema:
{
"type": "record",
"name": "ApiRequest",
"namespace": "org.wikimedia.mediawiki.api",
"doc": "Describes an API request made via mediawiki ApiMain",
"fields": [
{ "name": "dt", "type": "string" },
{ "name": "client_ip", "type": "string" },
{ "name": "user_agent", "type": "string" },
{ "name": "wiki", "type": "string" },
{ "name": "time_backend_ms", "type": "int" },
{ "name": "params", "type": {
"type": "map", "values": "string"
} }
]
}
Co-Author: Bryan Davis <bd808@wikimedia.org>
Bug: T108618
Change-Id: I38f5cdb288f332f75adca8a2d03fbe0fc36ab936
Timo Tijhof [Tue, 17 Nov 2015 02:01:16 +0000 (02:01 +0000)]
phpunit: Omit long xdiff test provider from Jenkins output
In PHPUnit v4.3 and higher one could call markTestSkipped() from
inside a data provider.
Bug: T43683
Change-Id: Ic5f9f4c715466e3998af76ad98543aeb9c5d396e
Aaron Schulz [Tue, 17 Nov 2015 04:37:42 +0000 (20:37 -0800)]
Make JobRunner::commitMasterChanges() check getServerCount()
This is a sanity check to avoid problems in waitForOne()
Change-Id: I9792ea8fb69d560bd4adb9bd01515f6456b7e9f3
Timo Tijhof [Tue, 17 Nov 2015 04:22:15 +0000 (04:22 +0000)]
resourceloader: Centralise expected version hash for blank test modules
To avoid repeating this too much and make it easier to update when
underlying components incorporated into the version hash change.
Change-Id: I986988c07f5f888046b1d93c7e72f2e9585893cf
Timo Tijhof [Mon, 16 Nov 2015 21:41:10 +0000 (21:41 +0000)]
objectcache: Implement check keys per cache key in WANObjectCache::getMulti()
To allow batch queries for multiple keys that themselves have different check
keys. Previously check keys always applied to all keys being retrieved.
Change-Id: I9e5ba198d79020ce05a802a510762e29fcfb2f1b
jenkins-bot [Tue, 17 Nov 2015 04:15:09 +0000 (04:15 +0000)]
Merge "resourceloader: Use 'phpunit' instead of 'test' as default target in PHPUnit tests"
Timo Tijhof [Tue, 17 Nov 2015 03:55:19 +0000 (03:55 +0000)]
resourceloader: Use 'phpunit' instead of 'test' as default target in PHPUnit tests
Follows-up
e9b9e4df7a5, which started using target=test as reserved for
Special:JavaScriptTest. However that conflicted with this.
Without this change, the unit tests fail if the MediaWiki install has
$wgEnableJavaScriptTest enabled.
Change-Id: I471017e7aedb74dddb4dc18ee4e89c1706ff09b5
Aaron Schulz [Tue, 17 Nov 2015 00:13:37 +0000 (16:13 -0800)]
objectcache: Add more WAN cache check key unit tests
Change-Id: If9bfef463b294391a456c5f04f48858f9dbe73fd
jenkins-bot [Tue, 17 Nov 2015 03:26:09 +0000 (03:26 +0000)]
Merge "objectcache: Add more @covers to WANObjectCache unit tests"
jenkins-bot [Tue, 17 Nov 2015 02:53:03 +0000 (02:53 +0000)]
Merge "Reduce updateLinksTimestamp() DB contention"
Ed Sanders [Tue, 17 Nov 2015 02:25:59 +0000 (18:25 -0800)]
Remove vendor prefix support for SVG embedding
Also remove the -o- prefix which uses 'fallback', as without
that rule it will use 'fallback' anyway.
Bug: T118815
Change-Id: I6a6e3b24b1cda55dfa9675743c39d21e792275c7
Aaron Schulz [Thu, 12 Nov 2015 20:46:45 +0000 (12:46 -0800)]
Reduce updateLinksTimestamp() DB contention
Do the LinksUpdateComplete hook updates in a separate
transaction as they may do slow SELECTs and updates.
A large amount of DBPerformance warnings were triggered
by such cases.
Bug: T95501
Change-Id: Ie4e6b7f6aefc21bafba270282c55571ff5385fe0
Timo Tijhof [Tue, 17 Nov 2015 01:53:30 +0000 (01:53 +0000)]
Remove redundant null-handling for Title::newFromText
* Linker: Follows-up
9ce5ca9886. null is already handled.
* PrefixSearch: Follows-up
337b1e2e. null is already handled.
If other types are bassed, we want to find these.
* UploadBase: Follows-up
11f5ebec28. null is already handled.
WebRequest::getVal($name) can only return string or null.
Change-Id: I3dc3b700cde735f5cd9d497f0867a2b4e3b61f46
jenkins-bot [Tue, 17 Nov 2015 01:32:21 +0000 (01:32 +0000)]
Merge "Revert "Avoid doNotifyQueueEmpty() race conditions for Redis""
Kunal Mehta [Tue, 17 Nov 2015 00:49:45 +0000 (16:49 -0800)]
Add 'mobile' target to 'mediawiki.raggett' module
Bug: T49673
Change-Id: I7c360738e205e90856dfbdc4597123bc961e3c89
jenkins-bot [Mon, 16 Nov 2015 23:22:31 +0000 (23:22 +0000)]
Merge "phpcs: Assignment expression not allowed"
Marius Hoch [Mon, 16 Nov 2015 22:13:55 +0000 (23:13 +0100)]
Don't claim model validation failed if the content couldn't be loaded
Also include the corresponding revision id in the exception message.
Bug: T118747
Change-Id: If3e5694f8b471045cf62d672f414446cf5365ed5
Timo Tijhof [Mon, 16 Nov 2015 21:48:47 +0000 (21:48 +0000)]
objectcache: Add more @covers to WANObjectCache unit tests
Has only ~ 30% coverage according to PHPUnit, but mostly due to
lack of @covers annotations.
Change-Id: I871b45d8d8ee22c7cda644c450d78f577584e78c
jenkins-bot [Mon, 16 Nov 2015 21:05:39 +0000 (21:05 +0000)]
Merge "Improve error message if check not defined for a password policy."
Translation updater bot [Mon, 16 Nov 2015 21:00:52 +0000 (22:00 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: I0be21ef9182ea4424b4bf4f415240e0ec363f975
umherirrender [Thu, 12 Nov 2015 19:07:59 +0000 (20:07 +0100)]
phpcs: Assignment expression not allowed
Fix some "Assignment expression not allowed"
Found by tests:
https://integration.wikimedia.org/ci/job/mediawiki-core-phpcs/2736/consoleFull
Change-Id: I9bc2eff20a317a74671acd49749bb336a0fd9f67
Reedy [Mon, 16 Nov 2015 20:47:15 +0000 (20:47 +0000)]
Improve error message if check not defined for a password policy.
Bug: T118776
Change-Id: Ic1826f15424197545f4d6c2b1af49adbc4289e15
jenkins-bot [Mon, 16 Nov 2015 18:40:00 +0000 (18:40 +0000)]
Merge "Allow a TitleInputWidget user to decide, if an empty value should be validated"
Florian [Thu, 12 Nov 2015 17:31:57 +0000 (18:31 +0100)]
Allow a TitleInputWidget user to decide, if an empty value should be validated
For some use cases an empty value is valid, too, or at least, it's not a reason to
mark the form input red. Special:Search, e.g.. This change implements a new config
for MediaWiki\Widgets\TitleInputWidget, validate, which allows a user of this
widget to decide, if the value of the input type should be validated (empty -> flagged
red).
Extra points:
* Fix php notice errors for previously added configuration
* Added doc for previously added configuration
Bug: T106946
Change-Id: I732a2f56a2375d8c708e3b295996187ee209f1a6
Brad Jorsch [Mon, 16 Nov 2015 15:26:39 +0000 (10:26 -0500)]
ApiFeedWatchlist: Set messages for param-per-value too when copying from ApiQueryWatchlist
Bug: T118675
Change-Id: I9244a177716d4bbe8c011fd7c374e125552ea531
Translation updater bot [Sun, 15 Nov 2015 20:56:14 +0000 (21:56 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: I13ff9d21bd07513cf26dfddbce091418c62d38e7
jenkins-bot [Sun, 15 Nov 2015 20:30:53 +0000 (20:30 +0000)]
Merge "phpcs: Use __DIR__ constant instead of calling"
Aaron Schulz [Wed, 11 Nov 2015 21:50:35 +0000 (13:50 -0800)]
Make JobQueueAggregator::doNotifyQueueNonEmpty() avoid queries
Avoid 2 of the 3 queries in doNotifyQueueNonEmpty(), the ones
that register the queue, once such a command has been done in
the request already.
Change-Id: I58553f0c56660f05a3e3000065270baebb8cbb62
umherirrender [Thu, 12 Nov 2015 18:58:20 +0000 (19:58 +0100)]
phpcs: Use __DIR__ constant instead of calling
Replaced all dirname(__FILE__) by __DIR__ or added
@codingStandardsIgnore
Found by tests:
https://integration.wikimedia.org/ci/job/mediawiki-core-phpcs/2736/consoleFull
Change-Id: I90ff10f183ed60175fe580c43d73c0e57fd04234
Aaron Schulz [Fri, 13 Nov 2015 08:07:14 +0000 (00:07 -0800)]
Clean up some wfDebug() calls in LoadBalancer
Change-Id: I01143bec5b084a32c3edd836d194c0a17ca0e43c
jenkins-bot [Sun, 15 Nov 2015 06:52:12 +0000 (06:52 +0000)]
Merge "Generalize the LinkCache clear() call to JobRunner"
Translation updater bot [Sat, 14 Nov 2015 21:02:44 +0000 (22:02 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: I71454ec5faa274e2b0e768a041c0a595009be4e0
Aaron Schulz [Sat, 14 Nov 2015 13:17:23 +0000 (05:17 -0800)]
Generalize the LinkCache clear() call to JobRunner
The use for this logic is not specific to RefreshLinksJob
Change-Id: I4bb911ab5882d1795e12163df8ae6b227c58bc8a
Matthew Flaschen [Fri, 13 Nov 2015 21:54:41 +0000 (16:54 -0500)]
Have SquidUpdate::newFromTitles use getSquidURLs
This causes it to add history, and trigger the TitleSquidURLs hook.
Bug: T116095
Change-Id: I41ebd2f34347a3f218f7d0bfc8962d286b943c16
Translation updater bot [Fri, 13 Nov 2015 20:16:30 +0000 (21:16 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: I9891f7770ff4ccf0f12847c1e903a85cb030789a
Brad Jorsch [Fri, 13 Nov 2015 14:55:21 +0000 (09:55 -0500)]
Add i18n messages for API feedrecentchanges 'categories' and 'categories_any'
Bug: T118515
Change-Id: I7ae7c474aacceea0346991882f1f44cc6c998c7d
jenkins-bot [Fri, 13 Nov 2015 06:30:20 +0000 (06:30 +0000)]
Merge "resourceloader: Update MessageBlobStore documentation and code cleanup"
jenkins-bot [Fri, 13 Nov 2015 01:01:00 +0000 (01:01 +0000)]
Merge "Remove PHP detection from entry points other than index.php"
Timo Tijhof [Thu, 12 Nov 2015 23:54:04 +0000 (23:54 +0000)]
resourceloader: Update MessageBlobStore documentation and code cleanup
* Update and improve class documentation.
* Remove comment that claims to return false if the module has no message.
generateMessageBlob() returns '{}' in that case. And this is expected since
we want to cache the absence of messages.
* Re-use the module objects passed to MessageBlobStore::get() in getFromDB()
instead of using ResourceLoader::getModule(). The object is the same either
way (since ResourceLoader re-uses the objects also) but reduces complexity
of getFromDB() to not need the ResourceLoader object as parameter.
Change-Id: I89a14d7185877fae52791f6837883ed3a6749cd7
Aaron Schulz [Fri, 13 Nov 2015 00:07:50 +0000 (16:07 -0800)]
Add LBFactory::disableChronologyProtection method
This is useful for things like job running entry points by
avoiding pointless overhead.
Change-Id: I007273dd95e6a2e9d258d475d383bc869d63f7b1
Aaron Schulz [Sun, 18 Oct 2015 19:53:40 +0000 (12:53 -0700)]
Decouple ChronologyProtector from user sessions
* It now works for users without using sessions.
Sessions should not be cluttered with things
unrelated to authentication and tokens.
* Public services doing api.php requests on behalf
of a users only need to set XFF headers (as normal)
for position wait logic to trigger. They can opt out
of ChronologyProtector via a new HTTP header
"ChronologyProtection: false".
* Requests across subdomains, such as the SUL2 handshake
for CentralAuth on account creation, now have position
wait logic applied. This helps avoid anomolies were a
row just written in the last request may not be seen.
* Use merge() to avoid rolling back master positions if
the user has multiple tabs open and doing writes at once.
* $_SESSION global state is gone from ChronologyProtector.
* Cleaned up post-send LBFactory::shutdown() logic for
avoiding master position writes with an explicit flag.
* Use 'replication' debug log group in more places.
Bug: T111264
Change-Id: Ib25d05994d62b25c2f89e67b7f51009c54f4bca8
Aaron Schulz [Thu, 12 Nov 2015 22:41:42 +0000 (22:41 +0000)]
Merge "Move down $logEntry publish() call in recordUpload2()"
Timo Tijhof [Thu, 12 Nov 2015 22:36:50 +0000 (22:36 +0000)]
Remove PHP detection from entry points other than index.php
The following entry points already didn't have it:
* opensearch.php
* thumb.php
* thumb_handlers.php
Now removed from api.php and load.php as well. The check was broken
because these entry points use the 'use' keyword for PHP namespaces,
which results in a syntax error on PHP < 5.3.
The check remains in index.php, mw-config/index.php, and
Maintenance (for e.g. install.php).
Bug: T112942
Change-Id: I9026d69ddfb3e02612256b4a9df525c432bb33c6
Translation updater bot [Thu, 12 Nov 2015 21:13:58 +0000 (22:13 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: Ifab8c58dd1e702c586d0e9003a86d77cbfe92830
Brion VIBBER [Thu, 12 Nov 2015 20:58:07 +0000 (20:58 +0000)]
Merge "Add file extension mapping for opus"
Gilles Dubuc [Thu, 12 Nov 2015 15:36:03 +0000 (16:36 +0100)]
Extract file name from thumbnail only from first occurrence
The existing regex assumes repetition of the filename in both
areas of the URL, which is limiting. The use case is having the second
instance of the filename replaced by the sha1 of the original, as
done here: I545586ff8d0020d00d9faa1dff2d0d9721134452
Bug: T118437
Change-Id: I2c90e672e343fbb4d287f0f2a0397761824e25c7
Brian Wolff [Tue, 10 Nov 2015 23:33:23 +0000 (18:33 -0500)]
Release notes for Ic7cd6f77
Change-Id: I5da293a98f8de8172acc64987b8ef7b9fc7da98b
Aaron Schulz [Thu, 12 Nov 2015 03:36:13 +0000 (19:36 -0800)]
Move down $logEntry publish() call in recordUpload2()
This was moved before the defered doEditContent() call
for new pages by mistake.
Bug: T118433
Change-Id: I007acf82622ec6d68c007921f632793392025f40
jenkins-bot [Thu, 12 Nov 2015 02:46:03 +0000 (02:46 +0000)]
Merge "Followup
a88df43d: make $wgDebugDumpSql log commented queries again"
Roan Kattouw [Thu, 12 Nov 2015 02:17:23 +0000 (18:17 -0800)]
Followup
a88df43d: make $wgDebugDumpSql log commented queries again
Change-Id: I0c10b2119f03fa047dbb2bad1c4c1233403bff59
jenkins-bot [Thu, 12 Nov 2015 00:52:59 +0000 (00:52 +0000)]
Merge "Remove spammy wfDebug() from LocalFile::loadFromCache()"
Aaron Schulz [Wed, 11 Nov 2015 22:20:37 +0000 (22:20 +0000)]
Revert "Avoid doNotifyQueueEmpty() race conditions for Redis"
This might hitting a phpredis bug causing "read error" messages.
This reverts commit
ab2e1dae28f3b15e100e814544419f6719ef06f5.
Bug: T118430
Change-Id: I45b009e8768b79368898762bfedbca4dc0a79943
Timo Tijhof [Thu, 12 Nov 2015 00:24:38 +0000 (00:24 +0000)]
resourceloader: Remove deprecated MessageBlobStore::getInstance()
Deprecated since MediaWiki 1.25.
Not used anywhere in public Wikimedia Git.
Change-Id: Iaa31d0e83b95fb033c62430bc3fc4dd66af16906
jenkins-bot [Wed, 11 Nov 2015 23:17:19 +0000 (23:17 +0000)]
Merge "startup.test: Add IE11 and Edge strings to Grade A tests"
James D. Forrester [Wed, 11 Nov 2015 16:48:05 +0000 (08:48 -0800)]
startup.test: Add IE11 and Edge strings to Grade A tests
Change-Id: Ia4fa69c1abfb8381913885aada0784a04c22aa7c
jenkins-bot [Wed, 11 Nov 2015 22:46:25 +0000 (22:46 +0000)]
Merge "Really validate that $wgArticlePath starts with a slash"
jenkins-bot [Wed, 11 Nov 2015 22:24:08 +0000 (22:24 +0000)]
Merge "Cleaner Special:Watchlist options form"
jenkins-bot [Wed, 11 Nov 2015 22:09:58 +0000 (22:09 +0000)]
Merge "Allow undo via ApiEditPage for all content models"
Bartosz Dziewoński [Wed, 11 Nov 2015 22:00:31 +0000 (23:00 +0100)]
Really validate that $wgArticlePath starts with a slash
The regular expression wasn't entirely correct.
Follow-up to
a4a3d0454069c25a24e2bfe732a665cc6a865878.
Bug: T48998
Change-Id: I08bdf2db20c1c3de55527fc812bcbb55fa23f7bc
Aaron Schulz [Wed, 11 Nov 2015 21:36:53 +0000 (13:36 -0800)]
Remove spammy wfDebug() from LocalFile::loadFromCache()
Change-Id: I36ad31f197ec8f71c97e6a8673ac5ca979f8d9ab
Translation updater bot [Wed, 11 Nov 2015 20:34:04 +0000 (21:34 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: I197a422a9cd705e75853fbbbd6da01714a3e22f1
aude [Thu, 13 Aug 2015 20:34:45 +0000 (22:34 +0200)]
Allow undo via ApiEditPage for all content models
It might be even nicer to separate undo into action=undo,
but for now undo is done via ApiEditPage and should be
allowed for all content models.
Bug: T101694
Change-Id: I833bcc20d86fa5bf216dc9444e2b8a16ddd45f66
jenkins-bot [Wed, 11 Nov 2015 19:01:33 +0000 (19:01 +0000)]
Merge "Update OOjs to v1.1.10"
James D. Forrester [Wed, 11 Nov 2015 17:02:06 +0000 (09:02 -0800)]
Update OOjs to v1.1.10
Release notes:
https://git.wikimedia.org/blob/oojs%2Fcore.git/v1.1.10/History.md
Change-Id: Id19682f59690aafc70fa05c6febf32b1206090c2
jenkins-bot [Wed, 11 Nov 2015 17:11:22 +0000 (17:11 +0000)]
Merge "Make TitleInputWidget configurable, if term should be highlighted or not"
jenkins-bot [Wed, 11 Nov 2015 16:43:03 +0000 (16:43 +0000)]
Merge "mw.loader: Use requestIdleCallback to update module store"
jenkins-bot [Wed, 11 Nov 2015 16:16:38 +0000 (16:16 +0000)]
Merge "Add flexbox mixins to mediawiki.mixins"
jenkins-bot [Wed, 11 Nov 2015 15:20:31 +0000 (15:20 +0000)]
Merge "Language: Convert names cache from MapCacheLRU to HashBagOStuff"
jenkins-bot [Wed, 11 Nov 2015 15:16:28 +0000 (15:16 +0000)]
Merge "Title: Convert cache from MapCacheLRU to HashBagOStuff"
Timo Tijhof [Wed, 11 Nov 2015 00:14:30 +0000 (00:14 +0000)]
mediawiki.Uri: Remove redundant jshint overrides for latedef
These aren't being violated. They were either left-over from
refactoring or added to work around bugs in JSHint that have
been fixed since.
Change-Id: I3ac4a6e97b6294f392ae9ec2474eab448b044a13
jenkins-bot [Wed, 11 Nov 2015 03:46:39 +0000 (03:46 +0000)]
Merge "build: Enable all remaining jsduck jsDoc rules except two"
jenkins-bot [Wed, 11 Nov 2015 02:18:35 +0000 (02:18 +0000)]
Merge "TitleSearchWidget: Only update results if the query is current"
jenkins-bot [Wed, 11 Nov 2015 01:41:57 +0000 (01:41 +0000)]
Merge "UserMailer: Use PHP_EOL instead of DIY"
David Lynch [Tue, 10 Nov 2015 23:59:27 +0000 (15:59 -0800)]
TitleSearchWidget: Only update results if the query is current
With near-simultaneous inputs (e.g. holding down the backspace key
while deleting text) you can cause the suggestion promise to resolve
out-of-order. This causes apparently incorrect suggestions to be
displayed for the current input.
To fix this, abort the existing promise if it exists.
Bug: T114178
Change-Id: I9332452fd914b54e7c564284da2a8a00865ae806
Chad Horohoe [Wed, 11 Nov 2015 01:28:32 +0000 (17:28 -0800)]
UserMailer: Use PHP_EOL instead of DIY
Also fixes arrayToHeaderString() to be correct when called without
the $endl parameter
Change-Id: I8b9f72500f9a055f9f2e1cfcbb276d565674f1b8
Isarra [Tue, 27 Oct 2015 02:54:45 +0000 (02:54 +0000)]
Add flexbox mixins to mediawiki.mixins
Includes some fallback support for 2009 (old firefox and some mobile
browsers) and 2012 (IE10) specs.
Change-Id: I0c6fca82b778a28930bf83fd43a3059858fe9243
jenkins-bot [Wed, 11 Nov 2015 00:33:49 +0000 (00:33 +0000)]
Merge "Avoid using !important and hide the nolabel instead"
jenkins-bot [Wed, 11 Nov 2015 00:11:42 +0000 (00:11 +0000)]
Merge "Update OOjs UI to v0.13.2"
jenkins-bot [Tue, 10 Nov 2015 23:49:30 +0000 (23:49 +0000)]
Merge "Make runOnTransactionIdleCallbacks() handle dangling transactions"
James D. Forrester [Tue, 10 Nov 2015 23:44:04 +0000 (15:44 -0800)]
Update OOjs UI to v0.13.2
Release notes:
https://git.wikimedia.org/blob/oojs%2Fui.git/v0.13.2/History.md
Change-Id: I0626d91d4b93e1d680579f1e6a02555c6050127f
jenkins-bot [Tue, 10 Nov 2015 23:21:19 +0000 (23:21 +0000)]
Merge "Validates wgArticlePath does start with slash (/)."
JuneHyeon Bae [Sat, 24 May 2014 10:48:02 +0000 (19:48 +0900)]
Validates wgArticlePath does start with slash (/).
When relative URL used in $wgArticlePath, and $wgArticlePath does not
start with slash (/), raise FatalError.
Bug: T48998
Change-Id: Ic7cd6f774cff97081f4f35af351161170b4b26eb
jenkins-bot [Tue, 10 Nov 2015 22:50:55 +0000 (22:50 +0000)]
Merge "Avoid doNotifyQueueEmpty() race conditions for Redis"
Aaron Schulz [Tue, 10 Nov 2015 22:34:24 +0000 (14:34 -0800)]
Avoid doNotifyQueueEmpty() race conditions for Redis
Previously, races could cause queues to be seen as empty
and ignored when they actually have jobs in them.
Change-Id: I6cdf5c1fbd33c9ed7982e5d2d494974b1d7e09fd
Timo Tijhof [Tue, 10 Nov 2015 22:09:21 +0000 (22:09 +0000)]
mw.loader: Use requestIdleCallback to update module store
.. instead of setTimeout.
Also adapt the code accordingly since it is no longer needed to
cancel and re-schedule an update every time update() is called.
This is already handled by requestIdleCallback.
We can let the already-scheduled callback survive. The data
that will be saved is serialised during the flush anyway,
not when scheduling.
Change-Id: Iea48919b4baba7647040b6ed9ff4b6d0d387b962
Florian [Fri, 6 Nov 2015 17:17:29 +0000 (18:17 +0100)]
Make TitleInputWidget configurable, if term should be highlighted or not
Depends on: I36502da43c383373
Bug: T106273
Change-Id: I393eef9cd20bdf80e4db72891f23de08bcdfd376