From caa1ae0fe0da6ed77dba73235f6f9facdab5835b Mon Sep 17 00:00:00 2001 From: =?utf8?q?Bartosz=20Dziewo=C5=84ski?= Date: Fri, 19 May 2017 23:09:52 +0200 Subject: [PATCH] BaseTemplate: Handle `$this->data['language_urls'] === false` specially Per 53ab861a2fcba98d876e5a2be5af7bc7186b880c, extensions can set this to an empty array to have the sidebar section displayed even if it has no items. Wikidata and UniversalLanguageSelector rely on this. Change-Id: I79cef25d79ed25fa6d96698a121c3105870e890b --- includes/skins/BaseTemplate.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/includes/skins/BaseTemplate.php b/includes/skins/BaseTemplate.php index 5868904d20..e68969fc75 100644 --- a/includes/skins/BaseTemplate.php +++ b/includes/skins/BaseTemplate.php @@ -201,13 +201,13 @@ abstract class BaseTemplate extends QuickTemplate { ]; break; case 'LANGUAGES': - if ( $this->data['language_urls'] ) { + if ( $this->data['language_urls'] !== false ) { $msgObj = $this->getMsg( 'otherlanguages' ); $boxes[$boxName] = [ 'id' => 'p-lang', 'header' => $msgObj->exists() ? $msgObj->text() : 'otherlanguages', 'generated' => false, - 'content' => $this->data['language_urls'], + 'content' => $this->data['language_urls'] ?: [], ]; } break; -- 2.20.1