From a728e7b6582bff96b76d0f38b94da4c7682e3df6 Mon Sep 17 00:00:00 2001 From: MatmaRex Date: Fri, 26 Apr 2013 23:48:29 +0200 Subject: [PATCH] Remove all uses of obsolete .editsection class Cleanup after I6a6c12a9. To be merged after appropriate caches are purged. Change-Id: I4950496e584735a3ceeb0e1c4123dfe6597f2ae1 --- .../ResourceLoaderUserCSSPrefsModule.php | 2 +- .../mediawiki.action.view.rightClickEdit.js | 4 ++-- skins/cologneblue/screen.css | 4 ---- skins/common/commonElements.css | 20 ------------------- skins/common/commonPrint.css | 1 - skins/common/oldshared.css | 10 ---------- skins/common/shared.css | 18 ++--------------- skins/common/wikiprintable.css | 1 - skins/modern/main.css | 4 ---- skins/modern/print.css | 1 - skins/vector/screen.css | 4 ---- 11 files changed, 5 insertions(+), 64 deletions(-) diff --git a/includes/resourceloader/ResourceLoaderUserCSSPrefsModule.php b/includes/resourceloader/ResourceLoaderUserCSSPrefsModule.php index 61e6e15023..7b4b668de3 100644 --- a/includes/resourceloader/ResourceLoaderUserCSSPrefsModule.php +++ b/includes/resourceloader/ResourceLoaderUserCSSPrefsModule.php @@ -81,7 +81,7 @@ class ResourceLoaderUserCSSPrefsModule extends ResourceLoaderModule { $rules[] = "#toc { display: none; }\n"; } if ( !$options['editsection'] ) { - $rules[] = ".mw-editsection, .editsection { display: none; }\n"; + $rules[] = ".mw-editsection { display: none; }\n"; } if ( $options['editfont'] !== 'default' ) { // Double-check that $options['editfont'] consists of safe characters only diff --git a/resources/mediawiki.action/mediawiki.action.view.rightClickEdit.js b/resources/mediawiki.action/mediawiki.action.view.rightClickEdit.js index 0e85fd9696..93befe3a44 100644 --- a/resources/mediawiki.action/mediawiki.action.view.rightClickEdit.js +++ b/resources/mediawiki.action/mediawiki.action.view.rightClickEdit.js @@ -5,10 +5,10 @@ */ jQuery( function ( $ ) { // Select all h1-h6 elements that contain editsection links - // Don't use the ":has:(.editsection a)" selector because it performs very bad. + // Don't use the ":has:(.mw-editsection a)" selector because it performs very bad. // http://jsperf.com/jq-1-7-2-vs-jq-1-8-1-performance-of-mw-has/2 $( document ).on( 'contextmenu', 'h1, h2, h3, h4, h5, h6', function ( e ) { - var $edit = $( this ).find( '.mw-editsection a, .editsection a' ); + var $edit = $( this ).find( '.mw-editsection a' ); if ( !$edit.length ) { return; } diff --git a/skins/cologneblue/screen.css b/skins/cologneblue/screen.css index 349638aa16..9dbc4cbd76 100644 --- a/skins/cologneblue/screen.css +++ b/skins/cologneblue/screen.css @@ -135,10 +135,6 @@ h1 { line-height: 21pt; } -h1 .editsection { - font-size: 55.6%; -} - h1#firstHeading { padding-bottom: 0; margin-bottom: 0; diff --git a/skins/common/commonElements.css b/skins/common/commonElements.css index a1e809d930..f609716d44 100644 --- a/skins/common/commonElements.css +++ b/skins/common/commonElements.css @@ -86,15 +86,9 @@ h6 { h1 { font-size: 188%; } -h1 .editsection { - font-size: 53%; -} h2 { font-size: 150%; } -h2 .editsection { - font-size: 67%; -} h3, h4, h5, @@ -105,29 +99,15 @@ h6 { h3 { font-size: 132%; } -h3 .editsection { - font-size: 76%; - font-weight: normal; -} h4 { font-size: 116%; } -h4 .editsection { - font-size: 86%; - font-weight: normal; } h5 { font-size: 105%; } -h5 .editsection { - font-weight: normal; -} h6 { font-size: 100%; } -h6 .editsection { - font-size: 125%; - font-weight: normal; -} /* Some space under the headers in the content area */ h1, diff --git a/skins/common/commonPrint.css b/skins/common/commonPrint.css index 9ea89d91b1..4bb99ae9ea 100644 --- a/skins/common/commonPrint.css +++ b/skins/common/commonPrint.css @@ -112,7 +112,6 @@ div.top, div#column-one, #colophon, .mw-editsection, -.editsection, .toctoggle, .tochidden, div#f-poweredbyico, diff --git a/skins/common/oldshared.css b/skins/common/oldshared.css index fa86aeeeb7..2a9c25f5f6 100644 --- a/skins/common/oldshared.css +++ b/skins/common/oldshared.css @@ -20,16 +20,6 @@ h1, h2, h3, h4, h5, h6 { /* Now the custom parts */ -/* Make edit sections (which are inside h# tags) normal-sized */ -.editsection { - font-weight: normal; -} -h1 .editsection { font-size: 50%; } -h2 .editsection { font-size: 66.7%; } -h3 .editsection { font-size: 85.5%; } -h5 .editsection { font-size: 120%; } -h6 .editsection { font-size: 133%; } - #footer { clear: both } /* images */ /* @noflip */ diff --git a/skins/common/shared.css b/skins/common/shared.css index d946ce2504..4c684014e7 100644 --- a/skins/common/shared.css +++ b/skins/common/shared.css @@ -127,21 +127,6 @@ span.texhtml { cursor: pointer; } -/* Edit section links */ -/* Correct directionality when page dir is different from site/user dir */ -/* @noflip */ -.mw-content-ltr .editsection, -.mw-content-rtl .mw-content-ltr .editsection { - float: right; - margin-left: 5px; -} -/* @noflip */ -.mw-content-rtl .editsection, -.mw-content-ltr .mw-content-rtl .editsection { - float: left; - margin-right: 5px; -} - /** * File description page */ @@ -1121,7 +1106,8 @@ table.floatleft { z-index: 99; } -.mw-editsection, .editsection, .toctoggle { +.mw-editsection, +.toctoggle { -moz-user-select: none; -webkit-user-select: none; -ms-user-select: none; diff --git a/skins/common/wikiprintable.css b/skins/common/wikiprintable.css index f5650b5105..dc236ea0c6 100644 --- a/skins/common/wikiprintable.css +++ b/skins/common/wikiprintable.css @@ -33,7 +33,6 @@ a.stub { #footer, #siteNotice, .mw-editsection, -.editsection, .toctoggle { display: none; } diff --git a/skins/modern/main.css b/skins/modern/main.css index 7e7758a697..f222028887 100644 --- a/skins/modern/main.css +++ b/skins/modern/main.css @@ -340,10 +340,6 @@ a.new:visited { color: #a55858; } -span.editsection { - font-size: small; -} - h1, h2 { border-bottom: solid 1px #003366; } diff --git a/skins/modern/print.css b/skins/modern/print.css index 6e0f8b3fef..e97bbdb403 100644 --- a/skins/modern/print.css +++ b/skins/modern/print.css @@ -4,7 +4,6 @@ #jump-to-nav, #footer, .mw-editsection, -span.editsection, .noprint { display: none; } diff --git a/skins/vector/screen.css b/skins/vector/screen.css index eb4a4dda64..fd839bd49d 100644 --- a/skins/vector/screen.css +++ b/skins/vector/screen.css @@ -688,10 +688,6 @@ div#content { font-size: 0.8em; } -.editsection { - float: right; -} - ul { list-style-type: disc; /* @embed */ -- 2.20.1