From 6b1ca85051cb54fb1e0f87aff7489cf0f8a0a0bf Mon Sep 17 00:00:00 2001
From: Reedy <reedy@wikimedia.org>
Date: Sat, 7 Apr 2012 17:33:50 +0100
Subject: [PATCH] Export::dumpFrom() doesn't return any values, and hence
 neither do any of the methods calling it (return $this->dumpFrom)

Remove return statements and extra from upstream callers

Change-Id: Ibad983128ef601e9fab5538d9ec02963e024b0a6
---
 includes/Export.php | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/includes/Export.php b/includes/Export.php
index 24daa0932e..b97615b709 100644
--- a/includes/Export.php
+++ b/includes/Export.php
@@ -103,7 +103,7 @@ class WikiExporter {
 	 * the most recent version.
 	 */
 	public function allPages() {
-		return $this->dumpFrom( '' );
+		$this->dumpFrom( '' );
 	}
 
 	/**
@@ -118,7 +118,7 @@ class WikiExporter {
 		if ( $end ) {
 			$condition .= ' AND page_id < ' . intval( $end );
 		}
-		return $this->dumpFrom( $condition );
+		$this->dumpFrom( $condition );
 	}
 
 	/**
@@ -133,14 +133,14 @@ class WikiExporter {
 		if ( $end ) {
 			$condition .= ' AND rev_id < ' . intval( $end );
 		}
-		return $this->dumpFrom( $condition );
+		$this->dumpFrom( $condition );
 	}
 
 	/**
 	 * @param $title Title
 	 */
 	public function pageByTitle( $title ) {
-		return $this->dumpFrom(
+		$this->dumpFrom(
 			'page_namespace=' . $title->getNamespace() .
 			' AND page_title=' . $this->db->addQuotes( $title->getDBkey() ) );
 	}
@@ -150,7 +150,7 @@ class WikiExporter {
 		if ( is_null( $title ) ) {
 			throw new MWException( "Can't export invalid title" );
 		} else {
-			return $this->pageByTitle( $title );
+			$this->pageByTitle( $title );
 		}
 	}
 
@@ -161,7 +161,7 @@ class WikiExporter {
 	}
 
 	public function allLogs() {
-		return $this->dumpFrom( '' );
+		$this->dumpFrom( '' );
 	}
 
 	public function logsByRange( $start, $end ) {
@@ -169,7 +169,7 @@ class WikiExporter {
 		if ( $end ) {
 			$condition .= ' AND log_id < ' . intval( $end );
 		}
-		return $this->dumpFrom( $condition );
+		$this->dumpFrom( $condition );
 	}
 
 	# Generates the distinct list of authors of an article
-- 
2.20.1