From 600d880fb782d94058381b2f683739f2f047e570 Mon Sep 17 00:00:00 2001 From: Priyanka Dhanda Date: Thu, 14 Oct 2010 17:56:52 +0000 Subject: [PATCH] Cleanup of SimpleSeleniumTestCase. Removed unnecessary include. --- maintenance/tests/selenium/SimpleSeleniumConfig.php | 2 +- maintenance/tests/selenium/SimpleSeleniumTestCase.php | 4 ++++ maintenance/tests/selenium/SimpleSeleniumTestSuite.php | 1 - 3 files changed, 5 insertions(+), 2 deletions(-) diff --git a/maintenance/tests/selenium/SimpleSeleniumConfig.php b/maintenance/tests/selenium/SimpleSeleniumConfig.php index 48de1e25a0..cffa83c4ea 100644 --- a/maintenance/tests/selenium/SimpleSeleniumConfig.php +++ b/maintenance/tests/selenium/SimpleSeleniumConfig.php @@ -3,7 +3,7 @@ class SimpleSeleniumConfig { public static function getSettings(&$includeFiles, &$globalConfigs) { $includes = array( - 'skins/Chick.php' + //files that needed to be included would go here ); $configs = array( 'wgDefaultSkin' => 'chick' diff --git a/maintenance/tests/selenium/SimpleSeleniumTestCase.php b/maintenance/tests/selenium/SimpleSeleniumTestCase.php index 8f27dcd360..8f01b43791 100644 --- a/maintenance/tests/selenium/SimpleSeleniumTestCase.php +++ b/maintenance/tests/selenium/SimpleSeleniumTestCase.php @@ -17,6 +17,10 @@ class SimpleSeleniumTestCase extends SeleniumTestCase { $this->assertEquals( $correct, true ); } + /* + * All this test really does is verify that a global var was set. + * It depends on $wgDefaultSkin = 'chick'; being set + */ public function testGlobalVariableForDefaultSkin() { $this->open( $this->getUrl() . '/index.php?&action=purge' ); $bodyClass = $this->getAttribute( "//body/@class" ); diff --git a/maintenance/tests/selenium/SimpleSeleniumTestSuite.php b/maintenance/tests/selenium/SimpleSeleniumTestSuite.php index cf3293766e..49a06d4618 100644 --- a/maintenance/tests/selenium/SimpleSeleniumTestSuite.php +++ b/maintenance/tests/selenium/SimpleSeleniumTestSuite.php @@ -7,7 +7,6 @@ * $wgSeleniumTestConfigs['SimpleSeleniumTestSuite'] = 'SimpleSeleniumConfig::getSettings'; * OR * 2) Add the following to your Localsettings.php - * require_once( "$IP/skins/Chick.php" ); * $wgDefaultSkin = 'chick'; */ class SimpleSeleniumTestSuite extends SeleniumTestSuite -- 2.20.1