Sam Reed [Tue, 6 Dec 2011 15:23:21 +0000 (15:23 +0000)]
Add a getExpiry method to Block (rather than direct member variable access. Yuck)
Antoine Musso [Tue, 6 Dec 2011 12:49:59 +0000 (12:49 +0000)]
revert r104468 per CR: not needed :-)
Antoine Musso [Tue, 6 Dec 2011 10:50:47 +0000 (10:50 +0000)]
allow bold in TOC lines
just like r102179 allowed italics in TOC lines for bug 26375, this
patch allow bold text as well.
Antoine Musso [Tue, 6 Dec 2011 09:41:52 +0000 (09:41 +0000)]
Diff colors now use the french Wikipedia scheme
The french community has been using a specific set of colors for diff, it is
believed to be easier to read for people perceiving colors differently.
Source is from:
http://fr.wikipedia.org/w/index.php?oldid=
72567845&uselang=en
This commit override r94429 / r94461.
See also docs/uidesign/mediawiki.action.history.diff.html
Antoine Musso [Tue, 6 Dec 2011 09:35:24 +0000 (09:35 +0000)]
uidesign: fix diffchange, show basic diff just like on wiki
Antoine Musso [Tue, 6 Dec 2011 09:15:41 +0000 (09:15 +0000)]
basic design file for our diffs
Might help folks on r94461 . Loading this file will let you easily
look at the diff file. Might need to be improved to show a real diff
instead.
Antoine Musso [Tue, 6 Dec 2011 09:14:27 +0000 (09:14 +0000)]
move docs/design.html to a new 'uidesign' directory
Tim Starling [Tue, 6 Dec 2011 01:21:08 +0000 (01:21 +0000)]
Fix for r103471: WikiPage::doSubmit() is not the only implementation of doSubmit() that needs to be patched to return true. Without this, action=purge on an image page just shows a blank body.
Krinkle [Mon, 5 Dec 2011 22:29:40 +0000 (22:29 +0000)]
mediawiki.user.js comment fix
Raimond Spekking [Mon, 5 Dec 2011 21:02:57 +0000 (21:02 +0000)]
Localisation updates for core and extension messages from translatewiki.net
Aaron Schulz [Mon, 5 Dec 2011 19:17:44 +0000 (19:17 +0000)]
FU r104216: keep the r103738 regex check for thumbnails but use the parent directory as the source file name. This avoids the assumption that the thumb URL starts with /thumb.
Daniel Friesen [Mon, 5 Dec 2011 18:56:09 +0000 (18:56 +0000)]
Add missing @since tags for getLanguage and deal with this sanitizeLangCode fatal that no-one bothered to fix.
Sam Reed [Mon, 5 Dec 2011 16:50:58 +0000 (16:50 +0000)]
More documentation of parameters following up r104591
Sam Reed [Mon, 5 Dec 2011 16:33:54 +0000 (16:33 +0000)]
Fix hook name in RELEASE-NOTES-1.19 per Niklas on r104441
Antoine Musso [Mon, 5 Dec 2011 16:15:05 +0000 (16:15 +0000)]
Fix PageHistoryBeforeList hook
Following r100534 refactoring, it was using an incorrect variable.
Raimond Spekking [Mon, 5 Dec 2011 12:47:52 +0000 (12:47 +0000)]
Revert r105162 for now per CR.
Antoine Musso [Mon, 5 Dec 2011 10:56:56 +0000 (10:56 +0000)]
Fix PageHistoryBeforeList hook
Following r100534 refactoring, it was using an incorrect variable.
Use the new accessor instead.
Antoine Musso [Mon, 5 Dec 2011 10:14:40 +0000 (10:14 +0000)]
Skip replaceInternalLinks2 for js/css pages
Just skip the whole replaceInternalLinks2 parser function whenever we hit
js/css pages. Previous patch r103476 only handled Category links which was
not enough.
Aaron Schulz [Mon, 5 Dec 2011 07:22:27 +0000 (07:22 +0000)]
* Made resetDB() actually clear out the tables rather than leave the contents
* Removed destroyDB(); unused and broken (does not use prefix)
Roan Kattouw [Mon, 5 Dec 2011 07:03:21 +0000 (07:03 +0000)]
Revert r105140 temporarily. The exception is thrown while running the parser tests (at least from Jenkins, haven't tried locally), which completely breaks the test suite and renders Jenkins useless. Feel free to reapply once the cause of the oi_archive_name bug is fixed and committing this won't cause exceptions to be thrown in Jenkins's face.
John Du Hart [Mon, 5 Dec 2011 02:29:08 +0000 (02:29 +0000)]
Type hinting please
Amir E. Aharoni [Mon, 5 Dec 2011 00:13:06 +0000 (00:13 +0000)]
Showing an error message always left-to-right.
Aaron Schulz [Sun, 4 Dec 2011 23:34:24 +0000 (23:34 +0000)]
Added file old version name sanity check to recordUpload2()
John Du Hart [Sun, 4 Dec 2011 18:35:40 +0000 (18:35 +0000)]
svn:eol-style native on all phase3 stuff, since I messed that up in r105122
Also adding the MWDebug class I missed there as well
John Du Hart [Sun, 4 Dec 2011 18:29:57 +0000 (18:29 +0000)]
Adding new debugging toolbar
Needs a UI cleanup still, but for the most part is working.
Derk-Jan Hartman [Sun, 4 Dec 2011 16:38:43 +0000 (16:38 +0000)]
Remove documentByLine, as documentDescription unused since introduced in r2881
Derk-Jan Hartman [Sun, 4 Dec 2011 16:31:17 +0000 (16:31 +0000)]
Remove documentDescription class, which seems to have been introduced with the original monobook commit, but was never actually used.
Derk-Jan Hartman [Sun, 4 Dec 2011 16:19:14 +0000 (16:19 +0000)]
Remove totally pointless and somewhat annoying !important from commonPrint.
This fixes bug 32795
Derk-Jan Hartman [Sun, 4 Dec 2011 16:06:56 +0000 (16:06 +0000)]
Follow up to r105114
one more tocindent
Derk-Jan Hartman [Sun, 4 Dec 2011 15:59:38 +0000 (15:59 +0000)]
Remove tocindent and tocinline from print stylesheet. These seem to have been unused since r7073
Daniel Friesen [Sat, 3 Dec 2011 23:19:34 +0000 (23:19 +0000)]
Followup r103678; Add a comment.
Raimond Spekking [Sat, 3 Dec 2011 14:56:00 +0000 (14:56 +0000)]
Localisation updates for core and extension messages from translatewiki.net
Sam Reed [Fri, 2 Dec 2011 21:50:42 +0000 (21:50 +0000)]
Per Timo, the second line would wipe out the first
Brion Vibber [Fri, 2 Dec 2011 21:47:46 +0000 (21:47 +0000)]
Followup r104671: fix regression in jquery.delayedBind() due to change in param processing for jquery's bind()
Problem was per CR comment https://www.mediawiki.org/wiki/Special:Code/MediaWiki/104671#c26836 -- parameter count check changed in upstream jquery.bind(), causing the way we passed params to break if the optional 'data' parameter was left out.
Added QUnit test cases for jquery.delayedBind() with and without the optional 'data' parameter.
Undoes r104671 since the issue it was working around is fixed.
Aaron Schulz [Fri, 2 Dec 2011 07:45:20 +0000 (07:45 +0000)]
Fixed comment typo
Tim Starling [Fri, 2 Dec 2011 02:59:11 +0000 (02:59 +0000)]
purgeParserCache.php improvements:
* Do queries in batches of 100 rows instead of all at once. Note that if there are a lot of objects with the exact same expiry time, it might take multiple runs of the script to delete them all.
* Progress meter.
Sam Reed [Fri, 2 Dec 2011 00:29:46 +0000 (00:29 +0000)]
Reverting r103706
Only seemingly supported by MySQL, and likely a seldom used function
Not worth trying to support it, as other non mysql db's would need workarounds, and that's just not happening
gicode [Thu, 1 Dec 2011 19:11:54 +0000 (19:11 +0000)]
Attempt to fix External Edit for files.
I would feel better if I knew how to test this all the way through...
Follow-up r102521.
Raimond Spekking [Thu, 1 Dec 2011 15:19:26 +0000 (15:19 +0000)]
Localisation updates for core and extension messages from translatewiki.net
Chad Horohoe [Thu, 1 Dec 2011 14:41:07 +0000 (14:41 +0000)]
Fix double period from r104043
Sam Reed [Thu, 1 Dec 2011 14:40:11 +0000 (14:40 +0000)]
Don't comment tests out, use $this->markTestIncomplete()
Followup r104812
Sam Reed [Thu, 1 Dec 2011 00:40:56 +0000 (00:40 +0000)]
Comment out brokwn Xml::dateMenu() tests
Failing because it's december (ie the test is wrong)
Sam Reed [Thu, 1 Dec 2011 00:24:22 +0000 (00:24 +0000)]
Another artefact of the disable account merge
Remove disableaccount userright from core
Brion Vibber [Wed, 30 Nov 2011 23:17:19 +0000 (23:17 +0000)]
* (bug 4901) lang, hreflang attributes added to sidebar interlanguage links
The lang attribute assists screen readers in reading out the language name correctly; see sample recordings from iOS's VoiceOver reader mode attached on <https://bugzilla.wikimedia.org/show_bug.cgi?id=4901>
hreflang attribute is less clearly useful, but may assist some tools in indicating the language of the destination site.
Inline interwiki links have not been changed.
Release notes will be added on 1.18 channel, this is an old bug fix and easy to backport.
Platonides [Wed, 30 Nov 2011 23:06:18 +0000 (23:06 +0000)]
Unused $wgParser. Fix comment
Roan Kattouw [Wed, 30 Nov 2011 22:48:10 +0000 (22:48 +0000)]
Fix notice in r104684
Brion Vibber [Wed, 30 Nov 2011 22:38:39 +0000 (22:38 +0000)]
* (bug 16434) Fix paging on Special:Prefixindex when prefix is empty (whole namespace).
Tweaked input handling to make sure the 'from' => 'prefix' mapping doesn't happen if we have passed a namespace parameter (indicating we're working within the form). Tweaked the form paging links to include the NS even if it's 0. :)
Originally wanted to just check for presence of 'prefix' however wfArrayToCgi() strips empty values, and I'm not comfortable tweaking that without a lot more testing.
Raimond Spekking [Wed, 30 Nov 2011 20:59:10 +0000 (20:59 +0000)]
Localisation updates for core and extension messages from translatewiki.net
Roan Kattouw [Wed, 30 Nov 2011 20:03:34 +0000 (20:03 +0000)]
Add RefreshLinks class to the AutoLoader, I'll need it for my cleanup script for bug 31576
Jan Gerber [Wed, 30 Nov 2011 15:58:16 +0000 (15:58 +0000)]
add concatenate no-op to ForeignAPIRepo.php
Follow up r104687
Jan Gerber [Wed, 30 Nov 2011 15:24:27 +0000 (15:24 +0000)]
Fix DatabaseSqliteTest for db changes for chunk support.
follow up 104687
Daniel Friesen [Wed, 30 Nov 2011 15:12:19 +0000 (15:12 +0000)]
Followup r104688, reintroduce the full PathRouter code now that the bug with url encoded paths is fixed.
Daniel Friesen [Wed, 30 Nov 2011 15:09:08 +0000 (15:09 +0000)]
Followup r104274, r104676. Fix the bug that broke fr. Forgot to rawurldecode path contents.
Also add /u just for sanity sake.
Add new tests for url encoding, unicode, and length edge cases.
Jan Gerber [Wed, 30 Nov 2011 14:56:40 +0000 (14:56 +0000)]
Use database to track uploaded chunks and concatenate at the end.
with i18n documentation dont break phpunit
follow up r93720
Roan Kattouw [Wed, 30 Nov 2011 14:56:28 +0000 (14:56 +0000)]
RELEASE-NOTES for r104668, r104671, r104684
Roan Kattouw [Wed, 30 Nov 2011 14:51:07 +0000 (14:51 +0000)]
)bug 15521) Use new section summary when the action of adding a new section also happens to create the page. Patch by Harry Burt
Roan Kattouw [Wed, 30 Nov 2011 13:54:35 +0000 (13:54 +0000)]
Revert r104659 and its followup r104665: break the unit tests with a fatal error. This cripples our CI system, we can't detect new failures this way.
Daniel Friesen [Wed, 30 Nov 2011 13:37:22 +0000 (13:37 +0000)]
Recommit PathRouter code from r104274, r104284, r104285 without the WebRequest.php and hooks.txt code so we can start to add tests and fix the bug in it.
Roan Kattouw [Wed, 30 Nov 2011 13:16:18 +0000 (13:16 +0000)]
(bug 31212) History tab not collapsed when the screen is narrow. Patch by Michael M
Roan Kattouw [Wed, 30 Nov 2011 12:43:10 +0000 (12:43 +0000)]
(bug 32230) Expose wgRedirectedFrom (title of the page we were redirected from, if any) in JavaScript. Patch by MrBlueSky
Jan Gerber [Wed, 30 Nov 2011 12:13:11 +0000 (12:13 +0000)]
add i18n#Message_documentation for the newly added messages and add entry to messages.inc
follow up r104659
Jan Gerber [Wed, 30 Nov 2011 08:55:16 +0000 (08:55 +0000)]
Use database to track uploaded chunks and concatenate at the end.
follow up r93720
Neil Kandalgaonkar [Wed, 30 Nov 2011 01:41:05 +0000 (01:41 +0000)]
use example.com, the RFC-2606 guaranteed example url. followup to r99446
Brion Vibber [Wed, 30 Nov 2011 00:37:35 +0000 (00:37 +0000)]
Apply the actual fix from r104635. :P
Brion Vibber [Wed, 30 Nov 2011 00:36:34 +0000 (00:36 +0000)]
* (bug 32712) Fix for search indexing of pages with certain unicode chars following URL
A regex in SearchUpdate was built for ancient pure ISO 8859-1 and looked for \xa0-\xff bytes -- this caused the regex to cut off partway through if there was a char containing a byte in the \x80-\x9f range.
Fixed regex to pass \x80-\xff instead.
Added a test case to SearchUpdateTest which checks for this case (example text run through the update squash algo, then run through preg_replace with a /u param to make sure it gets treated as UTF-8 and checking whether it breaks.)
Robin Pepermans [Tue, 29 Nov 2011 21:07:24 +0000 (21:07 +0000)]
Change number separator from dot to a space, per User:Nemo_bis (it is the convention in Italian to use spaces)
Sam Reed [Tue, 29 Nov 2011 21:04:20 +0000 (21:04 +0000)]
Moar documentations
Raimond Spekking [Tue, 29 Nov 2011 20:32:09 +0000 (20:32 +0000)]
Localisation updates for core and extension messages from translatewiki.net
Chad Horohoe [Tue, 29 Nov 2011 17:59:52 +0000 (17:59 +0000)]
Fix r102137. CliInstaller needs to override wgServer, but not in a manner that breaks the web installer.
Robin Pepermans [Tue, 29 Nov 2011 16:48:37 +0000 (16:48 +0000)]
The URL wasn't loading when the database is used (interwiki cache works). "PHP Notice: Trying to get property of non-object in /www/w/includes/api/ApiQuerySiteinfo.php on line 295"
This reverts r97806. It took me some time to find out, but r96475 accidentally backported the change from $row->iw_url to $row['iw_url'] (etc) to 1.18, which was fixed in r97789. That revision was merged to trunk, which shouldn't have been done either. I.e. until 1.18 it is an object, from 1.19 it is an array.
Antoine Musso [Tue, 29 Nov 2011 14:23:24 +0000 (14:23 +0000)]
Fix fatal error when running newParserTest
The delayed parser test feature was expecting a ParserTest object which is
almost never the case when using the NewParserTest for PHPUnit. The class
name is forged after the file name! They at least all extends NewParserTest
no polymorphism? no multiple hinting. Be creative the PHP way by writing
your own code :-(
Antoine Musso [Tue, 29 Nov 2011 13:54:17 +0000 (13:54 +0000)]
parserTest: delay hooks execution to the point we really need them
disabled and filtered out tests were still triggering hooks run. This patch
let us delay hooks running run a little bit until we know we will really need
their execution (i.e. when test is not filtered out and not disabled).
Saving all that unneeded code execution makes running a subset of parser tests
a bit faster when one has many extension enabled.
NOTE: '!!article' sections are still parsed regardless of their usage.
We would need to add an article/test dependency system to really filter them
Antoine Musso [Tue, 29 Nov 2011 12:46:04 +0000 (12:46 +0000)]
use {} even when if statement is oneliner
Antoine Musso [Tue, 29 Nov 2011 12:17:55 +0000 (12:17 +0000)]
Move terminal colorers classes in their own file
They were originally written for parserTests output and were in
tests/testHelpers.inc since them. Those classes can be used by most
our maintenance scripts anyway, so here is their new home.
Also make tests/testHelpers.inc a bit shorter which is always welcome.
Antoine Musso [Tue, 29 Nov 2011 11:45:52 +0000 (11:45 +0000)]
abstract out $data and name it 'sectionData'
Makes things easier to handle when calling other methods. This avoid method
with ton of parameters.
Also moved duplicate code that reset section data to a new clearSection()
method. Less lines makes code easier to read.
Follow r104549
Antoine Musso [Tue, 29 Nov 2011 11:34:05 +0000 (11:34 +0000)]
nicely align array key / values
Antoine Musso [Tue, 29 Nov 2011 11:27:29 +0000 (11:27 +0000)]
abstract out section sanity check
$section is now a private propery.
The new function avoid code duplication.
Antoine Musso [Tue, 29 Nov 2011 10:52:26 +0000 (10:52 +0000)]
nice debug msg for Title::getRestrictionTypes
Antoine Musso [Tue, 29 Nov 2011 10:22:09 +0000 (10:22 +0000)]
restore parser tests names
r100932 disabled two 'Bad images' tests but did so by also erasing the
test name. Hence we could no more tests them even with --run-disabled.
Test plan:
==========
$ php parserTests.php --run-disabled --filter 'Bad images'
--> output two tests failing as expected
$ php parserTests.php --filter 'Bad images'
--> output no tests found
$ php parserTests.php --quiet
--> ALL PASSED :-)
Sam Reed [Tue, 29 Nov 2011 00:09:04 +0000 (00:09 +0000)]
Bit more documentation
(test commit also)
Sam Reed [Mon, 28 Nov 2011 23:18:55 +0000 (23:18 +0000)]
* (bug 32276) Skins were generating output using the internal page title which would allow anonymous users to determine wheter a page exists, potentially leaking private data. In fact, the curid and oldid request parameters would
allow page titles to be enumerated even when they are not guessable.
* (bug 32616) action=ajax requests were dispatched to the relevant internal functions without any read permission checks being done. This could lead to data leakage on private wikis.
Raimond Spekking [Mon, 28 Nov 2011 21:01:31 +0000 (21:01 +0000)]
Localisation updates for core and extension messages from translatewiki.net
Robin Pepermans [Mon, 28 Nov 2011 20:53:26 +0000 (20:53 +0000)]
* (bug 27721) Make JavaScript variables wgSeparatorTransformTable and wgDigitTransformTable depend on page content language so the sort script sorts correctly more often. It will e.g. sort according to the user language on special pages, where localised numbers are usually used.
* New JavaScript variable wgPageContentLanguage (independent from the bug, but I assume this var can be useful)
Sam Reed [Mon, 28 Nov 2011 20:35:32 +0000 (20:35 +0000)]
* (bug 32688) Paraminfo for parameter "generator" of the query module shows too many types
Pass prop and list through the generator filtering in the constructor
Sam Reed [Mon, 28 Nov 2011 20:04:40 +0000 (20:04 +0000)]
Followup r104445, swap the xmlnamespace url back to
Brion Vibber [Mon, 28 Nov 2011 19:55:49 +0000 (19:55 +0000)]
Revert r104274, r104284, r104285 -- breaks special pages on non-english
Brion Vibber [Mon, 28 Nov 2011 19:30:34 +0000 (19:30 +0000)]
* (bug 32659) Code cleanup: normalize order of params to implode() in Language:: functions
Patch by Daniel Werner, https://bugzilla.wikimedia.org/attachment.cgi?id=9555&action=diff
For "historical reasons" implode() accepts parameters as ($list, $sep) as well as the usual ($sep, $list) but it's better to use the standard to be clear.
Sam Reed [Mon, 28 Nov 2011 19:17:06 +0000 (19:17 +0000)]
Followup r104441
Fix capitalisation mismatch
Sam Reed [Mon, 28 Nov 2011 19:02:59 +0000 (19:02 +0000)]
URL-ify index.php urls
Sam Reed [Mon, 28 Nov 2011 15:43:11 +0000 (15:43 +0000)]
Oh noes, moar http:// -> https://
Sam Reed [Mon, 28 Nov 2011 15:33:28 +0000 (15:33 +0000)]
Added "ApiGetDescription" hook
Sam Reed [Mon, 28 Nov 2011 15:19:20 +0000 (15:19 +0000)]
Bump MySQL version to 5.0.2 after r104047
Documentation
Antoine Musso [Mon, 28 Nov 2011 15:19:09 +0000 (15:19 +0000)]
use meaningful test in a parser test
Readin the text case, I though 'pre' was some kind of magic keyword to render
a preformatted text. It happens it is just a text. Replacing it with something
that will not confuse me or others.
follow up r103933
Sam Reed [Mon, 28 Nov 2011 15:17:46 +0000 (15:17 +0000)]
Https for all!
(omg, this hadn't been reported)
Aaron Schulz [Mon, 28 Nov 2011 09:03:39 +0000 (09:03 +0000)]
Fix r104410: Added default value for $options to purgeThumbnails(), not sure how this was lost in the patch
Aaron Schulz [Mon, 28 Nov 2011 08:57:46 +0000 (08:57 +0000)]
FU r104410: don't even bother calling filterThumbnailPurgeList() if 'forRefresh' isn't set to be safe
Aaron Schulz [Mon, 28 Nov 2011 08:53:03 +0000 (08:53 +0000)]
Restored r98710 but with a 'forRefresh' option (not used yet)
Antoine Musso [Mon, 28 Nov 2011 06:52:34 +0000 (06:52 +0000)]
using real identity for hashar
Most other occurrences where changed by r100588 already.
Thanks to "Reach Out to the Truth" for spotting this one.
Tim Starling [Mon, 28 Nov 2011 04:40:31 +0000 (04:40 +0000)]
Fix for r101677: remove the extra parameters from the other getImageArea() callers.
Tim Starling [Mon, 28 Nov 2011 04:37:15 +0000 (04:37 +0000)]
Fix for r99911: don't use getImageArea() to determine the area for comparison against $wgMaxImageArea, this breaks the $wgMaxAnimatedGifArea feature completely.