Roan Kattouw [Sat, 24 Sep 2011 15:24:13 +0000 (15:24 +0000)]
Followup r97962: add qqq for new messages, and expand it for the -abbrev messages.
Raimond Spekking [Sat, 24 Sep 2011 06:13:43 +0000 (06:13 +0000)]
Register new message keys from r97962
Aaron Schulz [Sat, 24 Sep 2011 01:17:04 +0000 (01:17 +0000)]
Added filecache support for history pages
Aaron Schulz [Sat, 24 Sep 2011 00:55:49 +0000 (00:55 +0000)]
FU r97978: removed more raw page file cache code
Aaron Schulz [Sat, 24 Sep 2011 00:37:11 +0000 (00:37 +0000)]
Removed action=raw support from HTMLFileCache. Obsolete due to RL.
Brion Vibber [Fri, 23 Sep 2011 22:17:41 +0000 (22:17 +0000)]
Followup r97954: fix unit tests for wfShellMaintenanceCmd() to work on Unix as well as Windows
Roan Kattouw [Fri, 23 Sep 2011 22:17:10 +0000 (22:17 +0000)]
Make Language::formatTimePeriod() more flexible so it can produce stuff like '3 hours ago'.
* Add a $noAbbrevs parameter that causes the 'seconds', 'minutes', etc. messages to be used instead of the 'seconds-abbrev', 'minutes-abbrev', etc. messages
* Add the 'seconds', 'minutes', 'hours' and 'days' messages
* Change the -abbrev messages to take a parameter rather than having the number prepended to them. This is for compatibility with 'seconds' et al, which need the parameter for {{PLURAL:}}. It also generally makes more sense. This does BREAK the messages in non-English languages that override them; Niklas told me to leave this alone and ping the TranslateWiki folks
* Introduce an 'ago' message for '$1 ago'. Not currently used in core, but I want to use it in an extension and it seemed stupid not to have such a thing in core.
* Refactor the function to use message objects and pass the number as a parameter
* Add tests! They exposed a subtle bug in my first iteration; all hail tests!
Roan Kattouw [Fri, 23 Sep 2011 22:02:36 +0000 (22:02 +0000)]
Rewrite testFormatTimePeriod() with a data provider
Aaron Schulz [Fri, 23 Sep 2011 20:42:22 +0000 (20:42 +0000)]
Added wfShellMaintenanceCmd() for Het Deploy support
Sam Reed [Fri, 23 Sep 2011 20:20:41 +0000 (20:20 +0000)]
Fix single character access
Raimond Spekking [Fri, 23 Sep 2011 20:09:54 +0000 (20:09 +0000)]
Localisation updates for core and extension messages from translatewiki.net
Sam Reed [Fri, 23 Sep 2011 18:01:40 +0000 (18:01 +0000)]
God. Damn. You. Php.
Followup r97919
Alexandre Emsenhuber [Fri, 23 Sep 2011 17:21:08 +0000 (17:21 +0000)]
Use local context instead of global variables
Alexandre Emsenhuber [Fri, 23 Sep 2011 16:15:30 +0000 (16:15 +0000)]
* Call Linker methods statically
* Moved wfReadOnly() check after permissions so that users don't think the error is temporary if they and don't have permissions and the database is locked
* Removed "unexpected value of 'oldimage'" message which seems to say there's an internal error somewhere instead that the oldimage parameter is not in correct format
Sam Reed [Fri, 23 Sep 2011 14:14:55 +0000 (14:14 +0000)]
Mostly revert r97328
Swap substring to be done on smaller (more correct) values
Alexandre Emsenhuber [Fri, 23 Sep 2011 12:55:01 +0000 (12:55 +0000)]
Factorise calls to $this->getSkin()->getUser() in SkinCologneBlue::quickBar(); also moved the call $this->getSkin()->getTitle() near the only place where it's used
Ariel Glenn [Fri, 23 Sep 2011 07:48:30 +0000 (07:48 +0000)]
add mwscript handling for call of fetchText.php maintenance script
Ariel Glenn [Fri, 23 Sep 2011 06:15:20 +0000 (06:15 +0000)]
handle naming checkpoint file with first/last pageID when the file is empty
Sam Reed [Thu, 22 Sep 2011 23:53:37 +0000 (23:53 +0000)]
Rarrgh
Swapping " for ' doesn't make it en-gb
Deleted also on TW
Brion Vibber [Thu, 22 Sep 2011 22:10:41 +0000 (22:10 +0000)]
* (bug 31089) Fix regression in Special:Block reasons list (MediaWiki:Ipbreason-dropdown parsing)
Followup to r83298: makes HTMLSelectAndOtherField backwards-compatible with Xml::listDropDown as it was apparently intended to be.
Also fixed double-escaping in the options for HTMLSelectAndOtherField.
Followup to r83795: fixes regression in Special:Block by fixing HTMLSelectAndOtherField which got used in place of Xml::listDropDown, but wasn't compatible.
Note that this removes the clever thing that lets you have separate values and texts in your dropdown; since Xml::listDropDown had no such feature and actual usage includes texts containing links and other stuch where the pipe character is a legit part of the content.
Brion Vibber [Thu, 22 Sep 2011 21:35:24 +0000 (21:35 +0000)]
* (bug 31100) Fix regression in sidebar (special: page links lost parameters)
Regression in Title::fixSpecialName() in r86255; fixed and added a unit test case to TitleTest.
Niklas Laxström [Thu, 22 Sep 2011 21:27:04 +0000 (21:27 +0000)]
rv r97851 for further inspection, causes PHP notices
Happy-melon [Thu, 22 Sep 2011 21:06:55 +0000 (21:06 +0000)]
FU r95640: documentation for message change. Also replace a deprecated <font> element that my IDE complained about.
Ilmari Karonen [Thu, 22 Sep 2011 20:44:05 +0000 (20:44 +0000)]
followup r79862: the for loop only cleans up half the output handlers (since $i counts up while ob_get_level() counts down); check the return value of ob_end_clean() instead.
(I just noticed this while eyeballing the code -- apparently most people don't have multiple output handlers active, given that nobody had caught this in over eight months.)
Robin Pepermans [Thu, 22 Sep 2011 20:31:23 +0000 (20:31 +0000)]
Re-do r96798 ("LanguageConverter now depends on the page content language"), without the change in WikiPage which caused an infinite loop (see bug 31098)
Raimond Spekking [Thu, 22 Sep 2011 19:48:56 +0000 (19:48 +0000)]
Localisation updates for core and extension messages from translatewiki.net
Alexandre Emsenhuber [Thu, 22 Sep 2011 19:15:25 +0000 (19:15 +0000)]
Per Aaron, fix for r97658: removed double call to parent constructor that will also fix the E_NOTICE
Niklas Laxström [Thu, 22 Sep 2011 16:00:33 +0000 (16:00 +0000)]
Parser test for bug 31098, disabled of course
Sam Reed [Thu, 22 Sep 2011 15:08:32 +0000 (15:08 +0000)]
Guard against
PHP fatal error in /home/wikipedia/common/php-1.18/includes/Linker.php line 831:
Argument 1 passed to Linker::makeMediaLinkObj() must be an instance of Title, null given, called in /home/wikipedia/common/php-1.18/includes/Linker.php on line 1221 and defined
Sam Reed [Thu, 22 Sep 2011 14:57:08 +0000 (14:57 +0000)]
Fix single character access
Niklas Laxström [Thu, 22 Sep 2011 14:04:08 +0000 (14:04 +0000)]
Don't load all languages just to check whether message is known.
I'm pretty sure I already fixed this once in the past.
Sam Reed [Thu, 22 Sep 2011 12:14:21 +0000 (12:14 +0000)]
* (bug 31081) $wgEnotifUseJobQ causes many unnecessary jobs to be queued
Do some of the cheap checks before spawning attempting to send emails via any method
Santhosh Thottingal [Thu, 22 Sep 2011 11:52:44 +0000 (11:52 +0000)]
stylize.php - minor whitespace fixes.
Sam Reed [Thu, 22 Sep 2011 11:06:48 +0000 (11:06 +0000)]
Fix mixed tabs and spaces from r97793
Couple of minor style tweaks also
Sam Reed [Thu, 22 Sep 2011 11:04:30 +0000 (11:04 +0000)]
Merge r97789 into trunk
Follows up r92528 where this was introduced
Santhosh Thottingal [Thu, 22 Sep 2011 09:21:54 +0000 (09:21 +0000)]
Add number grouping pattern. Ref Bug 29495. Ml and Hi added in r97793
Ariel Glenn [Thu, 22 Sep 2011 07:03:25 +0000 (07:03 +0000)]
remove cruft that didn't all get cleaned up before commit in r95260, addressing fixme.
Tim Starling [Thu, 22 Sep 2011 06:17:26 +0000 (06:17 +0000)]
Fixed User::getGroups(), apparently broken since r33333. User::load() doesn't load groups anymore, so calling $this->getGroups() was the same as just accessing $this->mGroups. Usually it doesn't matter, since most factory functions are funnelled into loadFromId() which calls loadGroups() or loads the groups from the cache, but loadFromRow() was potentially broken.
It's necessary for User::loadFromRow() to set $this->mGroups to null, same as the calling code in User::loadFromDatabase(), so that they will be loaded dynamically when User::newFromRow() is called.
No bugs found that are caused by this but it couldn't hurt to have working accessors. Tested from eval.php.
Santhosh Thottingal [Thu, 22 Sep 2011 05:01:19 +0000 (05:01 +0000)]
Add support for Number grouping(commafy) based on CLDR number grouping patterns like ##,##,###.
Testcases for Malayalam and Dutch
Number grouping Patterns added to Ml and Hi Message classes.
Reference: Bug 29495
Santhosh Thottingal [Thu, 22 Sep 2011 03:51:59 +0000 (03:51 +0000)]
Zero padding for #firstHeading makes text cut for scripts like Devanagari , Malayalam etc(Bug 29405 and Bug 30809), especially when the glyphs are stacked or
having lower diacritic marks. Remove padding-top:0 and padding-bottom:0 to allow h1 inherit the padding bottom and top values from commonElements.css fixes this.
Santhosh Thottingal [Thu, 22 Sep 2011 03:42:14 +0000 (03:42 +0000)]
stylize.php changes.
Tim Starling [Thu, 22 Sep 2011 03:37:39 +0000 (03:37 +0000)]
Removed the redundant wfMkdirParents() call added to BitmapHandler::doTransform() in r79845. This causes problems on Wikimedia due to incorrect NFS access. If a sysadmin misconfigures their thumbnail destination directory, they should get a helpful error message, it shouldn't transparently fall back to client-side scaling and cache the resulting HTML forever.
Aaron Schulz [Thu, 22 Sep 2011 03:21:43 +0000 (03:21 +0000)]
Added array type hinting too getGroupPermissions()
Brion Vibber [Thu, 22 Sep 2011 01:15:06 +0000 (01:15 +0000)]
* (bug 29154) Allow upload-by-URL to follow HTTP redirects
Brion Vibber [Thu, 22 Sep 2011 00:35:55 +0000 (00:35 +0000)]
* (bug 30041) Fix installer cache selection field to keep the selected radio button, initialize the memcached server fold-out correctly when coming back to the page
Brion Vibber [Thu, 22 Sep 2011 00:11:03 +0000 (00:11 +0000)]
* (bug 30041) Fix memcached validation in installer to accept resolvable hostnames
'localhost:11211' was rejected because 'localhost' isn't an IP address... however it's a perfectly legit host to connect to. :)
Followup to r82687 which introduced the IP address check.
Aaron Schulz [Wed, 21 Sep 2011 21:32:24 +0000 (21:32 +0000)]
Clear findFile() process cache of file moves (issue came up with bug bug 31056)
Raimond Spekking [Wed, 21 Sep 2011 21:30:38 +0000 (21:30 +0000)]
Localisation updates for core and extension messages from translatewiki.net
Aaron Schulz [Wed, 21 Sep 2011 20:51:26 +0000 (20:51 +0000)]
Made trimCache() protected
Aaron Schulz [Wed, 21 Sep 2011 20:25:58 +0000 (20:25 +0000)]
Added lock/unlock function stubs. Fixes:
PHP fatal error in /usr/local/apache/common-local/php-1.18/includes/objectcache/MemcachedPhpBagOStuff.php line 91:
Call to undefined method MemCachedClientforWiki::lock()
Robin Pepermans [Wed, 21 Sep 2011 19:30:08 +0000 (19:30 +0000)]
* follow-up r97636: decrease indentation & mention revision per Nikerabbit
* add @since for r97071
Robin Pepermans [Wed, 21 Sep 2011 16:52:44 +0000 (16:52 +0000)]
Revert r93388 because it was a fix for r93386 which was reverted.
Sam Reed [Wed, 21 Sep 2011 16:36:43 +0000 (16:36 +0000)]
Return documentation
Sam Reed [Wed, 21 Sep 2011 16:34:23 +0000 (16:34 +0000)]
Comment out unreachable code
Remove unreachable return false;
Niklas Laxström [Wed, 21 Sep 2011 09:41:40 +0000 (09:41 +0000)]
* (bug 30245) Use the correct way to construct a log page title
Alexandre Emsenhuber [Wed, 21 Sep 2011 09:11:26 +0000 (09:11 +0000)]
Don't use isset() to check for null
Alexandre Emsenhuber [Wed, 21 Sep 2011 09:03:53 +0000 (09:03 +0000)]
Wrap the copyright when its language is not the user's language; avoids problem when direction of the two languages is different
Alexandre Emsenhuber [Wed, 21 Sep 2011 08:54:14 +0000 (08:54 +0000)]
Added missing calls to SpecialPage::setHeaders() and SpecialPage::outputHeader()
Aaron Schulz [Wed, 21 Sep 2011 08:52:57 +0000 (08:52 +0000)]
FU 97704: I was thinking the space was already added in this case
Alexandre Emsenhuber [Wed, 21 Sep 2011 08:40:40 +0000 (08:40 +0000)]
Call Linker methods statically
Aaron Schulz [Wed, 21 Sep 2011 08:39:36 +0000 (08:39 +0000)]
Tweaked diff size number location to make sp:contribs look prettier and more consistent with how it was without them
Alexandre Emsenhuber [Wed, 21 Sep 2011 07:41:45 +0000 (07:41 +0000)]
Per Nikerabbit, follow-up r97658: change getAuthor() into getPerformer() for consistency
Niklas Laxström [Wed, 21 Sep 2011 05:52:55 +0000 (05:52 +0000)]
Fix a conflict(?) in Special:Contributions in r97658.
Brian Wolff [Wed, 21 Sep 2011 00:19:09 +0000 (00:19 +0000)]
Make per page edit notices work in namespaces without subpages enabled.
Brion Vibber [Tue, 20 Sep 2011 22:25:54 +0000 (22:25 +0000)]
* (bug 31048) Fix for width/height reported on Special:Upload thumbnail for EXIF-rotated images
Followup to r79867: switch the reported width/height as well as rotating the thumbnail image. This matches the logical width/height later seen when we complete the upload.
Brion Vibber [Tue, 20 Sep 2011 22:13:34 +0000 (22:13 +0000)]
* (bug 6672, 31024) Fixes for handling of images with an EXIF orientation
- sets an image's reported width/height to the logical form (portait image reports itself as portait)
- everything works in logical coordinates when sizing -- we don't touch the physical pre-rotation dimensions again until it's actual low-level resize time. This fixes several problems with incorrect thumb sizing (eg getting a 600x800 image when we asked for something that fits in 800x600 box)
- fixes unit test cases in ExifRotationTest that were reporting that the width/height were coming back with the physical form which we don't want
- removes some test cases on ExifRotationTest that tested dimension swapping in a place where we don't want it
- ensures that only logical width/height need be exposed to API etc, making exif-rotated images work via ForeignAPIRepo
Note that this may actually cause file metadata to get loaded twice during File::getPropsFromPath, as the $image parameter it passes in to the handler's getImageSize function is bogus and can't be used to fetch an already-loaded metadata blob. This should not generally be too expensive though; it's not a fast path.
Rotated files that were uploaded under previous versions may still have their width/height reversed; an action=purge on the file page will refresh it and cause thumbs to be regenerated.
Follows up on r79845, r90016, r92246, r92279, r96687, r97651, r97656, r97659.
Needs merge to 1.18.
Trevor Parscal [Tue, 20 Sep 2011 21:41:40 +0000 (21:41 +0000)]
Cleaned up leftovers from applying a patch
Sean Colombo [Tue, 20 Sep 2011 21:39:25 +0000 (21:39 +0000)]
Haz moar spaces :) ... follow-up to r97554 as per Jack Phoenix.
Raimond Spekking [Tue, 20 Sep 2011 20:49:59 +0000 (20:49 +0000)]
Localisation updates for core and extension messages from translatewiki.net
Trevor Parscal [Tue, 20 Sep 2011 20:40:54 +0000 (20:40 +0000)]
Fixed IE6 issues in RTL mode
Brion Vibber [Tue, 20 Sep 2011 20:04:26 +0000 (20:04 +0000)]
Further tweaks to r96687, r90016, r97398, r97656 etc tests: try several thumbnail resolutions so we test both width-only and width & height requests
Alexandre Emsenhuber [Tue, 20 Sep 2011 20:00:05 +0000 (20:00 +0000)]
* Made IndexPager extend ContextSource
* Updated special pages using IndexPager or one if its subclasses to pass the context object and use it instead of global variables
* Call Linker methods statically
* Changed LogPager::getUser() to LogPager::getAuthor() to avoid conflict with ContextSource::getUser()
Robin Pepermans [Tue, 20 Sep 2011 19:47:57 +0000 (19:47 +0000)]
Fix support of legacy skins Standard & CologneBlue for user language direction: the topbar and footer used a "quickbar compensator" which relied on the topbar and footer following the content language direction.
Therefore it's easier to do it via CSS (which simplifies PHP code).
See also bug 31031.
Brion Vibber [Tue, 20 Sep 2011 19:39:17 +0000 (19:39 +0000)]
Further tweaks to r96687, r90016, r97398 etc tests: actually produce a thumbnail and check its size as well. Confirms that we're handling bounding boxes incorrectly.
Roan Kattouw [Tue, 20 Sep 2011 19:20:16 +0000 (19:20 +0000)]
Followup r97652, *actually* break the line
Roan Kattouw [Tue, 20 Sep 2011 19:18:57 +0000 (19:18 +0000)]
Break line in r97634
Brion Vibber [Tue, 20 Sep 2011 19:13:52 +0000 (19:13 +0000)]
Partial revert of broken test changes from r92246 -- for some reason it was trying to test some random handler parameter normalization instead of the actual reported width/height! Confirms that returned width/height are incorrect for exif-rotated images.
Niklas Laxström [Tue, 20 Sep 2011 16:26:39 +0000 (16:26 +0000)]
I broke few parser tests in r97633 by overlooking the return value. This fixes them.
Robin Pepermans [Tue, 20 Sep 2011 15:58:01 +0000 (15:58 +0000)]
r97636: ParserCache meant to be committed already too
Robin Pepermans [Tue, 20 Sep 2011 15:55:08 +0000 (15:55 +0000)]
Re-do several things of r96798 in preparation of re-doing the rest (there's a bug somewhere that needs fixing).
* Do additional validation and is_array() check in LanguageConverter
* Make redirects be in content language again (remove from Title->getPageLanguage())
* Pass title object from ParserCache to ParserOptions->optionsHash
Roan Kattouw [Tue, 20 Sep 2011 15:33:17 +0000 (15:33 +0000)]
Followup r97623: some fixes for RTL in IE70Fixes.css:
* Remove useless .rtl #bodyContent a.external rule, already handled by CSSJanus
* Flip the div#column-content div#content hack in RTL mode so the content area doesn't end prematurely on the left
* Fix display of the user icon next to the login link or user name
* External link icons are still broken in IE7+RTL, but they were already broken in 1.17 and are also broken in Vector
Niklas Laxström [Tue, 20 Sep 2011 15:19:18 +0000 (15:19 +0000)]
Added LinkCache::addGoodLinkObjFromRow, since addGoodLinkObj is not going to work much longer when new parameters are added
Niklas Laxström [Tue, 20 Sep 2011 14:53:10 +0000 (14:53 +0000)]
Use LinkBatch, instead of trying doing it manually and incompletely as it gets out of sync.
Adds one or two queries, but that shouldn't be a problem.
Alexandre Emsenhuber [Tue, 20 Sep 2011 13:57:56 +0000 (13:57 +0000)]
Fix for r97328: use SOL_SOCKET instead of SOL_UDP; fixes E_WARNING
Niklas Laxström [Tue, 20 Sep 2011 13:52:47 +0000 (13:52 +0000)]
No need to check isset before unset, shortens the code a bit, and added some whitespace
Sam Reed [Tue, 20 Sep 2011 13:36:09 +0000 (13:36 +0000)]
Followup r90749, beat Aaron
PLEASE!!!! please please please don't hide schema changes in the lists for older versions!
Roan Kattouw [Tue, 20 Sep 2011 13:21:00 +0000 (13:21 +0000)]
Reinstate IE*Fixes.css . This fixes most of the breakage from r74966, but there's one thing (icon placement) that's still broken in IE7 in RTL. Seems like it shouldn't be hard to fix though, I'll poke Trevor
Robin Pepermans [Tue, 20 Sep 2011 13:05:49 +0000 (13:05 +0000)]
As reported in bug 31031, WebKit can mess up the TOC title (which is in user language) because it inherits the direction from the page content direction.
Tim Starling [Tue, 20 Sep 2011 11:06:46 +0000 (11:06 +0000)]
* Fixed notices issued from ProfilerSimpleUDP which were due to ProfilerSimple::profileOut() not adding a complete entry to $this->mCollated for a profile error.
* Simplified other points in the code where $this->mCollated entries were added, by using template arrays $this->errorEntry and $this->zeroEntry.
* Fixed double-counting of -total due to a -total entry being added to $this->mWorkStack both by parent::__construct() and ProfilerSimple::__construct().
* Tested against 1.18wmf1 only.
Roan Kattouw [Tue, 20 Sep 2011 09:16:25 +0000 (09:16 +0000)]
For backwards compatibility with cached HTML generated by MediaWiki 1.17, re-introduce mw.loader.go() . This would have normally been a no-op, but because there is another inconsistency between 1.17 and 1.18 (loading of mw.user) I decided it to abuse it to cover that too. Thanks for Derk-Jan Hartman for reporting the JS errors on test2wiki and figuring out that they were caused by incompatibilities in Squid-cached HTML.
Roan Kattouw [Tue, 20 Sep 2011 09:13:41 +0000 (09:13 +0000)]
Accept ResourceLoader URLs containing '!' in '.' for backwards compatibility with a hack that existed in MediaWiki at some point (was in trunk and 1.17wmf1 but never in any release). This is needed because Squid-cached HTML at Wikimedia still contains such URLs.
Niklas Laxström [Tue, 20 Sep 2011 08:39:29 +0000 (08:39 +0000)]
Moved PatrolLog to logging folder, sorted the autoloaded entries alphabetically
Niklas Laxström [Tue, 20 Sep 2011 08:18:20 +0000 (08:18 +0000)]
Fixing a bug in r97495 that Aaron catched. I misinterpreted the documentation for what 'valid' means.
Tim Starling [Tue, 20 Sep 2011 01:28:08 +0000 (01:28 +0000)]
Don't call Profiler::collateData() from ProfilerSimpleUDP, it destroys $this->mCollated which was filled by profileOut(), leading to a profile with only overhead entries. Call Profiler::close() instead, like what ProfilerSimpleText does.
Chad Horohoe [Mon, 19 Sep 2011 23:25:13 +0000 (23:25 +0000)]
Back-compat for $wgProfiler set as a class. Fix for r89206
Brion Vibber [Mon, 19 Sep 2011 23:14:52 +0000 (23:14 +0000)]
Add in a 'TestCanonicalRedirect' hook to be called when about to make a redirect to the canonical page form of a regular page view. Some extensions such as MobileProfile may need to modify this logic to prevent incorrect redirects, such as on alternate en.m.wikipedia.org domain, where we'd want to either skip it or rewrite to the alternate domain.
Support for resolving bug 31012.
Aaron Schulz [Mon, 19 Sep 2011 21:55:17 +0000 (21:55 +0000)]
Removed duplication in insertArticleLink
Brion Vibber [Mon, 19 Sep 2011 21:16:00 +0000 (21:16 +0000)]
* (bug 30977) Remove directions cruft, undo random limitation of input format for Special:Filepath
Reverts r43471 which forced Special:FilePath's input to not accept titles with the File: or Image: namespace on them, or otherwise requiring any normalization beyond space/underscore.
Also removes the extra line saying 'input the name without the file: prefix' which used the native namespace name, which prompted a question about its formatting in mixed-directionality contexts.
Sean Colombo [Mon, 19 Sep 2011 20:50:08 +0000 (20:50 +0000)]
Merged in change from Wikia which prevents an E_NOTICE on Special:FewestRevisions page.
Sam Reed [Mon, 19 Sep 2011 20:27:36 +0000 (20:27 +0000)]
Followup r97551, use isLocal, more dynamic!