Sam Reed [Sat, 17 Mar 2012 22:39:38 +0000 (22:39 +0000)]
Unit tests for r114067
Sam Reed [Sat, 17 Mar 2012 22:26:26 +0000 (22:26 +0000)]
Followup r114067 rename to formatDuration to match other methods
Jeroen De Dauw [Sat, 17 Mar 2012 22:26:02 +0000 (22:26 +0000)]
adding special page with scaffolding for caching chunks of HTML
Sam Reed [Sat, 17 Mar 2012 22:14:44 +0000 (22:14 +0000)]
Followup r114067
Add centuries because the messages were already there but not used
Add decade and millennia for the luls/completeness
Jeroen De Dauw [Sat, 17 Mar 2012 21:47:17 +0000 (21:47 +0000)]
follow up to r114067, use correct language
Siebrand Mazeland [Sat, 17 Mar 2012 21:19:31 +0000 (21:19 +0000)]
Follow-up r113939: Add divs to addWikiText().
Jeroen De Dauw [Sat, 17 Mar 2012 21:13:01 +0000 (21:13 +0000)]
Follow up to r114067;
Jeroen De Dauw [Sat, 17 Mar 2012 20:58:46 +0000 (20:58 +0000)]
adding a duration function to language that converts seconds to text
Raimond Spekking [Sat, 17 Mar 2012 20:51:46 +0000 (20:51 +0000)]
Localisation updates for core and extension messages from translatewiki.net
Thomas Gries [Sat, 17 Mar 2012 08:22:58 +0000 (08:22 +0000)]
follow up r113862 . changed public function name extensionTableExists to tableExists
Benny Situ [Sat, 17 Mar 2012 02:23:06 +0000 (02:23 +0000)]
fix for bug33214 - catch all exceptions in api execute and provides necessary parameters required by the custom printer
Raimond Spekking [Fri, 16 Mar 2012 20:39:04 +0000 (20:39 +0000)]
Localisation updates for core and extension messages from translatewiki.net
Ryan Kaldari [Fri, 16 Mar 2012 14:44:46 +0000 (14:44 +0000)]
partial fix for bug 35057 - backporting a patch from jQuery 1.7.2pre
Siebrand Mazeland [Fri, 16 Mar 2012 04:38:00 +0000 (04:38 +0000)]
Remove incorrect "the" in 'filereadonlyerror'.
Make use of reasons more consistent in a few messages.
Sam Reed [Fri, 16 Mar 2012 02:02:41 +0000 (02:02 +0000)]
Make UsageException extend MWException
Tim Starling [Fri, 16 Mar 2012 00:29:26 +0000 (00:29 +0000)]
In the $clearState=true case, remove strip marker prefixes from the Parser::parse() input. It's only possible for strip markers to be present in this case if the caller manages to guess the output of Parser::getRandomString() in advance. Even if that is possible, it's not recommended as a robust calling procedure.
Also cleaned up some old commented-out code in this area.
Jeroen De Dauw [Thu, 15 Mar 2012 22:40:27 +0000 (22:40 +0000)]
docs++
Raimond Spekking [Thu, 15 Mar 2012 20:51:16 +0000 (20:51 +0000)]
Localisation updates for core and extension messages from translatewiki.net
Aaron Schulz [Thu, 15 Mar 2012 20:37:58 +0000 (20:37 +0000)]
[FileRepo] Tweaked transformErrorOutput() to allow more useful error output (like backend errors) for problems moving thumbnails into storage.
Aaron Schulz [Thu, 15 Mar 2012 17:50:55 +0000 (17:50 +0000)]
* r113886: use <div> instead of span to wrap element that has p tags.
* Also fixed an older instance of the same problem.
Sam Reed [Thu, 15 Mar 2012 17:14:28 +0000 (17:14 +0000)]
Move RELEASE-NOTES after merging r111647 into 1.19 in r113933
Max Semenik [Thu, 15 Mar 2012 15:38:11 +0000 (15:38 +0000)]
Follow-up r113922: tests
Max Semenik [Thu, 15 Mar 2012 15:21:46 +0000 (15:21 +0000)]
Bug 35051 - [Regression] If heading has a trailing space after == then its name is not preloaded into edit summary on section edit. Regression from r105380.
Krinkle [Thu, 15 Mar 2012 06:44:25 +0000 (06:44 +0000)]
[jquery.client] clean up
* Move translate() out of the if-block, no need to re-define
* `else` after return in `if`
* update js coding style
* remove bogus '=' in comment
* line-wrapping of long arrays
Krinkle [Thu, 15 Mar 2012 06:04:20 +0000 (06:04 +0000)]
[mediawiki.action.watch] clean up
* Fix implied global variable 'i' in mwUriGetAction()
* Indention nearly everything an extra level (svn di -x-uw)
* other minor js coding style
Krinkle [Thu, 15 Mar 2012 05:54:58 +0000 (05:54 +0000)]
[mediawiki.action.watch] Move re-used logic into local function
* Follows-up r112440, r107969, r107350
Aaron Schulz [Thu, 15 Mar 2012 04:34:22 +0000 (04:34 +0000)]
Fixed 'Illegal string offset 'LIMIT' in <b>C:\wamp\www\MediaWiki\includes\db\Database.php</b> on line <b>1462</b>'
Marcin Cieślak [Thu, 15 Mar 2012 02:00:16 +0000 (02:00 +0000)]
Followup-To: r113888 Remove extra wfDebug()
Marcin Cieślak [Thu, 15 Mar 2012 01:52:38 +0000 (01:52 +0000)]
Unbreak maintenance/deleteDefaultMessages.php for PostgreSQL
deleteDefaultMessages.php was failing during upgrade
from MediaWiki 1.7.3 with a databaser error.
A stub user:
$user = User::newFromName( 'MediaWiki default' );
has user ID 0, so that $user->isAnon() is true.
Unfortunately, ManualLogEntry::publish() from r96441
tries to insert $user->getName() ("MediaWiki default")
into rc_ip.
PostgreSQL won't allow this, because rc_ip is of
Postgres-specific CIDR type.
Traceback:
Checking existence of old default messages...
...deleting old default messages (this may take a long time!)...A database query syntax error has occurred.
The last attempted database query was:
"INSERT INTO "recentchanges" (rc_timestamp,rc_cur_time,rc_namespace,rc_title,rc_type,rc_minor,rc_user,rc_user_text,rc_comment,rc_this_oldid,rc_last_oldid,rc_bot,rc_moved_to_ns,rc_moved_to_title,rc_ip,rc_patrolled,rc_new,rc_old_len,rc_new_len,rc_deleted,rc_logid,rc_log_type,rc_log_action,rc_params,rc_id) VALUES ('2012-03-14 21:51:05 GMT','2012-03-14 21:51:05 GMT','8','1movedto2','3','0','0','MediaWiki default','No longer required','0','0',1,'0','','MediaWiki default','1','0',NULL,NULL,'0','1','delete','delete','a:0:{}','1')"
from within function "RecentChange::save".
MySQL returned error "1: ERROR: invalid input syntax for type cidr: "MediaWiki default"
LINE 1: ...ki default','No longer required','0','0',1,'0','','MediaWiki...
^"
Backtrace:
#0 /usr/home/saper/public_html/pg/w/includes/db/DatabasePostgres.php(332): DatabaseBase->reportQueryError('ERROR: invalid...', 1, 'INSERT INTO "re...', 'RecentChange::s...', '')
#1 /usr/home/saper/public_html/pg/w/includes/db/Database.php(904): DatabasePostgres->reportQueryError('ERROR: invalid...', 1, 'INSERT INTO "re...', 'RecentChange::s...', '')
#2 /usr/home/saper/public_html/pg/w/includes/db/DatabasePostgres.php(604): DatabaseBase->query('INSERT INTO "re...', 'RecentChange::s...', '')
#3 /usr/home/saper/public_html/pg/w/includes/RecentChange.php(199): DatabasePostgres->insert('recentchanges', Array, 'RecentChange::s...')
#4 /usr/home/saper/public_html/pg/w/includes/logging/LogEntry.php(479): RecentChange->save('pleasedontudp')
#5 /usr/home/saper/public_html/pg/w/includes/WikiPage.php(2042): ManualLogEntry->publish('1')
#6 /usr/home/saper/public_html/pg/w/includes/WikiPage.php(1937): WikiPage->doDeleteArticleReal('No longer requi...', false, 0, false, '', Object(User))
#7 /usr/home/saper/public_html/pg/w/maintenance/deleteDefaultMessages.php(73): WikiPage->doDeleteArticle('No longer requi...', false, 0, false, '', Object(User))
#8 /usr/home/saper/public_html/pg/w/maintenance/update.php(128): DeleteDefaultMessages->execute()
#9 /usr/home/saper/public_html/pg/w/maintenance/doMaintenance.php(105): UpdateMediaWiki->execute()
#10 /usr/home/saper/public_html/pg/w/maintenance/update.php(151): require_once('/usr/home/saper...')
#11 {main}
Aaron Schulz [Thu, 15 Mar 2012 01:42:34 +0000 (01:42 +0000)]
Add error css to errors like the other file operation pages and actions
Thomas Gries [Wed, 14 Mar 2012 21:53:30 +0000 (21:53 +0000)]
follow up r113836 typo correction in function header dropExtensionTable
Thomas Gries [Wed, 14 Mar 2012 21:41:37 +0000 (21:41 +0000)]
follow up r113836 added public function extensionTableExists.
Aaron Schulz [Wed, 14 Mar 2012 21:30:26 +0000 (21:30 +0000)]
[FileRepo]
* Added getReadOnlyReason() function to FileRepo to check read-only status. Added such checks to the File object functions that mutate files in storage. This should make read-only mode more tolerable (which is needed at least briefly when switching backends).
* Added lock()/unlock() calls to File restore() function.
* Use proper isOK() accessor for Status objects.
Roan Kattouw [Wed, 14 Mar 2012 21:10:28 +0000 (21:10 +0000)]
Fix encoding issue in r113197
Aaron Schulz [Wed, 14 Mar 2012 21:04:28 +0000 (21:04 +0000)]
Fixed comment typo
Raimond Spekking [Wed, 14 Mar 2012 20:55:01 +0000 (20:55 +0000)]
Localisation updates for core and extension messages from translatewiki.net
Marcin Cieślak [Wed, 14 Mar 2012 20:20:53 +0000 (20:20 +0000)]
Follow-up to r15791: Rename "user" and "text" when upgrading on PostgreSQL
You can lie to me, but not to your installer.
Make DatabasePostgres::tableExists to check
for real table names, not faked ones.
DatabasePostgres is currently lying to the rest
of the MediaWiki that "mwuser" table is actually
called "user" and that "pagecontents" is called
"text". While MediaWiki does not care, the
installer (and updater do).
This allows us to overcome first hurdle
in getting MediaWiki 1.7.3 to update to trunk
on PostgreSQL and uncover further bugs.
For this commit to actually do something,
we rename those tables when upgrading to match
what we have in maintenance/postgres/tables.sql
And by the way, tell installer not to check
for "user" table, since most PostgreSQL users
will have "mwuser" instead. Picking "archive"
instead.
Thomas Gries [Wed, 14 Mar 2012 20:16:32 +0000 (20:16 +0000)]
adding two public convenience function wrappers: dropExtensionField and dropExtensionTable
Aaron Schulz [Wed, 14 Mar 2012 17:55:59 +0000 (17:55 +0000)]
Reverted r113803: makes already messy class messier (a bit to much)
Max Semenik [Wed, 14 Mar 2012 16:31:52 +0000 (16:31 +0000)]
* (bug 34889) User name should be normalized on Special:Contributions. Fixes regression from r103751.
Alexandre Emsenhuber [Wed, 14 Mar 2012 16:18:27 +0000 (16:18 +0000)]
We have DatabaseBase::selectRow() to select a single row
Alexandre Emsenhuber [Wed, 14 Mar 2012 16:04:21 +0000 (16:04 +0000)]
* (bug 34841) Fix for r103502: don't show edit links when display old page versions
Alexandre Emsenhuber [Wed, 14 Mar 2012 10:46:59 +0000 (10:46 +0000)]
Be consistent in the interface and use Title::quickUserCan() instead of Title::userCan() to show items in the interface so that when the user is blocked or the page is cascade protected there is not a part of the interface saying you can edit the page and another part not.
Alexandre Emsenhuber [Wed, 14 Mar 2012 09:52:34 +0000 (09:52 +0000)]
Don't create new Revision and Title object if we can use the ones that we already have
Aaron Schulz [Wed, 14 Mar 2012 01:42:14 +0000 (01:42 +0000)]
(bug 32827) "[Regression] Block log for IP ranges not shown on Special:Block"
Marcin Cieślak [Wed, 14 Mar 2012 00:36:11 +0000 (00:36 +0000)]
Cosmetic improvements to PostreSQL updater output
* Don't WARN on sequences already existing
* Align dots nicely to the rest
Amir E. Aharoni [Tue, 13 Mar 2012 23:09:06 +0000 (23:09 +0000)]
Bug 35034 - moved autocomment-prefix between the prefix and the arrow. Follow up to r109086.
Brion Vibber [Tue, 13 Mar 2012 22:38:14 +0000 (22:38 +0000)]
* (bug 35201) Edit buttons no longer cause jump in IE 9
Changed order of feature-detection checks so we prefer the IE method over the Mozilla method in encapsulateSelection. Fixes a problem where IE9 triggered the Mozilla mode, then mysteriously scrolled to the top of the page.
(IE9 and IE10 add a lot of standard and semi-standard HTML APIs, so this sort of thing happens from time to time. :)
Alexandre Emsenhuber [Tue, 13 Mar 2012 21:30:29 +0000 (21:30 +0000)]
Use local context to get message
Raimond Spekking [Tue, 13 Mar 2012 20:50:02 +0000 (20:50 +0000)]
Localisation updates for core and extension messages from translatewiki.net
Krinkle [Tue, 13 Mar 2012 20:22:48 +0000 (20:22 +0000)]
moved release notes for r113737 to 1.19 (a 1.19-regression fix)
* Follows-up r113746
Aaron Schulz [Tue, 13 Mar 2012 20:09:49 +0000 (20:09 +0000)]
Reverted r113177 per CR
Siebrand Mazeland [Tue, 13 Mar 2012 19:32:41 +0000 (19:32 +0000)]
Fix plural in 'backend-fail-maxsize'
Alexandre Emsenhuber [Tue, 13 Mar 2012 19:03:59 +0000 (19:03 +0000)]
Move delcaration of User::$mAllowUsertalk out of the "cache variables" block since it's not part of it; also reorder the cache variables for consistency.
Rob Moen [Tue, 13 Mar 2012 18:41:56 +0000 (18:41 +0000)]
update RELEASE-NOTES-1.20 follow up r113737
Alexandre Emsenhuber [Tue, 13 Mar 2012 18:41:13 +0000 (18:41 +0000)]
Follow-up r113223: set the "interface" flag in Message to true by default and set it to false when the page is included.
The point is to have the fix applied to all usages of IContextSource::msg() calls instead of only SpecialPage.
Aaron Schulz [Tue, 13 Mar 2012 18:30:34 +0000 (18:30 +0000)]
[FileBackend] r113704: updated FileBackend constructor documentation
Rob Moen [Tue, 13 Mar 2012 17:57:54 +0000 (17:57 +0000)]
User:PleaseStand patch fixes bug 34972
Alexandre Emsenhuber [Tue, 13 Mar 2012 15:54:20 +0000 (15:54 +0000)]
* (bug 34887) Fix for r100138: make $3 and $4 parameters being substituted correctly in message "movepage-moved"
Alexandre Emsenhuber [Tue, 13 Mar 2012 07:39:33 +0000 (07:39 +0000)]
* (bug 35152) Fix for r92924: help message for e-mail was removed from user preferences
Aaron Schulz [Tue, 13 Mar 2012 01:46:33 +0000 (01:46 +0000)]
[FileBackend]
* Added FileJournal class to log file changes for file backends. This can be used for migrations (like moving to Swift), syncing mirror repos, consistency checks, finishing/reverting operation batches, and such. The default journal is the "null" journal, which simply does nothing.
* Added the optional schema change required for using the DBFileJournal (MySQL, SQLite).
Aaron Schulz [Tue, 13 Mar 2012 01:44:39 +0000 (01:44 +0000)]
Tweak testFileRepoConstructionWithRequiredOptions so that it doesn't fail depending on the config of the wiki being tested on.
Aaron Schulz [Tue, 13 Mar 2012 00:32:47 +0000 (00:32 +0000)]
(bug 34978) Use a rev parent batch query to get the diff sizes for history pages rather than rely on assumptions that break if any filtering is used.
Aaron Schulz [Tue, 13 Mar 2012 00:18:29 +0000 (00:18 +0000)]
r113688: updated test assertions
Aaron Schulz [Tue, 13 Mar 2012 00:05:23 +0000 (00:05 +0000)]
Made wfShellMaintenanceCmd() not totally broken due to excess shell escaping.
Alexandre Emsenhuber [Mon, 12 Mar 2012 21:17:23 +0000 (21:17 +0000)]
Revert r113650 and reapply r113619 and r113649 with one modification: User::createNew() was missing a DatabaseBase::timestamp() call
Raimond Spekking [Mon, 12 Mar 2012 20:46:25 +0000 (20:46 +0000)]
Localisation updates for core and extension messages from translatewiki.net
Marcin Cieślak [Mon, 12 Mar 2012 19:58:27 +0000 (19:58 +0000)]
Revert r113619, r113649: Breaks unit tests
https://integration.mediawiki.org/ci/job/MediaWiki-postgres-phpunit/3210/console
Maybe a new property with unpredictable
value breaks some tests. Need to investigate.
Marcin Cieślak [Mon, 12 Mar 2012 19:35:38 +0000 (19:35 +0000)]
Fix r113619: Convert timestamp to the backend database value
Alexandre Emsenhuber [Mon, 12 Mar 2012 19:01:44 +0000 (19:01 +0000)]
* Put the timer stuff after leading line breaks in debug log entries (mainly for the first call on a request) so that they are placed near the remaing text and not on its own line
* Normalise line breaks in the first entry on a web request so that it's consistent with the one for command line requests
Sam Reed [Mon, 12 Mar 2012 16:55:25 +0000 (16:55 +0000)]
Add a getValue method...
Alexandre Emsenhuber [Mon, 12 Mar 2012 14:04:20 +0000 (14:04 +0000)]
Removed the remaining parts of "cookie password" stuff, does nothing and no longer used since ages
Alexandre Emsenhuber [Mon, 12 Mar 2012 13:07:50 +0000 (13:07 +0000)]
Set the user_touched field directly when adding a new user to the database so that the field is correct when someone does not call saveSettings() after addToDatabase()
Ryan Kaldari [Mon, 12 Mar 2012 12:43:35 +0000 (12:43 +0000)]
fix for bug 34696 - mw.loader.using shouldnt call callback more than once
Daniel Friesen [Mon, 12 Mar 2012 05:24:54 +0000 (05:24 +0000)]
Revert r113610, it appears it's impossible to fix vector in a sane way. If we try to fix it without images then the white in the version with images that's supposed to be there disappears. And that can't be fixed because that part of vector uses a variable em height disabling the ability to fix the issue by editing the uploaded image.
Daniel Friesen [Mon, 12 Mar 2012 04:34:28 +0000 (04:34 +0000)]
Tweak background colours in Vector's css so that Vector looks sane when images are disabled.
Siebrand Mazeland [Mon, 12 Mar 2012 00:50:10 +0000 (00:50 +0000)]
rebuildLanguage.php
Sam Reed [Sun, 11 Mar 2012 23:40:33 +0000 (23:40 +0000)]
Bug 35162 - Change in Database api break extension MSSQLBackCompat
$canonicalDBTypes is probably superfluous information, but doesn't harm as a shortcut
Ping r108051
Robin Pepermans [Sun, 11 Mar 2012 23:35:51 +0000 (23:35 +0000)]
r113599: add to names.php & release note
Sam Reed [Sun, 11 Mar 2012 23:28:11 +0000 (23:28 +0000)]
Over 40% completion of MediaWiki core messages translated
Sam Reed [Sun, 11 Mar 2012 22:05:54 +0000 (22:05 +0000)]
More of r113580
Raimond Spekking [Sun, 11 Mar 2012 20:39:18 +0000 (20:39 +0000)]
Localisation updates for core and extension messages from translatewiki.net
Sam Reed [Sun, 11 Mar 2012 18:54:55 +0000 (18:54 +0000)]
Normalise casing of getArticleID used in core
Robin Pepermans [Sun, 11 Mar 2012 14:53:30 +0000 (14:53 +0000)]
r113572 in trunk file too
Robin Pepermans [Sun, 11 Mar 2012 03:25:22 +0000 (03:25 +0000)]
Remove the explicit user lang/dir attributes, because variant names are usually not in the user language, and there are lang attributes on those li items.
Raimond Spekking [Sat, 10 Mar 2012 22:57:43 +0000 (22:57 +0000)]
Localisation updates for core and extension messages from translatewiki.net
Daniel Friesen [Sat, 10 Mar 2012 22:26:40 +0000 (22:26 +0000)]
Move printfooter hiding css from multiple stylesheets into shared.css where it should belong.
Robin Pepermans [Sat, 10 Mar 2012 02:07:31 +0000 (02:07 +0000)]
fix r113403
Benny Situ [Sat, 10 Mar 2012 00:31:54 +0000 (00:31 +0000)]
followup to -r113545 - add null for missing $default param
Sam Reed [Fri, 9 Mar 2012 23:33:42 +0000 (23:33 +0000)]
Documentation, spaces, braces, explicit member variables
Roan Kattouw [Fri, 9 Mar 2012 23:27:28 +0000 (23:27 +0000)]
(bug 34521) Returning to the previous page after logging in loses any array-valued parameters in the query string. This happens because WebRequest::getValues() calls getVal() which strips arrays, even though the doc comment says that no transformation is applied. Changed getValues() to call getGPCVal() instead. The only difference is that arrays are no longer stripped, so the doc comment is no longer a lie
Siebrand Mazeland [Fri, 9 Mar 2012 23:23:01 +0000 (23:23 +0000)]
Add message keys for 18 missing summary messages.
* Patch for bug 34319 for Special:DeletedContributions and Special:Contributions contributed by Srikanth Lakshmanan
* Other 16 instances identified by Der Umherirrende on translatewiki.net (https://translatewiki.net/wiki/Thread:Support/Missing_summary_message_keys_in_message_files), code updates by me.
Aaron Schulz [Fri, 9 Mar 2012 22:59:13 +0000 (22:59 +0000)]
Make sure ForkController nukes any connection resources that backends might have before forking
Raimond Spekking [Fri, 9 Mar 2012 22:30:45 +0000 (22:30 +0000)]
Localisation updates for core and extension messages from translatewiki.net
Marcin Cieślak [Fri, 9 Mar 2012 22:29:22 +0000 (22:29 +0000)]
Fix PostgreSQL updater broken by r113487
Alexandre Emsenhuber [Fri, 9 Mar 2012 20:37:44 +0000 (20:37 +0000)]
Let's be consistent and use the same check to show an the deleted version and cascade the parameter
Alexandre Emsenhuber [Fri, 9 Mar 2012 20:26:08 +0000 (20:26 +0000)]
No need to create a new Revision object if we already have one available
Aaron Schulz [Fri, 9 Mar 2012 19:36:19 +0000 (19:36 +0000)]
Made FileOp::allowStaleReads take a boolean argument (more versatile) and killed a few lines of code.
Sam Reed [Fri, 9 Mar 2012 19:05:29 +0000 (19:05 +0000)]
Fix syntax error and indenting from r113487
Sam Reed [Fri, 9 Mar 2012 19:01:30 +0000 (19:01 +0000)]
PHP Fatal error: Call to undefined method DatabasePostgres::getCoreSchea() in /var/lib/jenkins/jobs/MediaWiki-postgres-phpunit/workspace/mw-core/includes/installer/PostgresUpdater.php on line 309
Ping r113487