From: Daniel Friesen <daniel@nadir-seen-fire.com>
Date: Thu, 28 Mar 2013 16:41:12 +0000 (-0700)
Subject: Start outputting deprecation warnings when legacy linker methods are called on skins.
X-Git-Tag: 1.31.0-rc.0~20189^2
X-Git-Url: https://git.cyclocoop.org/%7B%24admin_url%7Dmembres/modifier.php?a=commitdiff_plain;h=dbb90e8e41dd88e8a8589ebb9c56eb42d4b0cd7c;p=lhc%2Fweb%2Fwiklou.git

Start outputting deprecation warnings when legacy linker methods are called on skins.

Change-Id: I97b046739428176540ddd80e72a80d5feefe3fc9
---

diff --git a/RELEASE-NOTES-1.21 b/RELEASE-NOTES-1.21
index efa534a2f9..ecb37d53c5 100644
--- a/RELEASE-NOTES-1.21
+++ b/RELEASE-NOTES-1.21
@@ -350,6 +350,7 @@ changes to languages because of Bugzilla reports.
    function, which is now deprecated).
 * BREAKING CHANGE: The Services_JSON class has been removed; if necessary,
   be sure to upgrade affected extensions at the same time (e.g. Collection).
+* Calling Linker methods using a skin will now output deprecation warnings.
 
 == Compatibility ==
 
diff --git a/includes/Skin.php b/includes/Skin.php
index e5aedd9eed..a4cb9f4d9d 100644
--- a/includes/Skin.php
+++ b/includes/Skin.php
@@ -1559,6 +1559,7 @@ abstract class Skin extends ContextSource {
 	function __call( $fname, $args ) {
 		$realFunction = array( 'Linker', $fname );
 		if ( is_callable( $realFunction ) ) {
+			wfDeprecated( get_class( $this ) . '::' . $fname, '1.21' );
 			return call_user_func_array( $realFunction, $args );
 		} else {
 			$className = get_class( $this );