From: WMDE-Fisch <christoph.jauera@wikimedia.de>
Date: Fri, 5 Apr 2019 16:23:49 +0000 (+0200)
Subject: Remove warning for unnused 4th argument on wikidiff2
X-Git-Tag: 1.34.0-rc.0~2146^2
X-Git-Url: https://git.cyclocoop.org/%7B%24admin_url%7Dmembres/modifier.php?a=commitdiff_plain;h=cbe4ffe26d23784f1b672d5434a3f1a348b91623;p=lhc%2Fweb%2Fwiklou.git

Remove warning for unnused 4th argument on wikidiff2

Since we changed the signature back to 3 arguments in wikidiff2 verion
1.8.0, the warning is invalid.

Bug: T220217
Bug: T203069
Bug: T194272
Change-Id: Ia326c67de28a4e9b024466c62097b4e1e1096007
---

diff --git a/includes/diff/TextSlotDiffRenderer.php b/includes/diff/TextSlotDiffRenderer.php
index e2cdd82b86..001944c5be 100644
--- a/includes/diff/TextSlotDiffRenderer.php
+++ b/includes/diff/TextSlotDiffRenderer.php
@@ -214,12 +214,6 @@ class TextSlotDiffRenderer extends SlotDiffRenderer {
 					$newText,
 					2
 				);
-
-				// Log a warning in case the configuration value is set to not silently ignore it
-				if ( $this->wikiDiff2MovedParagraphDetectionCutoff > 0 ) {
-					wfLogWarning( '$wgWikiDiff2MovedParagraphDetectionCutoff is set but has no
-						effect since the used version of WikiDiff2 does not support it.' );
-				}
 			}
 
 			return $text;