Merge "Use User::getDefaultOption() instead of $wgDefaultUserOptions"
authorAaron Schulz <aschulz@wikimedia.org>
Sun, 22 Jul 2012 09:45:18 +0000 (09:45 +0000)
committerGerrit Code Review <gerrit@wikimedia.org>
Sun, 22 Jul 2012 09:45:18 +0000 (09:45 +0000)
1  2 
includes/User.php

diff --combined includes/User.php
@@@ -119,7 -119,6 +119,7 @@@ class User 
                'delete',
                'deletedhistory',
                'deletedtext',
 +              'deletelogentry',
                'deleterevision',
                'edit',
                'editinterface',
         * as 300.300.300.300 will return true because it looks like an IP
         * address, despite not being strictly valid.
         *
 -       * We match \d{1,3}\.\d{1,3}\.\d{1,3}\.xxx as an anonymous IP
 +       * We match "\d{1,3}\.\d{1,3}\.\d{1,3}\.xxx" as an anonymous IP
         * address because the usemod software would "cloak" anonymous IP
         * addresses like this, if we allowed accounts like this to be created
         * new users could get the old edits of these anonymous users.
                $this->loadOptions();
  
                // Explicitly NULL values should refer to defaults
-               global $wgDefaultUserOptions;
-               if( is_null( $val ) && isset( $wgDefaultUserOptions[$oname] ) ) {
-                       $val = $wgDefaultUserOptions[$oname];
+               if( is_null( $val ) ) {
+                       $defaultOption = self::getDefaultOption( $oname );
+                       if( !is_null( $defaultOption ) ) {
+                               $val = $defaultOption;
+                       }
                }
  
                $this->mOptions[$oname] = $val;