From 3b2c160d7d4e5c7f4cdaafcde54348f8f8b5f46e Mon Sep 17 00:00:00 2001 From: Bryan Tong Minh Date: Thu, 29 Oct 2009 20:17:23 +0000 Subject: [PATCH] Do a weak boolean comparison against $asyncdownload in order to accept null as false (fixes API upload by URL). --- includes/upload/UploadFromUrl.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/includes/upload/UploadFromUrl.php b/includes/upload/UploadFromUrl.php index d872bb1240..39cfb53392 100644 --- a/includes/upload/UploadFromUrl.php +++ b/includes/upload/UploadFromUrl.php @@ -39,7 +39,7 @@ class UploadFromUrl extends UploadBase { global $wgTmpDirectory, $wgPhpCli; // check for $asyncdownload request: - if( $asyncdownload !== false){ + if( $asyncdownload ){ if( $wgPhpCli && wfShellExecEnabled() ){ $this->dl_mode = Http::ASYNC_DOWNLOAD; } else { -- 2.20.1