Andrew Garrett [Fri, 23 May 2008 10:34:11 +0000 (10:34 +0000)]
Core changes for GlobalBlocking and TorBlock extensions, plus some core refactoring work:
* Instead of saying 'do that' in a permissions error, actually list what the action is (drawn from the right-$1 messages). This isn't perfect - it says you don't have permission to edit pages when
you can't edit a single page, but it's better than 'do that'.
* Refactor out some code from various block files into Block::formatExpiry and Block::parseExpiryInput.
* Don't display 'you cannot edit special pages' when you're trying to execute, or create an account, or something like that.
* New AbortAutoblock hook (for use in TorBlock extension), which allows extensions to cancel autoblocks.
Tim Starling [Fri, 23 May 2008 09:03:49 +0000 (09:03 +0000)]
In FlaggedRevs:
* Moved the FlaggedRevs class to its own file
* Removed $wgFlaggedArticle, store an instance inside the Article object instead. Also store a reference in the Title object, since some hooks only have a Title available.
* Modified all hooks which were previously calling $wgFlaggedArticle directly to go via an instance loader function.
* Merged hook functions for ArticleViewHeader and DiffViewHeader
* Changed the way FlaggedRevs sets the right image version in ImagePage, to avoid a function call on startup
* Some coding style changes, such as consistent variable case, consistent indenting style, meaningful variable names, etc.
* Fixed typo in updateAutoPromote.php
* Removed the $wgFlaggedRevsVisible feature, this doesn't seem to be in keeping with our mission so I couldn't see the point in spending a lot of time fixing its bugs. Revert if necessary.
* Use Xml::encodeJsVar() to transfer data from PHP to JS, don't DIY
* Use OutputPage::addHeadItem() instead of an infinite-lifetime variable to ensure that only one copy of the header item is added. OutputPage objects may come and go.
Tim Starling [Fri, 23 May 2008 09:00:08 +0000 (09:00 +0000)]
Fixed sloppy usage of Database::selectField() in getPreviousRevisionID() and getNextRevisionID()
Tim Starling [Fri, 23 May 2008 08:54:19 +0000 (08:54 +0000)]
Clarify behaviour of wfGetDB(DB_SLAVE)
Aaron Schulz [Fri, 23 May 2008 07:33:35 +0000 (07:33 +0000)]
Remove shitty ass useless fucking ampersands that just make it harder to avoid fucking strict notices
Siebrand Mazeland [Fri, 23 May 2008 07:28:08 +0000 (07:28 +0000)]
Localisation updates. Rebuilt all language files.
Siebrand Mazeland [Fri, 23 May 2008 07:26:48 +0000 (07:26 +0000)]
Localisation updates. Rebuilt all language files.
Niklas Laxström [Fri, 23 May 2008 07:20:52 +0000 (07:20 +0000)]
* PHP Strict Standards: Only variables should be passed by reference in <>
Siebrand Mazeland [Fri, 23 May 2008 07:11:21 +0000 (07:11 +0000)]
Localisation updates. Some messages imported from af.wp. Removed Wikimedia specific messages.
Siebrand Mazeland [Fri, 23 May 2008 06:56:49 +0000 (06:56 +0000)]
Localisation updates. 15 messages imported from af.wp.
Aryeh Gregor [Fri, 23 May 2008 01:11:17 +0000 (01:11 +0000)]
Re-commit cleaned-up version of r33565 (move subpages along with page).
* Move subpages checkbox is not shown unless the current page or its talk page actually has subpages.
* Move subpages checkbox is shown if subpages are disabled for the current namespace, provided that the talk page has subpages (but then it has no effect unless the "move talk" box is also checked).
* Unnecessary ampersands expunged, superfluous ternary operators excised.
* Crazy 1=0 query removed.
* Limit of maximum number of pages to move at once added (default 1000).
One niggling annoyance is that if the maximum number of pages is hit due to the base page having too many subpages, the talk page probably won't be moved due to the order that results are returned, which is kind of unexpected. Also, make sure the queries don't cause MySQL 4 to explode -- MySQL sometimes has problems with OR, especially older versions. Other than that, should be production-ready, I think.
Aaron Schulz [Thu, 22 May 2008 22:49:23 +0000 (22:49 +0000)]
* Use $limit = min( $wgFeedLimit, $limit ); to shorten things
* Add comment
Aaron Schulz [Thu, 22 May 2008 22:36:00 +0000 (22:36 +0000)]
Make saveContent() protected
Aaron Schulz [Thu, 22 May 2008 22:33:34 +0000 (22:33 +0000)]
Doc
Meno25 [Thu, 22 May 2008 22:22:36 +0000 (22:22 +0000)]
Bug 12145 Kazakh message updates
Patch by: AlefZet
Aaron Schulz [Thu, 22 May 2008 22:19:19 +0000 (22:19 +0000)]
Break long lines
Siebrand Mazeland [Thu, 22 May 2008 21:41:30 +0000 (21:41 +0000)]
Localisation updates for core messages from Betawiki (2008-05-22 23:32 CEST)
Siebrand Mazeland [Thu, 22 May 2008 21:37:56 +0000 (21:37 +0000)]
Localisation updates for core messages from Betawiki (2008-05-22 23:32 CEST)
Roan Kattouw [Thu, 22 May 2008 21:33:25 +0000 (21:33 +0000)]
(bug 14231) Tweak help for action=edit
Ilmari Karonen [Thu, 22 May 2008 20:02:03 +0000 (20:02 +0000)]
(bug 14140) URL-encoded page titles are now decoded in edit summaries
Alexandre Emsenhuber [Thu, 22 May 2008 19:48:26 +0000 (19:48 +0000)]
Fix some doxygen warnings
Brion Vibber [Thu, 22 May 2008 18:34:39 +0000 (18:34 +0000)]
* (bug 14220) Disabling $wgCheckFileExtensions now works without also disabling $wgStrictFileExtensions
Niklas Laxström [Thu, 22 May 2008 18:13:47 +0000 (18:13 +0000)]
* Plural for badsiglength
Niklas Laxström [Thu, 22 May 2008 17:56:29 +0000 (17:56 +0000)]
* Update plural code
Aryeh Gregor [Thu, 22 May 2008 17:24:46 +0000 (17:24 +0000)]
-136 lines of worthless code. Even if the idea was hypothetically good, which I'm not sure of, nobody is using CategoryList anywhere and I don't foresee any use for it. Also makes what remains considerably easier to read (no looping, etc.). This seems to work correctly, but I might have missed something somewhere, so be on the lookout.
Brion Vibber [Thu, 22 May 2008 16:47:12 +0000 (16:47 +0000)]
Clean up r35180: prettify some functions, break some long lines and odd constructions.
Brion Vibber [Thu, 22 May 2008 16:39:43 +0000 (16:39 +0000)]
Revert r35178 and normalize User's getID() and setID() methods to prettier getId() and setId()
This doesn't accomplish anything, of course, but if you're going to run around changing them, at least make em prettier eh? :)
Brion Vibber [Thu, 22 May 2008 16:25:45 +0000 (16:25 +0000)]
* Fix typo in ApiQueryImageInfo which made mime type query fail to work :)
* Fix ForeignAPIRepo's query to use the corrected parameter to the API
* ForeignAPIFile fixes to use queried mime type if available, and type-safety checks in case some values are missing or funny
Brion Vibber [Thu, 22 May 2008 16:17:42 +0000 (16:17 +0000)]
ForeignAPIRepo fixes:
* use the proper factory method so findFile accepts strings as well as Title objects; fixes API image queries
* pass timestamp and SHA-1 hash on
Aaron Schulz [Thu, 22 May 2008 15:44:46 +0000 (15:44 +0000)]
* Remove cruft $time parameter from findFiles()
* Fucking document this fucking function
Aaron Schulz [Thu, 22 May 2008 15:15:00 +0000 (15:15 +0000)]
* Remove pointless newline
* It helps not to through fatal errors everywhere if not title
* Add optional $pageId param to getTimestampFromID() to avoid a secondary lookup, not that anything uses this function anyway...
Aaron Schulz [Thu, 22 May 2008 15:02:33 +0000 (15:02 +0000)]
Revision:getId() not getID()
Aaron Schulz [Thu, 22 May 2008 14:57:07 +0000 (14:57 +0000)]
*The function is User::getID() not getId()
Siebrand Mazeland [Thu, 22 May 2008 06:30:31 +0000 (06:30 +0000)]
Localisation updates for extension messages from Betawiki (2008-05-22 08:23 CEST)
Aaron Schulz [Thu, 22 May 2008 04:53:05 +0000 (04:53 +0000)]
It helps if doc is accurate ;)
Ilmari Karonen [Thu, 22 May 2008 01:29:33 +0000 (01:29 +0000)]
Make Special:Upload display detailed permissions errors. Also avoid checking for 'create' permissions if the target title already exists.
Aaron Schulz [Thu, 22 May 2008 01:12:51 +0000 (01:12 +0000)]
Respect $wgShowUpdatedMarker
Aaron Schulz [Thu, 22 May 2008 01:03:45 +0000 (01:03 +0000)]
*Redo newRevisionFromEditComplete hook. Pass an Article instead of a title
*Use prepareTextForEdit() to avoid double parsing
*Parser cache will be saved again later, so need to do it twice in a row
Aaron Schulz [Wed, 21 May 2008 23:17:30 +0000 (23:17 +0000)]
Pass in $flags to getArticleId()
Brion Vibber [Wed, 21 May 2008 23:00:49 +0000 (23:00 +0000)]
Cache image API lookups in-process and, if available, in memcached for up to 1 hour.
Cuts down on duplicate lookups...
Brion Vibber [Wed, 21 May 2008 22:39:08 +0000 (22:39 +0000)]
ForeignAPIRepo fixes:
* Now supports thumbnails!
* SVG seems to work
* Comments now working in version info
* Can fetch description pages without extra configuration (assuming standard script layout)
* Asks server for mime type, but doesn't get it back yet
Brion Vibber [Wed, 21 May 2008 22:36:53 +0000 (22:36 +0000)]
Don't assume the file repository will always return an object when checking for dupes
Aaron Schulz [Wed, 21 May 2008 22:28:21 +0000 (22:28 +0000)]
Minor comment tweak
Aaron Schulz [Wed, 21 May 2008 22:20:07 +0000 (22:20 +0000)]
Logic errors
Aaron Schulz [Wed, 21 May 2008 21:33:58 +0000 (21:33 +0000)]
*Respect displayImg
*Add getDisplayedFile()
Aaron Schulz [Wed, 21 May 2008 21:23:04 +0000 (21:23 +0000)]
Cleanup for displaying old versions
Aaron Schulz [Wed, 21 May 2008 21:09:31 +0000 (21:09 +0000)]
Fix yet more image links bugs
Roan Kattouw [Wed, 21 May 2008 20:07:10 +0000 (20:07 +0000)]
(bug 14212) Undefined variable $retval in Skin::subPageSubtitle()
Alexandre Emsenhuber [Wed, 21 May 2008 18:18:58 +0000 (18:18 +0000)]
Doc tweaks:
* @ingrouo -> @ingroup (whoops!)
* Fix doxygen warnings
* Remove duplicate definition of $wgMetaNamespaceTalk in DefaultSettings.php, thanks to VasilievVV for pointing this out
Aaron Schulz [Wed, 21 May 2008 16:26:53 +0000 (16:26 +0000)]
Move rewRevisionFromEditComplete call down till after page rows set
Roan Kattouw [Wed, 21 May 2008 14:33:27 +0000 (14:33 +0000)]
API: Requesting a token you aren't allowed to request no longer dies with an error but just throws a warning and doesn't give you the token.
Bryan Tong Minh [Wed, 21 May 2008 13:03:07 +0000 (13:03 +0000)]
Add descriptionurl to imageinfo
Aaron Schulz [Wed, 21 May 2008 06:23:18 +0000 (06:23 +0000)]
Backwards
Siebrand Mazeland [Wed, 21 May 2008 06:11:09 +0000 (06:11 +0000)]
Localisation updates for core messages from Betawiki (2008-05-20 08:04 CEST)
Aaron Schulz [Wed, 21 May 2008 05:45:00 +0000 (05:45 +0000)]
* validateIntOrNull() returns null for empty input
* NULL options become the defaults if saved (bug 14100)
Aaron Schulz [Wed, 21 May 2008 05:23:20 +0000 (05:23 +0000)]
$user->setNewtalk( false ) for deleted user talk pages (bug 14077)
Nick Jenkins [Wed, 21 May 2008 04:59:21 +0000 (04:59 +0000)]
Prevent two E_STRICT warnings when running "php maintenance/update.php" to update from 1.12 alpha to 1.13 alpha.
--------------------------------------------------
# php maintenance/update.php
MediaWiki 1.13alpha Updater
Going to run database updates for wikidb
Depending on the size of your database this may take a while!
Abort with control-c in the next five seconds...0
Strict Standards: Type: 8: Undefined offset: 1 in wiki/includes/Database.php on line 1420
Database.tableName("ipblocks") # line 1164, file: wiki/includes/Database.php
Database.tableExists("ipblocks") # line 203, file: wiki/maintenance/updaters.inc
add_field("ipblocks", "ipb_id", "patch-ipblocks.sql") # line unknown, file: unknown
call_user_func_array("add_field", Array[3]) # line 1051, file: wiki/maintenance/updaters.inc
do_all_updates(false, true) # line 60, file: wiki/maintenance/update.php
[ ... snip same warning repeated thousands of times ... ]
--------------------------------------------------
... also ... :
--------------------------------------------------
Strict Standards: Type: 8: Undefined index: USE INDEX in wiki/includes/Database.php on line 977
Database.selectSQLText(Array[2], Array[2], Array[3], "Database::select", Array[0], Array[0]) # line 952, file: wiki/includes/Database.php
Database.select(Array[2], Array[2], Array[3]) # line 32, file: wiki/maintenance/deleteDefaultMessages.php
deleteDefaultMessages() # line 1077, file: wiki/maintenance/updaters.inc
do_all_updates(false, true) # line 60, file: wiki/maintenance/update.php
--------------------------------------------------
Raimond Spekking [Wed, 21 May 2008 04:57:02 +0000 (04:57 +0000)]
Localisation updates Kazahk (bug 12145)
Tim Starling [Wed, 21 May 2008 03:13:24 +0000 (03:13 +0000)]
Allow rate limits to be specific to explicit groups
Aaron Schulz [Wed, 21 May 2008 00:28:13 +0000 (00:28 +0000)]
Move this till after ID set
Brion Vibber [Tue, 20 May 2008 22:09:30 +0000 (22:09 +0000)]
* (bug 14199) Fix deletion form for image redirect pages
Image deletion was popping up the special image deletion form for the target image, which isn't friendly for redirects. :)
Now checking for redirect state as well as non-localness and non-existence, and pop up the regular page delete form for this.
Aaron Schulz [Tue, 20 May 2008 21:58:48 +0000 (21:58 +0000)]
Don't check $wgEnotifWatchlist here
Roan Kattouw [Tue, 20 May 2008 19:43:50 +0000 (19:43 +0000)]
Handle multiple warnings correctly in ApiBase::setWarning(). Calling this function twice from the same module used to throw a fatal error.
Roan Kattouw [Tue, 20 May 2008 19:31:45 +0000 (19:31 +0000)]
API: Unrecognized values for multivalue parameters now don't cause the API to abort with an error anymore, but just throw a warning and are ignored. This is useful for ??prop parameters, but also applies to other multivalue parameters such as list, meta and prop. Single values still throw an error like they used to.
Brion Vibber [Tue, 20 May 2008 19:30:06 +0000 (19:30 +0000)]
Dump silly 'dontcountme=s'; old webalizer hack, it's not consistently used anyway.
Brion Vibber [Tue, 20 May 2008 18:49:11 +0000 (18:49 +0000)]
*cough* thx
Brion Vibber [Tue, 20 May 2008 18:23:55 +0000 (18:23 +0000)]
put comment in wrong file, woops :D
that's what i get for committing right before bed
Huji [Tue, 20 May 2008 17:45:42 +0000 (17:45 +0000)]
* Adding/updating Persian translations
Alexandre Emsenhuber [Tue, 20 May 2008 17:13:28 +0000 (17:13 +0000)]
WARNING: HUGE COMMIT
Doxygen documentation update:
* Changed alls @addtogroup to @ingroup. @addtogroup adds the comment to the group description, but doesn't add the file, class, function, ... to the group like @ingroup does. See for example http://svn.wikimedia.org/doc/group__SpecialPage.html where it's impossible to see related files, classes, ... that should belong to that group.
* Added @file to file description, it seems that it should be explicitely decalred for file descriptions, otherwise doxygen will think that the comment document the first class, variabled, function, ... that is in that file.
* Removed some empty comments
* Removed some ?>
Added following groups:
* ExternalStorage
* JobQueue
* MaintenanceLanguage
One more thing: there are still a lot of warnings when generating the doc.
Bryan Tong Minh [Tue, 20 May 2008 17:09:59 +0000 (17:09 +0000)]
Forgot to remove one debug statement.
Bryan Tong Minh [Tue, 20 May 2008 17:05:57 +0000 (17:05 +0000)]
Add RepoGroup::findFiles to efficiently find many files if the repo supports it. Added support for this in ApiQueryImageInfo.
Raimond Spekking [Tue, 20 May 2008 14:56:25 +0000 (14:56 +0000)]
Localisation updates German
Bryan Tong Minh [Tue, 20 May 2008 14:34:19 +0000 (14:34 +0000)]
Forgot one $this => self when making ApiQueryImageInfo::getInfo static.
Bryan Tong Minh [Tue, 20 May 2008 14:32:52 +0000 (14:32 +0000)]
Use ApiQueryImageInfo::getInfo for both ApiQueryAllimages and ApiQueryImageInfo. Should also give some more consistency between the two modules.
Shinjiman [Tue, 20 May 2008 14:17:38 +0000 (14:17 +0000)]
Localisation updates Cantonese, Chinese and Old/Late Time Chinese
Raimond Spekking [Tue, 20 May 2008 13:31:21 +0000 (13:31 +0000)]
Add bug per r35065
Rotem Liss [Tue, 20 May 2008 09:42:22 +0000 (09:42 +0000)]
Update.
Roan Kattouw [Tue, 20 May 2008 09:16:01 +0000 (09:16 +0000)]
Unified aiprop and iiprop somewhat by adding iiprop=mime and aiprop=metadata. The size vs. dimensions discrepancy is weird, but won't be fixed for backwards compatibility. Also iiprop has user, comment and archivename because it handles file *revisions*, whereas allimages doesn't.
Bryan Tong Minh [Tue, 20 May 2008 08:06:43 +0000 (08:06 +0000)]
Force reindexation of User::mRights. Hooks have the possibility to unset rights, leaving the array out of order.
Siebrand Mazeland [Tue, 20 May 2008 07:41:33 +0000 (07:41 +0000)]
Localisation updates. Rebuilt all language files.
Siebrand Mazeland [Tue, 20 May 2008 07:26:11 +0000 (07:26 +0000)]
Localisation updates for core messages from Betawiki (2008-05-20 09:15 CEST)
Brion Vibber [Tue, 20 May 2008 06:30:36 +0000 (06:30 +0000)]
Got sick of testing local copies of Wikipedia articles with no images handy.
Threw together a really quick hack FileRepo class to grab images from the remote wiki using the MediaWiki API.
Amazingly it sort of works -- be warned however:
* no scaling seems to be done yet -- multi-megapixel images in your browser :D
* no caching of lookups -- verrrry slow
* lookups are done one at a time, not in any kind of batching
* probably doesn't properly support lots and lots of things
Raimond Spekking [Tue, 20 May 2008 05:23:38 +0000 (05:23 +0000)]
Add corresponding messages to have a chance to find the usage of these messages via grep
Raimond Spekking [Tue, 20 May 2008 04:55:52 +0000 (04:55 +0000)]
Add a new section for parser/template warnings
Raimond Spekking [Tue, 20 May 2008 04:11:00 +0000 (04:11 +0000)]
Follow up for r35065:
* Add new message 'categoriesfrom' to messages.inc
* Add default existing 'categories-summary' as optional message
* Stick together all Special:Categories messages
Aaron Schulz [Tue, 20 May 2008 03:26:59 +0000 (03:26 +0000)]
* Use lazy initialization with loadFile()
* Add $current/$time to field list
* Fix some ugly coding style
Aaron Schulz [Tue, 20 May 2008 03:15:07 +0000 (03:15 +0000)]
Tweak $time default
Aaron Schulz [Tue, 20 May 2008 02:58:40 +0000 (02:58 +0000)]
Add functions to get an image via sha-1
Brion Vibber [Mon, 19 May 2008 23:53:01 +0000 (23:53 +0000)]
Toss in a "display from" input field on Special:Categories
I'm not 100% happy with this yet as it doesn't play nice with initial-lowercase input.
Brion Vibber [Mon, 19 May 2008 22:52:12 +0000 (22:52 +0000)]
* (bug 12773) addOnloadHook() now calls functions immediately when scripts are
loaded after the primary page completion, instead of dropping them
* (bug 13232) importScript(), importStylesheet() funcs available to custom JS
Increases wikibits.js by 1k or so, but it should help with those custom scripts :D
Brion Vibber [Mon, 19 May 2008 22:15:17 +0000 (22:15 +0000)]
Reverting r35060 -- can't reproduce the reported problem so far, but if it exists this should be moved upstream so User::getGroups() and User::getRights() return consistent values themselves
Siebrand Mazeland [Mon, 19 May 2008 21:50:05 +0000 (21:50 +0000)]
Fix syntax error
Siebrand Mazeland [Mon, 19 May 2008 21:48:48 +0000 (21:48 +0000)]
Tweaks to recently added messages
Bryan Tong Minh [Mon, 19 May 2008 21:43:52 +0000 (21:43 +0000)]
Force indices of groups and rights array to be in order so that the JSON formatter recognizes it as a list instead of a dict in case for some reason rights or groups are removed somewhere in between (as done for sysops on testwiki).
Nicolas Dumazet [Mon, 19 May 2008 21:33:47 +0000 (21:33 +0000)]
#14094 When the expansion size is reached, the editor is not warned about it :
Adding 2 messages + 2 categories, similarly to "Warning: This page contains too many expensive parser function calls" to warn the user when template post include size (or template argument post include size) is too large
Bryan Tong Minh [Mon, 19 May 2008 21:30:03 +0000 (21:30 +0000)]
API: Merge file deletion code from ApiEdit_Vodafone branch.
Brion Vibber [Mon, 19 May 2008 20:20:33 +0000 (20:20 +0000)]
* (bug 1701) Korean Hangul syllables now broken down properly in Category lists even if the wiki's overall content language is not Korean
Nothing else left in LanguageKo class, so ditching it.
Aaron Schulz [Mon, 19 May 2008 18:55:48 +0000 (18:55 +0000)]
Stabilize image description links
Aaron Schulz [Mon, 19 May 2008 17:02:58 +0000 (17:02 +0000)]
$join_conds
Brion Vibber [Mon, 19 May 2008 15:49:05 +0000 (15:49 +0000)]
Don't fall into an infinite loop o' death if the pipes get broken.
Exit out if we can't read from stdin anymore, instead of interpreting the 'false' error code as text ID 0...