Volker E [Thu, 24 Aug 2017 19:42:56 +0000 (12:42 -0700)]
RCFilters: Align remaining outdated greys to WikimediaUI palette ones
Replacing abandoned grey colors with appropriate colors from WikimediaUI
color palette.
Additional changes:
* Also simplified selector specificity in one case as OOUI code has already
changed.
Bug: T172850
Change-Id: I01e84d9a4d03ba894cbb67114821036b0ffe1ddb
jenkins-bot [Thu, 24 Aug 2017 01:55:10 +0000 (01:55 +0000)]
Merge "mediawiki.skinning: Vertical align inline media in Parsoid output"
Arlo Breault [Thu, 17 Aug 2017 16:01:33 +0000 (12:01 -0400)]
mediawiki.skinning: Vertical align inline media in Parsoid output
Change-Id: I56df80a25b43f9084e8cb5e537836ac773732259
jenkins-bot [Thu, 24 Aug 2017 00:23:47 +0000 (00:23 +0000)]
Merge "RCFilters: Adjust pushpin 'default' icon behavior and style"
Moriel Schottlender [Wed, 23 Aug 2017 23:10:23 +0000 (16:10 -0700)]
RCFilters: Adjust pushpin 'default' icon behavior and style
Bug: T173264
Change-Id: I8d977bb97e91a19c24527c66120f142738135730
Moriel Schottlender [Wed, 23 Aug 2017 23:35:10 +0000 (16:35 -0700)]
RCFilters: Hide saved queries from anonymous users
Bug: T173992
Change-Id: I5acb9ca4dd20de83da5db42c7c9053fccb091da0
jenkins-bot [Wed, 23 Aug 2017 22:46:40 +0000 (22:46 +0000)]
Merge "Unit tests for CollationFa (
0bfcbd724)"
jenkins-bot [Wed, 23 Aug 2017 21:07:23 +0000 (21:07 +0000)]
Merge "RCFilters: Minimize vertical space"
jenkins-bot [Wed, 23 Aug 2017 20:54:02 +0000 (20:54 +0000)]
Merge "mw.widgets.SelectWithInputWidget: Invisible invalid fields should not block form submission"
Bartosz Dziewoński [Wed, 23 Aug 2017 18:55:20 +0000 (20:55 +0200)]
mw.widgets.SelectWithInputWidget: Invisible invalid fields should not block form submission
Same logic as in resources/src/mediawiki/htmlform/hide-if.js,
explanatory comment is copy-pasted from there.
Bug: T173839
Change-Id: I87603936d23165926d2ef4c64f3a61dca2062caf
Moriel Schottlender [Tue, 22 Aug 2017 23:24:58 +0000 (16:24 -0700)]
RCFilters: Minimize vertical space
Bug: T173265
Change-Id: I38821571450c59b18c753c8b20ad9f19f01b6276
Aaron Schulz [Wed, 23 Aug 2017 17:35:04 +0000 (10:35 -0700)]
Make workItemCount() smarter for htmlCacheUpdate/refreshLinks
Do not count jobs that just make subdivide as having any
"work items". This makes $wgJobBackoffThrottling less
overzealous when used to limit these type of jobs.
The main reason to limit htmlCacheUpdate would be for
CDN purge rate limiting. For refreshLinks, it would
mostly be lag, though that is already handled for
leaf jobs and JobRunner itself.
Bug: T173710
Change-Id: Ide831b555e51e3111410929a598efb6c0afc0989
jenkins-bot [Wed, 23 Aug 2017 16:52:17 +0000 (16:52 +0000)]
Merge "Set line height to 1 for sup and sub elements in print"
jdlrobson [Wed, 23 Aug 2017 15:59:44 +0000 (10:59 -0500)]
Set line height to 1 for sup and sub elements in print
It is already set in screen styles (shared.css).
Bug: T172501
Change-Id: I5a90e21f6eac300c57b6daddada0ae94fe579294
jenkins-bot [Wed, 23 Aug 2017 16:40:07 +0000 (16:40 +0000)]
Merge "mediawiki.skinning: Vertical alignment for traditional galleries in Parsoid output"
jenkins-bot [Wed, 23 Aug 2017 16:22:31 +0000 (16:22 +0000)]
Merge "MediawikiUI: Introduce mw-ui-icon-large"
Arlo Breault [Thu, 17 Aug 2017 18:03:39 +0000 (14:03 -0400)]
mediawiki.skinning: Vertical alignment for traditional galleries in Parsoid output
* Note that this just an extraction of inline styles that are
already present in the output.
Change-Id: I718f16dfbb2c4122ac9fb4a714b607da3e62d5a0
jdlrobson [Thu, 17 Aug 2017 15:30:51 +0000 (10:30 -0500)]
MediawikiUI: Introduce mw-ui-icon-large
This will allow MobileFrontend and Minerva to share rules for icons
See Ib29736dc80ac2f84747e920c5b5c30918df12978
Bug: T143264
Change-Id: I456714086d2548b2e10cceb2a05f7a0fadf94a3b
Translation updater bot [Wed, 23 Aug 2017 06:29:09 +0000 (08:29 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I6d08864f2cf81b605438d16d5ce272b77a4fb8b2
jenkins-bot [Wed, 23 Aug 2017 05:35:27 +0000 (05:35 +0000)]
Merge "Split common pre-setup code out of WebStart/doMaintenance"
Tim Starling [Wed, 23 Aug 2017 02:21:14 +0000 (12:21 +1000)]
Split common pre-setup code out of WebStart/doMaintenance
Introduce PreConfigSetup.php, which is common file-scope code run before
LocalSettings.php.
I'm not maintaining autoload.ide.php since it supports closed source
software which I don't have, and it apparently needs significant work to
make it not be weird and hacky.
Change-Id: I44ac69b6b00a51d015546b9766d89d1c59749334
jenkins-bot [Tue, 22 Aug 2017 23:25:57 +0000 (23:25 +0000)]
Merge "Remove two deprecated functions and one depreciated variable in a function call within Parser.php"
jenkins-bot [Tue, 22 Aug 2017 23:22:19 +0000 (23:22 +0000)]
Merge "Update OOjs UI to v0.22.5"
Matthew Bowker [Wed, 16 Aug 2017 08:28:59 +0000 (02:28 -0600)]
Remove two deprecated functions and one depreciated variable in a function call within Parser.php
* Parser::getRandomString() (deprecated in 1.26) was removed.
* Parser::uniqPrefix() (deprecated in 1.26) was removed.
* Parser::extractTagsAndParams() now only accepts three arguments. The fourth, $uniq_prefix was deprecated in 1.26 and has now been removed.
Bug: T61113
Change-Id: I7333fff4eb8b9a754b4596992f2a69bbdaac664d
Volker E [Tue, 22 Aug 2017 22:50:49 +0000 (15:50 -0700)]
Update OOjs UI to v0.22.5
Release notes:
https://phabricator.wikimedia.org/diffusion/GOJU/browse/master/History.md;v0.22.5
Depends-On: Icf08f8c12d91b74425df319e69df22330c7088a9
Change-Id: Ia3ba4989c573de8b458c209560f6658b8324b548
jenkins-bot [Tue, 22 Aug 2017 22:54:26 +0000 (22:54 +0000)]
Merge "EditPage: Remove legacy non-OOUI render mode"
jenkins-bot [Tue, 22 Aug 2017 21:36:07 +0000 (21:36 +0000)]
Merge "resources: Provide the WikimediaUI LESS config vars for all OOjs UI users"
jenkins-bot [Tue, 22 Aug 2017 21:18:27 +0000 (21:18 +0000)]
Merge "resources: Consolidate on the WikimediaUI “erroneous” color value"
Volker E [Tue, 22 Aug 2017 00:38:33 +0000 (17:38 -0700)]
resources: Consolidate on the WikimediaUI “erroneous” color value
“Erroneous” color was updated to `#d33` in WikimediaUI color palette to
ensure WCAG 2.0 level AA conformance with both white and black.
Replacing all occurences of `#f00` and `#c00` to reflect color palette
change with the following caveats and exceptions:
- MW config styles are not amended, as it is out of scope and all
boundaries and applications of WikimediaUI are yet to be defined;
- oldshared.css is excluded, as WikimediaUI isn't touching old skins; &
- errorbox with its current background is getting a lowered textual
contrast but we still provide enough contrast for text size and bolded
font, and this needs to be seen as intermediate standardization step.
Bug: T152025
Change-Id: Iba3362abaa1702599f0d68860f579aea2114801c
jenkins-bot [Tue, 22 Aug 2017 20:52:29 +0000 (20:52 +0000)]
Merge "Revert "registration: Only allow one extension to set a specific config setting""
Thcipriani [Tue, 22 Aug 2017 20:40:15 +0000 (20:40 +0000)]
Revert "registration: Only allow one extension to set a specific config setting"
Breaks mergeMessageFileList which means scap can't run in beta.
This reverts commit
50d7546057c1089228a2a6d7d4a49d78d72887e3.
Change-Id: Idb65f1098abce28d49ebbcc8254c0976b6861c59
Kunal Mehta [Mon, 21 Aug 2017 23:56:33 +0000 (16:56 -0700)]
EditPage: Remove legacy non-OOUI render mode
Mostly remove it at least. Some things from the transition are still
left around:
* EditPage::isOouiEnabled() will now always return true and is soft
deprecated as some extensions are using it to detect whether in OOUI
mode.
* EditPage::getCheckboxes() is left around since getCheckboxesOOUI()
calls it. Someone else will need to disentangle that.
* The "mw-editform-ooui" class is kept as some on-wiki JavaScript uses
it to detect whether running in the OOUI mode.
* CSS is still using the .mw-editform-ooui class. It should be
transitioned to use .mw-editform in a follow-up.
Other cleanup:
* mediawiki.action.edit now directly depends upon oojs-ui-core instead
of transitively via mediawiki.widgets.visibleByteLimit. As a result, the
mw.loader.using call was removed from the JavaScript file.
Bug: T172315
Change-Id: I2b468c8b846db015b5a1e3d2500abb8ea252c442
jenkins-bot [Tue, 22 Aug 2017 19:35:26 +0000 (19:35 +0000)]
Merge "registration: Only allow one extension to set a specific config setting"
jenkins-bot [Tue, 22 Aug 2017 17:57:42 +0000 (17:57 +0000)]
Merge "Fix link prefix/suffixes around Category and Language links."
jenkins-bot [Tue, 22 Aug 2017 16:52:45 +0000 (16:52 +0000)]
Merge "rdbms: Avoid selectDB() call in LoadMonitor new connections"
Aaron Schulz [Sat, 19 Aug 2017 17:48:45 +0000 (10:48 -0700)]
rdbms: Avoid selectDB() call in LoadMonitor new connections
This is not really necessary and can cause problems if the local
wiki has no tables on the given database.
Bug: T172559
Change-Id: I77c1238bb59b9c060bdec22aa2f7f758e07b748c
jenkins-bot [Tue, 22 Aug 2017 15:16:13 +0000 (15:16 +0000)]
Merge "Remove MemcachedClient compat class names"
jenkins-bot [Tue, 22 Aug 2017 15:16:08 +0000 (15:16 +0000)]
Merge "Remove RunningStat compat class"
jenkins-bot [Tue, 22 Aug 2017 15:07:22 +0000 (15:07 +0000)]
Merge "Remove IPSet compat classes"
jenkins-bot [Tue, 22 Aug 2017 15:07:05 +0000 (15:07 +0000)]
Merge "Remove Cdb compat class names"
jenkins-bot [Tue, 22 Aug 2017 15:06:10 +0000 (15:06 +0000)]
Merge "PHPVersionCheck: Use HTTPS download URL for downloading PHP"
jenkins-bot [Tue, 22 Aug 2017 13:02:33 +0000 (13:02 +0000)]
Merge "RCFilters: Ignore sticky filters when emptying all filters"
jenkins-bot [Tue, 22 Aug 2017 10:51:24 +0000 (10:51 +0000)]
Merge "Soft deprecation of DatabaseMysql"
jenkins-bot [Tue, 22 Aug 2017 10:20:11 +0000 (10:20 +0000)]
Merge "jquery.migrate: Instrument with mw.track()"
Florian Schmidt [Mon, 17 Apr 2017 20:36:30 +0000 (22:36 +0200)]
registration: Only allow one extension to set a specific config setting
ExtensionProcessor would previously just blindly overwrite duplicate
config settings, which ends up depending upon load order.
It's relatively hard to debug since it is silently overwritten. This now
throws exceptions in case of duplicate config settings.
This will also have some side-effects of catching people putting things
like "ResourceModules" in their "config" section when it should be a
top-level item.
Bug: T152929
Change-Id: Iaef32efab397e82ff70ddca8ac79c545c5b7d2bb
jenkins-bot [Tue, 22 Aug 2017 06:33:07 +0000 (06:33 +0000)]
Merge "LocalisationCache: Remove unused "use" statements"
Translation updater bot [Tue, 22 Aug 2017 06:07:43 +0000 (08:07 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I69daeb5e4ae27d6dbef1f8b1766053724cb02499
Kunal Mehta [Tue, 22 Aug 2017 05:45:04 +0000 (22:45 -0700)]
PHPVersionCheck: Use HTTPS download URL for downloading PHP
Change-Id: Iaf8e012b91888233703577e2de4ec522f39428e7
Kunal Mehta [Tue, 22 Aug 2017 04:50:31 +0000 (21:50 -0700)]
Remove MemcachedClient compat class names
Deprecated since 1.27, and unused in Wikimedia Git.
Change-Id: I1d73efac2fddb771124bcd31b3d40769e751410c
Kunal Mehta [Tue, 22 Aug 2017 04:38:16 +0000 (21:38 -0700)]
Remove RunningStat compat class
Deprecated since 1.27, unused in Wikimedia Git.
Change-Id: I0086c1cd945865b10a1e7fcc34c08642db2474af
Kunal Mehta [Tue, 22 Aug 2017 04:34:50 +0000 (21:34 -0700)]
Remove IPSet compat classes
Deprecated in 1.26, unused in Wikimedia Git.
Change-Id: I7719a204160ddd0ba71a1a5d8f7088f7d552acbd
Kunal Mehta [Tue, 22 Aug 2017 04:29:00 +0000 (21:29 -0700)]
Remove Cdb compat class names
Deprecated since 1.25, and unused in Wikimedia Git.
Change-Id: I05bdefe2e2bf5ffcadb9846651af7367e8e7a814
Kunal Mehta [Tue, 22 Aug 2017 03:40:52 +0000 (20:40 -0700)]
LocalisationCache: Remove unused "use" statements
Change-Id: Ie1cdd52d87deffa251b7af0554370ba9a4edce73
jenkins-bot [Tue, 22 Aug 2017 01:56:17 +0000 (01:56 +0000)]
Merge "Delete maintenance/deleteRevision.php"
James D. Forrester [Mon, 21 Aug 2017 23:53:26 +0000 (16:53 -0700)]
resources: Provide the WikimediaUI LESS config vars for all OOjs UI users
Bug: T123359
Change-Id: I11677b9bacdbba9e17574891ca30428051b13606
James D. Forrester [Tue, 22 Aug 2017 00:06:02 +0000 (17:06 -0700)]
build: Bump eslint-config-wikimedia from 0.4.0 to 0.5.0
Change-Id: I06010cd6367c1884b5536e7929d3345feba7f305
jenkins-bot [Mon, 21 Aug 2017 22:41:17 +0000 (22:41 +0000)]
Merge "Don't hard-code Preferences page name"
Sam Wilson [Mon, 21 Aug 2017 02:08:32 +0000 (10:08 +0800)]
Don't hard-code Preferences page name
This fixes the restore-prefs link by switching to use whatever
the current title of the PreferencesForm is.
Bug: T173682
Change-Id: I67a13269a63f719a011a2d59a07493d9eb6b653b
Moriel Schottlender [Mon, 21 Aug 2017 21:03:29 +0000 (14:03 -0700)]
RCFilters: Ignore sticky filters when emptying all filters
Also, as a bonus, actually connect the 'update' event to the already
existing method that was supposed to respond to an update event on
the 'enhanced' filter.
Bug: T172580
Change-Id: I4db5689d1d2ef627bbb5ec34f8af772157d1ff09
jenkins-bot [Mon, 21 Aug 2017 19:23:28 +0000 (19:23 +0000)]
Merge "RCFilters: Add title attribute to [x] button"
jenkins-bot [Mon, 21 Aug 2017 19:20:18 +0000 (19:20 +0000)]
Merge "RCFilters: Fix highlight circle misalignment"
jenkins-bot [Mon, 21 Aug 2017 19:05:48 +0000 (19:05 +0000)]
Merge "Remove child-selector-emu.html"
Moriel Schottlender [Fri, 18 Aug 2017 23:08:09 +0000 (16:08 -0700)]
RCFilters: Add title attribute to [x] button
For accessibility, add title attribute to the remove button in
the active filters area.
Bug: T173608
Change-Id: Idcf735e3b610345a8206f83fe5f8115900455cc2
jenkins-bot [Mon, 21 Aug 2017 18:04:40 +0000 (18:04 +0000)]
Merge "Update jQuery Migrate to v3.0.1-pre (
9e3dfcb)"
Moriel Schottlender [Fri, 18 Aug 2017 23:28:35 +0000 (16:28 -0700)]
RCFilters: Fix highlight circle misalignment
Bug: T172820
Change-Id: I44b91529e8edb6a3fcc65ae9159211dbd2d7f4f1
Brad Jorsch [Mon, 21 Aug 2017 16:54:54 +0000 (12:54 -0400)]
Delete maintenance/deleteRevision.php
It hasn't been updated properly since 2006 so many fields aren't being
copied to the archive table. Tim suggests it'd be best to just delete it
and, if someone needs the ability to delete or revdel revisions from the
command line, properly abstract out the deletion code instead of
duplicating it.
Change-Id: I400b8ac30b31802e7dd9f6e4d0ec10918eba0183
jenkins-bot [Mon, 21 Aug 2017 16:42:23 +0000 (16:42 +0000)]
Merge "Change 'editfont' default preference to 'monospace'"
jenkins-bot [Mon, 21 Aug 2017 16:24:49 +0000 (16:24 +0000)]
Merge "SpecialNewpages: add $attribs['class'] immediately before creating <li>"
jenkins-bot [Mon, 21 Aug 2017 15:29:46 +0000 (15:29 +0000)]
Merge "RCFilters: Add title attribute to highlighted rows"
jenkins-bot [Mon, 21 Aug 2017 05:00:08 +0000 (05:00 +0000)]
Merge "debug: Add cli_argv field to monolog WikiProcessor"
Umherirrender [Sun, 20 Aug 2017 11:20:59 +0000 (13:20 +0200)]
Use short type bool/int in param documentation
Enable the phpcs sniffs for this and used phpcbf
Change-Id: Iaa36687154ddd2bf663b9dd519f5c99409d37925
Translation updater bot [Sat, 19 Aug 2017 06:36:59 +0000 (08:36 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I160964145dd308c644e72d34a8c5ef435ad09f56
Moriel Schottlender [Fri, 18 Aug 2017 23:01:30 +0000 (16:01 -0700)]
RCFilters: Add title attribute to highlighted rows
For accessibility and screen readers, add the actual highlighted
filter names to a title attribute in rows that are highlighted.
Bug: T173608
Change-Id: Id71a45621e545897988010acfd054760a617b1f1
Timo Tijhof [Fri, 18 Aug 2017 23:47:35 +0000 (16:47 -0700)]
debug: Add cli_argv field to monolog WikiProcessor
Follows investigation from T172559, where we found that there is no explicit
way to find what script triggered particular error messages when the script
was run from the command-line (as opposed to a web request, where the
built-in WebProcessor adds fields like http_method and url).
Change-Id: Ia9641274a164137dcc30324578d750cc662976ee
jenkins-bot [Fri, 18 Aug 2017 22:05:30 +0000 (22:05 +0000)]
Merge "WLFilters: new 'watchlist activity' filter group"
jenkins-bot [Fri, 18 Aug 2017 22:04:34 +0000 (22:04 +0000)]
Merge "WLFilters: convert mark as seen button to new style"
jenkins-bot [Fri, 18 Aug 2017 22:01:36 +0000 (22:01 +0000)]
Merge "Enable RCFilters app on Watchlist"
Volker E [Fri, 18 Aug 2017 21:10:35 +0000 (14:10 -0700)]
Remove child-selector-emu.html
Not necessary to keep this doc around any longer, as IE 6 is not
of concern any more.
Change-Id: I381a2bc750accee324b627e87dd4e11ba8f96364
Volker E [Mon, 7 Aug 2017 16:45:11 +0000 (18:45 +0200)]
Deprecate greys not part of WikimediaUI color palette any more
Deprecating greys, which are not part of WikimediaUI color palette
any more:
- @colorGray3: #333;
- @colorGray6: #666;
- @colorGray8: #888;
- @colorGray9: #999;
- @colorGray11: #bbb;
- @colorGray13: #ddd;
See https://wikimedia.github.io/WikimediaUI-Style-Guide/visual-style_icons.html
for further information.
Bug: T152025
Change-Id: Iaef72470c59665682f4a54d0b754d41a2678f146
Stephane Bisson [Fri, 18 Aug 2017 15:35:42 +0000 (11:35 -0400)]
WLFilters: new 'watchlist activity' filter group
Bug: T171127
Change-Id: I84bf122bd042dd9b8b5495cb59a2a8f7cb77eb55
jenkins-bot [Fri, 18 Aug 2017 19:43:52 +0000 (19:43 +0000)]
Merge "Remove deprecated jquery.mwExtension module"
Stephane Bisson [Fri, 18 Aug 2017 14:52:24 +0000 (10:52 -0400)]
WLFilters: convert mark as seen button to new style
Bug: T171121
Change-Id: I52b3c318fe8270c857d9afebdfd7f440d56131c9
Stephane Bisson [Thu, 3 Aug 2017 17:11:53 +0000 (13:11 -0400)]
Enable RCFilters app on Watchlist
* Add classes prefixed with cl (for ChangesList)
to both RC and WL so that the JS app can locate
similar elements using the same selectors
* Make saved queries preference name configurable
so that RC and WL use different preferences
* Move some code from SpecialRecentchanges.php to
its base class so it's accessible to SpecialWatchlist.php
To use the RCFilters app on WL, append ?rcfilters=1 to the URL
Bug: T171132
Bug: T171218
Change-Id: If7c63284224df24fa02022b4ea74bef116f28ca6
jenkins-bot [Fri, 18 Aug 2017 18:06:57 +0000 (18:06 +0000)]
Merge "Use json extension for .stylelintrc"
jenkins-bot [Fri, 18 Aug 2017 15:39:18 +0000 (15:39 +0000)]
Merge "Skin: Remove redundant use of QuickTemplate::setRef()"
Zhuyifei1999 [Fri, 18 Aug 2017 08:01:02 +0000 (08:01 +0000)]
SpecialNewpages: add $attribs['class'] immediately before creating <li>
The call to `wfArrayFilterByKey` / `isReservedDataAttribute` removes
all attributes that are not reserved (`/^data-(ooui|mw|parsoid)/i`).
The `class` attribute is not reserved, and is therefore unfortunately
removed. Moving the addition of $attribs['class'] will allow overriding
of the sanitizer, and actually add the attribute.
It is also moved below the Hooks::run call so that extensions can
effectively add the classes, and SpecialNewpages will not disregard
the changes to `$classes` from hooks.
This behaviour / placement is consistent with other calls to
`wfArrayFilterByKey` / `isReservedDataAttribute`, such as
`OldChangesList`, `DeletedContribsPager`, and `ContribsPager`.
Bug: T173556
Change-Id: I40e5e98228dae79a2de39efc28091cc9f69f64ea
Translation updater bot [Fri, 18 Aug 2017 06:30:40 +0000 (08:30 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I7319928e9a7f6a9ec00cfcc27dba4e9a5fbf2f61
Timo Tijhof [Fri, 18 Aug 2017 01:51:17 +0000 (18:51 -0700)]
Remove deprecated jquery.mwExtension module
* Deprecated since MediaWiki 1.26.
* Not used anywhere in Wikimedia Git.
* Grafana mw-js-deprecate dashboard shows < 1 hit per day on average
for any of the jquery.mwExtension properties, during the past 3 weeks.
Most days 0, some days 18 individual hits.
By comparison, legacy wikibits before we removed it in May 2017 was down
to about 6,000/24h (combined), so removal is quite overdue.
Change-Id: Ib66d1844b4fb8d7185b0e6607b9f98c1be632bb5
jenkins-bot [Fri, 18 Aug 2017 01:38:01 +0000 (01:38 +0000)]
Merge "rdbms: Support secondary autocommit connections in LoadBalancer"
Aaron Schulz [Thu, 20 Jul 2017 03:51:54 +0000 (20:51 -0700)]
rdbms: Support secondary autocommit connections in LoadBalancer
This is useful for things like SqlBagOStuff and JobQueueDB
being able to write in auto-commit mode while the main
transaction round still goes on.
SqlBagOStuff already had this sort of logic.
JobQueueDB now also takes this approach so it does not have to
defer insertion except for sqlite. This makes callers more likely
to know when insertion failed or not.
Make sure LoadBalancer sets "master"/"replica" LB info itself;
this fixes a bug found in the new tests.
Bug: T140338
Bug: T42451
Change-Id: I4199a9598d7afbf976a6efa8ed84b85b56da02bd
Timo Tijhof [Fri, 18 Aug 2017 01:20:40 +0000 (18:20 -0700)]
jquery.migrate: Instrument with mw.track()
Inspired by
cb20b5aa5a68d, which added similar instrumentation
during the jQuery 1.11 migration for MediaWiki in 2014.
This way we can plot overall usage in a Grafana dashboard and
help us track the progres of the on-going migration.
Bug: T124742
Change-Id: Ifab13d52d5681189cfb2faae342373558369b8c0
Timo Tijhof [Fri, 18 Aug 2017 01:04:46 +0000 (18:04 -0700)]
Update jQuery Migrate to v3.0.1-pre (
9e3dfcb)
Highlights:
* Event: Warn and fill jQuery.event.props.concat
> Adds back-compat for a removed property. (Undocumented)
> This makes jQuery 3 compatible with jQuery Mobile pre-1.5
* Effects: Warn on use of jQuery.fx.interval
> Adds detection for a deprecated property.
* Event: Warn about late use of $(window).on("load"...)
* Data: Fix support for object as second argument
> Fixes minor regression that jQuery Migrate introduced
> over jQuery 3.0 plain.
* Docs: Clarify wording around deprecated/removed methods
> Avoids confusion between whether a method was removed
> in jQuery 3, or merely deprecated.
Full change log:
https://github.com/jquery/jquery-migrate/compare/3.0.0...
9e3dfcb
Also re-apply and document hot patch from
a77525e56ac1a.
Bug: T124742
Change-Id: Ia55b6aad1648667648cc511eddea12b808d7e898
Timo Tijhof [Thu, 17 Aug 2017 22:22:36 +0000 (15:22 -0700)]
Skin: Remove redundant use of QuickTemplate::setRef()
As part of long-term moving towards having skins consume prepared
data and not making additional run-time database queries or additional
PHP-specific semantics and global state, try to phase out use
of QuickTemplate::setRef(), which is incompatible with the idea of
data only flowing in one direction (given it allows the value to
change at any time).
* jsmimetype: Deprecated/unused, has a constant value for compat.
* mimetype: Obsolete, Content-Type header comes from OutputPage.
* skin: Objects are references by default, '$this' can't be
modified anyway.
Bug: T140664
Change-Id: Ia505cc3e1b774a380fb36b4f0e2522550aef5bbd
jenkins-bot [Thu, 17 Aug 2017 22:18:11 +0000 (22:18 +0000)]
Merge "rdbms: Fix grammar in DBTransactionSizeError log message"
jenkins-bot [Thu, 17 Aug 2017 22:16:30 +0000 (22:16 +0000)]
Merge "Make mysql getHeartbeatData() method not count query/RTT in estimate"
jenkins-bot [Thu, 17 Aug 2017 22:16:27 +0000 (22:16 +0000)]
Merge "Restore the newFromId() approach in SpecialNewpages::feedItemDesc"
Aaron Schulz [Thu, 17 Aug 2017 21:38:27 +0000 (14:38 -0700)]
rdbms: Fix grammar in DBTransactionSizeError log message
Change-Id: Icc09d674359012f60494b95a36127c14c1a8d630
Aaron Schulz [Thu, 17 Aug 2017 20:53:01 +0000 (13:53 -0700)]
Restore the newFromId() approach in SpecialNewpages::feedItemDesc
Trying to use the row data is problematic since the text related
fields are missing. This fixing a regression from
4475e1c8c.
Also make SpecialNewpages::feedItemDesc() handle null content.
Bug: T173541
Change-Id: I2213675d3392c6e9761bdc7acde35fd1caee4517
jenkins-bot [Thu, 17 Aug 2017 20:33:32 +0000 (20:33 +0000)]
Merge "RCFilters: Fix validation for single_option groups"
jenkins-bot [Thu, 17 Aug 2017 20:26:29 +0000 (20:26 +0000)]
Merge "rdbms: Rename "memCache" to "memStash" in LBFactory"