Sam Reed [Sun, 5 Jun 2011 16:34:09 +0000 (16:34 +0000)]
* (bug 28897) rvparse doesn’t seem to work with rvsection
Sam Reed [Sun, 5 Jun 2011 15:12:38 +0000 (15:12 +0000)]
Add missing word to r89505
Sam Reed [Sun, 5 Jun 2011 15:10:11 +0000 (15:10 +0000)]
* (bug 29265) Mediawiki API documentation incomplete
Add text about erroneous requests when sent to the api
Remove extra //, and add some documentation
Sam Reed [Sun, 5 Jun 2011 14:46:55 +0000 (14:46 +0000)]
Adding method documentation
Add a couple of explicit variable definitions
Add some braces
Add one false; to return under case self::AS_NO_CREATE_PERMISSION:
Antoine Musso [Sun, 5 Jun 2011 09:25:42 +0000 (09:25 +0000)]
code documentation for $wgPreprocessorCacheThreshold
follow up r80180
Max Semenik [Sat, 4 Jun 2011 22:07:57 +0000 (22:07 +0000)]
SQLite-specific dropTable(): works a bit faster because it doesn't need a separate table existence check and does not rely on subtly broken tableExists() which I will fix a bit later
Max Semenik [Sat, 4 Jun 2011 21:56:44 +0000 (21:56 +0000)]
Revert r89254:
* It breaks if any extension uses any global except $IP, $wgHooks or $wgAutoloadClasses. Some unit tests that try updating a virtual database are already affected.
* If we have LocalSettings.php, we already have it loaded - are there code paths that don't have it?
* Parsing PHP with regexes is fragile and scary
Chad Horohoe [Sat, 4 Jun 2011 21:34:07 +0000 (21:34 +0000)]
pear -> port
Chad Horohoe [Sat, 4 Jun 2011 21:32:51 +0000 (21:32 +0000)]
Also support macports
Platonides [Sat, 4 Jun 2011 21:19:07 +0000 (21:19 +0000)]
Follow up r60599. Make normalizeUnicode() work even if $wgContLang is still not set,
just as it did before (eg. getGPCVal() check). This allows for early calls before
MediaWiki is completely initialised.
Alexandre Emsenhuber [Sat, 4 Jun 2011 20:28:59 +0000 (20:28 +0000)]
Fix for r89474: added missing () to function call
Alexandre Emsenhuber [Sat, 4 Jun 2011 20:27:51 +0000 (20:27 +0000)]
Fix for r89475: let's make this correctly
Alexandre Emsenhuber [Sat, 4 Jun 2011 20:21:50 +0000 (20:21 +0000)]
Added missing $PAGEEDITTIME replacement for impersonal mails
Platonides [Sat, 4 Jun 2011 20:12:21 +0000 (20:12 +0000)]
Follow up r89408. Magic >lang to getLang().
Alexandre Emsenhuber [Sat, 4 Jun 2011 20:11:05 +0000 (20:11 +0000)]
Use isAnon() so that the mail doesn't contain "anonymous user w.x.y.z" when a logged in user has "w.x.y.z" as real name and $wgEnotifUseRealName is true
Platonides [Sat, 4 Jun 2011 17:53:46 +0000 (17:53 +0000)]
Add BlockTest to the tests autoloader. Needed by ApiBlockTest.php
Added tabs to other items (compare ignoring whitespace).
Huji [Sat, 4 Jun 2011 14:33:01 +0000 (14:33 +0000)]
Follow up to r89419:
Per Brion's comment on Code Review, a generically named ltr class is created and used to reduce the number of rules
Krinkle [Sat, 4 Jun 2011 14:04:33 +0000 (14:04 +0000)]
Fixing fixme in r87164 (wrong if check)
Sam Reed [Sat, 4 Jun 2011 11:31:22 +0000 (11:31 +0000)]
* (bug 29265) Mediawiki API documentation incomplete
Flesh out documentation for the maxlag parameter
Alexandre Emsenhuber [Sat, 4 Jun 2011 09:22:24 +0000 (09:22 +0000)]
Added a note when this script is used
Mark A. Hershberger [Sat, 4 Jun 2011 02:59:10 +0000 (02:59 +0000)]
follow up r89278 — remove FTP support.
Chad Horohoe [Sat, 4 Jun 2011 02:54:29 +0000 (02:54 +0000)]
Followup r88124: fix the most glaring bug of the week
Sam Reed [Fri, 3 Jun 2011 22:59:34 +0000 (22:59 +0000)]
* (bug 29267) always give the servername for meta=siteinfo&siprop=dbrepllag
Brion Vibber [Fri, 3 Jun 2011 22:27:38 +0000 (22:27 +0000)]
Provisional revert of r89230: per CR, benchmarking currently shows that it makes things slightly slower, not faster
http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89230#c17571
Raimond Spekking [Fri, 3 Jun 2011 21:08:51 +0000 (21:08 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2011-06-03 20:47:00 UTC)
Max Semenik [Fri, 3 Jun 2011 19:55:37 +0000 (19:55 +0000)]
Use getSearchEngine() instead of constructing class name manually
Brion Vibber [Fri, 3 Jun 2011 18:58:34 +0000 (18:58 +0000)]
r89329 followup: roa-rup -> rup in addwiki.php's initial main page text.
(Is this script still used?)
Brion Vibber [Fri, 3 Jun 2011 18:48:59 +0000 (18:48 +0000)]
Provisional revert of r89406, r89414: reference-related warnings need cleanup before applying code like this
Per CR http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89406#c17545 :
'Here is a third one: Strict Standards: Only variables should be passed by reference in /www/sandwiki/includes/Wiki.php on line 177 '
Offending bit is this:
- SpecialPageFactory::executePath( $this->context->title, $this->context );
+ SpecialPageFactory::executePath( $this->getTitle(), $this->getContext() );
That function demands reference paramters for $title and $context, which is being violated here where we now pass function return values:
public static function executePath( Title &$title, RequestContext &$context, $including = false ) {
The $title does sometimes get replaced within the function body, but $context does not appear to ever be replaced (its *contents* are modified, which does not require passing by reference)
If replacing it is something it should be doing, then we need to be able to replace it upstream presumably, so $this->getTitle() probably isn't appropriate.
The $context probably should have the reference simply removed.
Brion Vibber [Fri, 3 Jun 2011 18:39:10 +0000 (18:39 +0000)]
Revert r89409: provided a default Database->listTables() implementation that didn't actually check the database, thus missing extension tables, any custom tables, any other tables being managed deliberately, and would be missing a matching table prefix if any.
Huji [Fri, 3 Jun 2011 16:20:00 +0000 (16:20 +0000)]
Extension to r89419, I was too excited fixing the bug
Huji [Fri, 3 Jun 2011 16:17:08 +0000 (16:17 +0000)]
Extension to r89419, removing a bugous CSS code
Huji [Fri, 3 Jun 2011 16:15:07 +0000 (16:15 +0000)]
(bug 29263) Add LTR class to the shared CSS to be used for left-to-right text such as SQL queries shown in dberrortext and similiar messages in RTL environements
Happy-melon [Fri, 3 Jun 2011 14:36:06 +0000 (14:36 +0000)]
Follow-up r89406 CR: another use of RequestContext::__get()
Jure Kajzer [Fri, 3 Jun 2011 11:43:54 +0000 (11:43 +0000)]
* suggestion for using tables.sql parsing instead of database query for tables list needed for phpunit
* would be better option IMO since the database is not necesserally dedicated to MW install
Happy-melon [Fri, 3 Jun 2011 11:04:49 +0000 (11:04 +0000)]
More unpicking of r85288. I think this is all of the magic method calls, but they're very hard to grep for (part of the problem with them!), so let's leave the calls in with a wfDeprecated() for a while...
Alexandre Emsenhuber [Fri, 3 Jun 2011 10:55:38 +0000 (10:55 +0000)]
Don't execute the loop if there's no X-Forwarded-For header, also don't use isset() to check only for null
Happy-melon [Fri, 3 Jun 2011 10:54:13 +0000 (10:54 +0000)]
Start unpicking r85288 (magic __get() accessor for RequestContext). Instead, bring back some of r86872 (abstract base class for classes providing access to RequestContext methods), which is a more 'classical' solution.
Alexandre Emsenhuber [Fri, 3 Jun 2011 10:41:53 +0000 (10:41 +0000)]
Deprecated wfGetAgent(), use $wgRequest->getHeader( 'User-Agent' ) instead
Alexandre Emsenhuber [Fri, 3 Jun 2011 10:20:45 +0000 (10:20 +0000)]
Removed usage of error suppression operator
Roan Kattouw [Fri, 3 Jun 2011 10:08:06 +0000 (10:08 +0000)]
(bug 29105) Splitlines completely messes up selection of inserted text. This is not a problem in practice (WikiEditor doesn't have multiline insertions with splitlines enabled since r89402), but just in case it ever becomes a problem I'm disabling selection of inserted text altogether when splitlines is enabled; instead, the cursor will be moved to the end of the inserted text.
Roan Kattouw [Fri, 3 Jun 2011 09:56:01 +0000 (09:56 +0000)]
(bug 29104) Fix r86622: make splitlines default to false, makes much more sense
Roan Kattouw [Fri, 3 Jun 2011 09:51:48 +0000 (09:51 +0000)]
(bug 29121) jquery.suggestions uses jquery.autoEllipsis but didn't have it in its dependency list, causing JS errors in non-Vector skins
Chad Horohoe [Fri, 3 Jun 2011 06:22:18 +0000 (06:22 +0000)]
Fix some of the weird freaky interaction between ApiBlockTest and BlockTest.
* By using the same summary for both, we allow both sets of tests to pass with --filter Block
* Just testing includes/BlockTest.php still passes
Chad Horohoe [Fri, 3 Jun 2011 05:44:28 +0000 (05:44 +0000)]
rvv: r89398. Tim wants me to wait
Chad Horohoe [Fri, 3 Jun 2011 05:39:32 +0000 (05:39 +0000)]
Kill off action=raw from index.php
* One less entry point to worry about
* Completely obsolete by load.php and api.php
* Left $wgDebugRawPage in place, also affects load.php requests (docs already reflect)
* Affects dumpHTML (probably broken anyway, has anyone RL-ified this?), and two abandoned/obsolete extensions
Tim Starling [Fri, 3 Jun 2011 05:32:51 +0000 (05:32 +0000)]
(bug 28840) If the query string hits bug 28235, redirect to a safer URL instead of showing an unhelpful error message. IE 6 will only use the extension of the final destination for its cache filename.
Chad Horohoe [Fri, 3 Jun 2011 04:25:21 +0000 (04:25 +0000)]
Remove useless bootstrap inclusions
Chad Horohoe [Fri, 3 Jun 2011 04:22:14 +0000 (04:22 +0000)]
Fix for r85229: getOutput() instead of getOut(), leftover $wgOut usage.
Mark A. Hershberger [Fri, 3 Jun 2011 04:10:33 +0000 (04:10 +0000)]
Apply a patch adapted from the one on Bug #16794
This patch should allow you to use the $wgSharedDB [with Postgres]
normally, as you would with mysql. Basically this patch creates a
second connection with the shared database and when a query is
made, we check on which connection we should send it.
Patch from Luca Fulchir
Chad Horohoe [Fri, 3 Jun 2011 04:05:04 +0000 (04:05 +0000)]
Missing ,
Chad Horohoe [Fri, 3 Jun 2011 03:59:27 +0000 (03:59 +0000)]
Add Maintenance and FakeMaintenance to the autoloader for paranoia
Mark A. Hershberger [Fri, 3 Jun 2011 03:41:11 +0000 (03:41 +0000)]
forward port r88929
Chad Horohoe [Fri, 3 Jun 2011 03:38:52 +0000 (03:38 +0000)]
Kill $wgWikiFarm. Only use in a wmf code path, and I can't find any evidence of this being use in WMF anywhere.
Chad Horohoe [Fri, 3 Jun 2011 03:36:36 +0000 (03:36 +0000)]
Fix for r89166: need self
Krinkle [Fri, 3 Jun 2011 02:26:31 +0000 (02:26 +0000)]
Move fixes for config-error-box to mw-infobox in order to apply for warnings as well. And removed redundant clear: left. Poke r88465, 86060, r88109
Mark A. Hershberger [Fri, 3 Jun 2011 01:06:07 +0000 (01:06 +0000)]
Fix for bug #28172 (“wfGetDB called when it shouldn't be”).
forward ported from r88936 and r89374.
Krinkle [Fri, 3 Jun 2011 01:04:24 +0000 (01:04 +0000)]
typo from r78201
Jure Kajzer [Thu, 2 Jun 2011 22:23:05 +0000 (22:23 +0000)]
* fixed table duplication for phpunit testing
Chad Horohoe [Thu, 2 Jun 2011 20:15:00 +0000 (20:15 +0000)]
Revert r88648 per CR
Mark A. Hershberger [Thu, 2 Jun 2011 19:32:45 +0000 (19:32 +0000)]
w/s changes.
Sam Reed [Thu, 2 Jun 2011 18:39:55 +0000 (18:39 +0000)]
Followup r89348
Fix code style, and remove hint that variable may be multi
Max Semenik [Thu, 2 Jun 2011 17:58:34 +0000 (17:58 +0000)]
Don't duplicate tables starting with unittest_ which can be left if a previous run ended with a fatal on SQLite
Mark A. Hershberger [Thu, 2 Jun 2011 16:38:55 +0000 (16:38 +0000)]
follow up r88502 with a fix to resource loader to restore tochidden
removal addition.
Roan Kattouw [Thu, 2 Jun 2011 16:13:42 +0000 (16:13 +0000)]
Revert r88722 (allow multiple values for letype): this won't play nice with query indexing
Platonides [Thu, 2 Jun 2011 16:10:48 +0000 (16:10 +0000)]
Fix for r89263: this to $this
Mark A. Hershberger [Thu, 2 Jun 2011 16:02:04 +0000 (16:02 +0000)]
Revert r88502 since this can be done with a gadget
Roan Kattouw [Thu, 2 Jun 2011 15:42:23 +0000 (15:42 +0000)]
Fix regression in r84638, causing ArticleDeleteComplete to be called twice on file deletions. doDeleteArticle() already calls it, there's no need for FileDeleteForm::doDelete() to call it again
Platonides [Thu, 2 Jun 2011 15:39:24 +0000 (15:39 +0000)]
Close wfProfileIn
Exit point missed by r85204
Jeroen De Dauw [Thu, 2 Jun 2011 14:38:14 +0000 (14:38 +0000)]
added @ßince tag
Antoine Musso [Thu, 2 Jun 2011 14:17:00 +0000 (14:17 +0000)]
Add Debug hook as a new feature of 1.19
Release notes were not updated by r88843
Antoine Musso [Thu, 2 Jun 2011 13:44:27 +0000 (13:44 +0000)]
properly move the jpegmeta.js file from util to libs.
Follow up r89083 (code change)
Fix r89084 (file move without history, reverted by r89334)
Antoine Musso [Thu, 2 Jun 2011 13:40:05 +0000 (13:40 +0000)]
revert r89084 (file moved without keeping history)
Robin Pepermans [Thu, 2 Jun 2011 13:23:21 +0000 (13:23 +0000)]
Fix encoding (followup r89330)
Robin Pepermans [Thu, 2 Jun 2011 13:14:16 +0000 (13:14 +0000)]
Follow-up to r89329: Add MessagesRoa_rup.php as fallback to 'rup'
Robin Pepermans [Thu, 2 Jun 2011 13:10:06 +0000 (13:10 +0000)]
Renaming 'roa-rup' to 'rup' (see also bug 15988), and adding 'roa-rup' to $wgDummyLanguageCodes. I'm going to add MessagesRoa_rup.php as fallback, and update extension translations as well.
Alexandre Emsenhuber [Thu, 2 Jun 2011 08:18:52 +0000 (08:18 +0000)]
Removed useless call to wfLogProfilingData() since profiling is disabled in command-line mode
Alexandre Emsenhuber [Thu, 2 Jun 2011 08:17:12 +0000 (08:17 +0000)]
Removed obsolete comment that was mentioning $wgInputEncoding and $wgOutputEncoding
Tim Starling [Thu, 2 Jun 2011 02:44:33 +0000 (02:44 +0000)]
Explored some ideas for HipHop optimisation. Made a preprocessor implementation, based on a copy of Preprocessor_Hash, with a preprocessToObj() which is optimised. It takes 33% less time than Preprocessor_Hash for a certain realistic test case (the Barack Obama article). Some notes about what I did:
* Set EnableHipHopSyntax=true to enable string and integer type hints. I gave the file a .hphp extension to avoid false alarms in syntax checking scripts.
* Made sure almost all the local variables in preprocessToObj() have a specific type, instead of being variants. This is useful for integers, but has the largest impact for objects, since dynamic method calls can be avoided.
* Stopped using extract() since it forces all local variables to be variants, and adds some hashtable initialisation overhead.
* Found a way to cast a variant to a specific object class, by abusing argument type hinting. The method does not require special syntax; it is harmless in Zend PHP.
* Wrapped various internal function calls with type casts. strspn() and substr() need to be wrapped with intval() and strval() respectively, since they return a variant to support special error return values. HipHop isn't smart enough to know whether the error case will be triggered.
* Replaced most instances of double-equals with triple-equals. Profiling indicates that this makes a very large difference when comparing strings, much more so than in Zend.
Chad Horohoe [Thu, 2 Jun 2011 01:28:30 +0000 (01:28 +0000)]
Followup r89311: rv unrelated changes
Chad Horohoe [Thu, 2 Jun 2011 01:26:26 +0000 (01:26 +0000)]
Make user right selection in installer actually work, thanks Krinkle for spotting this
Brion Vibber [Thu, 2 Jun 2011 00:32:43 +0000 (00:32 +0000)]
Revert r88997: fix for bug 93 caused some additional problems.
Follow-up to r89191: disable test case for bug 93 as it currently fails (bug left open).
Chad Horohoe [Thu, 2 Jun 2011 00:11:38 +0000 (00:11 +0000)]
Self-revert r87545
Chad Horohoe [Wed, 1 Jun 2011 23:17:29 +0000 (23:17 +0000)]
Mostly revert r89302, was slower than the original
Chad Horohoe [Wed, 1 Jun 2011 22:54:33 +0000 (22:54 +0000)]
Exclude Block tests until somebody fixes them, also cache listTables() result so we can skip some queries
Chad Horohoe [Wed, 1 Jun 2011 22:43:19 +0000 (22:43 +0000)]
Test db cleanup
* Fix Oracle stuff per CR on r88755
* Don't expect tests to clean up after themselves, do it in MediaWikiTestCase::run() (skipping user and interwiki, also per CR)
** Also don't do it from the destructor, phpunit calls this more often than you'd think
* Need to find: way to detect "is this the last test?" so we can drop our tables on completion
Brion Vibber [Wed, 1 Jun 2011 22:35:03 +0000 (22:35 +0000)]
Add some doc comments on Cookie::validateCookieDomain() and Http::isValidUri(), which both have some failing test cases and are incomplete
Brion Vibber [Wed, 1 Jun 2011 22:27:24 +0000 (22:27 +0000)]
Add more super-cookie test cases to HttpTest; things like org & .org aren't being handled correctly either. Not super high prio but... should probably mark these tests broken if can't be fixed easily yet.
Brion Vibber [Wed, 1 Jun 2011 22:13:47 +0000 (22:13 +0000)]
Refactor validateCookieDomain test cases to use a data provider and report which bit's being tested so we can identify failures (there is still one failure in this set)
Platonides [Wed, 1 Jun 2011 22:04:44 +0000 (22:04 +0000)]
Not silly, but parser error (r89263)... fixing
PHP Parse error: syntax error, unexpected T_STRING, expecting T_VARIABLE in ExtensionUpdater.php on line 7
Sam Reed [Wed, 1 Jun 2011 21:44:16 +0000 (21:44 +0000)]
'unblockself' right was never added to User::$mCoreRights
Noticed while poking bug 27514
Brion Vibber [Wed, 1 Jun 2011 21:25:45 +0000 (21:25 +0000)]
Tweak HttpTest following r89278:
* remove FTP test case URL (shouldn't actually work, and as a directory listing, not super stable)
* remove old test case URLs that are now 30x redirects (example.com and a toolserver link), which broke the comparison tests
* added in http://en.wikipedia.org/robots.txt so we've got a nice basic fetch on one of our servers too
Now this test class is down to 3 failures, in URL & domain validation stuff
Platonides [Wed, 1 Jun 2011 21:22:53 +0000 (21:22 +0000)]
Document r89248,r89249 isQueryStringBad()
Brion Vibber [Wed, 1 Jun 2011 21:13:13 +0000 (21:13 +0000)]
HttpTest regression fix: test URL on example.com no longer returns a 404 (now a 302 redirect), so switching the 404 tests to use an URL on mediawiki.org in the /xml/ dir where we stash actual files.
Raimond Spekking [Wed, 1 Jun 2011 20:23:50 +0000 (20:23 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2011-06-01 20:12:00 UTC)
Mark A. Hershberger [Wed, 1 Jun 2011 18:57:33 +0000 (18:57 +0000)]
Fix Bug #29231: PhpHttpRequest doesn't support HTTPS
Tested fix with PHPUnit Tests that aren't currently executed by
CruiseControl b/c they're marked “broken” till someone comes up with
some reasonable unit tests that will work for everyone.
Sam Reed [Wed, 1 Jun 2011 16:40:59 +0000 (16:40 +0000)]
Add some documentation
Swap if ( $foo ) { $this->addFields( 'foo' ); } for $this->addFieldsIf( 'foo', $foo ); etc
Also swap $this->addFieldsIf( 'foo', $foo ); $this->addFieldsIf( 'foo2', $foo ); for $this->addFieldsIf( array( 'foo', 'foo2' ), $foo );
Micro-optimisation and readability!
Sam Reed [Wed, 1 Jun 2011 16:27:46 +0000 (16:27 +0000)]
Remove some unused variables, add/improve some documentation
Sam Reed [Wed, 1 Jun 2011 16:26:56 +0000 (16:26 +0000)]
* (bug 29221) Expose oldrevid in watchlist output
Jure Kajzer [Wed, 1 Jun 2011 15:15:24 +0000 (15:15 +0000)]
* suggestion for ExtensionUpdater that would handle DB install/update of extension from DatabaseUpdater
* could also generate default code for LocalSettingsGenerator
* revert if silly :D
Jure Kajzer [Wed, 1 Jun 2011 14:18:12 +0000 (14:18 +0000)]
* used Html static functions instead og Xml. (r89260#c17418)