Platonides [Thu, 6 Dec 2012 22:29:44 +0000 (23:29 +0100)]
Also pass $doxygenInputFilter as parameter instead of global.
Change-Id: I63fa0125576c4694f63d271f9824d783869f25d1
umherirrender [Thu, 6 Dec 2012 16:57:37 +0000 (17:57 +0100)]
Add parent::setUp() to DatabaseSQLTest
1) DatabaseSQLTest::testMediaWikiTestCaseParentSetupCalled
DatabaseSQLTest::setUp() must call parent::setUp()
Failed asserting that an array has the key 'setUp'.
Change-Id: I6aa5cb09999e0cee9b36fedd9193cb5aa08914ad
Translation updater bot [Thu, 6 Dec 2012 20:18:31 +0000 (20:18 +0000)]
Merge "Localisation updates from translatewiki.net."
Translation updater bot [Thu, 6 Dec 2012 20:04:03 +0000 (20:04 +0000)]
Localisation updates from translatewiki.net.
Change-Id: I857041254a52acb1ba791211048840168c120384
Aaron Schulz [Thu, 6 Dec 2012 20:03:40 +0000 (20:03 +0000)]
Merge "Purge videos from squid on action=purge"
Reedy [Thu, 6 Dec 2012 19:58:22 +0000 (19:58 +0000)]
Merge "(bug 42466) Allow djvutxt to use more memory"
Jan Gerber [Tue, 27 Nov 2012 05:41:56 +0000 (05:41 +0000)]
Purge videos from squid on action=purge
While we don't want to re-encode videos on purge, they should still
be removed from squid; compute the list of all urls before extensions
can filter it to remove files that should not be deleted from the
file backend.
Change-Id: Id837843b5a203e49a8594439ce3620da9b3c7b6a
Demon [Thu, 6 Dec 2012 18:50:41 +0000 (18:50 +0000)]
Merge "[Upload] Added async upload concatenation support."
Hashar [Thu, 6 Dec 2012 18:38:29 +0000 (18:38 +0000)]
Merge "LinkerTest needs to set the wiki language to en."
Platonides [Thu, 6 Dec 2012 17:53:43 +0000 (18:53 +0100)]
LinkerTest needs to set the wiki language to en.
The localisation of Special:Contributions break the
testUserLink otherwise.
Change-Id: I25a40356a96e03975d8ceca975449f7b064bca2b
Aaron Schulz [Thu, 6 Dec 2012 17:38:21 +0000 (17:38 +0000)]
Merge "While testing, turn off DataBase::ignoreErrors."
Catrope [Thu, 6 Dec 2012 06:25:35 +0000 (06:25 +0000)]
Merge "mediawiki.Uri: Don't raw encode the 'title' query parameter."
Anomie [Wed, 5 Dec 2012 22:42:03 +0000 (22:42 +0000)]
Merge "test: detects parent setUp not being called"
Translation updater bot [Wed, 5 Dec 2012 20:24:14 +0000 (20:24 +0000)]
Localisation updates from translatewiki.net.
Change-Id: Ib48025b8cdc6296b429f398e37f8bca54b8703ee
IAlex [Wed, 5 Dec 2012 19:58:04 +0000 (19:58 +0000)]
Merge "Update misleading variable names in docs"
IAlex [Wed, 5 Dec 2012 19:56:39 +0000 (19:56 +0000)]
Merge "Update docs for DifferenceEngine::getDiff()"
Antoine Musso [Wed, 5 Dec 2012 10:41:39 +0000 (11:41 +0100)]
Revert UIDGenerator commits.
Changes seemed to be merged without anyone really looking at it
and the authorship in git is wrong as well. All related changes
can later be batched as one commit.
Following commit / change are reverted:
-
7ac3edd https://gerrit.wikimedia.org/r/36803
-
036d03b https://gerrit.wikimedia.org/r/36813
-
2b168e3 https://gerrit.wikimedia.org/r/36812
-
6030d92 https://gerrit.wikimedia.org/r/36801
See wikitech-l thread
http://lists.wikimedia.org/pipermail/wikitech-l/2012-December/064801.html
Change-Id: Ie39fde2ee4121372b6d790943f306e56fbacc2b5
Aaron Schulz [Mon, 19 Nov 2012 08:07:50 +0000 (00:07 -0800)]
[Upload] Added async upload concatenation support.
* Clients can send the last chunk with 'async' to get an immediate
response and then check the status of the upload by polling the API
using the 'checkstatus' parameter.
* Pass the User object along to stash functions within UploadFromChunks.
Change-Id: Ie2ad4c7e94862a728e8a687c3195306e16a5059e
daniel [Wed, 5 Dec 2012 16:13:21 +0000 (17:13 +0100)]
While testing, turn off DataBase::ignoreErrors.
Database errors should cause an exception, not return false,
unless the test case, or the code under test, explicitely calls
ignoreErrors(true). The DB object should be reset to fail fast
and safe for every test.
Change-Id: Ifc2a720ec46a1843d9ffb1488c54743a0099ef9d
Antoine Musso [Mon, 22 Oct 2012 23:53:51 +0000 (01:53 +0200)]
test: detects parent setUp not being called
Our test classes often overload MediaWikiTestCase::setUp() but forget to
call their parent. This patch makes MediaWikiTestCase to flag whenever
its own setUp() is called and then simply assert it got called. Any
class failing the assertion is missing a call to its parent setup which
is easily fixed by adding: parent::setUp().
It would be nice to find a similar trick for tearDown().
Change-Id: Ia2afed6052eb3863d6c8e68c551cf03b33bb4be9
Siebrand Mazeland [Wed, 5 Dec 2012 14:21:58 +0000 (15:21 +0100)]
Update docs for DifferenceEngine::getDiff()
Previous docs were incorrect and misleading.
Change-Id: I6403c7c7c3b9803cc7e10cc45999244ff78dc14d
Siebrand Mazeland [Wed, 5 Dec 2012 13:41:41 +0000 (14:41 +0100)]
Update misleading variable names in docs
$article for a WikiPage object isn't a great choice. Let's use $wikiPage.
Change-Id: I98832355b14fc4a281d3f0e2dbee85e142d83418
Nikerabbit [Wed, 5 Dec 2012 13:37:45 +0000 (13:37 +0000)]
Merge "Add wfDeprecated to wfMsg* methods from 1.21 on"
Reedy [Wed, 5 Dec 2012 13:03:14 +0000 (13:03 +0000)]
Merge "Add 1.20 RELEASE-NOTES to HISTORY"
Reedy [Wed, 5 Dec 2012 12:59:44 +0000 (12:59 +0000)]
Merge "Add type hint"
Nikerabbit [Wed, 5 Dec 2012 10:09:31 +0000 (10:09 +0000)]
Merge "(bug 37263) better handling of minor/bot in enhanced changelist"
Nikerabbit [Wed, 5 Dec 2012 10:09:19 +0000 (10:09 +0000)]
Merge "(bug 36211) add cursor:pointer to .mw-enhancedchanges-arrow"
umherirrender [Sat, 1 Dec 2012 19:51:09 +0000 (20:51 +0100)]
(bug 37263) better handling of minor/bot in enhanced changelist
It makes more sense, to have the whole group as minor/bot, when all of
the group are minor or bot edits, not when only one of the group is
minor/bot.
Change-Id: I62bf1099f2e3fb73e9b50374cbb7ba8bfd8a009e
umherirrender [Sat, 1 Dec 2012 20:05:53 +0000 (21:05 +0100)]
(bug 36211) add cursor:pointer to .mw-enhancedchanges-arrow
With this, the arrow is shown with a pointer and looks like clicking on
a link. Without this, the user has no feedback, that he can click the
arrow.
Change-Id: I8bee6e51b1786785128d56931dc1ff9a09ba1d78
Alexandre Emsenhuber [Sun, 2 Dec 2012 13:26:28 +0000 (14:26 +0100)]
(bug 42619) Adjust comment for log_params database field
Change-Id: Ib78fd5ad7bef78b07460200d5d8b143e5a9a8802
Nikerabbit [Wed, 5 Dec 2012 09:56:56 +0000 (09:56 +0000)]
Merge "Improve documentation for "pipe trick""
Aaron Schulz [Wed, 5 Dec 2012 01:44:48 +0000 (17:44 -0800)]
[JobQueue] Removed redundant DBO_TRX handling in JobQueueDB.
* The onTransactionIdle() function already handles this.
Change-Id: I4851e75a63a270984399cef288f370dcc3138e30
Siebrand Mazeland [Tue, 4 Dec 2012 23:38:59 +0000 (00:38 +0100)]
Add type hint
Change-Id: If529cfbf568a10e8cea184fa229959701268ebcb
Translation updater bot [Tue, 4 Dec 2012 21:11:10 +0000 (21:11 +0000)]
Merge "Localisation updates from translatewiki.net."
Translation updater bot [Tue, 4 Dec 2012 20:49:40 +0000 (20:49 +0000)]
Localisation updates from translatewiki.net.
Change-Id: I41401477973247555f5be35d76620d7b9dc71510
Aaron Schulz [Tue, 4 Dec 2012 20:44:19 +0000 (20:44 +0000)]
Merge "Treat message cache loading as fatal"
Aaron Schulz [Tue, 4 Dec 2012 19:15:25 +0000 (11:15 -0800)]
Cleaned up UIDGenerator docs a bit.
Change-Id: I32ca575ca4d7b446b4a27b91d1e8aaa7173c575b
Patrick Reilly [Tue, 4 Dec 2012 20:19:45 +0000 (12:19 -0800)]
fix sort order
Change-Id: I07e29fbdae88ce5164ba4fb60dbb597dbc2c4dcf
Patrick Reilly [Tue, 4 Dec 2012 20:13:48 +0000 (12:13 -0800)]
Add UIDGenerator to AutoLoader
Change-Id: I288eef52590033002d7e36f0ca2f667f46dd6aec
Patrick Reilly [Tue, 4 Dec 2012 18:58:29 +0000 (10:58 -0800)]
Class for getting statistically unique IDs NOT a RFC4122 standard string representation
Change-Id: Ia4133b65afb63931b5f887feb247dac1b1e42360
Aaron Schulz [Tue, 4 Dec 2012 18:44:48 +0000 (18:44 +0000)]
Merge "add method to check if ORMTable exists"
Subramanya Sastry [Tue, 4 Dec 2012 18:15:15 +0000 (12:15 -0600)]
New parser tests to spec wikitext behavior found on en:WP
* Added tests for:
- table-list nesting interactions
- templated-table tags
- templated-list tags
- stray *include* tags
- autoclosed *include* tags
* These tests should help catch regressions from recent
Parsoid fixes.
Change-Id: I54f0c13a16f4330fa258ff3718921b71bdafa6f0
GWicke [Tue, 4 Dec 2012 17:38:50 +0000 (17:38 +0000)]
Merge "Added a few tests to spec HTML-pre behavior and test Parsoid."
Aaron Schulz [Tue, 4 Dec 2012 17:34:09 +0000 (17:34 +0000)]
Merge "(bug 42483) Avoid serializing database object in update.php"
Subramanya Sastry [Tue, 4 Dec 2012 16:57:15 +0000 (10:57 -0600)]
Added a few tests to spec HTML-pre behavior and test Parsoid.
* Renamed existing pre tests to use Indent-Pre to distinguish
them from the HTML-pre tests.
Change-Id: I3500c3ba7db19b19baa1d9ab4e3bfb5ccbc491d2
aude [Tue, 4 Dec 2012 13:09:00 +0000 (13:09 +0000)]
add method to check if ORMTable exists
Change-Id: I7ef34545a9b4cfa6ed8bcdd302ad49faa7747974
Niklas Laxström [Tue, 4 Dec 2012 12:35:01 +0000 (12:35 +0000)]
Treat message cache loading as fatal
I suspect this is the primary cause we occasionally have
* Sidebar stuck in default values
* No gadgets at all
* Main page full of <int:custom-message> occurances
Change-Id: I811755d4c250800177c4ea9e509bf6e1d13443a0
Siebrand Mazeland [Tue, 4 Dec 2012 11:19:09 +0000 (12:19 +0100)]
Add wfDeprecated to wfMsg* methods from 1.21 on
These were marked soft deprecated in 1.18.
Change-Id: Ifa82da981c69b2ea9d5b298e9dfb04fc29483206
Siebrand Mazeland [Tue, 4 Dec 2012 11:05:40 +0000 (12:05 +0100)]
Add 1.20 RELEASE-NOTES to HISTORY
Change-Id: I2f5062c518017bdb26688df3278132befeb80826
Krinkle [Tue, 4 Dec 2012 00:22:21 +0000 (00:22 +0000)]
Merge "(bug 42638) Fix API action=options&reset=1 & unit tests"
Tim Starling [Mon, 3 Dec 2012 23:08:51 +0000 (10:08 +1100)]
Make Language::isValidBuiltInCode() return bool
Make Language::isValidBuiltInCode() return true or false, as
documented. Previously returned 0 or 1. Hacked around in I81ba3228.
Change-Id: Iaa7515095d687d745d878faaa957aae51737abf7
Krinkle [Mon, 3 Dec 2012 21:19:31 +0000 (21:19 +0000)]
Merge "(bug 42601) Make deleteOldRevisions.php no longer throw database errors on empty sets."
Tpt [Mon, 3 Dec 2012 21:03:53 +0000 (22:03 +0100)]
(bug 42466) Allow djvutxt to use more memory
The djvutxt utility of DjVuLibre 3.5.24 packed with Ubuntu 12.04 use a lot
of memory more that the old version packed with Ubuntu 10.04. S, to work,
the memory limit must be increased.
User:Phe suggest that this increase of memory consumption is maybe caused
by the loading of localisations file at the start of the tool.
Change-Id: Ia735e1b7d71f5aa512fb14e444989854c440074e
Translation updater bot [Mon, 3 Dec 2012 20:44:30 +0000 (20:44 +0000)]
Localisation updates from translatewiki.net.
Change-Id: Ied9bc631fb1feac6b31ce015f9507537f4f16b7b
Brad Jorsch [Mon, 3 Dec 2012 20:24:37 +0000 (15:24 -0500)]
(bug 42483) Avoid serializing database object in update.php
Change I96b4cfd4 changed the data being stored in updatelog, trying to
store the mangled parameters (which may included an added copy of the
DatabaseUpdater object itself) instead of the input parameters. This
causes warnings because database objects cannot be effectively
serialized.
Go back to storing the original input parameters instead.
Change-Id: I96e6dffed98772ebb9b812773ff2f608e7e40cb1
Aaron Schulz [Mon, 3 Dec 2012 18:32:10 +0000 (18:32 +0000)]
Merge "(no bug) Fix per-connection db name in ORMTable."
Aaron Schulz [Wed, 21 Nov 2012 21:58:50 +0000 (13:58 -0800)]
[Upload] [Schema] Added us_props column to avoid expensive GETs.
* We already compute the props when stashing, so including that in a column
lets us reuse it later when the stashed file is to be published.
Change-Id: I3d6adb6528f1e992d8986058806e745c4e1c0300
Aaron Schulz [Thu, 29 Nov 2012 00:09:46 +0000 (16:09 -0800)]
[JobQueue] Use SELECT for deduplication rather than more expensive DELETEs.
Change-Id: Iff5dbc0ca6dc7032596d1b4ffddb3cc1848b9e10
daniel [Mon, 3 Dec 2012 17:20:29 +0000 (18:20 +0100)]
(no bug) Fix per-connection db name in ORMTable.
ORMTable was bypassing the mechanism used by DBAccessBase to
ensure that the correct database name is selected when getting
a database connection.
Change-Id: Ic82ce46f1852dcaa5f52b40660ba4a9f52df22f6
Alexandre Emsenhuber [Sun, 2 Dec 2012 14:05:37 +0000 (15:05 +0100)]
(bug 42601) Make deleteOldRevisions.php no longer throw database errors on empty sets.
Also changes DatabaseBase::query() calls to more specific ones.
Change-Id: I7b1eef9ac7cfc89c535a932477fcf1598d3bc0b2
martineznovo [Sun, 16 Sep 2012 20:00:37 +0000 (22:00 +0200)]
(bug 27202) Add timestamp sort to list=allimages
New parameter 'sort' that defaults to 'name' so if not specified it will
act exactly as before.
Changes in the access to $params['dir'] to a boolean variable
$ascendingOrder in a try to be more meaningful.
Some existing filtering parameters are mutually exclusive with new ones.
The reason is because the table is sorted by name, as primary key, while
sorting by timestamp use the timestamp or usertext_timestamp index which
is not the primary key, thus filtering and ordering by different indices
doesn't make an efficient index usage.
Exceptions are:
* mime: disabled in Miser Mode
* size: although there's apparently no use for this when sorting by
timestamp, there's an index on that and the EXPLAIN doesn't use filesort
algorythm (unlike other combinations):
EXPLAIN
select img_name, img_user_text, img_timestamp
from image
where img_size>=1000 and img_size<=20000
and img_timestamp > '
20120916153705'
ORDER BY img_timestamp\G
* Same for sha1 (see comment on Patchset 1)
In function run:
* Added USE INDEX query options when sort=timestamp to ensure the proper
index is being used.
* Table selection and result fields moved at top, then filter parameters,
and finally order by and options.
Parameter description and definition sorted by purpose: sort and dir
first, then pagination, result fields, filters and limit.
Change-Id: Ide2ff3dbc3e617e749685d558444854617535bab
Antoine Musso [Mon, 3 Dec 2012 08:17:24 +0000 (09:17 +0100)]
test: raise timeout for DatabaseSqlite
DatabaseSqliteTest does file access and hence needs a slightly higher
timeout in PHPUnit.
Change-Id: I4b5eb7d7c5a3b9d4790f11cdb4efa9f578763183
Antoine Musso [Mon, 3 Dec 2012 08:14:32 +0000 (09:14 +0100)]
test: raise timeout for ExifRotation
ExifRotationTest does file access and hence needs a slightly higher
timeout in PHPUnit.
Change-Id: I871c4a4fde5e71708e55b3f28e7267e1023c2df5
Brad Jorsch [Mon, 3 Dec 2012 03:40:55 +0000 (22:40 -0500)]
(bug 42638) Fix API action=options&reset=1 & unit tests
Change I98df55f2 broke action=options&reset=1, causing it to return an
error "No changes were requested" rather than resetting the options as
it should. Unfortunately, that change also broke the unit test that
would have caught this regression.
This changeset fixes the bug and the unit tests.
Change-Id: I7fe63640d54efab4572538e9d08f5b75c61243a4
Translation updater bot [Sun, 2 Dec 2012 20:21:23 +0000 (20:21 +0000)]
Localisation updates from translatewiki.net.
Change-Id: Ib22bb939459977f160056d83697434b5a456474b
Hashar [Sun, 2 Dec 2012 19:51:27 +0000 (19:51 +0000)]
Merge "Fixed documentation"
Nikerabbit [Sun, 2 Dec 2012 16:53:24 +0000 (16:53 +0000)]
Merge "(Bug 40367) MediaWiki:Contributions should support gender"
IAlex [Sun, 2 Dec 2012 09:08:33 +0000 (09:08 +0000)]
Merge "Show comment not as block in tables"
IAlex [Sun, 2 Dec 2012 09:02:12 +0000 (09:02 +0000)]
Merge "(bug 37755) Set robot meta tags for 'view source' pages"
Nikerabbit [Sun, 2 Dec 2012 08:45:00 +0000 (08:45 +0000)]
Merge "(bug 42598) Database: fname was not logged for BEGIN/COMMIT."
Oren Held [Sat, 13 Oct 2012 10:40:55 +0000 (12:40 +0200)]
(bug 37755) Set robot meta tags for 'view source' pages
Apply the same robot behavior of the edit & history pages (noindex,nofollow), on view source pages
(case of ?action=edit when having no edit permissios).
Change-Id: Ifc162332798a3dea93db4096d26e928545fbf4b6
Timo Tijhof [Sun, 2 Dec 2012 04:11:06 +0000 (05:11 +0100)]
mediawiki.Uri: Don't raw encode the 'title' query parameter.
Previously:
Input:
http://alpha.wiki.krinkle.dev/w/index.php?title=Sandbox/2&oldid=611&veaction=edit
Action:
remove query.veaction
Output:
http://alpha.wiki.krinkle.dev/w/index.php?title=Sandbox%2F2&oldid=611
Now the title parameter stays the same.
Change-Id: Ieb9eee450ea8ae3cc97bab12de935c6e7b103842
Krinkle [Sun, 2 Dec 2012 02:02:01 +0000 (02:02 +0000)]
Merge "Add some __METHOD__ to begin/commit/rollback calls"
Timo Tijhof [Sat, 1 Dec 2012 10:52:23 +0000 (11:52 +0100)]
(bug 42598) Database: fname was not logged for BEGIN/COMMIT.
Relied on presence of whitespace. From git-blame looks like $commentedSql has been this way for a long time. Which is odd
since I've seen many commits since then specifically improving
callers of commit() and begin() to pass the __METHOD__, which
doesn't appear to have been logged anywhere up until now.
Change-Id: I48dc8b3f68a6764327b4b1a8f7c06c59a25a31bb
umherirrender [Sat, 1 Dec 2012 21:38:04 +0000 (22:38 +0100)]
Show comment not as block in tables
Special:BlockList and Special:ListFiles showing comments inside a table
cell. In that case the parentheses not needed, because the table cell
splits it from the rest. Using the Linker method, which does not produce
the parentheses.
The file history of an file pages does this the same way.
Change-Id: I7fbb068bd2acd90f8117719706c32ca05b27b09f
Nikerabbit [Sat, 1 Dec 2012 16:43:06 +0000 (16:43 +0000)]
Merge "mediawiki.Uri: Update doc comments."
Siebrand [Sat, 1 Dec 2012 16:42:19 +0000 (16:42 +0000)]
Merge "Fixing typo"
Niklas Laxström [Sat, 1 Dec 2012 16:02:15 +0000 (16:02 +0000)]
Fixing typo
Change-Id: I930c37ad7550c7dd0c4856c22921155dec6ccb3b
umherirrender [Sat, 1 Dec 2012 14:04:10 +0000 (15:04 +0100)]
Add some __METHOD__ to begin/commit/rollback calls
Change-Id: I20dad8d6bb7a523e8a6f50bc0af5cdba57d7160f
Timo Tijhof [Wed, 28 Nov 2012 18:35:21 +0000 (19:35 +0100)]
mediawiki.Uri: Update doc comments.
Change-Id: I2c49ae07587b23fc522f8c2dda9be955fa4602be
Translation updater bot [Fri, 30 Nov 2012 21:20:15 +0000 (21:20 +0000)]
Merge "Localisation updates from translatewiki.net."
Translation updater bot [Fri, 30 Nov 2012 21:04:17 +0000 (21:04 +0000)]
Localisation updates from translatewiki.net.
Change-Id: Iad76ee37cb4dfd50f8bc9e7b61b5a7cf31238d4c
Siebrand [Fri, 30 Nov 2012 20:58:12 +0000 (20:58 +0000)]
Merge "(Bug 40145) Changed the wording of the protectedpagetext message to include moving and other actions."
Nikerabbit [Fri, 30 Nov 2012 20:29:54 +0000 (20:29 +0000)]
Merge "Implement static public Parser::getExternalLinkRel"
Matthew Bowker [Fri, 30 Nov 2012 20:00:31 +0000 (13:00 -0700)]
(Bug 40145) Changed the wording of the protectedpagetext message to include moving and other actions.
Change-Id: Ia8a478586128c647a6957a125fdf5e6ae85ab150
Marius Hoch [Mon, 12 Nov 2012 22:52:43 +0000 (23:52 +0100)]
Implement static public Parser::getExternalLinkRel
I've implemented the function Parser::getExternalLinkRel which
gives the 'rel' attribute for a given link in a given NS. Per Tim's
suggestion, as it's currently impossible to invoke the logic in
Parser::getExternalLinkAttribs externally.
Change-Id: Id0bfed81e2afd6730d820b6c9a4a09155a557f37
Trevor Parscal [Fri, 30 Nov 2012 20:18:43 +0000 (12:18 -0800)]
Refactor edit notice rendering so that it's not baked into EditPage
* Move edit notice rendering to Title class
* Use new getEditNotices method in EditPage
This opens the door for alternative editors (such as the VisualEditor) to use the same notice systems already in use.
Change-Id: Ib0e40714f5433f4d75c54a3c3d60b1590fded7f1
Gabriel Wicke [Fri, 30 Nov 2012 17:51:27 +0000 (09:51 -0800)]
Test / spec handling of HTML entities in link tails
Change-Id: I97ed5e17efb1d783797c46161be56e83b94307a7
Nikerabbit [Fri, 30 Nov 2012 16:25:01 +0000 (16:25 +0000)]
Merge "Added assertException method to MediaWikiTestCase"
jeroendedauw [Fri, 30 Nov 2012 11:41:11 +0000 (12:41 +0100)]
Fixed documentation
Change-Id: I799304e44af405b58207b0f4f1ec4996f17a9c71
jeroendedauw [Thu, 29 Nov 2012 17:03:03 +0000 (18:03 +0100)]
Added assertException method to MediaWikiTestCase
Change-Id: I3ce667b4405241c66c5a979863d1cea2cf39956b
Catrope [Fri, 16 Nov 2012 18:19:15 +0000 (10:19 -0800)]
(bug 42202) Validate preference values in action=options
Previously, there was no validation whatsoever and the module would
happily write any preference you asked it to. This, combined with the
fact that the code using the 'editfont' preference didn't perform any
validation or escaping, led to a CSS injection vulnerability.
Using Preferences::getPreferences breaks some existing test cases
because a MockUser doesn't have groups for preferences.
Change-Id: I98df55f2b16ac1b6fce578798b6f58b5dad96775
Pavel Selitskas [Fri, 30 Nov 2012 00:23:26 +0000 (03:23 +0300)]
(Bug 40367) MediaWiki:Contributions should support gender
Change-Id: I80fea312e6f84b2aefaca23c751e6d44dd2ee787
Catrope [Fri, 16 Nov 2012 18:12:58 +0000 (10:12 -0800)]
(bug 42202) Validate editfont before embedding it in CSS
If the editfont preference somehow had a value like "foo; color: blue",
we have a CSS injection problem. Normally preference validation should
protect against that, but the API module for setting preferences doesn't
perform any validation.
Change-Id: I5c12aa9a48bf4f6ea4a8fb44554d13189e7757fb
Kevin Israel [Wed, 31 Oct 2012 20:59:50 +0000 (16:59 -0400)]
Remove the throw from Message::extractParam()
Per Tim Starling's comment on bug 41400, I replaced the throw (when a
message parameter is invalid) with a call to trigger_error().
The string [INVALID] is used as a placeholder to make it clear from
the output that an error has occurred.
Change-Id: I974d55d44d392c956e7de6d243da9d8dc07d8833
Kevin Israel [Tue, 30 Oct 2012 01:49:15 +0000 (21:49 -0400)]
Add comments to Linker::formatLinksInComment()
Per Tim Starling's suggestion, added comments to the regex in
Linker::formatLinksInComment().
Change-Id: If85567e5a2e57dd56f5f263f3512e9ed2f9c940c
Kevin Israel [Thu, 25 Oct 2012 13:54:52 +0000 (09:54 -0400)]
Optimized regex in Linker.php
Optimized the regex in Linker::formatLinksInComment().
Change-Id: Idea5554bcb8d7e78ddf972ce4c9827fa738ff837
csteipp [Thu, 29 Nov 2012 22:02:18 +0000 (14:02 -0800)]
(bug 40995) Refresh SessionId on login
SpecialUserlogin updated to refresh the user's session_id on each
successful login.
Change-Id: I1bd76f2c199b515f570e18669ca2138668bf847e
Aaron Schulz [Thu, 29 Nov 2012 21:56:23 +0000 (21:56 +0000)]
Merge "Change msg check sp-contributions-explain from exists to isBlank"
Translation updater bot [Thu, 29 Nov 2012 20:38:34 +0000 (20:38 +0000)]
Localisation updates from translatewiki.net.
Change-Id: I554504cd3d622f5eccc27feaf55057c1af443212