Aaron Schulz [Tue, 3 Nov 2015 13:09:57 +0000 (05:09 -0800)]
Convert JobQueueGroup::getCachedConfigVar to using WAN cache
Change-Id: I793ab8c11698a1c6f6c3bdd20c61b3645ca5d544
jenkins-bot [Tue, 3 Nov 2015 11:24:03 +0000 (11:24 +0000)]
Merge "Move brace matching rules to Preprocessor class"
jenkins-bot [Tue, 3 Nov 2015 11:10:45 +0000 (11:10 +0000)]
Merge "Improve BacklinkCache field docs"
jenkins-bot [Tue, 3 Nov 2015 11:10:41 +0000 (11:10 +0000)]
Merge "Improve MIME detection in FileBackend"
jenkins-bot [Tue, 3 Nov 2015 10:58:07 +0000 (10:58 +0000)]
Merge "Avoid "headers already sent" error in jobs for UseDC cookie"
Aaron Schulz [Tue, 3 Nov 2015 10:56:30 +0000 (02:56 -0800)]
Improve BacklinkCache field docs
Change-Id: I8303d5577ac84b8882e5ad79ac3058d6bf49356f
jenkins-bot [Tue, 3 Nov 2015 10:48:31 +0000 (10:48 +0000)]
Merge "Add script to find orphaned LocalRepo files"
jenkins-bot [Tue, 3 Nov 2015 10:42:16 +0000 (10:42 +0000)]
Merge "resourceloader: Sanitize lang with isValidBuiltInCode(), not isValidCode()"
Aaron Schulz [Tue, 3 Nov 2015 10:16:19 +0000 (10:16 +0000)]
Merge "objectcache: Add a clear() method to HashBagOStuff"
jenkins-bot [Tue, 3 Nov 2015 10:13:08 +0000 (10:13 +0000)]
Merge "objectcache: Refresh key in HashBagOStuff::set() for maxKeys eviction"
Timo Tijhof [Tue, 3 Nov 2015 06:49:13 +0000 (06:49 +0000)]
objectcache: Add a clear() method to HashBagOStuff
Including tests for delete() and clear().
Change-Id: If39d729838e312523f0df3ae8b235ebe939a17fd
Timo Tijhof [Tue, 3 Nov 2015 05:59:07 +0000 (05:59 +0000)]
objectcache: Refresh key in HashBagOStuff::set() for maxKeys eviction
* Match behaviour of MapCacheLRU and ProcessCacheLRU.
* Add missing unit tests for TTL and maxCacheKeys eviction behaviour.
Change-Id: I559eae1cd336274b21728e86775cfbad7e2f2c6d
jenkins-bot [Tue, 3 Nov 2015 09:22:27 +0000 (09:22 +0000)]
Merge "objectcache: Move unit tests for HashBagOStuff to its own suite"
jenkins-bot [Tue, 3 Nov 2015 09:22:23 +0000 (09:22 +0000)]
Merge "objectcache: Add TTL_INDEFINITE to IExpiringStore"
jenkins-bot [Tue, 3 Nov 2015 09:12:00 +0000 (09:12 +0000)]
Merge "LinkCache: Remove deprecated getBadLinks and getGoodLinks methods"
jenkins-bot [Tue, 3 Nov 2015 07:04:14 +0000 (07:04 +0000)]
Merge "OutputPage: documentation for (semi-)deprecated methods"
Timo Tijhof [Tue, 3 Nov 2015 06:36:06 +0000 (06:36 +0000)]
objectcache: Add TTL_INDEFINITE to IExpiringStore
Especially useful when interacting with getWithSetCallback of
HashBagOStuff where a $exptime is required before the callback.
In set() it is typically left out and thus not as counter-intuitive.
Change-Id: Ic2f7adda3c00cefe701d77bea91a7e8e77ef1439
Timo Tijhof [Tue, 3 Nov 2015 06:05:22 +0000 (06:05 +0000)]
LinkCache: Remove deprecated getBadLinks and getGoodLinks methods
Deprecated since MediaWiki 1.26 (
32d1017e7d). These methods contain the
only remaining callers of MapCacheLRU::getAllKeys() which is the only odd
method of MapCacheLRU not supported by BagOStuff.
Change-Id: I64e054803595d49a5bd779accc94353924f7d87d
Timo Tijhof [Tue, 3 Nov 2015 05:28:18 +0000 (05:28 +0000)]
objectcache: Move unit tests for HashBagOStuff to its own suite
Follows-up
7cddc22.
Also use PHPUnit_Framework_TestCase as parent instead of MediaWikiTestCase
in preparation for library extraction.
Change-Id: I0e68e56ecf8376b52a59c33ba6dd18b671bdcfc9
jenkins-bot [Tue, 3 Nov 2015 05:27:38 +0000 (05:27 +0000)]
Merge "Make SqlBagOStuff respect WRITE_SYNC flag"
Aaron Schulz [Mon, 2 Nov 2015 23:52:37 +0000 (15:52 -0800)]
Avoid "headers already sent" error in jobs for UseDC cookie
Bug: T115413
Change-Id: Ic6050bef04adbda2557422bf60b2ebe300c89629
Aaron Schulz [Sat, 31 Oct 2015 10:35:44 +0000 (03:35 -0700)]
Make SqlBagOStuff respect WRITE_SYNC flag
Also remove some pointless newlines in class.
Change-Id: I75880c56b1eac63c9a0616ca10890904ce823a99
Ori Livneh [Sat, 31 Oct 2015 23:10:54 +0000 (16:10 -0700)]
Move brace matching rules to Preprocessor class
Instead of declaring the array of rules within both Preprocessor_DOM:: and
Preprocessor_Hash::preprocessToXml(), declare it as a protected property of the
parent Preprocessor class.
Change-Id: I6193de66566c164fe85cdd6a88c04fa9c565f1a9
jenkins-bot [Tue, 3 Nov 2015 01:40:43 +0000 (01:40 +0000)]
Merge "TOC: Separate columns for tocnumber and toctext"
Fomafix [Fri, 13 Mar 2015 07:49:24 +0000 (07:49 +0000)]
TOC: Separate columns for tocnumber and toctext
IE 7 and lower ignores these definitions and shows the TOC as before.
Bug: T92481
Change-Id: Ibed5f02f04e63a4152109ddf9c2a23f4e45880ca
Fomafix [Mon, 2 Nov 2015 05:50:57 +0000 (05:50 +0000)]
gallery.js: Do not resize gallery caption
Resize only gallerybox which contains resized images.
Bug: T91075
Change-Id: Idcaf22fbaabaa26c8d06f5dd0194d4ed7c7b1a60
Matthias Mullie [Wed, 14 Oct 2015 09:14:51 +0000 (11:14 +0200)]
Let Import also read CDATA as content
Change-Id: I55275e20bb2fd589247fca5c44fd54d1ae9ff686
jenkins-bot [Tue, 3 Nov 2015 00:29:35 +0000 (00:29 +0000)]
Merge "Convert JobQueueDB to using the WAN cache"
jenkins-bot [Tue, 3 Nov 2015 00:12:48 +0000 (00:12 +0000)]
Merge "mw.widgets.TitleWidget: Correct documentation"
jenkins-bot [Mon, 2 Nov 2015 23:51:52 +0000 (23:51 +0000)]
Merge "User: Migrate from foreign cache to global cache for UserRightsProxy"
jenkins-bot [Mon, 2 Nov 2015 22:47:10 +0000 (22:47 +0000)]
Merge "Convert SiteStatsUpdate to using getMainStashInstance()"
Bartosz Dziewoński [Mon, 2 Nov 2015 22:35:44 +0000 (23:35 +0100)]
mw.widgets.TitleWidget: Correct documentation
Change-Id: If1ea6d411b57b4cb6e60f400a86351dc3dc7acbc
Timo Tijhof [Mon, 2 Nov 2015 21:45:43 +0000 (21:45 +0000)]
Remove getLocalServerInstance try/catch in UIDGenerator and DBLockManager
Follows-up
17c91ad610 in which the exception was removed.
Change-Id: If0c8465d0e04f69f29f3f2602dac7ae4538f7542
jenkins-bot [Mon, 2 Nov 2015 22:04:21 +0000 (22:04 +0000)]
Merge "Replace newAccelerator() with getLocalServerInstance()"
Timo Tijhof [Tue, 27 Oct 2015 23:43:40 +0000 (23:43 +0000)]
User: Migrate from foreign cache to global cache for UserRightsProxy
Avoid having one wiki access another wiki's local keyspace.
Instead, use the global keyspace to share values across wikis.
Also, imitating wfMemcKey from wfForeignMemcKey was semantically
incorrect due to $wgCachePrefix having precedence. Most interfaces
(e.g. UserRightsProxy, FileRepo, JobQueue etc.) only have access
to the wiki id (dbname + prefix). The local cache configuration
for wgCachePrefix is not and shouldn't have to be exposed.
Start enforcing that local cache keys are left private and
to share keys, one must use global keys.
Global keys (prefixed with "global:") have their own space and we
can use the wiki-id as regular key segment for keys about users.
Also:
* Expose a method to keep formatting of this key in one place.
As it used used in many different places in core, as well
as in CentralAuth.
* Make use of wfWikiId() in getDefaultKeyspace() to avoid
duplicating this logic.
Change-Id: I58836a24b9e239f460ab489bd2fe8ced8259833c
Aaron Schulz [Sat, 31 Oct 2015 18:42:48 +0000 (11:42 -0700)]
Replace newAccelerator() with getLocalServerInstance()
The name is clearer and more consistent, with simpler arguments.
Change-Id: I7205a99ce033e8b086a52cd02c8a721e99c84b1e
Ori Livneh [Mon, 2 Nov 2015 21:36:07 +0000 (13:36 -0800)]
Revert "Add MediaWiki-Timestamp header to ResourceLoader requests"
I have not had the time and wherewithal to write the follow-up code that
actually uses this value. So just remove it for now.
This reverts commit
3d5aca4a406424bf69016f9c7c4a94b317b62d25.
Change-Id: Ice9b65f39802b55b3d4ddf801c06d1be3227fd5b
Translation updater bot [Mon, 2 Nov 2015 21:19:27 +0000 (22:19 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: I57ee8f81dffb1b08e3dd37ada05711548fbeeb71
jenkins-bot [Mon, 2 Nov 2015 19:35:52 +0000 (19:35 +0000)]
Merge "Installer: Validate password against sysop/bureaucrat policies"
Aaron Schulz [Mon, 2 Nov 2015 03:19:38 +0000 (19:19 -0800)]
Make makeKeyInternal() limit more conservative
This should avoid error log entries for long WAN cache keys
Change-Id: I401482d25dd5bf47052a3c6729c5f8bc9fd68770
Aaron Schulz [Fri, 14 Nov 2014 06:47:06 +0000 (22:47 -0800)]
Improve MIME detection in FileBackend
The content type detector will now inspect the file contents
to better handle extensionless files.
Also dependency inject the callback and make the default one
use FileInfo.
Change-Id: Iad59bf6c6a416b706f976a4c425763fd30e2debb
jenkins-bot [Sun, 1 Nov 2015 23:28:22 +0000 (23:28 +0000)]
Merge "Normalize header case for FileBackend operations"
jenkins-bot [Sun, 1 Nov 2015 22:42:19 +0000 (22:42 +0000)]
Merge "phpcs: Fix some "Assignment expression not allowed""
jenkins-bot [Sun, 1 Nov 2015 22:38:47 +0000 (22:38 +0000)]
Merge "mw.html: Document mw.html.elements optional parameters"
jenkins-bot [Sun, 1 Nov 2015 20:42:22 +0000 (20:42 +0000)]
Merge "Fixed arguments syntax in hooks.txt"
Translation updater bot [Sun, 1 Nov 2015 20:27:14 +0000 (21:27 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: If418ae5921eefe082e19851a35f6745b25aeda92
umherirrender [Sun, 1 Nov 2015 19:56:20 +0000 (20:56 +0100)]
phpcs: Fix some "Assignment expression not allowed"
Found by new version of mediawiki/codesniffer
https://integration.wikimedia.org/ci/job/mediawiki-core-phpcs/1939/consoleFull
Change-Id: I673f71fd0dfc8d6ba1ce6c3d5da21787ff95cb32
Aaron Schulz [Sun, 1 Nov 2015 09:05:34 +0000 (01:05 -0800)]
Convert JobQueueDB to using the WAN cache
Change-Id: Ie5820d1439014572ca171c9303d51a8d3938ad00
Derk-Jan Hartman [Sat, 31 Oct 2015 15:16:58 +0000 (16:16 +0100)]
OutputPage: documentation for (semi-)deprecated methods
Deprecated: addExtensionStyle, getExtStyle
These had been deprecated unofficially for a while now. ResourceLoader
is preferred.
Internal/Unpreferred: addHeadItem, addScript, addScriptFile,
addInlineScript, addStyle, addInlineStyle.
All should be used as littel as possible, in favor of ResourceLoader
and a few other higher level accessors. They are not truly deprecated,
but should not really be used unless you have a really good reason.
Also added a few missing wfDeprecated calls to methods marked as
deprecated in the phpdoc.
Bug: T89955
Change-Id: I472d906b6de16257fa34a2f9bfe9e4eb284d02b4
Derk-Jan Hartman [Sat, 31 Oct 2015 15:47:00 +0000 (15:47 +0000)]
mw.html: Document mw.html.elements optional parameters
* Move tests to a separate test suite.
* Unit tests already covered these cases without second and third
parameter so no extra tests.
* Update code to clearly make attribs optional.
Bug: T88962
Change-Id: I26bb4b0a907f48064f41236972e115ec1f7edf0c
jenkins-bot [Sat, 31 Oct 2015 23:09:35 +0000 (23:09 +0000)]
Merge "Improve error message from when vendor files don't exist"
Reedy [Sat, 31 Oct 2015 22:57:07 +0000 (22:57 +0000)]
Improve error message from when vendor files don't exist
Change-Id: Id1caeb487a4e801bd7f0f5377b6c06c6fc7eebe4
jenkins-bot [Sat, 31 Oct 2015 22:49:15 +0000 (22:49 +0000)]
Merge "Remove search preferences from Special:Preferences JavaScript"
Derk-Jan Hartman [Mon, 29 Jun 2015 19:27:40 +0000 (21:27 +0200)]
Enable WebP uploads by default
Initially disabled for WMF I33b7de30c746e36539e9af29e9598e6723d030dd
Bug: T27397
Change-Id: I9604668b0f7108fe52222d7f76854f9d30e637b0
saper [Sat, 31 Oct 2015 20:15:05 +0000 (21:15 +0100)]
Remove search preferences from Special:Preferences JavaScript
Search preferences are now handled by Special:Search, not
by Special:Preferences
Bug: T54817
Change-Id: I8faabbed190a46397b35f630c031fc1b4bb6e3e1
Aaron Schulz [Sat, 31 Oct 2015 20:05:03 +0000 (13:05 -0700)]
Convert SiteStatsUpdate to using getMainStashInstance()
Also fixed various $wgMemc related comments
Change-Id: I20602b672f724c8df1e82bbe3c586cb899a54640
Translation updater bot [Sat, 31 Oct 2015 19:44:53 +0000 (20:44 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: I5f61d69577610c47d7054205d6c5e41a1611b315
umherirrender [Sat, 31 Oct 2015 18:14:29 +0000 (19:14 +0100)]
Fixed arguments syntax in hooks.txt
BaseTemplateAfterPortlet: Add colon to match the other arguments
FileUpload: Adjust spacing to match the other arguments
Change-Id: Iae0285b1a39cf851aaaa735cb22e95c839813997
umherirrender [Sat, 31 Oct 2015 12:49:11 +0000 (13:49 +0100)]
Load 'mediawiki.page.gallery.styles' also without javascript
Using OutputPage::addModules lets the style loaded over javascript
Using OutputPage::addModuleStyles forces loading over css
Follows I32697c2c65824d7622c1840330d6074ebb68b488
Bug: T117328
Change-Id: I3ddf105d180336b6eb7ae31286221151055e649f
jenkins-bot [Sat, 31 Oct 2015 02:20:25 +0000 (02:20 +0000)]
Merge "objectcache: Allow bounded HashBagOStuff sizes and limit it in WANObjectCache"
Aaron Schulz [Thu, 29 Oct 2015 21:23:32 +0000 (14:23 -0700)]
objectcache: Allow bounded HashBagOStuff sizes and limit it in WANObjectCache
Change-Id: Icca2474b1ea6feb7134f8958aecf79aa51b7f71e
jenkins-bot [Sat, 31 Oct 2015 01:33:03 +0000 (01:33 +0000)]
Merge "Disallow User::setPassword() on users not in database"
jenkins-bot [Fri, 30 Oct 2015 22:38:37 +0000 (22:38 +0000)]
Merge "objectcache: Use singleton cache in newAccelerator()"
Timo Tijhof [Fri, 30 Oct 2015 22:22:44 +0000 (22:22 +0000)]
objectcache: Use singleton cache in newAccelerator()
It was re-creating objects for each call.
This matches behaviour of newAnything().
Bug: T115729
Change-Id: If12aedae7f9f791eb8e233eb241c12efd2921762
jenkins-bot [Fri, 30 Oct 2015 22:18:05 +0000 (22:18 +0000)]
Merge "Log warnings on on preg_* failures in MagicWordArray::matchAndRemove()"
Translation updater bot [Fri, 30 Oct 2015 20:33:58 +0000 (21:33 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: I2825eb46161ccb66a10c6df4fbc4a02404923dc9
jenkins-bot [Fri, 30 Oct 2015 20:07:41 +0000 (20:07 +0000)]
Merge "updateSpecialPages: Get rid of dead SpecialPage::getFile() code"
jenkins-bot [Fri, 30 Oct 2015 16:34:51 +0000 (16:34 +0000)]
Merge "Typo fix for maintenance/install.php."
Brad Jorsch [Fri, 30 Oct 2015 15:19:12 +0000 (11:19 -0400)]
Disallow User::setPassword() on users not in database
Change I2c736ad mostly removed the password handling from the User
object, but left in a little password handling to preserve the existing
ability to call $user->setPassword() before the user was actually added
to the database. That ability is now removed.
Bug: T47716
Change-Id: Id3d40742f2e2b197ad6facd149cc6350006bf289
Kevin Israel [Fri, 30 Oct 2015 09:29:12 +0000 (05:29 -0400)]
Update description of LinkCache::forUpdate()
The $mForUpdate flag no longer causes the FOR UPDATE option to be added.
This was at first only true for some values of $wgAntiLockFlags (since
r9248 /
ba8a00bcb833), though since
12757b50f8da (when the setting was
removed), is always the case.
The added text is based on the description for $wgAntiLockFlags.
Change-Id: I02a3e2df37ec40c7e36ae6210c8263f13d9e3e5b
Timo Tijhof [Fri, 30 Oct 2015 06:08:37 +0000 (06:08 +0000)]
jobqueue: Pass count value delta instead of $type for the inserts_actual metric
Follows-up
4844595. Which wrongly passed the delta as $type parameter.
This resulted in the creation of "jobqueue.inserts_actual.50" and other
random buckets.
The "all" key also got incremented with 1, but doesn't reflect the actual
value in any meaningful way (besides the number of data points pushed
to statsd).
Change-Id: Ic93e06946ce3fcf0c21d2b7504fb10b3711c6e2b
Gergő Tisza [Thu, 29 Oct 2015 23:03:15 +0000 (16:03 -0700)]
Log warnings on on preg_* failures in MagicWordArray::matchAndRemove()
Softer version of I3840a56adc0a6e50963b930051892491f8e90245.
Bug: T115514
Change-Id: Idb297a31b17928a0151476879294eedfbec0d744
Kunal Mehta [Thu, 29 Oct 2015 22:56:07 +0000 (15:56 -0700)]
Add and use wikimedia/base-convert 1.0.1
Change-Id: I3ae56e761ef6fb2b2d506bc2990b97f57183ccf1
jenkins-bot [Fri, 30 Oct 2015 00:30:30 +0000 (00:30 +0000)]
Merge "Fix AbortLogin hook return value check"
Gergő Tisza [Fri, 30 Oct 2015 00:13:37 +0000 (17:13 -0700)]
Fix AbortLogin hook return value check
Bug: T117027
Change-Id: Ia0a222058306bd7e3d1d090dca9976dee54dcc6d
Isarra [Wed, 28 Oct 2015 18:09:06 +0000 (18:09 +0000)]
Get rid of the !importants in the Special:Search form styling
Change-Id: Ibf77eaa6060caba8b6b83439f18f99ea9204ca56
jenkins-bot [Thu, 29 Oct 2015 22:26:06 +0000 (22:26 +0000)]
Merge "Parse huge XML metadata from DjVu images"
jenkins-bot [Thu, 29 Oct 2015 22:09:44 +0000 (22:09 +0000)]
Merge "Revert throwing exceptions on preg_* failures"
jenkins-bot [Thu, 29 Oct 2015 22:04:41 +0000 (22:04 +0000)]
Merge "Free $textMatches results only when done using it"
Gergő Tisza [Thu, 29 Oct 2015 21:52:44 +0000 (14:52 -0700)]
Revert throwing exceptions on preg_* failures
This reverts I3840a56adc0a6e50963b930051892491f8e90245 which
threw exceptions on broken UTF-8 in $text.
Bug: T115514
Bug: T117066
Change-Id: Ie665056a13f9e3678a49790d787b0a41dbba6362
Aaron Schulz [Thu, 29 Oct 2015 21:41:00 +0000 (14:41 -0700)]
Free $textMatches results only when done using it
Change-Id: Ic534fa605ca9c771e7cbe7d3d243f1062fb2d022
Aaron Schulz [Thu, 29 Oct 2015 21:36:29 +0000 (14:36 -0700)]
Fix "Notice: Undefined property: Category::$mId" errors
This should also improve performance while at it.
Change-Id: Ib62ce801f597c653d0a8d5fc19b81c1ce8e0f5f2
jenkins-bot [Thu, 29 Oct 2015 21:19:32 +0000 (21:19 +0000)]
Merge "Include preg_last_error() in error message when preg_* fails"
Gergő Tisza [Thu, 29 Oct 2015 20:49:11 +0000 (13:49 -0700)]
Include preg_last_error() in error message when preg_* fails
Bug: T115514
Bug: T117066
Change-Id: I1d13f8542a4cf11c8e87cd4f6a983fa852dfdf1e
jenkins-bot [Thu, 29 Oct 2015 20:44:18 +0000 (20:44 +0000)]
Merge "Styling tweaks for inline interwiki search"
jenkins-bot [Thu, 29 Oct 2015 20:41:00 +0000 (20:41 +0000)]
Merge "[search] Fix method call on null value"
Translation updater bot [Thu, 29 Oct 2015 20:06:27 +0000 (21:06 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: Ia42d861907521a354efd99d97703c09035927fd2
Brad Jorsch [Thu, 29 Oct 2015 17:40:52 +0000 (13:40 -0400)]
API: Be consistent in siteinfo showhooks output
This was originally made 'BCarray' to avoid breaking BC, but in this
case the nonstandard output is so rare it's probably best to just be
internally consistent.
Bug: T117022
Change-Id: I501c415f6170383c163110b00e54ac88c3dfec89
jenkins-bot [Thu, 29 Oct 2015 15:59:59 +0000 (15:59 +0000)]
Merge "mediawiki.Upload.BookletLayout: Allow for asynchronous initialization"
jenkins-bot [Thu, 29 Oct 2015 15:15:46 +0000 (15:15 +0000)]
Merge "TitleWidget: Sort results correctly"
Ed Sanders [Thu, 29 Oct 2015 13:18:42 +0000 (13:18 +0000)]
TitleWidget: Sort results correctly
Bug: T117039
Change-Id: Ie86c1751dacb5c32afe708b354809b914a54ea51
Reedy [Tue, 6 Oct 2015 15:58:18 +0000 (16:58 +0100)]
Remove ORM code from core
Bug: T114538
Change-Id: Ic4196ca9da927fc5c85b01cfff65f0636e3202ae
Rainer Rillke [Thu, 29 Oct 2015 12:08:18 +0000 (13:08 +0100)]
Parse huge XML metadata from DjVu images
Bug: T117013
Change-Id: I88ef3c1390dc48fa2cfe41d83867eaf0c244726e
This, that and the other [Thu, 29 Oct 2015 12:24:40 +0000 (23:24 +1100)]
Installer: Validate password against sysop/bureaucrat policies
Previously, user-group-specific policies were not checked, because the
user hadn't been created yet, and so wasn't assigned to any groups. In his
overhaul of password policy, Chris wrote a function that was designed for
exactly this purpose (UserPasswordPolicy::checkUserPasswordForGroups) but
didn't put it into use.
Some changes to the error handling code are needed so the error messages
display correctly.
Bug: T115700
Change-Id: I1391c77c9667b646b29003bb0b2abcdc21d8c4d8
jenkins-bot [Thu, 29 Oct 2015 11:56:17 +0000 (11:56 +0000)]
Merge "Add tests for MemcachedBagOStuff::validateKeyEncoding"
Aaron Schulz [Wed, 28 Oct 2015 20:01:50 +0000 (13:01 -0700)]
Add script to find orphaned LocalRepo files
Bug: T111838
Change-Id: I60ac7f3451c8240a0716933dcfff413669458206
jenkins-bot [Thu, 29 Oct 2015 08:04:32 +0000 (08:04 +0000)]
Merge "Convert buildSidebar() to using getWithSetCallback()"
Erik Bernhardson [Thu, 29 Oct 2015 01:37:22 +0000 (18:37 -0700)]
[search] Fix method call on null value
Seeing these pop up in the production logs. This can be null under
certain circumstances, so expect and handle it.
Change-Id: I25a355174e0ad93280eccffd4ec711a641d14bf3
Timo Tijhof [Thu, 29 Oct 2015 01:02:58 +0000 (01:02 +0000)]
Language: Remove logic for class file inclusion
* Remove strcspn() check in newFromCode already in isValidCode().
* Leverage the autoloader instead via class_exists instead of
including files based on user input.
* Create fallback instance directly instead of recursing back
into newFromCode().
* Remove method preloadLanguageClass (unused).
* Remove method getClassFileName (unused)
Change-Id: I90035ca4b07facae051b1a584e92df72b42c4a49
Aaron Schulz [Wed, 28 Oct 2015 05:25:36 +0000 (22:25 -0700)]
Convert buildSidebar() to using getWithSetCallback()
Change-Id: Id9a27ba2bbd3aceee26bf35844d1c970dbb32d47