Rob Lanphier [Sun, 15 May 2011 13:56:12 +0000 (13:56 +0000)]
Changing !isset to is_null (thanks Roan!) and fixing some coding style stuff
Followup to r88178
Rob Lanphier [Sun, 15 May 2011 13:42:10 +0000 (13:42 +0000)]
Setting $wgLocalTZoffset based on $wgLocaltimezone, using code that used to
be in a comment in DefaultSettings. Pair programmed with hashar.
Tim Starling [Sun, 15 May 2011 13:36:59 +0000 (13:36 +0000)]
Fix for HipHop breakage in r87748 etc. Please do not use require_once(dirname(__FILE__)...) to fetch class, function or define() dependencies anymore. You do not need to have HipHop to know that doing so will break it.
Tim Starling [Sun, 15 May 2011 13:21:16 +0000 (13:21 +0000)]
Revert r87635, r87637, r87639, r87643 (MW_MIN_PHP_VERSION etc.): breaks HipHop support.
Sam Reed [Sun, 15 May 2011 13:16:13 +0000 (13:16 +0000)]
* (bug 27593) API: add error message when sha1/sha1base36 is invalid
Platonides [Sun, 15 May 2011 13:12:19 +0000 (13:12 +0000)]
Follow up r87805. Remove unused global.
Bryan Tong Minh [Sun, 15 May 2011 12:51:52 +0000 (12:51 +0000)]
(bug 23464) File: prefixes are now chopped off during uploading.
Platonides [Sun, 15 May 2011 12:40:32 +0000 (12:40 +0000)]
Profile brace substitution per title to help detect the "bad templates". (Make this configurable?)
Platonides [Sun, 15 May 2011 12:37:50 +0000 (12:37 +0000)]
Move $wgContLang out of the switch
Platonides [Sun, 15 May 2011 12:36:21 +0000 (12:36 +0000)]
Follow up r88053. This was trying to throw the return value of a function called MWException.
Bryan Tong Minh [Sun, 15 May 2011 12:35:50 +0000 (12:35 +0000)]
(bug 1780) Uploading files with non-ascii characters are now forbidden on Windows. PHP on Windows does not reliably support non-ascii characters to forbid them all. Theoretically we could detect the filesystem locale and iconv the filename, but that is just too much hassle. Added message 'windows-nonascii-filename'.
Platonides [Sun, 15 May 2011 12:34:00 +0000 (12:34 +0000)]
Perform an early exit
Tim Starling [Sun, 15 May 2011 12:25:36 +0000 (12:25 +0000)]
HipHop build fixes:
* Generate the file list from the autoloader so that it won't break so often
* Removed spyc.php from AutoLoader.php, was deleted in r86302
Antoine Musso [Sun, 15 May 2011 12:09:59 +0000 (12:09 +0000)]
In tests, remove references to wgInputEncoding and wgOutputEncoding
Those globals are no more used as of r87589
Domas Mituzas [Sun, 15 May 2011 11:16:59 +0000 (11:16 +0000)]
initialize Profiler instance singleton with ProfilerStub if 'bogus' is detected, rather than failing. CBA to debug. Reviewed by Tim eating his lunch.
Roan Kattouw [Sun, 15 May 2011 10:57:01 +0000 (10:57 +0000)]
Remove debugging code introduced in r88115
Krinkle [Sun, 15 May 2011 10:47:37 +0000 (10:47 +0000)]
Redo r88144
Bryan Tong Minh [Sun, 15 May 2011 10:43:51 +0000 (10:43 +0000)]
Follow-up r87176 use wfLocalFile instead of wfFindFile
Roan Kattouw [Sun, 15 May 2011 10:42:33 +0000 (10:42 +0000)]
Revert r88144, deleted the wrong file
Bryan Tong Minh [Sun, 15 May 2011 10:39:15 +0000 (10:39 +0000)]
Follow-up r87176: Make importDump.php import files
* Fixes for Import.php: Check sha1 of the file; only delete source files if they are temporary
* importDump.php now imports embedded files if --uploads is set; if they are not present it will try to get them from --image-base-path
Krinkle [Sun, 15 May 2011 10:34:28 +0000 (10:34 +0000)]
Goodbye mediawiki.util.test. In no particular order:
* Uses ugly eval()
* Initially meant to cross-browser test mediawiki.util.test, (re|ab|)used for random other tests
* Uses ugly html-element innerText comparison to validate tests
* Loaded for all debug=true requests
* Not automatable, not distributeable, not pushable, not compatible with TestSwarm.
* I wrote it on a late sunday night because we needed it.
* QUnit is the opposite of this.
To run the test suite: visit /w/resources/test/
Krinkle [Sun, 15 May 2011 10:33:07 +0000 (10:33 +0000)]
(bug 27073) Lazy init the style marker and insert if not available (ie. when using resourceloader js on a non-mediawiki domain); fixing typo (r88074 CR)
Bryan Tong Minh [Sun, 15 May 2011 09:54:31 +0000 (09:54 +0000)]
Add 'hash' => array( 'class' => 'HashBagOStuff' ) to $wgObjectCaches; greatly speeds up importDump.php
Jure Kajzer [Sun, 15 May 2011 09:20:40 +0000 (09:20 +0000)]
* fixed typo
Trevor Parscal [Sun, 15 May 2011 09:10:04 +0000 (09:10 +0000)]
Fixes regression in r88125 - if batch is empty we should bail early
Niklas Laxström [Sun, 15 May 2011 07:16:25 +0000 (07:16 +0000)]
Fixed a bug in transformation where previous language could leak into later transformations in UI language. Not sure what do with userlang.
Aaron Schulz [Sun, 15 May 2011 06:32:26 +0000 (06:32 +0000)]
Marked some _Newtalk functions protected
Roan Kattouw [Sat, 14 May 2011 23:49:29 +0000 (23:49 +0000)]
Kill diff.js with fire. It only applies to versions of Gecko that were released before Nov 2002, which is waaaay beyond what we support, or what anyone could conceivably be using in this day and age.
Brian Wolff [Sat, 14 May 2011 23:48:59 +0000 (23:48 +0000)]
(bug 28940) When making a thumb of an SVG, and only specifying the height
make the width be the max SVG size, not the natrual width of the SVG.
Some of the linker code here should perhaps be moved. See comments on bug 28940
Trevor Parscal [Sat, 14 May 2011 23:12:16 +0000 (23:12 +0000)]
Removed the go() call, and the suspended until go() is called behavior.
Siebrand Mazeland [Sat, 14 May 2011 23:11:15 +0000 (23:11 +0000)]
Add Rotem Liss and Platonides to author list.
Platonides [Sat, 14 May 2011 23:08:43 +0000 (23:08 +0000)]
Bump to 1.19
Benjamin Lees [Sat, 14 May 2011 22:57:55 +0000 (22:57 +0000)]
(bug 28287) The "your changes" box for edit conflicts is now read-only. Patch by MZMcBride.
Antoine Musso [Sat, 14 May 2011 22:53:31 +0000 (22:53 +0000)]
Credits to Victor Vasiliev in [[Special:Version]]
Be bold!
Platonides [Sat, 14 May 2011 22:36:19 +0000 (22:36 +0000)]
Revert r88043. It was broken in several ways.
Mark A. Hershberger [Sat, 14 May 2011 22:10:10 +0000 (22:10 +0000)]
Fix Bug 28979 — “remove some CSS for abbr and acronym tags”
The <abbr> and <acronym> tags were whitelisted with bug 671, but
there are some CSS rules for them since long, long times. They can
be found in the first versions of chick, monobook and are carried
on to vector skin.
Often these tags are used in links, e.g. [[Normalnull|<abbr
title="meter above see level">NN</abbr>]]. But in here the
color:black; makes the text unrecognizable as a hyperlink
(together with the senseful cursor:help; rule).
When these rules where meant to override some crazy
browserdependent default settings, they should be be changed to
"inherit".
from Bergi
Jure Kajzer [Sat, 14 May 2011 22:06:47 +0000 (22:06 +0000)]
* added alternative revison size display if diff size is not selected
Roan Kattouw [Sat, 14 May 2011 17:56:01 +0000 (17:56 +0000)]
(bug 28978) jquery.autoEllipsis cache doesn't take position into account, leads to cache pollution
Alexandre Emsenhuber [Sat, 14 May 2011 17:11:32 +0000 (17:11 +0000)]
Rewrote the article counting code and related:
* (bug 26033, bug 24754) Added $wgArticleCountMethod to have a more flexible way to define which method to use to define if a page is an article or not and deprecated $wgUseCommaCount. There is now a new 'any' method to count any article that is in a content namespace and not a redirect.
* (bug 11868) If using links to count articles, Article::isCountable() will now use the ParserOutput to check if there's a link instead of checking for the "[[" string. Changed Article::isCountable() to take a stdObject or false for the first parameters. If false is passed, the result will be based on the current article's state (i.e. database). The only call outside of the Article class is in DeleteAction (including extensions).
* Removed this horror of Article::$mGoodAdjustment and Article::$mTotalAdjustment, replaced by the new $created parameter on Article::editUpdates(); simplified Article::createUpdates()
* Updated Import.php to take advantage of the new parameter and make a single call to Article::editUpdates()
Jure Kajzer [Sat, 14 May 2011 17:05:25 +0000 (17:05 +0000)]
* added an option to toggle the display of diff size with a warning message.
* in misermode this option is disabled
Alexandre Emsenhuber [Sat, 14 May 2011 17:02:37 +0000 (17:02 +0000)]
Follow-up r87589: let's simplify this a bit :P
Jure Kajzer [Sat, 14 May 2011 16:54:22 +0000 (16:54 +0000)]
discussion with hashar
* moved getInfoBox into Xml.php as infoBox static method
* moved config-infobox* css classes from config to mw-infobox* in shared
* left getInfoBox as a wrapper in the installer
Antoine Musso [Sat, 14 May 2011 16:46:16 +0000 (16:46 +0000)]
Basic HTML file to test our CSS box
Antoine Musso [Sat, 14 May 2011 16:09:56 +0000 (16:09 +0000)]
orange should be prefered to yellow
This is a recommandation by Jorm following a live conversation with him.
See also: http://www.mediawiki.org/wiki/Style_guide
Follow up r88098
Siebrand Mazeland [Sat, 14 May 2011 16:01:15 +0000 (16:01 +0000)]
Remove special case for IE on Mac. No longer supported. Also fixes bug 28937: The /* Empty */ comment inserted by RawPage::getArticleText should be localizable.
Antoine Musso [Sat, 14 May 2011 15:39:37 +0000 (15:39 +0000)]
add a shared CSS class for warnings
We already have one for success and error
Jack Phoenix [Sat, 14 May 2011 15:14:03 +0000 (15:14 +0000)]
Vector.php: coding style
Sam Reed [Sat, 14 May 2011 14:44:37 +0000 (14:44 +0000)]
Fix line removedfor no explicit reason from r85771
Bryan Tong Minh [Sat, 14 May 2011 14:41:31 +0000 (14:41 +0000)]
(bug 18803) JPEG2000 images can no longer be uploaded as JPEG image. Done by adding the relevant mime info to mime.types and mime.info
Roan Kattouw [Sat, 14 May 2011 14:20:18 +0000 (14:20 +0000)]
Fix broken --sysop flag in r87480: it was triggering the bureaucrat right instead, and createAndPromote.php couldn't be used to create sysops at all
Bryan Tong Minh [Sat, 14 May 2011 14:15:35 +0000 (14:15 +0000)]
(bug 27864) Transcluding {{Special:Prefix}} with empty prefix now lists all pages.
Removed All pages link which doesn't make sense
Patch by Salvatore Ingala
Put ST47 on the proper place in CREDITS
Bryan Tong Minh [Sat, 14 May 2011 14:08:58 +0000 (14:08 +0000)]
RELEASE-NOTES for r88054
Antoine Musso [Sat, 14 May 2011 13:56:13 +0000 (13:56 +0000)]
bug 28503: add ircs to UrlProtocols in defaultsettings & css
Roan Kattouw [Sat, 14 May 2011 13:45:07 +0000 (13:45 +0000)]
Put jQuery UI modules in their own group
Roan Kattouw [Sat, 14 May 2011 13:34:03 +0000 (13:34 +0000)]
Fix bug in r87497, reported in CR: &modules=foo,bar,baz would look for '.foo', '.ar' and '.az' . Now handling prefixless modules correctly
Trevor Parscal [Sat, 14 May 2011 13:21:58 +0000 (13:21 +0000)]
Fixed language in comments and error messages - see comments in r88053.
Trevor Parscal [Sat, 14 May 2011 13:14:34 +0000 (13:14 +0000)]
Improves on r88053 - added code basically lifted from jQuery.getScript which ensures that onreadystatechange is handled properly - only executing the callback when the state is changed to the correct state, and only calling it one time. Thanks John Resig!
Bryan Tong Minh [Sat, 14 May 2011 13:12:58 +0000 (13:12 +0000)]
Follow-up r88054: Update messages.inc
Krinkle [Sat, 14 May 2011 13:07:12 +0000 (13:07 +0000)]
Adding a small test to verify that the regex worked. Apparently it's failing in IE8. Thanks TestSwarm
Krinkle [Sat, 14 May 2011 12:54:06 +0000 (12:54 +0000)]
Adding files missing in r88061
Krinkle [Sat, 14 May 2011 12:48:38 +0000 (12:48 +0000)]
Adding QUnit tests for mw.loader (Follow-up r88053)
Roan Kattouw [Sat, 14 May 2011 12:48:07 +0000 (12:48 +0000)]
(bug 28952) Add tofragment to the redirect resolution info.
Changes the format of ApiPageSet::getRedirectTitles() from returning prefixed text strings to returning title objects so we can obtain the fragment info
Niklas Laxström [Sat, 14 May 2011 12:24:45 +0000 (12:24 +0000)]
Special pages don't have talk page. Fixes exception in feeds when using revision deletion feature:
Exception: MWNamespace::getTalk does not make any sense for given namespace -1
Bryan Tong Minh [Sat, 14 May 2011 12:20:45 +0000 (12:20 +0000)]
(bug 23002) Imagelinks table not updated after imagemove. The actual bug was inconsistent behaviour between imagelinks and pagelinks for redirects.
* Parser now only adds the redirect source to imagelinks, like it does in pagelinks
* ImagePage now shows the file redirects in-line with the normal "The following pages link to this file:"
** Added message linkstoimage-redirect
** Removed the separate file redirects section and removed associated message redirectstofile
** ImagePage::imageLinks will first fetch image links to the file, determine which are redirects, and if there are fewer links than the limit, fetch the redirect target links.
Trevor Parscal [Sat, 14 May 2011 12:15:58 +0000 (12:15 +0000)]
Added direct file loading functionality to debug mode for both scripts and styles, with callbacks for module state changes (changing to ready) and executing of jobs and modules awaiting dependency resolutions. These changes also provide a way to used mw.loader.implement with arrays of URLs for the scripts and styles arguments, which will make it possible to implement modules using user scripts. This probably solves bug #27023 - tests to verify that will be coming soon.
Sam Reed [Sat, 14 May 2011 12:14:25 +0000 (12:14 +0000)]
Fix up last errors from r88047
Antoine Musso [Sat, 14 May 2011 12:01:08 +0000 (12:01 +0000)]
Fix MWNamespaceTest::testGetTalkExceptions()
It was actually testing for associated. Thanks copy & paste for this bug.
Test result:
$ php phpunit.php -c suite.xml includes/MWNamespaceTest.php
.........IIIII..........
Tests: 24, Assertions: 99, Incomplete: 5.
Sam Reed [Sat, 14 May 2011 12:00:46 +0000 (12:00 +0000)]
Fix daft loading error I added in r88047
Jure Kajzer [Sat, 14 May 2011 11:36:03 +0000 (11:36 +0000)]
* changed display function for length to Linker::formatRevisionSize
Sam Reed [Sat, 14 May 2011 11:29:45 +0000 (11:29 +0000)]
* (bug 28963) add langbacklinks module to api
Completely untested at this point, that's being done next
Raimond Spekking [Sat, 14 May 2011 11:21:36 +0000 (11:21 +0000)]
Followup r88043: Add new message keys to maintenance file
Antoine Musso [Sat, 14 May 2011 11:19:59 +0000 (11:19 +0000)]
ApiBase::dieUsageMsg() now also accept being given a single element as a string.
So the old:
$api->dieUsageMsg( array( 'nologging' ) );
Can now be written:
$api->dieUsageMsg( 'nologging' );
Saves up a few keystrokes.
Platonides [Sat, 14 May 2011 11:09:26 +0000 (11:09 +0000)]
(Bug 28960) add message when email copy is sent to user
Also added an error message when the mails were not sent.
Documented the new messages plus some older ones.
Note: $successCount and $failCount fields of Status are ugly to use.
Brion Vibber [Sat, 14 May 2011 09:27:36 +0000 (09:27 +0000)]
* (bug 28945) Keyboard shortcuts on history page no longer work in 1.18
The link replacements for the button were dropping title & accesskey attributes, losing the shortcut key. Now copying these and replacing the buttons in-place, makes em work.
Roan Kattouw [Sat, 14 May 2011 09:24:24 +0000 (09:24 +0000)]
Followup r87711: add ! to the forbidden characters list for module names, per CR
Sam Reed [Sat, 14 May 2011 09:05:15 +0000 (09:05 +0000)]
Followup r88002, fix naming on param documentation
Jure Kajzer [Fri, 13 May 2011 23:42:06 +0000 (23:42 +0000)]
* addon to previous
Jure Kajzer [Fri, 13 May 2011 23:31:06 +0000 (23:31 +0000)]
* removed unused messages because of previous revert.
* hidden namespace select box if in wgMiserMode(requested by domas)
Jure Kajzer [Fri, 13 May 2011 23:18:02 +0000 (23:18 +0000)]
* partial revert of r88019. Left the messages in for now ... don't know ... those mesages seem logical to me, i know domas might not like it, but they are still displayed.
Jure Kajzer [Fri, 13 May 2011 23:08:38 +0000 (23:08 +0000)]
* bug 28571
* Not sure about this one: the index i changed is defined as ar_usertext_timestamp in tables.sql, but created and used as usertext_timestamp.
Krinkle [Fri, 13 May 2011 21:51:31 +0000 (21:51 +0000)]
Follow-up r88014: Removing tablesorter from mw.util test loader, no longer being used there
Raimond Spekking [Fri, 13 May 2011 21:34:44 +0000 (21:34 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2011-05-13 21:15:00 UTC)
Jure Kajzer [Fri, 13 May 2011 21:33:56 +0000 (21:33 +0000)]
* fixed as per comment on r88008
Chad Horohoe [Fri, 13 May 2011 19:04:57 +0000 (19:04 +0000)]
Rewrite importUseModWiki to subclass maintenance, general cleanup, etc. Also fixing bug 22287, change default field separator
Chad Horohoe [Fri, 13 May 2011 17:54:34 +0000 (17:54 +0000)]
(bug 21086) generateSitemap.php uses wfWikiID() in sitemap filenames
Add optional --identifier parameter to override wfWikiId()
Leo Koppelkamm [Fri, 13 May 2011 17:48:29 +0000 (17:48 +0000)]
Followup to r87987: Remove tablesorter from mw.util dependencies
Chad Horohoe [Fri, 13 May 2011 17:47:24 +0000 (17:47 +0000)]
Kill defines in favor of class constants, not used anywhere else
Krinkle [Fri, 13 May 2011 17:28:28 +0000 (17:28 +0000)]
Adding qunit tests for isIPv4Address and isIPv6Address in mw.util
Markus Glaser [Fri, 13 May 2011 17:24:43 +0000 (17:24 +0000)]
removed max line size for a sql dump file. This optional since PHP 4.2.0. Larger lines are needed when importing test databases in selenium framework. This change was discussed on wikitech-l on 03.Feb.2011.
Jure Kajzer [Fri, 13 May 2011 17:11:44 +0000 (17:11 +0000)]
* bug 24037
Roan Kattouw [Fri, 13 May 2011 16:34:36 +0000 (16:34 +0000)]
(bug 24781) Define XML namespace for API output. Also created the referenced URL on the cluster.
Chad Horohoe [Fri, 13 May 2011 16:21:39 +0000 (16:21 +0000)]
(bug 10154) Don't allow user to specify days beyond $wgRCMaxAge
Sam Reed [Fri, 13 May 2011 16:16:44 +0000 (16:16 +0000)]
Fix unused variables
Decapitalise False
Sam Reed [Fri, 13 May 2011 16:16:08 +0000 (16:16 +0000)]
Improve variable naming
Leo Koppelkamm [Fri, 13 May 2011 15:57:33 +0000 (15:57 +0000)]
Followup to r87987: Actually load the lazy loader
Antoine Musso [Fri, 13 May 2011 15:56:12 +0000 (15:56 +0000)]
bug 2429 fix up index by using IN / NOT IN instead of (!= and !=)
Tested (EXPLAIN <query>) against the english wikipedia database.
Follow up:
- r83110 : original ns association implementation
- r87992 : abstraction support for 'NOT IN'
(note: breaks some existing PHPUnit tests)
Brion Vibber [Fri, 13 May 2011 15:52:46 +0000 (15:52 +0000)]
* (bug 15461) Make IE8 turn off content sniffing. Everbody else should ignore this
Adding X-Content-Type-Options: nosniff header in WebStart.php so that it's *always* set, even for alternate entry points and when $wgOut gets disabled or overridden.
Note that this of course doesn't apply to uploaded images and such loaded directly -- the usual caveats still apply.
Have not tested to confirm that this actually protects against sniffing errors -- please test on IE8 and IE9.
Antoine Musso [Fri, 13 May 2011 15:39:45 +0000 (15:39 +0000)]
Support abstraction for 'NOT IN' SQL structure
Following a live discussion with Catrope.
When using Database::makeList() in LIST_AND or LIST_OR modes, you can now
suffix the field name with an exclamation mark. It will negate the logical
boolean.
Example:
$db->makeList( array( 'field!' => array( 1,2,3 ) );
outputs:
'field' NOT IN ('1', '2', '3' );
$db->makeList( array( 'foo!' => array( 777 ) ) );
outputs:
'foo' =! 777
(note: tests not ran, please run them and ammend them)
Krinkle [Fri, 13 May 2011 15:28:44 +0000 (15:28 +0000)]
Looks like even margin-top isn't save due to box model differences (ie. becomes 6px in WebKit browser...?). Using visibility insteawd. (Follow-up to r87938, r87970)
Leo Koppelkamm [Fri, 13 May 2011 15:28:42 +0000 (15:28 +0000)]
Lazy load tablesorter only when needed. Bug 28946