Timo Tijhof [Tue, 26 Jun 2018 17:22:26 +0000 (18:22 +0100)]
mediawiki.inspect: Fix exception when calling mw.inspect() a second time
In mediawiki.js, the mw.inspect() method is defined to lazy-load the
'mediawiki.inspect' module, and then call mw.inspect.runReports().
The problem is that, mediawiki.inspect.js, re-creates mw.inspect as a plain
object, which blows away the mw.inspect() function that was there.
Calling it a second time threw "TypeError: inspect is not a function".
Fix this by making mediawiki.inspect.js extend the function object,
instead of re-defining it.
Bug: T197810
Change-Id: I61aa965f3e1fd0a1c9f9d98310632b4a8d5e1683
Timo Tijhof [Tue, 26 Jun 2018 17:11:13 +0000 (18:11 +0100)]
mediawiki.inspect: Fix doc index for inspect.grep()
Because this was positioned linearly after the sub-object for
`mw.inspect.reports.*`, JSDuck was indexing this as part of that
object instead of the outer `mw.inspect.*` scope.
This could be fixed by adding `@member mw.inspect` on this method,
or by re-starting the `@class mw.inspect` scope, but really
this should've been declared closer to the rest of that class,
which naturally avoids the index issue.
Change-Id: Ib2c9dc861f7f062c05bc059643a1a676906d338f
Timo Tijhof [Tue, 26 Jun 2018 17:07:43 +0000 (18:07 +0100)]
mediawiki.inspect: Use property assignments for clarity
This changes the assignment of these methods from being declared
at once in an object literal, to assigning properties in separate
statements.
This is functionally a no-op and produces the exact same values,
but was factored out of the next commit to keep the diff cleaner
when fixing T197810 (which changes the host object from a plain
empty object, to a function object, which cannot be declared
as a literal).
Bug: T197810
Change-Id: I6ba1891acf8807cb9e01fa11a608e0c509e5f2bc
Kunal Mehta [Sat, 2 Jun 2018 02:14:02 +0000 (19:14 -0700)]
Skip MediaWikiTestCaseSchema1Test on Postgres
According to Anomie, the idea behind this test is semi-broken, and would
benefit from T191231 being implemented first.
Bug: T195807
Change-Id: I9561fd0a82c37cf044e292e00499ecb611fcded6
jenkins-bot [Tue, 26 Jun 2018 15:25:07 +0000 (15:25 +0000)]
Merge "Declare HTMLSelectNamespace::mAllValue"
C. Scott Ananian [Tue, 26 Jun 2018 14:37:51 +0000 (10:37 -0400)]
Sync up with Parsoid parserTests.txt
This now aligns with Parsoid commit
b068bb51d29e294a4f4a875ae829cca8cf314205
Change-Id: Ie8e8a7ed631894f56372e286ed01d1583f7a8979
jenkins-bot [Tue, 26 Jun 2018 14:21:33 +0000 (14:21 +0000)]
Merge "Checkboxes should be styled on non-JS browsers"
Umherirrender [Mon, 25 Jun 2018 19:36:21 +0000 (21:36 +0200)]
Declare HTMLSelectNamespace::mAllValue
It is protected, because some extension extends this class
Change-Id: I576e9e7e843844433655b11b8847c9e3060ba8e9
jenkins-bot [Tue, 26 Jun 2018 12:27:53 +0000 (12:27 +0000)]
Merge "Fix PHP7 warning "non well formed numeric value encountered""
jenkins-bot [Tue, 26 Jun 2018 10:54:25 +0000 (10:54 +0000)]
Merge "Add some output for progress in populateChangeTagDef.php"
jenkins-bot [Tue, 26 Jun 2018 07:42:58 +0000 (07:42 +0000)]
Merge "Expand $wgDBDefaultGroup documentation"
Edward Chernenko [Mon, 25 Jun 2018 22:45:13 +0000 (01:45 +0300)]
Fix PHP7 warning "non well formed numeric value encountered"
PHP 7.1 warns when non-numeric string is implicitly cast to integer.
Change-Id: Ia46ea793e9495548c7d421b3372f6deaeda163f5
jenkins-bot [Mon, 25 Jun 2018 21:49:55 +0000 (21:49 +0000)]
Merge "French space armoring: Use unicode regex instead of octal escapes"
jenkins-bot [Mon, 25 Jun 2018 21:42:03 +0000 (21:42 +0000)]
Merge "Armor against French spaces detection in HTML attributes"
jenkins-bot [Mon, 25 Jun 2018 21:19:59 +0000 (21:19 +0000)]
Merge "wdio-mediawiki: Tag v0.2.0"
jenkins-bot [Mon, 25 Jun 2018 21:13:32 +0000 (21:13 +0000)]
Merge "Avoid bad method call to patchPatch() in DbTestRecorder"
jenkins-bot [Mon, 25 Jun 2018 21:05:59 +0000 (21:05 +0000)]
Merge "Align loading animation for first load later reloads"
Timo Tijhof [Mon, 25 Jun 2018 20:57:32 +0000 (21:57 +0100)]
wdio-mediawiki: Tag v0.2.0
Change-Id: Ia975b2d35220a6ad8ca90e6198ca2ba74c256ea3
Marius Hoch [Mon, 25 Jun 2018 20:56:51 +0000 (22:56 +0200)]
Expand $wgDBDefaultGroup documentation
Per Krinkle's comment:
https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/440022/2/includes/DefaultSettings.php
Change-Id: I94e6e7f5048de610d2ae0722cb3de216288ed182
Aaron Schulz [Mon, 25 Jun 2018 20:14:08 +0000 (21:14 +0100)]
Avoid bad method call to patchPatch() in DbTestRecorder
Bug: T193995
Change-Id: Ibc480b04463792b7cd720a6eb080e0960a30e440
L10n-bot [Mon, 25 Jun 2018 19:54:19 +0000 (19:54 +0000)]
Merge "Localisation updates from https://translatewiki.net."
Translation updater bot [Mon, 25 Jun 2018 19:54:09 +0000 (21:54 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: Ie589a2973df5cc34bc5b622cd135608b7bb29a34
jenkins-bot [Mon, 25 Jun 2018 19:51:41 +0000 (19:51 +0000)]
Merge "resourceloader: Update StartUpModule to use file hash instead of mtime"
jenkins-bot [Mon, 25 Jun 2018 19:28:28 +0000 (19:28 +0000)]
Merge "resourceloader: Fix duplicate semi-colon in generated startup code"
jenkins-bot [Mon, 25 Jun 2018 18:51:58 +0000 (18:51 +0000)]
Merge "skins: Remove redundant mediawiki.hidpi script"
Timo Tijhof [Mon, 25 Jun 2018 18:30:48 +0000 (19:30 +0100)]
resourceloader: Update StartUpModule to use file hash instead of mtime
This was overlooked as part of the whole shift from timestamps
to file hashes (T94074,
f37cee996e, T104950,
28f6d7fbde).
The key name and method call here matches that of FileModule.
The impact of this still using mtimes was fairly low, given:
* The startup module is only cached for 5 minutes.
* The startup module's hash varies on "everything" which includes
wgVersion, as such, when a new branch is cut and cloned and this file's
timestamp is reset, there will still be other factors causing the
overall hash to vary. As such, this change is unlikely to improve
200-304 response ratio.
Change-Id: I6543fb75575e9a793a7fc93e15d2f3e0b5a04342
Timo Tijhof [Mon, 25 Jun 2018 18:25:36 +0000 (19:25 +0100)]
resourceloader: Fix duplicate semi-colon in generated startup code
The startup.js template used '$CODE.registrations();', which makes
sense syntatically (and for the linter), but the substitution logic
was only replacing the '$CODE.registrations()' portion.
This made the generated output contain two consecutive semi-colons.
Change-Id: Ibef1a0d932b19037987a7effa12aa57f578a142d
jenkins-bot [Mon, 25 Jun 2018 18:30:17 +0000 (18:30 +0000)]
Merge "LCStoreStaticArray: create cache directory when it doesn't exist"
Timo Tijhof [Sat, 23 Jun 2018 23:30:18 +0000 (00:30 +0100)]
skins: Remove redundant mediawiki.hidpi script
This is an internal script automatically loaded by Skin.php to
activate the 'jquery.hidpi' polyfill for all images on the current
page in browsers that don't natively support the 'srcset' attribute
on the HTML img element.
This script is loaded via ResourceLoader for which Grade A currently
requires:
> IE11+/Edge, Chr 65+, Ff 52+, Saf 5+, Op 15+, iOS 6+, Android 4+.
According to MDN and CanIUse, the basic 'x' syntax of srcset is supported, and
enabled by default, in:
> Edge, Chr 34+, Ff 38+, Saf 7+, Op 21+, iOS 8+, Android 5+.
This means in the following browsers, MediaWiki will no longer attempt to
replace images in articles with their hidpi versions.
| Browser | analytics.wikimedia.org (22 May - 22 June)
| ---------------------- | -----------------------
| IE 11 on Windows <= 7 | 3.4% (OS does not support HiDPI)
| IE 11 on Windows 8+ | 1.1%
| Safari 5 & 6 (desktop) | <0.1%
| Opera 15-20 (desktop) | <0.1%
| iOS 6 & 7 (mobile) | 0.1%
| Android 4 (mobile) | 0.5%
While the total of 1.7% is higher than our usual point where we decide
to remove support, I think we should consider dropping the hidpi polyfill
still for several reasons:
* MobileFrontend no longer uses 'srcset' attributes. As such, these browsers
don't actually change their behaviour based on the polyfill.
* For IE 11/Win8 in particular, most users don't have an HiDPI monitor,
but we still download the polyfill. HiDPI on Win8 is primarily tablets.
* In all cases where the polyfill activates, we download the HiDPI images
in addition to the standard resolution (which downloads and renders first).
This is because client-side JavaScript is not able to replace it sooner.
This could be considered a waste of bandwidth, as it can double or tripple
the bandwidth cost for end users.
This also means pages complete their loading much later because the browser
first renders the page nearly to completion with standard resolution images,
and only at the end our polyfill activates to restarts all image loading.
The experience gracefully falls back to normal web rendering, where the standard
resolution of the image is used. This would match what users of these devices
see on other websites, given client-side emulation of srcset is fairly rare.
== Modules
The 'mediawiki.hidpi' module was removed, and considered internal to Skin.php.
It contained no public methods. I confirmed there were no matches in Codesearch,
and no matches in mwgrep on Wikimedia wikis.
I did not remove 'jquery.hidpi', which is what contains the actual polyfill
and the jQuery.fn.hidpi() public method. (Codesearch shows 2 extenisons using
it, and mwgrep returned 1 unused gadget on Meta-Wiki referencing it).
It has been kept, but marked as deprecated. To be removed in a future release.
Bug: T127328
Change-Id: I42ce0feea1fbfe534f00e05a7cd8d81df0c33d8f
jenkins-bot [Mon, 25 Jun 2018 15:49:06 +0000 (15:49 +0000)]
Merge "resourceloader: spin base module code out as a proper module"
Edward Chernenko [Mon, 25 Jun 2018 15:40:25 +0000 (18:40 +0300)]
LCStoreStaticArray: create cache directory when it doesn't exist
Array store (LCStoreStaticArray) should behave as standard LCStoreCDB,
creating the target directory when it doesn't exist.
This fixes unexpected "No such file or directory" errors when
replacing 'files' with 'array' in $wgLocalisationCacheConf['store'].
Change-Id: Ie49cf03ca93ac47fc98665de36e6207bef287193
Amir Sarabadani [Tue, 19 Jun 2018 07:02:41 +0000 (09:02 +0200)]
Add some output for progress in populateChangeTagDef.php
I ran it on beta cluster and all was done without one single line of output
Bug: T193871
Change-Id: I05a7c7827203eb159b5845a874b94d74f5d5e299
Aaron Schulz [Wed, 20 Jun 2018 15:14:28 +0000 (16:14 +0100)]
resourceloader: spin base module code out as a proper module
Bug: T192623
Change-Id: I6f7dc40488a990d0f8a25e84ebc9eb25ad4c2975
jenkins-bot [Mon, 25 Jun 2018 13:04:27 +0000 (13:04 +0000)]
Merge "Revert "Use pathinfo() in AutoLoaderStructureTest::testPSR4Completeness""
Hashar [Mon, 25 Jun 2018 12:38:07 +0000 (12:38 +0000)]
Revert "Use pathinfo() in AutoLoaderStructureTest::testPSR4Completeness"
This reverts commit
634c2ec2afd93827e5aaf571396eb76d35948188.
Reason for revert: that strips the PSR4 directories from the class.
Example:
$dir BlueSpiceFoundation/src/"
$file BlueSpiceFoundation/src/ConfigDefinition/IntSetting.php
$abbrFileName: IntSetting
$expectedClassName: BlueSpice\IntSetting
$abbrFileName should be relative to $dir and not just the filename.
Bug: T198077
Change-Id: Ie934e309fee0392439b4e26d86249f0650e5ea67
jenkins-bot [Mon, 25 Jun 2018 12:05:26 +0000 (12:05 +0000)]
Merge "Use pathinfo() in AutoLoaderStructureTest::testPSR4Completeness"
Antoine Musso [Mon, 25 Jun 2018 11:32:30 +0000 (13:32 +0200)]
Use pathinfo() in AutoLoaderStructureTest::testPSR4Completeness
When setting AutoloadNamespaces to './' in extension.json, the test
AutoLoaderStructureTest::testPSR4Completeness would fail. The directory
path is not made canonical while the file is, which causes the substr()
call being used to strip too many characters. For example:
$dir : /mediawiki/extensions/Wikidata.org/./
$file: /mediawiki/extensions/Wikidata.org/Hooks.php
$abbrFileName = substr( substr( $file, strlen( $dir ) ), 0, -4 );
>>> oks
Use pathinfo() to parse the filename. Yields 'Hooks' as expected.
Bug: T198077
Change-Id: Ia8a11d87788b32ddb426a16a61b410b05ff5f15e
jenkins-bot [Mon, 25 Jun 2018 11:21:59 +0000 (11:21 +0000)]
Merge "Make WikiPage::convertSelectType protected"
Jakob Warkotsch [Mon, 25 Jun 2018 10:14:25 +0000 (12:14 +0200)]
Browser tests: use Util.getTestString in specialwatchlist.js
Follow-up on I5c5e9b22af5406f347636b22e68657b2674db6c9 and
I0747c2d361e951f8b3765a3dca548e55edb72216
Change-Id: I35ad793e6d9fe4c3bf58df9b4fcf6471c0a81f70
jenkins-bot [Mon, 25 Jun 2018 09:51:52 +0000 (09:51 +0000)]
Merge "Browser tests: extract commonly used getTestString function"
jenkins-bot [Mon, 25 Jun 2018 09:49:02 +0000 (09:49 +0000)]
Merge "Add browser test for basic watchlist functionality"
jenkins-bot [Mon, 25 Jun 2018 09:01:35 +0000 (09:01 +0000)]
Merge "mediawiki.hook: Move mw.hook tests to new mediawiki.base.test.js file"
jenkins-bot [Mon, 25 Jun 2018 08:14:13 +0000 (08:14 +0000)]
Merge "Remove deprecated 'dom-level2-shim' module"
jenkins-bot [Mon, 25 Jun 2018 08:05:31 +0000 (08:05 +0000)]
Merge "resourceloader: Add coverage for StartupModule::getDefinitionSummary"
Kunal Mehta [Sun, 24 Jun 2018 20:55:43 +0000 (23:55 +0300)]
GitInfo: Don't try shelling out if it's disabled
Bug: T198037
Change-Id: I364f9bc0e78439474101f4b2a171805c91f50a72
Translation updater bot [Sun, 24 Jun 2018 20:07:51 +0000 (22:07 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I9a6171181bfab383402ad99e1f59315d5aded560
Niklas Laxström [Wed, 13 Jun 2018 08:12:54 +0000 (10:12 +0200)]
Add the es-419 language code to support South American Spanish
This code is useful for targeting Spanish spoken in the Latin America
and the Caribbean region. There are no plans to make this available as
an interface language, hence I am not adding a language file with a
fallback to 'es'.
Bug: T112889
Change-Id: If7f0ed7a13f1cc86985ce5ce509dcf543cc1c0ff
Umherirrender [Sun, 24 Jun 2018 12:25:30 +0000 (14:25 +0200)]
Make WikiPage::convertSelectType protected
When override WikiPage this function is needed
to map the string to const
Change-Id: I4e4d597a77c859ad17bd6c29bed875fb4248b5fb
jenkins-bot [Sun, 24 Jun 2018 03:06:28 +0000 (03:06 +0000)]
Merge "rdbms: make some LBFactory fields private"
Timo Tijhof [Sun, 20 May 2018 14:15:40 +0000 (16:15 +0200)]
Remove deprecated 'dom-level2-shim' module
This is an empty placeholder module that does nothing. It was kept
for backwards compatibility with older extensions that were still
supporting MediaWiki versions that in turn supported older browsers.
There is no longer any use of 'dom-level2-shim' anywhere in Wikimedia Git,
nor anywhere found by Codesearch,
nor anywhere on-wiki at WMF (including user scripts).
Bug: T127328
Change-Id: I416b216471c321d56d3b6d72bc9ef7dcc0f16093
jenkins-bot [Sun, 24 Jun 2018 02:22:09 +0000 (02:22 +0000)]
Merge "MWExceptionRenderer: Fix db error outage page"
Timo Tijhof [Sun, 24 Jun 2018 01:59:44 +0000 (02:59 +0100)]
resourceloader: Add coverage for StartupModule::getDefinitionSummary
Change-Id: I913c8ecd5f51db851ef408c4281cdd75a0e0b239
jenkins-bot [Sun, 24 Jun 2018 01:47:52 +0000 (01:47 +0000)]
Merge "Make MessageCache::getMsgFromNamespace() process cache hook-defined keys"
jenkins-bot [Sun, 24 Jun 2018 01:41:35 +0000 (01:41 +0000)]
Merge "rdbms: rearrange LoadBalancer fields and make some private"
Aaron Schulz [Thu, 21 Jun 2018 00:58:51 +0000 (01:58 +0100)]
rdbms: rearrange LoadBalancer fields and make some private
Put the object/callback fields first, followed by config fields
and then state fields, similar to LBFactory.
Change-Id: I40ceaa48842b505f15efe5e41ca7a6de437b6ff1
Fomafix [Tue, 27 Dec 2016 21:14:16 +0000 (22:14 +0100)]
Use \u{00A0} instead of   or
Directly use the UTF-8 encoding of the 'NO-BREAK SPACE' (U+00A0) instead of
the HTML/XML entities   or   or .
With the UTF-8 character the generated HTML is shorter and better to read.
Also change the special value for the label in HTMLForm from   to
U+00A0 but also support   for backward compability.
Bug: T154300
Change-Id: I882599ac1120789bb4e524c4394870680caca4f4
Aaron Schulz [Wed, 20 Jun 2018 15:05:08 +0000 (16:05 +0100)]
resourceloader: move using() from mediawiki.js to the base module
Bug: T192623
Change-Id: I9095749a013cf97bff45d6d11afd9b2cee7e189b
Aaron Schulz [Wed, 20 Jun 2018 14:48:32 +0000 (15:48 +0100)]
resourceloader: remove internal use of using() in mediawiki.js
Bug: T192623
Change-Id: Id10ddf9f98661a8e328f40717b12cc08cbc04064
Aaron Schulz [Sat, 23 Jun 2018 16:59:12 +0000 (17:59 +0100)]
Make MessageCache::getMsgFromNamespace() process cache hook-defined keys
Change-Id: I6f8a0c002b54dc48bc3e6902ab1ba41b2f99412a
daniel [Fri, 27 Apr 2018 14:04:36 +0000 (16:04 +0200)]
[MCR] Rollback for all slots
Bug: T194034
Change-Id: Ifd23bc1cd64ddc090e1c1c26aacda37e8ba7a18b
jenkins-bot [Sat, 23 Jun 2018 08:59:37 +0000 (08:59 +0000)]
Merge "Make undo fail if more than just the main slot is affected."
Timo Tijhof [Fri, 22 Jun 2018 18:56:00 +0000 (19:56 +0100)]
mediawiki.hook: Move mw.hook tests to new mediawiki.base.test.js file
Follows-up
3801e54c29a.
Also:
* Split the test into smaller more dedicated tests.
* Make minor changes so as to only assert values in the tests'
outer scope. Assertions within callbacks are an anti-pattern
that is fragile and can easily miss or mask problems. Using a
single state observer that is modified by the callbacks makes
for strict assertions with no implied or untested behaviour.
Callbacks running in a different order or a different number of
times now cause assertion failures - instead of causing the
assertion to not be run, or to be run multiple times, which
would pass.
Bug: T192623
Change-Id: Ice1560b754f8df29ca583eea19f559020fafaf12
jenkins-bot [Fri, 22 Jun 2018 21:36:36 +0000 (21:36 +0000)]
Merge "API: Check assert parameters earlier in the request"
C. Scott Ananian [Thu, 21 Jun 2018 18:53:04 +0000 (14:53 -0400)]
French space armoring: Use unicode regex instead of octal escapes
Follow up to Id8cdb887182f346acab2d108836ce201626848af
Change-Id: I35f7b35746e63a98a115a0dbc9d5869b691c3a9c
jenkins-bot [Fri, 22 Jun 2018 19:09:35 +0000 (19:09 +0000)]
Merge "RCFilters: Fix saved filter name truncation for Firefox"
Moriel Schottlender [Wed, 20 Jun 2018 22:14:23 +0000 (15:14 -0700)]
RCFilters: Fix saved filter name truncation for Firefox
Firefox seem to have a bit of trouble with variable-width flexbox
div that need to be truncated with an ellipses.
This fix includes a couple of changes:
* Split the three elements of the title into three separate divs,
and define the flex divs properly for a variable-width one in
the middle.
* Taking advantage of #1, clean up the class names too (move to
under '-top-xxx' classes for better organization in the LESS
file too.
* Add a max-width: 100% rule to the label that gets
truncated; this seems to force Firefox to recalculate its proper
width while in flexbox and actually add the ellipses.
Bug: T197835
Change-Id: Ibe2002a5fe9006f262b2256cae222fed9e9a8fd0
jenkins-bot [Fri, 22 Jun 2018 14:42:13 +0000 (14:42 +0000)]
Merge "Only use languages with localisation in the installer"
jenkins-bot [Fri, 22 Jun 2018 14:42:07 +0000 (14:42 +0000)]
Merge "MCR: rename $baseRevId paramter to match actual semantics."
daniel [Tue, 19 Jun 2018 17:20:53 +0000 (19:20 +0200)]
Make undo fail if more than just the main slot is affected.
Bug: T194412
Change-Id: Ifdf9bc9d884844f9ffeb8019d9b13d5737862063
daniel [Tue, 19 Jun 2018 14:09:01 +0000 (16:09 +0200)]
MCR: rename $baseRevId paramter to match actual semantics.
The $baseRevId in WikiPage::doEditContent is used only to indicate what
revision an edit reverted to. It is not used to indicate the actual base
revision of an edit in any sense. Specifically, EditPage never sets it.
So, this change renames the parameter to $originalRevId to match $undidRevId.
It also renames PageUpdater::setBaseRevisionId to setOriginalRevisionId.
Further, this introduces a paramter to PageUpdater::hasEditConflict():
Before this change, PageUpdater::hasEditConflict() was based on the
revision set via PageUpdater::setBaseRevisionId(), assuming the semantics
of "base revision" used by EditPage. However, this is NOT how the $baseRevId
parameter in WikiPage works.
Bug: T197685
Change-Id: Ib78257d4d6ee7c4ec093d5706904c599b02c73e0
jenkins-bot [Fri, 22 Jun 2018 01:24:53 +0000 (01:24 +0000)]
Merge "Fix Special:Userrights temp groups with no non-temp groups"
Translation updater bot [Thu, 21 Jun 2018 20:09:18 +0000 (22:09 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: Ibd413089aba90336bcc5bd0be2fdccb78130781c
Brad Jorsch [Thu, 21 Jun 2018 20:08:56 +0000 (16:08 -0400)]
Fix Special:Userrights temp groups with no non-temp groups
Special:Userrights was only checking the count of non-temporary groups
when deciding whether to show the list of temporary and non-temporary
groups. It needs to check both.
Bug: T197860
Change-Id: Ie8a9caad01f1a610584fb4a1272ad3800e9c8e6a
Brad Jorsch [Wed, 20 Jun 2018 14:32:03 +0000 (10:32 -0400)]
API: Check assert parameters earlier in the request
Specifically, check the assert and assertuser parameters before setting
up the action module, so errors in parsing the module's parameters due
to being logged out don't override the client's intended "am I logged
in?" check.
Note this means that assertion failures will no longer use custom module
output formatters. This seems like an acceptable tradeoff: on Wikimedia
sites in May 2018 there were no requests that would have been affected
by this change.
Bug: T197672
Change-Id: I02a71395d5ed9f445e57162f2136292825f8dbb5
Hagar Shilo [Wed, 13 Jun 2018 08:30:23 +0000 (11:30 +0300)]
Align loading animation for first load later reloads
Bug: T192210
Change-Id: Ia058201697889f7d6d8575b9fb8fe5dbb383747a
Fomafix [Thu, 16 Nov 2017 18:37:43 +0000 (19:37 +0100)]
Armor against French spaces detection in HTML attributes
This change also solves T13874 in a generic way.
Bug: T5158
Change-Id: Id8cdb887182f346acab2d108836ce201626848af
tacsipacsi [Mon, 2 Apr 2018 19:15:40 +0000 (21:15 +0200)]
Set $linkTrail for Abkhazian.
Set $linkTrail for Abkhazian. I don't speak the language, just copied
the characters from the referenced Phabricator task.
Bug: T189923
Change-Id: I0db35e9ac46aea19d082c1e9fa35a9120034e4bd
jenkins-bot [Thu, 21 Jun 2018 16:54:50 +0000 (16:54 +0000)]
Merge "RCFilters: Readjust welcome text so results don't jump after load"
jenkins-bot [Thu, 21 Jun 2018 16:15:13 +0000 (16:15 +0000)]
Merge "LanguageConverter: Fix @return description"
Moriel Schottlender [Wed, 20 Jun 2018 21:45:58 +0000 (14:45 -0700)]
RCFilters: Readjust welcome text so results don't jump after load
Bug: T197833
Change-Id: If3a433c84c53d80a4470fbc112b75c00cae20bac
Reedy [Thu, 21 Jun 2018 10:50:54 +0000 (11:50 +0100)]
Remove PageContentSaveComplete hook subscriber that won't work..
Change-Id: Ib68ea80e9db85e79589699cbbc6a731bc37f52a3
Reedy [Thu, 21 Jun 2018 10:50:27 +0000 (11:50 +0100)]
Reduce indenting, remove else conditions
Change-Id: If39ed94f12108dee231ff99dbe740418d192f349
Amir Sarabadani [Thu, 21 Jun 2018 06:59:02 +0000 (08:59 +0200)]
Turning change_tag_def store to a service
This will be useful when reading the table.
Bug: T194162
Change-Id: I8c0a0075910a79465a648a052b4e7fbc888b10e7
Aaron Schulz [Thu, 21 Jun 2018 00:27:49 +0000 (01:27 +0100)]
rdbms: make some LBFactory fields private
Change-Id: I3fbd35048556593e298731cb497cc83335c5ad8e
jenkins-bot [Wed, 20 Jun 2018 22:55:26 +0000 (22:55 +0000)]
Merge "Xhprof: support tideways-xhprof extension"
Translation updater bot [Wed, 20 Jun 2018 20:54:25 +0000 (22:54 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I07213bede472c7fc7f22596703492b8dace4360d
jenkins-bot [Wed, 20 Jun 2018 20:04:10 +0000 (20:04 +0000)]
Merge "Blob can't be false"
jenkins-bot [Wed, 20 Jun 2018 19:39:30 +0000 (19:39 +0000)]
Merge "RCFilters: Preserve collapsed state and adjust display"
jdlrobson [Wed, 20 Jun 2018 00:08:51 +0000 (17:08 -0700)]
Checkboxes should be styled on non-JS browsers
Previously we didn't do this so that checkboxes worked on older
versions of Opera Mini.
This was added 3 years ago
(https://trello.com/c/D2FnYlmf/21-bug-fix-broken-settings-page-on-opera-mini)
https://imgur.com/a/DL6ASy4
This no longer seems to be a problem on more modern versions of
Opera Mini and given how this degrades the experience of more modern
browsers I propose we restore this styling.
Bug: T196947
Change-Id: I5f646b5c939e498eda9bec249658a969f3f91c5d
Moriel Schottlender [Mon, 18 Jun 2018 22:04:47 +0000 (15:04 -0700)]
RCFilters: Preserve collapsed state and adjust display
When collapsed, make sure we are adjusting the 'min-height' on the
'rcfilters-head' div so that it actually takes the space it should.
Make sure the preference of whether the area is collapsed or not is
preserved for the user, per RC or WL pages, and that it is loaded
properly with the correct minimum height dimensions depending on
which state is in the preferences, so to prevent "jump" of the
result list after load.
Bug: T177206
Change-Id: I82c3042cd1bb85dedcd6b5458b157fed94def808
Fomafix [Wed, 20 Jun 2018 16:32:34 +0000 (18:32 +0200)]
LanguageConverter: Fix @return description
validateVariant returns null, not false.
Change-Id: I5241205da9f4d6266f09b361df856e50ddd96a7d
jenkins-bot [Wed, 20 Jun 2018 15:42:39 +0000 (15:42 +0000)]
Merge "objectcache: change "miss" to "renew" in metric name for preemptive refreshes"
daniel [Fri, 12 Jan 2018 15:03:47 +0000 (16:03 +0100)]
Blob can't be false
Change-Id: Ic06fcfaac71128c0ff7e9079685eac18206f2004
jenkins-bot [Wed, 20 Jun 2018 15:30:40 +0000 (15:30 +0000)]
Merge "API: Use param-per-value for meta=filerepoinfo's friprop docs"
Aaron Schulz [Wed, 20 Jun 2018 11:43:10 +0000 (12:43 +0100)]
objectcache: change "miss" to "renew" in metric name for preemptive refreshes
This will usually let one distinguish asynchronous preemptive cache refreshes
from synchronous value recomputations due to actual cache misses.
Change-Id: I3424a89cc96a12fe283460eeaf722ee0cf299534
Brad Jorsch [Wed, 20 Jun 2018 14:08:26 +0000 (10:08 -0400)]
API: Use param-per-value for meta=filerepoinfo's friprop docs
This avoids documenting properties that may not be valid on the local
wiki, depending on which repos are actually available.
This patch also documents the other values available from repo types
available in MediaWiki core.
Bug: T197730
Change-Id: I6bf9fbf4ac29042d9f7524c6c1a5990051150cd3
Niklas Laxström [Sun, 17 Jun 2018 16:26:24 +0000 (18:26 +0200)]
Only use languages with localisation in the installer
To match recent change to Special:Preferences, only allow languages
with localisation as interface or content language.
Bug: T188030
Change-Id: I8acae47ee70feb98bcde982d9b0e3637daf96ffb
jenkins-bot [Wed, 20 Jun 2018 14:06:23 +0000 (14:06 +0000)]
Merge "Improve documentation of fields in EditPage"
jenkins-bot [Wed, 20 Jun 2018 11:45:55 +0000 (11:45 +0000)]
Merge "Selenium: run Wikibase repo tests"
Jakob Warkotsch [Wed, 20 Jun 2018 11:06:45 +0000 (13:06 +0200)]
Browser tests: extract commonly used getTestString function
Extracting this function into a Util module reduces redundancy for
existing and future tests in core and extensions.
Change-Id: I5c5e9b22af5406f347636b22e68657b2674db6c9