From 91a5ea4e5cadc4ffbdbf4fb47a143650921d9d59 Mon Sep 17 00:00:00 2001 From: Alexandre Emsenhuber Date: Tue, 30 Apr 2013 20:51:26 +0200 Subject: [PATCH] Remove LocalisationCache::unloadAll() call from NewParserTest::addDBData() - Localisation cache does not depend on the database, only on the localisation files themselves - the backend is already set to LCStore_Null, so it will not interfere with other caches (CDB, database, etc.) Unloading the whole cache before each test thus only adds overhead without any benefit, and slows down the test suite (this changes allows to win about 20 seconds on my local machine). Change-Id: Ifa36a7135d9f8355e1a10dd49ece806d90f657a2 --- tests/phpunit/includes/parser/NewParserTest.php | 3 --- 1 file changed, 3 deletions(-) diff --git a/tests/phpunit/includes/parser/NewParserTest.php b/tests/phpunit/includes/parser/NewParserTest.php index 994bc1cce6..3449cc73c0 100644 --- a/tests/phpunit/includes/parser/NewParserTest.php +++ b/tests/phpunit/includes/parser/NewParserTest.php @@ -190,9 +190,6 @@ class NewParserTest extends MediaWikiTestCase { __METHOD__ ); - # Reinitialise the LocalisationCache to match the database state - Language::getLocalisationCache()->unloadAll(); - # Clear the message cache MessageCache::singleton()->clear(); -- 2.20.1