From 1418cbbac92efacc9a425aa3243eb49836161986 Mon Sep 17 00:00:00 2001 From: Timo Tijhof Date: Sun, 9 Dec 2018 19:09:43 +0000 Subject: [PATCH] Special:AllMessages: Remove 'id' attribute from message rows This was introduced in r13629 (2006; 17633ab92a4) to allow easy linking to individual results, which predates the pagination feature that was added in r53286 (2009; c90b9b93ecb). This was a hidden feature not exposed througuh the user-interface in any way, and not documented. Removing it should be safe. Any recently crafted permalinks fallback to loading the page containing the message key without jumping to it. Any older permalinks have already been broken for 10 years because pagination would have limited the results returned, likely not included the anchored ID (dead-end fragment). Change-Id: I53bd56e0d5a82fba65388e1c2da3c8349a138261 --- includes/specials/pagers/AllMessagesTablePager.php | 6 ------ 1 file changed, 6 deletions(-) diff --git a/includes/specials/pagers/AllMessagesTablePager.php b/includes/specials/pagers/AllMessagesTablePager.php index 6d5f64b7a2..a9479c4846 100644 --- a/includes/specials/pagers/AllMessagesTablePager.php +++ b/includes/specials/pagers/AllMessagesTablePager.php @@ -372,12 +372,6 @@ class AllMessagesTablePager extends TablePager { $arr['class'] = 'allmessages-customised'; } - if ( !$isSecond ) { - $arr['id'] = Sanitizer::escapeIdForAttribute( - 'msg_' . $this->getLanguage()->lcfirst( $row->am_title ) - ); - } - return $arr; } -- 2.20.1