From: Kunal Mehta <legoktm@member.fsf.org>
Date: Fri, 28 Sep 2018 05:01:28 +0000 (-0700)
Subject: BitmapMetadataHandlerTest: Don't reinvent $this->checkPHPExtension()
X-Git-Tag: 1.34.0-rc.0~3970
X-Git-Url: https://git.cyclocoop.org/%7B%24admin_url%7Dmembres/cotisations/Dunav?a=commitdiff_plain;h=68015d3b91863d6a1e86c306a6d78806622c6d03;p=lhc%2Fweb%2Fwiklou.git

BitmapMetadataHandlerTest: Don't reinvent $this->checkPHPExtension()

Change-Id: I4957ca1be698844bafbf8de64af450cb884ec71a
---

diff --git a/tests/phpunit/includes/media/BitmapMetadataHandlerTest.php b/tests/phpunit/includes/media/BitmapMetadataHandlerTest.php
index a70c005497..83554d28e1 100644
--- a/tests/phpunit/includes/media/BitmapMetadataHandlerTest.php
+++ b/tests/phpunit/includes/media/BitmapMetadataHandlerTest.php
@@ -127,9 +127,8 @@ class BitmapMetadataHandlerTest extends MediaWikiTestCase {
 	 * @covers BitmapMetadataHandler::png
 	 */
 	public function testPNGXMP() {
-		if ( !extension_loaded( 'xml' ) ) {
-			$this->markTestSkipped( "This test needs the xml extension." );
-		}
+		$this->checkPHPExtension( 'xml' );
+
 		$handler = new BitmapMetadataHandler();
 		$result = $handler->PNG( $this->filePath . 'xmp.png' );
 		$expected = [