James D. Forrester [Wed, 13 Jun 2018 19:04:51 +0000 (12:04 -0700)]
INSTALL, UPGRADE: Re-wrap to 80 chars and enforce
Change-Id: Idabcc4db7a0b25448e7ad30641763e2b3e1a3160
jenkins-bot [Tue, 16 Oct 2018 16:17:59 +0000 (16:17 +0000)]
Merge "Update ImportableUploadRevisionImporter for interwiki usernames"
jenkins-bot [Tue, 16 Oct 2018 16:10:24 +0000 (16:10 +0000)]
Merge "Have maintenance/updateExtensionJsonSchema.php copy documentation"
Brad Jorsch [Tue, 16 Oct 2018 15:12:43 +0000 (11:12 -0400)]
Have maintenance/updateExtensionJsonSchema.php copy documentation
It already skips version-1 style documentation keys that begin with "@".
It should also copy them into the "description" metadata key for
version 2.
Change-Id: I460568f074b9c0256eb6bbbcd0b046b16e0d8790
Brad Jorsch [Tue, 16 Oct 2018 14:47:44 +0000 (10:47 -0400)]
Update ImportableUploadRevisionImporter for interwiki usernames
This was somehow missed in I5401941c.
Bug: T206013
Change-Id: Ia618b05329e6cbfca7c95d9161f12ba4150705c8
Brad Jorsch [Tue, 16 Oct 2018 14:22:33 +0000 (10:22 -0400)]
Add session_write_close() calls to SessionManager tests
PHP 7.3 doesn't like it if session_id() is called when the session has
been started, so we need to be sure to close it first in a few tests.
Bug: T207112
Change-Id: Ief36c1bb7b5c9066f158b5bb0d6d785a7f7ddd3c
Amir Sarabadani [Tue, 16 Oct 2018 11:02:45 +0000 (13:02 +0200)]
Avoid fatals when the filter tags is empty
Bug: T194164
Change-Id: I418cbe2259e7c1622a58a4a310a3cd56873f16c3
jenkins-bot [Tue, 16 Oct 2018 05:28:33 +0000 (05:28 +0000)]
Merge "Simplify `list-style` property"
jenkins-bot [Tue, 16 Oct 2018 03:04:06 +0000 (03:04 +0000)]
Merge "Fix warning in doEditSectionLink() caused by not-yet-unstubbed $wgLang"
jenkins-bot [Mon, 15 Oct 2018 23:07:47 +0000 (23:07 +0000)]
Merge "API: Ignore expired blocks in ApiQueryBase::showHiddenUsersAddBlockInfo()"
jenkins-bot [Mon, 15 Oct 2018 22:34:25 +0000 (22:34 +0000)]
Merge "LocalisationCache: Avoid use of compact()"
jenkins-bot [Mon, 15 Oct 2018 22:34:20 +0000 (22:34 +0000)]
Merge "API: Remove long-deprecated methods (and one class)"
jenkins-bot [Mon, 15 Oct 2018 21:48:29 +0000 (21:48 +0000)]
Merge "CREDITS: Bump for 1.32.0 release"
Brad Jorsch [Wed, 10 Oct 2018 17:55:09 +0000 (13:55 -0400)]
API: Remove long-deprecated methods (and one class)
* ApiBase::profileIn() (deprecated in 1.25)
* ApiBase::profileOut() (deprecated in 1.25)
* ApiBase::safeProfileOut() (deprecated in 1.25)
* ApiBase::profileDBIn() (deprecated in 1.25)
* ApiBase::profileDBOut() (deprecated in 1.25)
* ApiBase::dieUsage() (deprecated in 1.29)
* ApiBase::dieUsageMsg() (deprecated in 1.29)
* ApiBase::dieUsageMsgOrDebug() (deprecated in 1.29)
* ApiBase::getErrorFromStatus() (deprecated in 1.29)
* ApiBase::parseMsg() (deprecated in 1.29)
* ApiBase::setWarning() (deprecated in 1.29)
* ApiPageSet::getInvalidTitles() (deprecated in 1.26)
* ApiQueryLogEvents::addLogParams() (deprecated in 1.25)
* ApiUsageException::getCodeString() (deprecated in 1.29)
* ApiUsageException::getMessageArray() (deprecated in 1.29)
* UsageException (deprecated in 1.29)
Change-Id: Iabb2589a29cc3b46624d31358f3a6bf7b3ccbd57
Kunal Mehta [Mon, 15 Oct 2018 07:17:38 +0000 (00:17 -0700)]
LocalisationCache: Avoid use of compact()
In PHP 7.3, compact() now raises notices if the variable is undefined, which
is something that we expect. So we can check whether the key exists instead
of bothering with compat() and suppressing warnings.
Bug: T206979
Change-Id: I612049db4debd850a2e6d10bc631d31aa17be898
Edward Chernenko [Mon, 15 Oct 2018 01:39:29 +0000 (04:39 +0300)]
Fix warning in doEditSectionLink() caused by not-yet-unstubbed $wgLang
In ParserOutput::getText(), $wgLang can be a StubUserLang object,
which causes a typecheck warning in doEditSectionLink().
Solution is to replace $wgLang with $context->getLanguage(),
which is always a Language object.
Change-Id: I9945e1615c3f1b7ed5c7897b9f67d7ca0450ee50
Volker E [Mon, 15 Oct 2018 20:03:13 +0000 (13:03 -0700)]
Simplify `list-style` property
Using `none none` value is also working on older IEs, which had
issues with shorthand only `list-style: none`.
Change-Id: I7d4b075ac90fd902e0c0fbc3e11449faf71fe9b2
Translation updater bot [Mon, 15 Oct 2018 19:57:04 +0000 (21:57 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I4b631605549ac3599ca01d59fa69e35fad6c879e
James D. Forrester [Fri, 12 Oct 2018 17:31:55 +0000 (10:31 -0700)]
CREDITS: Bump for 1.32.0 release
Change-Id: I2187346003a53874c559fcfe23ee94d822829794
RazeSoldier [Mon, 15 Oct 2018 15:58:26 +0000 (23:58 +0800)]
Use "break" instead of "continue" inside a switch
"continue" statements in a switch are equivalent to "break". In PHP 7.3, will generate a warning.
Bug: T206974
Change-Id: I54bcec013ff52ab81bff09f8f7ef02f3944a5b7d
Brad Jorsch [Mon, 15 Oct 2018 15:21:44 +0000 (11:21 -0400)]
API: Ignore expired blocks in ApiQueryBase::showHiddenUsersAddBlockInfo()
This probably went unnoticed for so long because expired blocks are
regularly cleared as long as new blocks continue being issued, so people
found that the problem "fixed" itself.
Bug: T206944
Change-Id: I6559e1ec23f4469d19684b4d931913acbccb56d4
jenkins-bot [Mon, 15 Oct 2018 14:19:43 +0000 (14:19 +0000)]
Merge "EmailNotification: Add newline before minor edit text"
jenkins-bot [Mon, 15 Oct 2018 14:07:14 +0000 (14:07 +0000)]
Merge "resources: Register jquery.client as foreign resource and update to v2.0.1"
jenkins-bot [Mon, 15 Oct 2018 13:48:07 +0000 (13:48 +0000)]
Merge "Add MessagesShn.php"
Martin Urbanec [Sun, 14 Oct 2018 18:02:26 +0000 (20:02 +0200)]
Add MessagesShn.php
This localizes:
* namespaces
* special page names
Bug: T206917
Bug: T206921
Change-Id: I0d27746aca56849056098ffffa866954d97f133d
Timo Tijhof [Mon, 15 Oct 2018 02:27:41 +0000 (03:27 +0100)]
resources: Register jquery.client as foreign resource and update to v2.0.1
Change-Id: Iec6414a1675dec4aeb5d9b66635d28670f094e42
Translation updater bot [Sun, 14 Oct 2018 19:54:50 +0000 (21:54 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I27647ca9376c400143ba52074322c4b50960db53
MGChecker [Sun, 14 Oct 2018 18:28:54 +0000 (20:28 +0200)]
docs: Remove outdated information from globals.txt
design.txt doesn't exist anymore.
Bug: T111283
Change-Id: Ibb67fb721060b325114e571ba3e470a607d98884
jenkins-bot [Sat, 13 Oct 2018 23:59:35 +0000 (23:59 +0000)]
Merge "jobqueue: clean up JobQueueDB::getCacheKey() to use makeGlobalKey()"
Translation updater bot [Sat, 13 Oct 2018 07:49:22 +0000 (09:49 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I5958a3381bd070c1cb7d79e6819b638418b87165
Aaron Schulz [Sat, 13 Oct 2018 07:14:38 +0000 (00:14 -0700)]
jobqueue: clean up JobQueueDB::getCacheKey() to use makeGlobalKey()
Change-Id: I341720fda0d242c7822f78048cb49f63538d08bc
Kunal Mehta [Sat, 13 Oct 2018 06:47:42 +0000 (23:47 -0700)]
travis: Remove PHP 7.2 from allowed failures
It's now passing!
Bug: T204884
Change-Id: Idb17630cff54b803ca5fa942b2fcf17a775edd0d
jenkins-bot [Sat, 13 Oct 2018 06:29:17 +0000 (06:29 +0000)]
Merge "Output only to stderr in unit tests"
jenkins-bot [Sat, 13 Oct 2018 05:27:16 +0000 (05:27 +0000)]
Merge "SlotDiffRenderer: add utility method for parameter type checks"
jenkins-bot [Sat, 13 Oct 2018 05:23:43 +0000 (05:23 +0000)]
Merge "Linker: Document parseComment() as returning HTML"
jenkins-bot [Sat, 13 Oct 2018 01:45:09 +0000 (01:45 +0000)]
Merge "Log startAtomic()/endAtomic() to the query logger"
Tim Starling [Wed, 10 Oct 2018 04:03:21 +0000 (15:03 +1100)]
Log startAtomic()/endAtomic() to the query logger
Change-Id: Ife7e292ef42946ec1c5e9121b7be6a90301b3903
jenkins-bot [Sat, 13 Oct 2018 00:58:16 +0000 (00:58 +0000)]
Merge "exception: Correct label "Notice" for E_USER_NOTICE, not "Warning""
jenkins-bot [Sat, 13 Oct 2018 00:58:11 +0000 (00:58 +0000)]
Merge "Revert "rdbms: add domain sanity checks to LoadBalancer connection methods""
Krinkle [Sat, 13 Oct 2018 00:35:55 +0000 (00:35 +0000)]
Revert "rdbms: add domain sanity checks to LoadBalancer connection methods"
This reverts commit
b416e166a3eba1dcfc2e912e37e443981d7f60ef.
Fails on Travis CI / PHP 7.1 / Postgres:
> Creating administrator user account
>
> UnexpectedValueException:
> Got connection to 'traviswiki-mediawiki', but expected 'traviswiki'.
>
> Backtrace:
> #0 includes/libs/rdbms/loadbalancer/LoadBalancer.php(887): Wikimedia\Rdbms\LoadBalancer->openForeignConnection(integer, string, integer)
> #1 includes/libs/rdbms/loadbalancer/LoadBalancer.php(766): Wikimedia\Rdbms\LoadBalancer->openConnection(integer, string, integer)
> #2 includes/libs/rdbms/loadbalancer/LoadBalancer.php(851): Wikimedia\Rdbms\LoadBalancer->getConnection(integer, array, string, integer)
> #3 includes/jobqueue/JobQueueDB.php(780): Wikimedia\Rdbms\LoadBalancer->getConnectionRef(integer, array, string, integer)
> #4 includes/jobqueue/JobQueueDB.php(761): JobQueueDB->getDB(integer)
> #5 includes/jobqueue/JobQueueDB.php(187): JobQueueDB->getMasterDB()
> #6 includes/jobqueue/JobQueue.php(332): JobQueueDB->doBatchPush(array, integer)
> #7 includes/jobqueue/JobQueue.php(302): JobQueue->batchPush(array, integer)
> #8 includes/jobqueue/JobQueueGroup.php(154): JobQueue->push(array)
> #9 includes/user/UserGroupMembership.php(162): JobQueueGroup->push(array)
> #10 includes/user/User.php(3733): UserGroupMembership->insert(boolean)
> #11 includes/installer/Installer.php(1680): User->addGroup(string)
> #12 includes/installer/Installer.php(1601): Installer->createSysop(PostgresInstaller)
> #13 includes/installer/CliInstaller.php(176): Installer->performInstallation(array, array)
Change-Id: I269df89d47cc5a183af630447cd1642d3d4a3deb
Krinkle [Sat, 13 Oct 2018 00:08:28 +0000 (00:08 +0000)]
Merge "rdbms: add domain sanity checks to LoadBalancer connection methods"
jenkins-bot [Fri, 12 Oct 2018 22:35:49 +0000 (22:35 +0000)]
Merge "Avoid global $wgUpdateRowsPerQuery in WatchedItemStore"
jenkins-bot [Fri, 12 Oct 2018 22:30:59 +0000 (22:30 +0000)]
Merge "Add OOUI for HTMLFormFieldCloner"
Roan Kattouw [Fri, 12 Oct 2018 22:18:03 +0000 (15:18 -0700)]
Linker: Document parseComment() as returning HTML
It's not entirely clear from the documentation whether this method
returns wikitext or HTML, so make it explicit.
Change-Id: I094e370e921c43dd8c5dc4376b3dddd803665d90
jenkins-bot [Fri, 12 Oct 2018 21:48:54 +0000 (21:48 +0000)]
Merge "Pass LBFactory to WatchedItemStore"
jenkins-bot [Fri, 12 Oct 2018 18:59:28 +0000 (18:59 +0000)]
Merge "HtmlTest: Perform multilingual tests"
jenkins-bot [Fri, 12 Oct 2018 18:34:02 +0000 (18:34 +0000)]
Merge "Use a ScopedCallback to silence transaction profiler in SqlBagOStuff"
Erik Bernhardson [Fri, 12 Oct 2018 18:23:02 +0000 (11:23 -0700)]
HtmlTest: Perform multilingual tests
The tests here were only testing when user and content language
are the same, but the way things are rendered when they differ
is perhaps more interesting as it allows ensuring the two are used
in the correct places.
Change-Id: I357f50b082882fee485a95323d3a0a7cadb9a63c
Umherirrender [Sat, 22 Sep 2018 12:38:02 +0000 (14:38 +0200)]
Use a ScopedCallback to silence transaction profiler in SqlBagOStuff
This affects most LCStoreDB which is the default cache
and spamming the log.
Bug: T154424
Bug: T97693
Change-Id: I68af177c7d0d88ab266eb3fefb4336eff86d861c
C. Scott Ananian [Fri, 12 Oct 2018 15:50:14 +0000 (11:50 -0400)]
Deprecate $wgUseKeyHeader and OutputPage::getKeyHeader()
The `Key` header was a draft IETF specification which expired without
becoming a standard. It does not appear to be in active use anywhere.
Change-Id: I3924a1b5ff428b107573d2827c40e4af8adaaeb1
Umherirrender [Thu, 11 Oct 2018 19:13:35 +0000 (21:13 +0200)]
Avoid global $wgUpdateRowsPerQuery in WatchedItemStore
Change-Id: Ibff69d16919a595c3edb8e2b431aa42d84a2777a
Umherirrender [Thu, 11 Oct 2018 19:11:43 +0000 (21:11 +0200)]
Pass LBFactory to WatchedItemStore
Instead of passing the LoadBalancer and than get the LBFactory from the
service,
store the LBFactory on creation
Bug: T206601
Change-Id: I4c0d3712da591b2c5ddf2a65855d2cc9142417d2
Timo Tijhof [Fri, 12 Oct 2018 04:05:16 +0000 (05:05 +0100)]
exception: Correct label "Notice" for E_USER_NOTICE, not "Warning"
Follows-up
ef06b528d9, which fixed the severity of all PHP errors
to have severity "Warning" or higher.
However, it also accidentally changed the label of "Notice"
to "Warning", which is confusing and incorrect.
Change-Id: Iffd39aa23b7f2cbff5cdaf876b8d4d595dcd6f96
Aaron Schulz [Wed, 15 Aug 2018 02:24:37 +0000 (19:24 -0700)]
rdbms: add domain sanity checks to LoadBalancer connection methods
Bug: T193565
Change-Id: I94d905277e01b8e30ac3f6532ece07388bb20cce
jenkins-bot [Fri, 12 Oct 2018 01:13:29 +0000 (01:13 +0000)]
Merge "Make MergeableUpdate jobs avoid the sub-queue so they can always merge"
jenkins-bot [Fri, 12 Oct 2018 00:58:59 +0000 (00:58 +0000)]
Merge "Make merged MergeableUpdate items always go to the end of the queue"
jenkins-bot [Fri, 12 Oct 2018 00:58:54 +0000 (00:58 +0000)]
Merge "Fix Setup.php file-scope test"
Aaron Schulz [Thu, 11 Oct 2018 22:11:50 +0000 (15:11 -0700)]
Make MergeableUpdate jobs avoid the sub-queue so they can always merge
Change-Id: I5b100fae29b785ab4524d165dad2e8ee46406b0c
Aryeh Gregor [Thu, 2 Aug 2018 18:42:17 +0000 (21:42 +0300)]
Increase OutputPage test coverage to >45%
Also stop returning a value from OutputPage::adaptCdnTTL(). There are
no users and the value doesn't seem very helpful: one would probably
expect it to return the new value of mCdnMaxage, but instead it
returns the new value of mCdnMaxageLimit. Better to have no return
value than one that's easily misunderstood (*and* which nobody uses).
Change-Id: Ia9dab86923b839334eab9f6fde17c4aed52130ec
jenkins-bot [Thu, 11 Oct 2018 22:11:53 +0000 (22:11 +0000)]
Merge "Add join conditions to ActiveUsersPager"
jenkins-bot [Thu, 11 Oct 2018 22:11:47 +0000 (22:11 +0000)]
Merge "resourceloader: Throw exception when config serialization fails"
Aaron Schulz [Thu, 11 Oct 2018 21:51:36 +0000 (14:51 -0700)]
Make merged MergeableUpdate items always go to the end of the queue
Change-Id: I2e8aa28f7426470d9b8b9e11b902deea793069b3
Roan Kattouw [Tue, 9 Oct 2018 20:43:56 +0000 (13:43 -0700)]
resourceloader: Throw exception when config serialization fails
If something puts a string that's invalid UTF-8 in a JS config variable,
JSON serialization will fail on the entire config blob. Currently, this
causes the entire config blob to be silently dropped, which breaks all
JavaScript because elementary variables like wgPageName are missing.
This change makes this scenario fail loudly rather than quietly, by
throwing an exception. This also makes bugs like these easier to track
down.
Bug: T206475
Change-Id: Ief2ae00228389a23627d440dc1cd9a54cf2b6926
jenkins-bot [Thu, 11 Oct 2018 20:56:33 +0000 (20:56 +0000)]
Merge "MessageCache: replace should actually replace, not reload"
jenkins-bot [Thu, 11 Oct 2018 20:46:47 +0000 (20:46 +0000)]
Merge "Localisation updates from https://translatewiki.net."
jenkins-bot [Thu, 11 Oct 2018 20:46:42 +0000 (20:46 +0000)]
Merge "Accept BCP 47 codes as aliases for nonstandard variants"
jenkins-bot [Thu, 11 Oct 2018 20:46:35 +0000 (20:46 +0000)]
Merge "Ensure LanguageCode::bcp47() returns a valid BCP 47 language code"
Translation updater bot [Thu, 11 Oct 2018 20:14:07 +0000 (22:14 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I17af87ea492359cd0c09dc3c62af8caa8755368a
Aaron Schulz [Thu, 11 Oct 2018 17:39:05 +0000 (10:39 -0700)]
Split out getSlotParserOutputUncached() method for the sake of profiling
Change-Id: I553dba13486982b4530d290c84dc1f53b4df6ff9
jenkins-bot [Thu, 11 Oct 2018 19:52:13 +0000 (19:52 +0000)]
Merge "Allow and use type Language instead of string for $lang of doEditSectionLink"
jenkins-bot [Thu, 11 Oct 2018 19:52:02 +0000 (19:52 +0000)]
Merge ".mailmap: Add a few new entries"
jenkins-bot [Thu, 11 Oct 2018 19:47:10 +0000 (19:47 +0000)]
Merge "Drop ParserLimitReport, deprecated in 1.22"
jenkins-bot [Thu, 11 Oct 2018 19:44:16 +0000 (19:44 +0000)]
Merge "Drop UnknownAction, deprecated in 1.19(!)"
jenkins-bot [Thu, 11 Oct 2018 19:41:18 +0000 (19:41 +0000)]
Merge "Drop wfRunHooks, deprecated since 1.25"
jenkins-bot [Thu, 11 Oct 2018 19:41:13 +0000 (19:41 +0000)]
Merge "Drop UserGetImplictGroups, deprecated since 1.25"
Brad Jorsch [Fri, 21 Sep 2018 18:32:34 +0000 (14:32 -0400)]
Add join conditions to ActiveUsersPager
We're (very slowly and somewhat unofficially) moving towards using join
conditions everywhere, and here they're needed to avoid errors once the
actor migration reaches the READ_NEW stage.
Bug: T204767
Change-Id: I8bfe861fac7874f8938bed9bfac3b7ec6f478238
jenkins-bot [Thu, 11 Oct 2018 19:27:39 +0000 (19:27 +0000)]
Merge "Drop DoEditSectionLink, deprecated since 1.25"
jenkins-bot [Thu, 11 Oct 2018 19:05:51 +0000 (19:05 +0000)]
Merge "tests: Add helper function for ini_set with automatic cleanup"
jenkins-bot [Thu, 11 Oct 2018 18:59:34 +0000 (18:59 +0000)]
Merge "Load installer i18n when running update.php"
jenkins-bot [Thu, 11 Oct 2018 18:59:24 +0000 (18:59 +0000)]
Merge "messagecache: avoid caching message pages that do not override"
jenkins-bot [Thu, 11 Oct 2018 18:32:40 +0000 (18:32 +0000)]
Merge "Do not retry the ThumbnailRenderJob."
Reedy [Thu, 11 Oct 2018 18:20:30 +0000 (19:20 +0100)]
Load installer i18n when running update.php
Bug: T206765
Change-Id: Ie1c1a5dbf7c905eaca55777448e5aba00267ed31
jenkins-bot [Thu, 11 Oct 2018 18:11:55 +0000 (18:11 +0000)]
Merge "Revert "Unwrap HTML loaded from parser cache""
James D. Forrester [Wed, 10 Oct 2018 23:34:43 +0000 (16:34 -0700)]
.mailmap: Add a few new entries
Change-Id: Iaacd5eff9c01ae9c03cf002a5063cae78cfb9e37
Fomafix [Wed, 30 May 2018 04:33:01 +0000 (06:33 +0200)]
Allow and use type Language instead of string for $lang of doEditSectionLink
Hard-deprecate that the parameters $tooltip and $lang are optional.
Hard-deprecate other types than Language for parameter $lang.
Change-Id: I3ce048e3d0de9a4e96e2aa05d75a4ce41c3ec964
Depends-On: Ibe295e7020e995eea52e319feaf59c635f8bb4dc
Petr Pchelko [Thu, 11 Oct 2018 15:19:41 +0000 (08:19 -0700)]
Do not retry the ThumbnailRenderJob.
The job is a warmup for the thumbnail cache, so loosing it is not
an issue. Most of the times thumbnail rendering fails because of
non-renderable or broken images, or because the thumbnail was
already created by a request. These conditions will not be fixed
by retrying, will only create more load on Thumbor.
Bug: T203135
Change-Id: Ib4640eb13ca93f7350ff0671fc559a76ebbbb1e9
Brad Jorsch [Wed, 26 Sep 2018 16:56:58 +0000 (12:56 -0400)]
MessageCache: replace should actually replace, not reload
Prior to I462554b30, MessageCache::replace() did just that: it took the
existing cache and updated the one entry.
In I462554b30, the rearrangement of work into a DeferredUpdate
introduced a bug: the in-process cache was updated, but when the shared
cache was loaded later the entry was never updated in there so the
shared caches kept the old value. This was found in code review and
worked around by reloading all the messages from the database instead of
updating the existing cache.
But all that extra work reloading everything from the database causes
major slowness saving any MediaWiki-namespace page when the wiki has
many such small pages. Let's go back and fix the bug so replace() can
again replace instead of reloading everything.
Bug: T203925
Change-Id: Ife8e1bd6f143f480eb8da09b817c85aadf33a923
C. Scott Ananian [Thu, 11 Oct 2018 13:05:05 +0000 (09:05 -0400)]
Only expand `{{...}}` in messages once
If we're going to call `OutputPage::addWikiText` to parse the message,
we don't need to pre-expand `{{...}}` markup before passing it to the
parser. This makes these callsites consistent with how
`OutputPage::addWikiMsg()` inserts messages.
Bug: T206574
Change-Id: I2f68f73365df876e6f9d017e4e3ddea39c4a1284
jenkins-bot [Thu, 11 Oct 2018 07:44:08 +0000 (07:44 +0000)]
Merge "Drop File / MediaHandler::getStreamHeaders(), deprecated since 1.30"
jenkins-bot [Thu, 11 Oct 2018 07:44:02 +0000 (07:44 +0000)]
Merge "Drop DeferredUpdates::setImmediateMode(), deprecated since 1.29"
jenkins-bot [Thu, 11 Oct 2018 07:36:20 +0000 (07:36 +0000)]
Merge "Drop ChangesListSpecialPageFilters, deprecated in 1.29 and uncalled"
C. Scott Ananian [Tue, 3 Jul 2018 20:12:38 +0000 (16:12 -0400)]
Accept BCP 47 codes as aliases for nonstandard variants
The browser Accept-Language header uses BCP 47 codes, which don't
precisely match our internal mediawiki variant names in a number of
places. Allow proper BCP 47 codes to alias our internal variants
for: Accept-Language parsing, URL parsing, user preferences, and
explicit enumeration of codes in LanguageConverter rules.
This is a replay of an earlier merged patch,
0818070c59eb4e8330496796b943951c01c7a573, which had to be reverted
because it was based on
8380f0173e79b66f0e2afd6c49cd88afb9f4f6f3 which
caused regressions in the Babel extension (T199941).
Change-Id: Ica89d9547c58967747ab0fa15d4e83be5378796d
C. Scott Ananian [Tue, 26 Jun 2018 20:39:57 +0000 (16:39 -0400)]
Ensure LanguageCode::bcp47() returns a valid BCP 47 language code
MediaWiki uses a number of nonstandard codes which do not validate
according to the IANA language subtag registry. Some of them have
the wrong semantics entirely: MediaWiki's `sr-ec` variant maps to
BCP 47 `sr-EC` which is "Serbian as used in Ethiopia" (!).
Extend LanguageCode::bcp47() to map our nonstandard codes to valid
BCP 47 language codes. Export the mapping so that it can be used
in JavaScript's corresponding mw.language.bcp47() implementation
as well, and return the standard BCP 47 codes in the siteinfo
API.
Thanks to TheDJ (I10b4473c7e53f027812bbccf26bb47aec15fddfd) and
Fomafix (I93efc190714ba76247d30ba49fc21ae872fc3555) for previous
attempts at this!
Also removed a fixme for the name of 'Twi', dating back to 2004
(
f59c3be23b209e178a917cb14ebedcc243c847b6) -- checking
tw.wikipedia.org it certainly appears that the autonym of 'Twi'
is correctly 'Twi'.
Tracking bugs for invalid language codes are T125073 and T145535.
Discussion of zh-XX => zh-HanX-XX mapping is at T198419.
This is a replay of an earlier merged patch,
8380f0173e79b66f0e2afd6c49cd88afb9f4f6f3, which had to be reverted
because it caused regressions in the Babel extension (T199941).
Bug: T34483
Bug: T106367
Bug: T120847
Depends-On: I27a5b8e45b34c6b57c1b612b11548001c88cd483
Change-Id: Iebbc604af21d7f2af9c1f1ab2574cb5f309bf6ed
jenkins-bot [Thu, 11 Oct 2018 05:34:33 +0000 (05:34 +0000)]
Merge "install.php: Allow extensions and skins to be specified"
Kunal Mehta [Thu, 11 Oct 2018 05:31:37 +0000 (22:31 -0700)]
tests: Add helper function for ini_set with automatic cleanup
Some tests need to change the value of an ini setting, and typically implement
cleanup handling themselves, usually imperfectly.
Provide a helper function, $this->setIniSetting(), which will take care of
teardown in the same way that $this->setMwGlobals() does.
Change-Id: I7be4198592f0aaf73a28d3c60acb307a918b1a1f
jenkins-bot [Thu, 11 Oct 2018 05:30:09 +0000 (05:30 +0000)]
Merge "Hard-deprecate hooks APIGetDescription and APIGetParamDescription"
jenkins-bot [Thu, 11 Oct 2018 01:54:19 +0000 (01:54 +0000)]
Merge "WikiPage: Fix viewing of wiki redirects to NS_MEDIA"
Alex Ezell [Tue, 9 Oct 2018 15:51:04 +0000 (11:51 -0400)]
WikiPage: Fix viewing of wiki redirects to NS_MEDIA
If a user creates a redirect to a Media namespace title, a fatal
error is thrown on viewing such rediect because we protect against
redirecting to virtual namespaces. This fix catches this kind of
redirect and modifies the namespace to be File before the Title object
is created.
Follow-up from
613e2699.
Bug: T203942
Change-Id: Ib211d98498f635862fea6bf3e7395f4f8718b3d8
Brad Jorsch [Tue, 18 Sep 2018 18:21:20 +0000 (14:21 -0400)]
ActorMigration: Remove possibility of read-both
When this was originally written, the plan was to read both the old and
new fields during the transition period, while stopping writes to them
midway through. It turns out that the WHERE conditions to do read-both
correctly are generally not handled well by the database and working
around that would require a lot of complicated code (see what's being
removed from ApiQueryUserContribs here, for example).
We can simplify things greatly by instead having it write both fields
during the transition period, reading from the old for the first part
and the new for the second part, as is being done for MCR.
Bug: T204669
Change-Id: I4764c1c7883dc1003cb12729455c8107319f70b1
Depends-On: I845f6ae462f2539ebd35cbb5f2ca8b5714e2c1fb
Depends-On: I88b31b977543fdbdf69f8c1158e77e448df94e11
Bartosz Dziewoński [Tue, 2 Oct 2018 21:22:00 +0000 (23:22 +0200)]
HTMLInfoField: Undo breaking change, deprecate instead, add release notes
Follow-up to
e6eb87ae2028d9d3f9317d75cced42511ed97b9e.
Bug: T203202
Bug: T205956
Change-Id: I2d19d376d218c59e4ea36e8635e883afac2adea6