From: Stephane Bisson <sbisson@wikimedia.org>
Date: Mon, 27 Mar 2017 19:34:39 +0000 (-0400)
Subject: rcfilters: Avoid $.type()
X-Git-Tag: 1.31.0-rc.0~3692^2
X-Git-Url: https://git.cyclocoop.org/%7B%24admin_url%7Dmembres/%7B%7B%20url_for%28%27vote%27%2C%20idvote=vote.voteid%29%20%7D%7D?a=commitdiff_plain;h=8cef87f3e1b0effe5b4616c69f19383605c0e00e;p=lhc%2Fweb%2Fwiklou.git

rcfilters: Avoid $.type()

Followup to I9a0c5e40b813e075ec33eea882b625dc43a15df6

Replace $.type() with typeof or Array.isArray

Change-Id: I4f0f717c345ab1279b626b158b0ed6ada056bbc1
---

diff --git a/resources/src/mediawiki.rcfilters/mw.rcfilters.Controller.js b/resources/src/mediawiki.rcfilters/mw.rcfilters.Controller.js
index 14eabe2e04..7405baef3f 100644
--- a/resources/src/mediawiki.rcfilters/mw.rcfilters.Controller.js
+++ b/resources/src/mediawiki.rcfilters/mw.rcfilters.Controller.js
@@ -321,8 +321,8 @@
 	 * @param {array|object|string} filters
 	 */
 	mw.rcfilters.Controller.prototype.trackHighlight = function ( action, filters ) {
-		filters = $.type( filters ) === 'string' ? { name: filters } : filters;
-		filters = $.type( filters ) === 'object' ? [ filters ] : filters;
+		filters = typeof filters === 'string' ? { name: filters } : filters;
+		filters = !Array.isArray( filters ) ? [ filters ] : filters;
 		mw.track(
 			'event.ChangesListHighlights',
 			{