From: Brad Jorsch <bjorsch@wikimedia.org>
Date: Fri, 23 Feb 2018 18:25:10 +0000 (-0500)
Subject: Force READ_LATEST for User::newFromId() if writes had been done
X-Git-Tag: 1.31.0-rc.0~514
X-Git-Url: https://git.cyclocoop.org/%7B%24admin_url%7Dmembres/%24wgLogo?a=commitdiff_plain;h=e93841a621cadfdbbccd0b5f6a34c9b77e51ec3d;p=lhc%2Fweb%2Fwiklou.git

Force READ_LATEST for User::newFromId() if writes had been done

The User::newFromName() case already does this, there seems to be no
reason not to do it for User::newFromId() too.

Bug: T188014
Change-Id: Ic7fdef0cc1f5750cb5e6b2a7f48f1549862b41cb
---

diff --git a/includes/user/User.php b/includes/user/User.php
index c614111a84..b5106ed631 100644
--- a/includes/user/User.php
+++ b/includes/user/User.php
@@ -406,6 +406,15 @@ class User implements IDBAccessObject, UserIdentity {
 				}
 				break;
 			case 'id':
+				// Make sure this thread sees its own changes, if the ID isn't 0
+				if ( $this->mId != 0 ) {
+					$lb = MediaWikiServices::getInstance()->getDBLoadBalancer();
+					if ( $lb->hasOrMadeRecentMasterChanges() ) {
+						$flags |= self::READ_LATEST;
+						$this->queryFlagsUsed = $flags;
+					}
+				}
+
 				$this->loadFromId( $flags );
 				break;
 			case 'actor':