From ebec47ca248fb741c36d74c4f6b5730c9cddef83 Mon Sep 17 00:00:00 2001 From: Aaron Schulz Date: Sun, 25 Aug 2019 23:04:24 -0700 Subject: [PATCH] rdbms: simplify comment in LoadBalancer::reuseConnection() Change-Id: Ie6ea6ac7617b1f026b0ee7b8b76c287ec0da9e34 --- includes/libs/rdbms/loadbalancer/LoadBalancer.php | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/includes/libs/rdbms/loadbalancer/LoadBalancer.php b/includes/libs/rdbms/loadbalancer/LoadBalancer.php index 5c172d653d..ba0f757128 100644 --- a/includes/libs/rdbms/loadbalancer/LoadBalancer.php +++ b/includes/libs/rdbms/loadbalancer/LoadBalancer.php @@ -970,17 +970,7 @@ class LoadBalancer implements ILoadBalancer { $serverIndex = $conn->getLBInfo( 'serverIndex' ); $refCount = $conn->getLBInfo( 'foreignPoolRefCount' ); if ( $serverIndex === null || $refCount === null ) { - /** - * This can happen in code like: - * foreach ( $dbs as $db ) { - * $conn = $lb->getConnection( $lb::DB_REPLICA, [], $db ); - * ... - * $lb->reuseConnection( $conn ); - * } - * When a connection to the local DB is opened in this way, reuseConnection() - * should be ignored - */ - return; + return; // non-foreign connection; no domain-use tracking to update } elseif ( $conn instanceof DBConnRef ) { // DBConnRef already handles calling reuseConnection() and only passes the live // Database instance to this method. Any caller passing in a DBConnRef is broken. -- 2.20.1