jenkins-bot [Mon, 25 Aug 2014 09:51:15 +0000 (09:51 +0000)]
Merge "Add some @see to doc blocks"
jenkins-bot [Mon, 25 Aug 2014 09:48:14 +0000 (09:48 +0000)]
Merge "Do not return anything on __construct"
jenkins-bot [Mon, 25 Aug 2014 09:47:39 +0000 (09:47 +0000)]
Merge "Add missing @return to function docs"
jenkins-bot [Mon, 25 Aug 2014 09:46:47 +0000 (09:46 +0000)]
Merge "Remove double @return from User::isAllowedAny"
jenkins-bot [Mon, 25 Aug 2014 06:20:30 +0000 (06:20 +0000)]
Merge "Remove useNew (no longer any effect) from qqq messages"
jenkins-bot [Mon, 25 Aug 2014 05:25:07 +0000 (05:25 +0000)]
Merge "Deprecate $wgDeferredUpdateList"
Matthew Flaschen [Mon, 25 Aug 2014 04:00:35 +0000 (00:00 -0400)]
Remove useNew (no longer any effect) from qqq messages
Change-Id: I6b09efe28db2d61d55d1a79a801207f3e371777f
Kunal Mehta [Sun, 24 Aug 2014 22:09:01 +0000 (15:09 -0700)]
Update findHooks.php and move MonoBook hook out of docs/hooks.txt
Added includes/skins/ to the list of directories and removed
the skins that were moved out of core.
The MonoBook hook is moved to skins/MonoBook in Ieb85b4bed.
Change-Id: Ie8ad1eb694575b8e1485177e2d14f2a9dcab179d
umherirrender [Sun, 24 Aug 2014 09:29:45 +0000 (11:29 +0200)]
Do not return anything on __construct
Change-Id: I47f67ed17112af832b19f7e7538cae3e0b8354ef
umherirrender [Sun, 24 Aug 2014 09:19:32 +0000 (11:19 +0200)]
Add some @see to doc blocks
This avoids repeating the @params for the functions
Change-Id: Ie1f4488a0a7aa30ab128b9ea7ff6f3af12a88884
umherirrender [Sun, 24 Aug 2014 09:05:16 +0000 (11:05 +0200)]
Remove double @return from User::isAllowedAny
And fix the @param for the varargs
Change-Id: Idb9b3037bb6cbb41e01432a278695d6a29008edd
Kunal Mehta [Sun, 24 Aug 2014 05:41:26 +0000 (22:41 -0700)]
Deprecate $wgDeferredUpdateList
Callers should instead use DeferredUpdates::addUpdate. The
function is superior because it is able to enforce type-hinting
rather than throwing a fatal error. Also it's not a global :)
The only extension still using the global is FlaggedRevs,
for which I've submitted I1a7c6540b2.
Change-Id: Ic59c90c0d0131039295bd785280dc70ebde6e40f
jenkins-bot [Sun, 24 Aug 2014 04:39:47 +0000 (04:39 +0000)]
Merge "Apply csshelpclass to vform help"
Matthew Flaschen [Sun, 24 Aug 2014 01:12:26 +0000 (21:12 -0400)]
Fix regression: Allow HTML as checkbox label in HTMLCheckField
Follow-up to
aa15d5287d898b624a30a70d14e495899f7d251e
Change-Id: Ie9a6b3f017912d0f3493da09a267cf32852392af
Bryan Davis [Sat, 23 Aug 2014 22:10:17 +0000 (16:10 -0600)]
Apply csshelpclass to vform help
Ensure that a form field which sets 'csshelpclass' and is rendered as
a vform receives expected styling.
Change-Id: Ibe082e07fe846334bd4dc257c9c0df8db23a1957
umherirrender [Sat, 23 Aug 2014 20:34:25 +0000 (22:34 +0200)]
Add missing @return to function docs
Change-Id: I45b9d02f94ecc58372268ec5e6a0b572a0b7e2a9
jenkins-bot [Sat, 23 Aug 2014 20:21:44 +0000 (20:21 +0000)]
Merge "Use config instead of globals for OutputPage"
Translation updater bot [Sat, 23 Aug 2014 20:08:25 +0000 (20:08 +0000)]
Merge "Localisation updates from https://translatewiki.net."
jenkins-bot [Sat, 23 Aug 2014 19:59:49 +0000 (19:59 +0000)]
Merge "OutputPage: addParserOutput*() family doesn't need to take a reference"
Bartosz Dziewoński [Sat, 23 Aug 2014 16:20:51 +0000 (18:20 +0200)]
OutputPage: addParserOutput*() family doesn't need to take a reference
We never assign to the variable, only call some (mutating) methods on
the object. With PHP 5 we don't need to pass this by reference.
The functions that evolved into this family were originally added in
r12337, back then we probably still ran on PHP 4 or something.
Change-Id: Ib4ab141ca6d803f9df0351b1f65c7e9955c37d57
jenkins-bot [Sat, 23 Aug 2014 19:46:57 +0000 (19:46 +0000)]
Merge "Be consistent about 'TablePager' CSS class usage"
jenkins-bot [Sat, 23 Aug 2014 19:45:51 +0000 (19:45 +0000)]
Merge "Split includes/Pager.php"
jenkins-bot [Sat, 23 Aug 2014 19:45:19 +0000 (19:45 +0000)]
Merge "Remove unused styles for .imagelist"
Translation updater bot [Sat, 23 Aug 2014 19:12:41 +0000 (21:12 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I0d1cdf104964c0923cfea01e3c7e18838ed47046
Bartosz Dziewoński [Sat, 23 Aug 2014 13:00:07 +0000 (15:00 +0200)]
Be consistent about 'TablePager' CSS class usage
* Do not use it when not actually using the TablePager
* Always use it when actually using the TablePager
* Use parent::getTableClass() rather than hardcoding it every time
* Place it before other classes to allow overriding
Change-Id: I042b65be64e2c2fa6c68a7bb972a7a2ea7f55b4e
Bartosz Dziewoński [Sat, 23 Aug 2014 12:25:02 +0000 (14:25 +0200)]
Split includes/Pager.php
Change-Id: I67fcffca4e3de081a895deb1a285a5545940ece9
Bartosz Dziewoński [Sat, 23 Aug 2014 11:56:47 +0000 (13:56 +0200)]
Remove unused styles for .imagelist
Added in r16083 for Special:ImageList, which has been renamed to
Special:ListFiles in r45357, with class names being changed in the PHP
code without adjusting the CSS.
It seems no one has missed these styles over the years, so let's just
delete them.
Change-Id: I1f7775b3c7733cbfdd3f404527063e973fb80ec7
jenkins-bot [Sat, 23 Aug 2014 11:20:23 +0000 (11:20 +0000)]
Merge "Add more tests for GlobalVarConfig"
jenkins-bot [Sat, 23 Aug 2014 10:40:41 +0000 (10:40 +0000)]
Merge "Add a test for ApiFormatNone"
umherirrender [Sat, 23 Aug 2014 08:52:41 +0000 (10:52 +0200)]
Use config instead of globals for OutputPage
Change-Id: I5e0ebc173631d1d1052de7ccee4ef839c7c1767f
Kunal Mehta [Sat, 23 Aug 2014 06:32:37 +0000 (23:32 -0700)]
Mark ConfigFactory::destroyDefaultInstance() with @codeCoverageIgnore
Change-Id: Icd4a5724aefab58dad1af07874ef7ee415922ead
Kunal Mehta [Sat, 23 Aug 2014 06:27:51 +0000 (23:27 -0700)]
Add a test for ApiFormatNone
Because lolz.
Change-Id: I9c472131746a722737300b7d2d2291c70f80bb2e
jenkins-bot [Sat, 23 Aug 2014 00:43:07 +0000 (00:43 +0000)]
Merge "ResourceLoaderFileModule: Do not separately cache .less files"
Bartosz Dziewoński [Wed, 20 Aug 2014 17:39:36 +0000 (19:39 +0200)]
Fix documentation for $wgResourceLoaderLESSVars
* These aren't string values, but LESS code snippets. This rarely
matters, but it matters very much when it does.
* Changes to the values do not actually trigger cache invalidation.
Hashed contents are only used for "second-level" cache keys and do
not make it possible to invalidate module cache.
Change-Id: I373dfedac1e43db4d0aa709384eee7f7e7f1808c
jenkins-bot [Fri, 22 Aug 2014 23:53:13 +0000 (23:53 +0000)]
Merge "Use config instead of globals for ImageGallery"
jenkins-bot [Fri, 22 Aug 2014 23:42:39 +0000 (23:42 +0000)]
Merge "Use getConfig for ChangesList"
jenkins-bot [Fri, 22 Aug 2014 23:32:33 +0000 (23:32 +0000)]
Merge "Fix name of SpecialListFilesTest > ImageListPagerTest"
jenkins-bot [Fri, 22 Aug 2014 23:32:30 +0000 (23:32 +0000)]
Merge "Remove unused private var and fix phpdoc"
jenkins-bot [Fri, 22 Aug 2014 23:30:34 +0000 (23:30 +0000)]
Merge "Rename variable in RequestContext, $t => $title"
jenkins-bot [Fri, 22 Aug 2014 23:21:08 +0000 (23:21 +0000)]
Merge "tests: avoid sql queries in TitleTest"
jenkins-bot [Fri, 22 Aug 2014 23:20:36 +0000 (23:20 +0000)]
Merge "Change @return to start with type"
Antoine Musso [Thu, 21 Aug 2014 19:54:51 +0000 (21:54 +0200)]
tests: avoid sql queries in TitleTest
testIsAlwaysKnown was invoked on an interwiki link. To have the test
pass, we used addDBData() to inject the interwiki in the database. This
end up being execute on each test when it is only needed for a single
assertion.
Instead of creating a Title, use Title::makeTitle() to populate the
interwiki, thus letting us avoid the database hits.
Random timing: 1.20s -> 150ms.
Change-Id: I63a4e7b9af5eacb7dc1de4b33b8e631e6c3f1fa6
jenkins-bot [Fri, 22 Aug 2014 23:10:37 +0000 (23:10 +0000)]
Merge "Rename variable in Title: $parser -> $titleParser"
jenkins-bot [Fri, 22 Aug 2014 22:16:10 +0000 (22:16 +0000)]
Merge "Pass config to ResourceLoader from OutputPage"
jenkins-bot [Fri, 22 Aug 2014 22:15:11 +0000 (22:15 +0000)]
Merge "Use getConfig in HistoryAction for global"
Aaron Schulz [Thu, 21 Aug 2014 17:33:09 +0000 (10:33 -0700)]
Avoid sleeper connections in LoadMonitor::getLagTimes()
* Also improved the cache fallback logic
Change-Id: I65a2c46b49a2d79e014b910a7f7357aa64964690
Translation updater bot [Fri, 22 Aug 2014 20:51:09 +0000 (20:51 +0000)]
Merge "Localisation updates from https://translatewiki.net."
umherirrender [Fri, 22 Aug 2014 20:36:59 +0000 (22:36 +0200)]
Use config instead of globals for ImageGallery
Have to pass a context to the constructor to acutally use it for
settings.
Also adds a RequestContext::getMainAndWarn to get a default warning,
when using the main request, but it would be better to pass one.
Change-Id: I1628a1790c45d44aa4239701486b8b1b7c59a0e6
jdlrobson [Fri, 22 Aug 2014 20:33:20 +0000 (13:33 -0700)]
Change css rule order
:invalid is incorrectly overriding a :focus:invalid element
correct the order and add a note about this.
Change-Id: I4ee1a4634840b2251e294dfb704c1f5e3b730f7d
Translation updater bot [Fri, 22 Aug 2014 20:19:33 +0000 (22:19 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: Ie07b1bd0e3696af417e3c131f8c6d2506c881b0e
umherirrender [Fri, 22 Aug 2014 20:13:16 +0000 (22:13 +0200)]
Pass config to ResourceLoader from OutputPage
Change-Id: Iae99ab65a254fc3fe3acac764a068470f99af1c4
umherirrender [Fri, 22 Aug 2014 20:01:08 +0000 (22:01 +0200)]
Use getConfig for ChangesList
Change-Id: I1f440a2fca2dd8f1973987d635c70954938b6ea6
umherirrender [Fri, 22 Aug 2014 19:48:49 +0000 (21:48 +0200)]
Use getConfig in HistoryAction for global
Change-Id: I4a3bb4149c3c1da75215e0e6336c89e4a00fc8e4
Aaron Schulz [Wed, 20 Aug 2014 23:41:59 +0000 (16:41 -0700)]
Made getCachedRevisionObject() use MapCacheLRU
* Previously the cache size was unbounded and leaky
* Also made MapCacheLRU handle null values properly
Change-Id: Ia02258cf051e1ccf11457c758741b8c7922afe89
jenkins-bot [Fri, 22 Aug 2014 18:10:39 +0000 (18:10 +0000)]
Merge "Ensure that expiry times are given as integers"
jenkins-bot [Fri, 22 Aug 2014 18:06:07 +0000 (18:06 +0000)]
Merge "Fixed bogus mysql error code 0 on mid-transaction disconnect"
physikerwelt [Thu, 14 Aug 2014 16:28:36 +0000 (12:28 -0400)]
Protect MathML from Tidy
MediaWiki installations that use the setting
$wgUseTidy = true; are unable to output
MathML since the well defined MathML elements
are filtered out by Tidy. This was reported as
http://sourceforge.net/p/tidy/patches/84/ .
This change hides MathML blocks from
Tidy.
Bug: 66516
Change-Id: Ib48b91238c3eddd6a86b62f6ce57801d7058f0d8
jenkins-bot [Fri, 22 Aug 2014 16:06:46 +0000 (16:06 +0000)]
Merge "Drop "left in" debugging var_dump from WikiImporter"
Bryan Davis [Fri, 22 Aug 2014 15:55:59 +0000 (09:55 -0600)]
Ensure that expiry times are given as integers
Fixes "Fatal error: Argument 4 passed to Memcached::cas() must be an
instance of int, float given".
Change-Id: Ibf1ea638ec1a4dcf009cdaea8aa66008c74ff30b
jenkins-bot [Fri, 22 Aug 2014 15:43:27 +0000 (15:43 +0000)]
Merge "Make ApiModuleManagerTest::testAddModules un-risky"
aude [Fri, 22 Aug 2014 14:15:47 +0000 (16:15 +0200)]
Rename variable in Title: $parser -> $titleParser
so not to confuse this with Parser
Change-Id: I7e06baa0a924310e9491f125d0cb851bde2702ab
Thiemo Mättig [Fri, 22 Aug 2014 14:11:30 +0000 (16:11 +0200)]
Drop "left in" debugging var_dump from WikiImporter
I found this on accident when searching for a var_dump I forgot
somewhere in my own code. We are maintaining production code here,
right? Debugging and testing should be somewhere else.
Also note the stray print before the var_dump.
Change-Id: I98725b277039f55db9ff95399e9559a477b43c26
jenkins-bot [Fri, 22 Aug 2014 05:53:47 +0000 (05:53 +0000)]
Merge "API: Add iwprop=url, deprecate iwurl for prop=iwlinks"
Kunal Mehta [Fri, 22 Aug 2014 05:47:24 +0000 (22:47 -0700)]
Make ApiModuleManagerTest::testAddModules un-risky
Change-Id: Idbea51cf45fc95676759e5ac9abb342701e5b551
Bryan Davis [Fri, 22 Aug 2014 02:24:25 +0000 (20:24 -0600)]
Check for existence of iw_local in Interwiki::getAllPrefixes
Interwiki::getAllPrefixes only sets the iw_local member in a response
row if $local is set to a non-null value. Under certain error
reporting conditions, the unqualified access to the array key leads to
warnings such as "message repeated 1471 times: [ #012Notice: Undefined
index: iw_trans in ...".
Change-Id: Ibf434dc9c362984cad76ae6bdb29de826974d81e
jenkins-bot [Fri, 22 Aug 2014 01:22:55 +0000 (01:22 +0000)]
Merge "mediawiki.language: Expose language fallback chain"
Timo Tijhof [Wed, 13 Aug 2014 18:06:10 +0000 (19:06 +0100)]
resourceloader: Only conditional-wrap script responses with only=scripts
Follows-up
9272bc6c4721225. The shouldIncludeScripts method returns
true for only=scripts, but also for other responses (except for
only=styles, naturally).
Regular load.php responses that load both scripts and styles don't
need the conditional wrap because those requests should only be
made from the mw.loader client which inherently means the
environment has been provided already.
It's merely unnecessary and shouldn't have caused any issues since
it simply evaluates to true always. It was already correctly being
excluded from raw modules that run before the environment is
provided (such as startup, jquery and mediawiki).
Change-Id: I375a7a8039f9b3ad4909e76005725f7d975d8a5e
Bartosz Dziewoński [Sat, 9 Aug 2014 00:14:09 +0000 (02:14 +0200)]
mediawiki.language: Expose language fallback chain
The data can now be accessed via mw.language#getFallbackLanguages or
mw.language#getFallbackLanguageChain.
Bug: 69285
Change-Id: Id0c3267f01d5c4da0e4000a0fb318a9dfb538ef3
James D. Forrester [Thu, 21 Aug 2014 23:45:56 +0000 (16:45 -0700)]
Update OOjs UI to v0.1.0-pre (
d6008381aa)
New changes:
7205b2a build: Check for files' existence before building using grunt-file-exists
d600838 Make window managers destroyable
Change-Id: I32e4f5bd41a5401b817cc6e37c6325df624a9e0e
Kunal Mehta [Wed, 20 Aug 2014 07:35:35 +0000 (00:35 -0700)]
Add more tests for GlobalVarConfig
Change-Id: I31d50a0636792104e32e3f25694f45942c5c0217
Kunal Mehta [Thu, 21 Aug 2014 22:31:51 +0000 (00:31 +0200)]
ResourcesTest: Add variable type annotations
Change-Id: I07ec986830dcec739b0553395b9a220b44bba77d
jenkins-bot [Thu, 21 Aug 2014 21:41:39 +0000 (21:41 +0000)]
Merge "Add more tests for SkinFactory"
Bartosz Dziewoński [Thu, 21 Aug 2014 20:45:56 +0000 (22:45 +0200)]
Delete skins/common/images/button_template.png
Unused in core, as well as extensions and skins.
I have removed the two usages on Wikimedia wikis (found by mwgrep)
which must have been the cause of the 97 requests for this file per
bug 69277 comment 11:
* https://de.wikipedia.org/wiki/MediaWiki:Gadget-Vorlagenmeister.css
* https://hu.wikipedia.org/wiki/MediaWiki:Gadget-sablonmester.css
Bug: 69277
Change-Id: I9d151e1fbc2da948b5265da731496d4178f51039
Aaron Schulz [Tue, 19 Aug 2014 21:13:30 +0000 (14:13 -0700)]
Made showJobs.php show queues with just abandoned jobs too
Change-Id: I7fbf000c9b9edf433ac6723843a96fcaf937b5c7
jenkins-bot [Thu, 21 Aug 2014 17:11:37 +0000 (17:11 +0000)]
Merge "Sync up with Parsoid parserTests."
Roan Kattouw [Thu, 21 Aug 2014 16:59:20 +0000 (09:59 -0700)]
Update OOjs UI to v0.1.0-pre (
55b861b167)
New changes:
466a876 [BREAKING CHANGE] Make content isolation optional
23f26c3 [BREAKING CHANGE] Set active and pressed on the buttoned element, not the button
55b861b build: Switch from grunt-recess to grunt-contrib-less
Change-Id: Ie4454376df9492e3b77b6cc174ce7b38548cc56d
Subramanya Sastry [Tue, 19 Aug 2014 21:19:24 +0000 (16:19 -0500)]
Sync up with Parsoid parserTests.
This now aligns with Parsoid commit
13c31fc815749a6239dd357672d39de0a51d51ce
Change-Id: I929e1c195801a9055ad2847994e050836262a896
Aaron Schulz [Thu, 21 Aug 2014 16:58:03 +0000 (09:58 -0700)]
Fixed bogus mysql error code 0 on mid-transaction disconnect
* Now the proper error (e.g. "server has gone away") and code is shown.
Change-Id: If0255101151441c7d05141ffc7cb416ad79e6bd8
jenkins-bot [Thu, 21 Aug 2014 16:54:20 +0000 (16:54 +0000)]
Merge "Set default setting for thumbsize to 300px (index 5) not 180px"
jenkins-bot [Thu, 21 Aug 2014 15:44:43 +0000 (15:44 +0000)]
Merge "Never cache pages with the fallback skin"
jenkins-bot [Thu, 21 Aug 2014 15:38:10 +0000 (15:38 +0000)]
Merge "Made LocalFile move/delete/restore handle network partitions better"
jenkins-bot [Thu, 21 Aug 2014 15:31:20 +0000 (15:31 +0000)]
Merge "Title::getContentModel(): load from DB if necessary"
James D. Forrester [Thu, 21 Aug 2014 00:23:53 +0000 (17:23 -0700)]
Update OOjs UI to v0.1.0-pre (
944c47c5fe)
New changes:
36ae086 Use a pollNode for every transplanted stylesheet, not just external ones
a1771ed Support nested style transplantation
8c60d3c Create a combo box widget
944c47c Update oojs to v1.0.12
Change-Id: I800bb36b80d04e165e9fa9b00ed8a5223f2d954b
Kevin Israel [Wed, 20 Aug 2014 21:46:11 +0000 (17:46 -0400)]
Title::getContentModel(): load from DB if necessary
Also don't cast $model to int in LinkCache::addGoodLinkObj(); content
model IDs are non-numeric strings, not integers, so that field was
always populated with the value 0. Because 0 is a falsy value, this
caused subsequent calls to Title::getContentModel() to return the
default model rather than the correct one.
Also (hopefully) fixed every single query that could cause a
LinkCache entry to be added without the content model.
Bug: 69789
Change-Id: I94f06baf406afa538cd2b10139598442f9fc6759
James D. Forrester [Wed, 20 Aug 2014 22:35:43 +0000 (15:35 -0700)]
Update OOjs to v1.0.12
Release notes:
https://git.wikimedia.org/blob/oojs%2Fcore.git/v1.0.12/History.md
Change-Id: I5542d1cf5aad4d4fd78a04f6bea7a27cbabf055a
James D. Forrester [Sat, 16 Aug 2014 14:37:22 +0000 (15:37 +0100)]
Set default setting for thumbsize to 300px (index 5) not 180px
Bug: 67703
Change-Id: I172ccc0128747090a199695d3bce04388b3bef57
bsitu [Tue, 19 Aug 2014 22:23:05 +0000 (15:23 -0700)]
Add support for adding deferred update within a deferred update
Under some configurations all Echo notifications are inserted
via a DeferredUpdate. When an extension delays its own notification
trigger via DeferredUpdate as well the Echo notification will not
be run.
Change-Id: Ib40fcd4939ede5b0ff986ab109432630efd1be74
Florianschmidtwelzow [Wed, 20 Aug 2014 21:59:14 +0000 (21:59 +0000)]
Revert "Load mediawiki.action.view.redirectToFragment in mobile"
This reverts commit
21ec580f066566d7da97cca0ef40c112b6a0b7a1.
Change-Id: I49788d6b56efdd2fed77ff7657e11554b9927076
jenkins-bot [Wed, 20 Aug 2014 21:38:32 +0000 (21:38 +0000)]
Merge "Load mediawiki.action.view.redirectToFragment in mobile"
Translation updater bot [Wed, 20 Aug 2014 20:45:00 +0000 (20:45 +0000)]
Merge "Localisation updates from https://translatewiki.net."
Translation updater bot [Wed, 20 Aug 2014 20:25:51 +0000 (22:25 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I01ae5ce97f4b82c10bc8184a5d5db0517ca6f7fe
Bartosz Dziewoński [Tue, 8 Jul 2014 00:50:37 +0000 (02:50 +0200)]
On redirects update the URL to that of the target page with JavaScript
Redirects to sections will now update the URL in browser's address bar
using the HTML5 History API. When [[Dog]] redirects to [[Animals#Dog]],
the user will now see "Animals#Dog" in their browser instead of "Dog#Dog".
The target URL is generated server-side to avoid pulling in dependencies
in the client-side RL module, which is loaded in the top queue.
Browsers that do not support the History API are still supported, the
way they always were.
Given the following three pages:
* A: #REDIRECT [[C]]
* B: #REDIRECT [[C#Section]]
* C: ==Section== \n ==Other section== \n
The following links should behave as follows:
* A → C
* B → C#Section
* A#Other_section → C#Other_section
* B#Other_section → C#Other_section
The code also supports forwarding query parameters like 'debug=1'.
Bug: 35045
Bug: 39328
Change-Id: I9d8d834762e19b836b7e35122b6c4cef0f91b7f0
jenkins-bot [Wed, 20 Aug 2014 18:44:51 +0000 (18:44 +0000)]
Merge "Fix @param of Language::dateTimeObjFormat"
jenkins-bot [Wed, 20 Aug 2014 18:40:43 +0000 (18:40 +0000)]
Merge "Split RevisionDeleteAbstracts.php to separate files"
umherirrender [Wed, 13 Aug 2014 17:54:49 +0000 (19:54 +0200)]
Change @return to start with type
MediaWiki default is "@return type Description", so set a type after
return and start the description with a capital letter. Also use the
more common spelling of boolean.
See http://phpdoc.org/docs/latest/references/phpdoc/tags/return.html for
more about @return
Change-Id: I4e5198822fe92836f9cef9918a9fc1a1a1e0a043
Bartosz Dziewoński [Wed, 20 Aug 2014 18:26:46 +0000 (20:26 +0200)]
ResourceLoaderFileModule: Do not separately cache .less files
We used to have a second level of caching for them – when a module's
cache was invalidated, individual .less files that comprise it would
only be recompiled (with all their @imports) if their mktime changed
(or if $wgResourceLoaderLESSVars changed).
Given that practice has shown that RL modules including .less files
usually just include one file that @imports tons of stuff, and given
that RL already is very careful about invalidating caches, I think
this is unnecessary at best and harmful at worst.
The behavior proved problematic when I tried to implement support for
per-module LESS variables, values of which were language-dependent –
files would not be recompiled for different languages, and
getLessCacheKey() is called several levels deep in code that doesn't
have access to the context in which the module is being compiled.
Change-Id: I667f063507583e4cd3a669e32398d440f1431f7e
jenkins-bot [Wed, 20 Aug 2014 18:24:10 +0000 (18:24 +0000)]
Merge "API: Adjust feature usage log format"
umherirrender [Wed, 20 Aug 2014 17:35:30 +0000 (19:35 +0200)]
Fix @param of Language::dateTimeObjFormat
Follow-Up: Ib26407bc55dff7969d8a3b1e2ae51751b202d8fb
Change-Id: I078ffe3ff385f4541d91b2fb8ef9564138f78393
umherirrender [Fri, 8 Aug 2014 14:05:33 +0000 (16:05 +0200)]
Split RevisionDeleteAbstracts.php to separate files
Same as I244a66fe19c089df4bcabcf745536d99b2103bc4
Change-Id: I90cea070a8e24d82f0675f122c79326988351e08
Bartosz Dziewoński [Wed, 20 Aug 2014 16:48:10 +0000 (18:48 +0200)]
Consistently use 'Less' rather than 'LESS' in function names
PHP function names are case-insensitive, so this is a fully
backwards-compatible change.
Change-Id: Ide04ad542ac5c3a26b6064093ae272cf9aeef2d1