Amir E. Aharoni [Tue, 27 Mar 2012 12:09:25 +0000 (14:09 +0200)]
Improved the comment about Special:Contributions.
It was prompted by an IRC discussion with SrikanthLogic,
who found the comment hard to understand.
Change-Id: Idd686257bc4d44f93e06b5645bdc1531bb2b4a2e
tstarling [Tue, 27 Mar 2012 04:23:44 +0000 (15:23 +1100)]
Split hashar's patchset2 into its own commit
* updated FileBackend constructor documentation
* squash change 3321 (r113742)
Change-Id: I6bb054ac6aaeee38a03880558c918963138330c4
Aaron Schulz [Tue, 13 Mar 2012 01:46:33 +0000 (01:46 +0000)]
[FileBackend]
* Added FileJournal class to log file changes for file backends. This can be used for migrations (like moving to Swift), syncing mirror repos, consistency checks, finishing/reverting operation batches, and such. The default journal is the "null" journal, which simply does nothing.
* Added the optional schema change required for using the DBFileJournal (MySQL, SQLite).
Change-Id: I33c9f9a598ba1f164c862b9dc3c718f9172db02b
tstarling [Tue, 27 Mar 2012 00:12:35 +0000 (11:12 +1100)]
Fix typo in comment
Change-Id: I5861982d91a32b5f65c250dde38fc5ce8f5c2693
tstarling [Mon, 26 Mar 2012 23:53:48 +0000 (10:53 +1100)]
Revert previous commit: accidental branch merge
This reverts commit
685fffec2049e1e152105dae919b58ed8876d04e, reversing
changes made to
59a68b48a74763af58ad7d62820ae1e7b0639476.
Change-Id: I5ed9f66e6afd5004ed5ee0f00e46888359376689
tstarling [Mon, 26 Mar 2012 23:47:04 +0000 (23:47 +0000)]
Merge "Fix typo in comment"
tstarling [Mon, 26 Mar 2012 23:44:24 +0000 (10:44 +1100)]
Fix typo in comment
Change-Id: Ia0af1e53c11c371f70dd60acdf5d32485bd8b3bc
Brion VIBBER [Mon, 26 Mar 2012 22:09:20 +0000 (22:09 +0000)]
Merge "Sync HISTORY with RELEASE-NOTES from REL1_18"
Aaron Schulz [Mon, 26 Mar 2012 22:04:55 +0000 (22:04 +0000)]
Merge "First half of fix for bug #30332 ("API spamblocklist error should provide *all* blocked URLs, not just one")."
jarry1250 [Mon, 26 Mar 2012 21:50:34 +0000 (22:50 +0100)]
First half of fix for bug #30332 ("API spamblocklist error should provide *all* blocked URLs, not just one").
Allow spamPageWithContent() to accept an array of matches, rather than just one.
Not dependent on other half of fix.
Change-Id: I75faac51f24bbb2569b36bc2e44f3cd5c43b1bd7
Alexandre Emsenhuber [Mon, 26 Mar 2012 20:57:32 +0000 (22:57 +0200)]
Sync HISTORY with RELEASE-NOTES from REL1_18
Change-Id: Iedb39de2c357ecb5b36bcb277722825d89a86031
Alexandre Emsenhuber [Mon, 26 Mar 2012 19:59:23 +0000 (21:59 +0200)]
Use local context to get messages
Change-Id: Ibbe6cd92ad3057742a6193471971fb11244e843b
Alexandre Emsenhuber [Mon, 26 Mar 2012 18:26:32 +0000 (20:26 +0200)]
* (bug 35446) Using "{{nse:}}" with an invalid namespace name no longer throws a PHP warning
Change-Id: I8e7611cdb03558af13ec5b96e02857ff5b16b571
Aaron Schulz [Mon, 26 Mar 2012 18:17:21 +0000 (18:17 +0000)]
Merge "Closing dump buffers on stream end"
Liangent [Mon, 26 Mar 2012 13:36:24 +0000 (21:36 +0800)]
Was causing Notice: Array to string conversion in .../includes/api/ApiBase.php on line 285 and examples of list=allimages are not displayed properly
Change-Id: I4fde14245ac19716957beb634a274c3a6042d776
Reedy [Thu, 22 Mar 2012 19:52:37 +0000 (19:52 +0000)]
* (bug 34212) ApiBlock/ApiUnblock allow action to take place without a token parameter present
* (bug 35317) CSRF in Special:Upload
Revert r56793, which removed the CSRF check for Special:Upload for normal file
uploads. Cross-site posting of file uploads without user interaction has been
possible since at least as early as Chrome 8 (late 2010) and Firefox 6 (mid
2011).
Commonist has used api.php since version 0.4.0 (April 2010), and the API
already requires an edit token, so Commonist 0.4.0+ is not affected by this
change.
* (bug 34907) Fix for CSRF vulnerability due to mw.user.tokens. Patch by Roan
Kattouw and Tim Starling.
* Filter out private modules early in ResourceLoader::makeResponse() and just
pretend they weren't specified. This means these modules cannot be loaded
through load.php . This filtering must not happen in makeModuleResponse(),
because that would break inlining.
* Force inlining of private modules in OutputPage::makeResourceLoaderLink(),
disregarding $wgResourceLoaderInlinePrivateModules
* Remove $wgResourceLoaderInlinePrivateModules
* Remove special treatment of private modules ($private) in
ResourceLoader::makeResponse() and sendResponseHeaders(), because we're not
allowing private modules to be loaded through here any more
* Remove identity checks in ResourceLoaderUserOptionsModule and
ResourceLoaderUserCSSPrefsModule, they didn't make a lot of sense before but
they're certainly useless now.
* Factored out error comment construction in ResourceLoader.php and stripped
comment terminations from exception messages. I didn't find an XSS
vulnerability but it looked scary.
Patchset2:
Removes whitespace error that prevented automatic merge by Gerrit:
includes/resourceloader/ResourceLoaderUserOptionsModule.php
Change-Id: I2dec8b8caf9db3c64919763865cc10cccdd6a1a3
Christian Aistleitner [Mon, 26 Mar 2012 09:26:48 +0000 (11:26 +0200)]
Closing dump buffers on stream end
Change-Id: I7bef095f2f9189fb20064da4fd09ed4caa7a90e5
Aaron Schulz [Mon, 26 Mar 2012 06:30:04 +0000 (06:30 +0000)]
Merge "No more undefined usage of rev{Start,End}Id warnings"
Aaron Schulz [Mon, 26 Mar 2012 05:35:07 +0000 (05:35 +0000)]
Merge "Same as #3715, but for master: * Moved the new entry to a new section "Changes since 1.19 beta 2" (did not see that the beta 2 was out)"
Aaron Schulz [Mon, 26 Mar 2012 05:31:51 +0000 (05:31 +0000)]
Merge "Use local context to get message"
Daniel Friesen [Mon, 26 Mar 2012 03:44:57 +0000 (20:44 -0700)]
Fix broken email confirmation expiration caused by MWCryptRand changes.
Change-Id: I7ef0913074f372b5ace3d14993e0e3a914b9f22c
Tim Starling [Mon, 26 Mar 2012 03:45:23 +0000 (03:45 +0000)]
Merge "Localisation updates for namespace names for core from translatewiki.net."
Alexandre Emsenhuber [Sun, 25 Mar 2012 20:10:09 +0000 (22:10 +0200)]
Use local context to get message
Change-Id: Ieeb4b20591baa3b6ceebdef55953648142622b44
Christian Aistleitner [Sun, 25 Mar 2012 19:32:18 +0000 (21:32 +0200)]
No more undefined usage of rev{Start,End}Id warnings
Change-Id: Id9754e430a566f79acbac3a7839a26cfd70db51c
Alexandre Emsenhuber [Sun, 25 Mar 2012 15:24:05 +0000 (17:24 +0200)]
Same as #3715, but for master:
* Moved the new entry to a new section "Changes since 1.19 beta 2" (did not see that the beta 2 was out)
Change-Id: Id2f39240ecac47a5ac70bc668f353adbac81428a
Greg Sabino Mullane [Sat, 24 Mar 2012 21:14:09 +0000 (17:14 -0400)]
Fix whitespace; change tabs to spaces.
Change-Id: I0c95653b47295e4bd84dec1ae74a850ca6598d9a
Alexandre Emsenhuber [Sat, 24 Mar 2012 18:45:05 +0000 (19:45 +0100)]
Use local context to get messages
Change-Id: I1a00bdca30132380640e872a5aa01c658d238202
Demon [Sat, 24 Mar 2012 15:50:36 +0000 (15:50 +0000)]
Merge "[FileRepo] * Added getReadOnlyReason() function to FileRepo to check read-only status. Added such checks to the File object functions that mutate files in storage. This should make read-only mode more tolerable (which is needed at least briefly when switching backends). * Added lock()/unlock() calls to File restore() function. * Use proper isOK() accessor for Status objects."
Reedy [Sat, 24 Mar 2012 15:23:30 +0000 (15:23 +0000)]
Merge "Put the sha1 tag in <revision> and not wrongly in <page>"
Marcin Cieślak [Wed, 14 Mar 2012 20:20:53 +0000 (20:20 +0000)]
Rename "user" and "text" when upgrading on PostgreSQL
Follow-up to r15791.
You can lie to me, but not to your installer.
Make DatabasePostgres::tableExists to check for real table names, not
faked ones.
DatabasePostgres is currently lying to the rest of the MediaWiki that
"mwuser" table is actually called "user" and that "pagecontents" is
called "text". While MediaWiki does not care, the installer (and updater
do).
This allows us to overcome first hurdle in getting MediaWiki 1.7.3 to
update to trunk on PostgreSQL and uncover further bugs.
For this commit to actually do something, we rename those tables when
upgrading to match what we have in maintenance/postgres/tables.sql
And by the way, tell installer not to check for "user" table, since most
PostgreSQL users will have "mwuser" instead. Picking "archive" instead.
Patchset2: wrapped commit message at 72 chars
Change-Id: Ic874e92bb1adda3430d3292423d4f3617c25456c
Aaron Schulz [Sat, 24 Mar 2012 07:30:31 +0000 (07:30 +0000)]
Merge "* (bug 35449) Removed double call to OutputPage::setRobotPolicy() in SpecialWatchlist::execute() (the other one is hidden in SpecialPage::setHeaders()) * Special:Watchlist no longer sets links to feed when the user is anonymous"
Aaron Schulz [Sat, 24 Mar 2012 07:26:46 +0000 (07:26 +0000)]
Merge "* Added Profiler::addInitialStack() to separate definitions of local variables and insertion of the first stacks * Use it in ProfilerSimple and call $this->profileOut() there to factorise common code"
Alexandre Emsenhuber [Sat, 24 Mar 2012 07:19:40 +0000 (08:19 +0100)]
* (bug 35449) Removed double call to OutputPage::setRobotPolicy() in SpecialWatchlist::execute() (the other one is hidden in SpecialPage::setHeaders())
* Special:Watchlist no longer sets links to feed when the user is anonymous
I did not add a RELEASE-NOTES entry for such trivial change, but rather for the second one which is more problematic that I found while investigating the bug.
Change-Id: I5ca6ccc1339ceacd98371e660d26876b6283decd
bsitu [Fri, 23 Mar 2012 23:57:05 +0000 (16:57 -0700)]
fix and comparison in pingLimiter
Change-Id: Ib8aa8ecf169acdf69c55f8c1dbce0d709fb9e852
Alex Monk [Fri, 23 Mar 2012 22:30:46 +0000 (22:30 +0000)]
Fixed some links from SVN to Git.
Change-Id: If425135e3601f11e42c0fc66b1eff7192b2a0704
preilly [Fri, 23 Mar 2012 22:29:30 +0000 (22:29 +0000)]
Merge "Resolve bug #18704 ("Add an unique CSS class or ID to the tagfilter table row at RecentChanges")"
jarry1250 [Fri, 23 Mar 2012 20:33:45 +0000 (20:33 +0000)]
Resolve bug #18704 ("Add an unique CSS class or ID to the tagfilter table row at RecentChanges")
Effectively followup previous attempt (r111186)
Change-Id: If11e2351ae7553da9ce010fce30354dbaf82b2dd
Hashar [Fri, 23 Mar 2012 21:23:38 +0000 (21:23 +0000)]
Merge "http->https"
Raimond Spekking [Fri, 23 Mar 2012 21:05:08 +0000 (22:05 +0100)]
http->https
Change-Id: I300f05ea4eb273bfa57192e58075bb027c6a02c8
Aaron Schulz [Fri, 23 Mar 2012 20:09:59 +0000 (13:09 -0700)]
Put the sha1 tag in <revision> and not wrongly in <page>
Change 1: while at it, also don't show the SHA1 if rev_deleted is set
Change-Id: I0d94338915e754bdee878d1e6570e2efc481b2b2
Aaron Schulz [Wed, 14 Mar 2012 21:30:26 +0000 (21:30 +0000)]
[FileRepo]
* Added getReadOnlyReason() function to FileRepo to check read-only status. Added such checks to the File object functions that mutate files in storage. This should make read-only mode more tolerable (which is needed at least briefly when switching backends).
* Added lock()/unlock() calls to File restore() function.
* Use proper isOK() accessor for Status objects.
Change-Id: I7368912b01f7fd1ec34125d12c0844388cbb3b2d
Daniel Friesen [Fri, 23 Mar 2012 18:59:30 +0000 (11:59 -0700)]
Update .gitignore for maintenance/
Add maintenance/dev/'s sqlite directory and maintenance/eval.php's history file to .gitignore.
Change-Id: I574532dc1d5475fb929cebd1934bd0149ea27039
Antoine Musso [Fri, 23 Mar 2012 17:18:07 +0000 (18:18 +0100)]
RecentChangeTest use the Database
Moving RecentChangeTest to the Database group will fix Jenkins jobs
handling databaseless tests.
Change-Id: I3f14120e806c35b19e96747aa43d6c64a6b504ca
Platonides [Fri, 23 Mar 2012 16:45:45 +0000 (17:45 +0100)]
API: trunk/phase3 is now mediawiki/core
e7544995a090f98fd4d803686d90087e9273bb41 follow-up.
Change-Id: Ic0c82e0a54cefded24fc3aa260ddc051e30e8ab5
Platonides [Fri, 23 Mar 2012 16:19:02 +0000 (17:19 +0100)]
trunk/phase3 is now mediawiki/core
Change-Id: Ief2721ee6573a5e54a276c91de636d9e1a678b8b
Antoine Musso [Fri, 23 Mar 2012 15:40:32 +0000 (16:40 +0100)]
git ignore almost everything in ./extensions/
Change-Id: I118733a47e154125a3a797c2763ea08b008f831c
Alexandre Emsenhuber [Fri, 23 Mar 2012 15:25:22 +0000 (16:25 +0100)]
* Added Profiler::addInitialStack() to separate definitions of local variables and insertion of the first stacks
* Use it in ProfilerSimple and call $this->profileOut() there to factorise common code
Change-Id: I2eb74088c6087a7c2dd32af1a1f600f327178c67
Demon [Fri, 23 Mar 2012 14:58:37 +0000 (14:58 +0000)]
Merge changes Id8107d24,I8c63dcc8
* changes:
[mediawiki.action.watch] clean up
[mediawiki.action.watch] Move re-used logic into local function * Follows-up r112440, r107969, r107350
Daniel Friesen [Fri, 23 Mar 2012 11:19:13 +0000 (04:19 -0700)]
Add GitInfo class.
This adds GitInfo which is used by Special:Version to get the SHA1 of
the git repo.
It's also useful for development to put blocks of config in
LocalSettings.php that only apply to branches where you are developing
large features:
if ( GitInfo::currentBranch() == 'myrewriteproject' ) {
// […]
}
Change-Id: I2a76662bb40080be6556d4edf60ac6714f36a727
Krinkle [Thu, 15 Mar 2012 06:04:20 +0000 (06:04 +0000)]
[mediawiki.action.watch] clean up
* Fix implied global variable 'i' in mwUriGetAction()
* Indention nearly everything an extra level (git diff -w)
* other minor js coding style
Change-Id: Id8107d24b9e5e9e6827c8c1dfbbce0626eb58490
Krinkle [Thu, 15 Mar 2012 05:54:58 +0000 (05:54 +0000)]
[mediawiki.action.watch] Move re-used logic into local function
* Follows-up r112440, r107969, r107350
Change-Id: I8c63dcc8b2af0369c42b11837fda927671565ad2
Demon [Fri, 23 Mar 2012 12:56:25 +0000 (12:56 +0000)]
Merge "Darker colors for profileinfo"
Daniel Friesen [Fri, 23 Mar 2012 09:45:47 +0000 (02:45 -0700)]
Vector did not show watch star on Special:MovePage
Fix the bug where Vector leaves "unwatch" in an action in the menu
instead of converting it into an icon when you are on
Special:MovePage/Foo.
Apply to when using $wgVectorUseIconWatch = true;
Change-Id: Ie914ac50974aa473fa474931ca69776dd1c2fc54
Niklas Laxström [Fri, 23 Mar 2012 07:31:46 +0000 (07:31 +0000)]
Darker colors for profileinfo
The original colors were indistinguishable on my screen.
Also adds bold on hover, to make it easier to match numbers to line.
Change-Id: I8e1ae3f123ad0ff57cb7531026f7ae8f83f79c67
Tim Starling [Fri, 23 Mar 2012 06:56:19 +0000 (06:56 +0000)]
Merge "Swap $bytes .= $iv; for $buffer .= $iv;"
Aaron Schulz [Fri, 23 Mar 2012 02:53:49 +0000 (02:53 +0000)]
Merge "Bring in https://mediawiki.org/wiki/Special:Code/MediaWiki/114376"
Aaron Schulz [Fri, 23 Mar 2012 01:45:51 +0000 (01:45 +0000)]
Merge "* Use local context to get messages * Use Language::userTimeAndDate() instead of Language::timeanddate() to display the date with user preferences"
Reedy [Fri, 23 Mar 2012 00:45:17 +0000 (00:45 +0000)]
Swap $bytes .= $iv; for $buffer .= $iv;
Add a few bits of documentation
Change-Id: I0997d6eaaa37f312633db4556752cb38d8b4a3b0
Reedy [Fri, 23 Mar 2012 00:37:18 +0000 (00:37 +0000)]
Bring in https://mediawiki.org/wiki/Special:Code/MediaWiki/114376
Change-Id: I8960213bdd73ce3b0a9eaba90f621156cd0fc224
Alexandre Emsenhuber [Thu, 22 Mar 2012 20:27:47 +0000 (21:27 +0100)]
* Use local context to get messages
* Use Language::userTimeAndDate() instead of Language::timeanddate() to display the date with user preferences
Change-Id: Id0213cdb503229fb637a2ee51f3896b234e0547b
Alexandre Emsenhuber [Thu, 22 Mar 2012 16:44:09 +0000 (17:44 +0100)]
Also display get the short SHA-1 in SpecialVersion::getVersion() instead of only in getVersionLinked()
Change-Id: I2f4839fb587903524fdaf041597174003ccfdfeb
Max Semenik [Thu, 22 Mar 2012 13:54:07 +0000 (17:54 +0400)]
Test. Removed a pointless date
Change-Id: I1c2d2882c5b1101de7dbb9f0db9cadf724c0bd9e
Demon [Thu, 22 Mar 2012 12:31:48 +0000 (12:31 +0000)]
Merge "(bug 32827) "[Regression] Block log for IP ranges not shown on Special:Block""
Demon [Thu, 22 Mar 2012 12:23:14 +0000 (12:23 +0000)]
Merge changes I40a10821,I9c0af860
* changes:
Code reformatting
Refactoring dumpTextPass's error handling
Christian Aistleitner [Thu, 22 Mar 2012 11:11:42 +0000 (12:11 +0100)]
Code reformatting
Change-Id: I40a108216045aad9496bbbf723de2f42b084d009
Hashar [Thu, 22 Mar 2012 11:01:00 +0000 (11:01 +0000)]
Merge "Added per-backend profiling calls."
Christian Aistleitner [Thu, 22 Mar 2012 09:10:31 +0000 (10:10 +0100)]
Refactoring dumpTextPass's error handling
Change-Id: I9c0af860ca97489222b3cec071ed721ce72ad9e5
Demon [Thu, 22 Mar 2012 09:25:51 +0000 (09:25 +0000)]
Merge "Bug 35162 - Change in Database api break extension MSSQLBackCompat"
Aaron Schulz [Thu, 22 Mar 2012 00:23:42 +0000 (00:23 +0000)]
Merge "Fix newline in the message per CR Change method visibility to private"
Aaron Schulz [Thu, 22 Mar 2012 00:20:21 +0000 (00:20 +0000)]
Merge "Trim trailing whitespace"
saper [Wed, 21 Mar 2012 23:57:16 +0000 (00:57 +0100)]
Fix newline in the message per CR
Change method visibility to private
https://www.mediawiki.org/wiki/Special:Code/MediaWiki/113888#c32433
Change-Id: I8ea562cb5346de6823b3c0f0259d438bbefa8bac
Aaron Schulz [Wed, 21 Mar 2012 23:54:22 +0000 (16:54 -0700)]
Added per-backend profiling calls.
Change-Id: I380d06838649ab77f905cb6fed46b8068dbdcb9f
Amir E. Aharoni [Wed, 21 Mar 2012 23:07:06 +0000 (01:07 +0200)]
A little fix in whitespace and comment spelling.
Change-Id: I23887de1a5ee454037b6346c767e302f2e6f02f7
Aaron Schulz [Wed, 14 Mar 2012 01:42:14 +0000 (01:42 +0000)]
(bug 32827) "[Regression] Block log for IP ranges not shown on Special:Block"
(imported from SVN)
Change-Id: I16485d84553256ff6ad4932de7d17540e90af779
Sam Reed [Sun, 11 Mar 2012 23:40:33 +0000 (23:40 +0000)]
Bug 35162 - Change in Database api break extension MSSQLBackCompat
$canonicalDBTypes is probably superfluous information, but doesn't harm as a shortcut
Ping r108051
(imported from SVN)
Change-Id: I09ecf56d984405506f654919a822a939e5a9b1ee
Sam Reed [Sat, 17 Mar 2012 22:52:54 +0000 (22:52 +0000)]
Trim trailing whitespace
Add/improve documentation
Explicitly define a few variables
Change-Id: If0017770a0a47f8f6be178b5bde8ae6691f74b6a
Siebrand Mazeland [Sun, 25 Dec 2011 23:58:49 +0000 (23:58 +0000)]
Localisation updates for namespace names for core from translatewiki.net.
Change-Id: I80a478444e00a0b63f73f88260483cbfdf817caa
Demon [Wed, 21 Mar 2012 21:09:36 +0000 (17:09 -0400)]
Adding .gitreview -- first official commit to mediawiki core in git \o/
Change-Id: Ica46ab303c89679ea8575f75f51830f36bf972d3
Tim Starling [Wed, 21 Mar 2012 10:27:34 +0000 (10:27 +0000)]
* Removed the $method parameters from MWCryptRand. Apparently Dantman didn't know about our awesome debug traceback functions like wfGetAllCallers(). The weird optional-middle-parameter calling convention thankfully disappears as a consequence.
* Reduced the amount of debug log noise slightly, removing a few redundant messages.
Santhosh Thottingal [Wed, 21 Mar 2012 05:49:03 +0000 (05:49 +0000)]
Fix Bug 13896: Rendering of devanagari numbers in automatic '#' number lists
Add -moz-devanagari as list type for mr and hi language ordered lists.
Roan Kattouw [Wed, 21 Mar 2012 00:16:50 +0000 (00:16 +0000)]
Revert r107309, r113601, r113704, r113742, r113792, r113838, r113859, r113893, r113894, r113952, r114047, r114252, r114256, r114257. This reverts the remaining 'new' revisions in core.
All of these revisions are tagged with 'gerritmigration' and will be resubmitted into Gerrit after the Gerrit switchover. See also http://lists.wikimedia.org/pipermail/wikitech-l/2012-March/059124.html
Roan Kattouw [Tue, 20 Mar 2012 23:03:59 +0000 (23:03 +0000)]
Revert r114067, r114071, r114075, r114079, r114081, r114082, r114084, r114086, r114088, r114089, r114101, r114118, r114137, r114147, r114164, r114172, r114175, r114180, r114208, r114209, r114215, r114219, r114226, r114321, r114322.
This reverts the SpecialCachedPage and formatDuration sagas, with some collateral damage here and there. All of these revisions are tagged with 'gerritmigration' and will be resubmitted into Gerrit after the Gerrit switchover. See also http://lists.wikimedia.org/pipermail/wikitech-l/2012-March/059124.html
Daniel Friesen [Tue, 20 Mar 2012 22:58:34 +0000 (22:58 +0000)]
Security paranoia, reject requests to router.php that aren't from the cli-server sapi.
Jeroen De Dauw [Tue, 20 Mar 2012 22:48:28 +0000 (22:48 +0000)]
added some tests using the intervals param
Jeroen De Dauw [Tue, 20 Mar 2012 22:47:50 +0000 (22:47 +0000)]
handle cases where an empty array is provided by using this as default, also correctly handle cases where the smallest unit is not the second and the result is 0 smallestunit
Alexandre Emsenhuber [Tue, 20 Mar 2012 21:34:50 +0000 (21:34 +0000)]
* Use local context to get messages
* Use Language::userTimeAndDate() instead of Language::timeanddate() to display the date with user preferences
* Set the form's action to $wgScript instead of direct link to the page since it makes a GET request (and the title would be displayed twice with pretty URLs since there's already a <input name="title" .../>
Sam Reed [Tue, 20 Mar 2012 14:21:27 +0000 (14:21 +0000)]
Followup r114270 (essentially reverts it), and r114233, use class member variables as they are already defined
Sam Reed [Tue, 20 Mar 2012 14:16:46 +0000 (14:16 +0000)]
Followup r114233, define the method static variables to be used
Christian Aistleitner [Tue, 20 Mar 2012 12:00:18 +0000 (12:00 +0000)]
Follow-up to r114256: Removing final assert
Christian Aistleitner [Tue, 20 Mar 2012 11:53:35 +0000 (11:53 +0000)]
Follow up to r114252: Removing asserts
Christian Aistleitner [Tue, 20 Mar 2012 11:11:53 +0000 (11:11 +0000)]
Refactoring dumpTextPass's error handling
Alexandre Emsenhuber [Tue, 20 Mar 2012 10:07:51 +0000 (10:07 +0000)]
* (bug 34735) Updated compressOld.php documentation to mention the different usages of -s and -n parameters depending on compression type
Based on patch by christian@quelltextlich.at - http://bug-attachment.wikimedia.org/attachment.cgi?id=10105
Tim Starling [Tue, 20 Mar 2012 06:19:02 +0000 (06:19 +0000)]
(bug 35316) On autocreate, use $this as the "doer" in the newuser log entry, since unlike User::addNewUserLogEntry(), there is no way the action could have been triggered by a different user. Usually $wgUser is set correctly, but there's no need to rely on it here.
Daniel Friesen [Tue, 20 Mar 2012 05:17:40 +0000 (05:17 +0000)]
Commit the cryptrand project worked on in git:
- MWCryptRand: A new api for generating cryptographic randomness for security tokens. Uses whatever cryptographic source is available and if not falls back to using random state and clock drift.
- wfRandomString - A simple non-cryptographic pesudo-random string generation function to replace wfGenerateToken which was written pretending to be secure when it's really not.
- Core updates to use MWCryptRand in various places:
-- user_token generation (to do this we stop generating user_token implicitly and only generate it when needed to avoid depleting the system's entropy pool by reading random data we'll never use)
-- email confirmation token generation
-- password salt generation
-- temporary password generation
-- Generation of the automatic watchlist token
-- login and create user tokens
-- session ids when php's entropy sources are not set
-- the installer when generating wgSecretKey and the upgrade key
Tim Starling [Tue, 20 Mar 2012 04:52:53 +0000 (04:52 +0000)]
Better bug reference for r114231.
Tim Starling [Tue, 20 Mar 2012 04:39:09 +0000 (04:39 +0000)]
Fixed a few "strip tag exposed" bugs.
* Introduced Parser::killMarkers() based on the concept from StringFunctions. Used it in cases where markerStripCallback() doesn't make sense semantically, namely grammar, padleft, padright and anchorencode. Used markerStripCallback() in other cases.
* Changed headline unstrip order as suggested by P.Copp on bug 18295
* In CPF::lc() and CPF::uc(), removed the is_callable(). This was a temporary testing hack committed by me in r30109, which allowed me to do differential testing against a copy of the parser from before that revision.
Aaron Schulz [Tue, 20 Mar 2012 00:57:18 +0000 (00:57 +0000)]
[FileRepo] Added long-since missing FOR UPDATE to LocalFile::lock(). This might help with the weird mismatched metadata for files with two uploads at the same time that I keep seeing in the DB.
Jeroen De Dauw [Tue, 20 Mar 2012 00:31:10 +0000 (00:31 +0000)]
added enabled field so you can disable the cache thing if you need to before its been initialized and fixed copypaste error
Tim Starling [Tue, 20 Mar 2012 00:28:30 +0000 (00:28 +0000)]
Fixed attempt to write to the wiki's upload directory during parser tests instead of /tmp, this is not allowed. I'm not sure what setupGlobals() is meant to do nowadays, that part is untested. It seems to be duplicated in ParserTest::__construct().
Jeroen De Dauw [Tue, 20 Mar 2012 00:04:36 +0000 (00:04 +0000)]
follow up to r114215, fix some fails and added CachedAction implementing the same stuff as SpecialCachedPage