Paladox [Mon, 8 Jul 2019 22:02:15 +0000 (22:02 +0000)]
Follow-up I3d56d5db5: Add release notes entry
Change-Id: Id836481ade41fdc0ea9951574677407f73f2611a
(cherry picked from commit
cf21cda12cf03f5532b103bc7678fba6299afaed)
jenkins-bot [Mon, 5 Aug 2019 22:52:06 +0000 (22:52 +0000)]
Merge "mediawiki.page.ready: Simplify logout code"
jenkins-bot [Mon, 5 Aug 2019 22:51:10 +0000 (22:51 +0000)]
Merge "Clean up spacing of doc comments"
jenkins-bot [Mon, 5 Aug 2019 22:44:00 +0000 (22:44 +0000)]
Merge "ResourceLoaderClientHtml: Simplify code"
Umherirrender [Mon, 5 Aug 2019 17:00:00 +0000 (19:00 +0200)]
Clean up spacing of doc comments
Align the doc stars and normalize start and end tokens
Change-Id: Ib0d92e128e7b882bb5b838bd00c74fc16ef14303
Fomafix [Sun, 4 Aug 2019 13:10:11 +0000 (15:10 +0200)]
mediawiki.page.ready: Simplify logout code
* Use location.href instead of window.location.
(Better static analysis, and theoretically quicker lookup)
* Initialize variable on declaration.
* Use .then() instead of .done().fail().
Change-Id: If007ae9bad37461cf1a1b51bd4d21281d7778254
jenkins-bot [Mon, 5 Aug 2019 22:11:25 +0000 (22:11 +0000)]
Merge "resourceloader: Move mw.libs and mw.widgets from startup to mediawiki.base"
jenkins-bot [Mon, 5 Aug 2019 22:10:01 +0000 (22:10 +0000)]
Merge "resourceloader: Merge mediawiki.legacy.wikibits into mediawiki.base"
jenkins-bot [Mon, 5 Aug 2019 22:09:55 +0000 (22:09 +0000)]
Merge "resourceloader: Minor optims in startup JS"
jenkins-bot [Mon, 5 Aug 2019 20:59:21 +0000 (20:59 +0000)]
Merge "Improve log entries display in change lists"
Translation updater bot [Mon, 5 Aug 2019 20:13:06 +0000 (22:13 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: Id08ec6c7c9efffd82de8cae27fdd9fa6e0e0f900
jenkins-bot [Mon, 5 Aug 2019 19:24:54 +0000 (19:24 +0000)]
Merge "Add explanatory comment to unexpected line of code"
jdlrobson [Mon, 5 Aug 2019 19:08:57 +0000 (12:08 -0700)]
Improve log entries display in change lists
Log entries are wrapped with parenthesis - not hardcoded into HTML
causing stray brackets in Minerva where this element is floated.
Has no impact on other skins
In addition to this the entire log entry item is wrapped in a new
span mw-changeslist-log-entry to ensure the text is recognised
as a whole entity - on Minerva floats were leading to the action
and the action object being separated (e.g. uploaded and "File:Name
were separated
Bug: T229360
Change-Id: Idae997b15f68bb0dfcaa857f7458ba3497233d41
jenkins-bot [Mon, 5 Aug 2019 19:21:53 +0000 (19:21 +0000)]
Merge "move rcfilters scroll logic to better support mobile mode"
Fomafix [Mon, 5 Aug 2019 18:59:08 +0000 (20:59 +0200)]
ResourceLoaderClientHtml: Simplify code
* Use nowdoc instead of heredoc syntax where variable expansion is not
wanted.
* Combine code paths for debug mode and normal mode.
Change-Id: Ic70d82aaec6396a31783e5a60419409f08c4ef73
jdlrobson [Mon, 5 Aug 2019 18:29:53 +0000 (11:29 -0700)]
Add explanatory comment to unexpected line of code
Bug: T229360
Change-Id: Ia3faab708925c4ea98ebc91cda79ba82ce8524e8
jenkins-bot [Mon, 5 Aug 2019 18:38:39 +0000 (18:38 +0000)]
Merge "rcfilters mobile cleanup"
jenkins-bot [Mon, 5 Aug 2019 18:27:24 +0000 (18:27 +0000)]
Merge "Code style cleanups to FileBackendGroup"
jenkins-bot [Mon, 5 Aug 2019 17:36:51 +0000 (17:36 +0000)]
Merge "Make LinksUpdate no longer extend EnqueueableDataUpdate"
Aaron Schulz [Fri, 12 Jul 2019 04:32:54 +0000 (21:32 -0700)]
Make LinksUpdate no longer extend EnqueueableDataUpdate
LinksUpdate does not match RefreshLinksJob since the former is only a subset
of the later. Also, DeferredUpdates::doUpdates() only runs in "enqueue" mode
for cases in MediaWiki::restInPeace() if there is no post-send support.
In a future commit, the deferred callback in which LinksUpdate runs
currently, will be abstracted into its own deferred update, which
will then bring back EnqueueableDataUpdate for this update.
Bug: T206283
Change-Id: I0680be445e8b8e8d0dba85df135b84640f4fcb81
Jan Drewniak [Mon, 5 Aug 2019 16:55:08 +0000 (18:55 +0200)]
move rcfilters scroll logic to better support mobile mode
Moves the logic that scrolls the rcfilters search input into view
from the onInputFocus callback to the onMenuToggle callback.
This allows the scroll behaviour to be triggered on mobile when
you tap the active filters area, and prevents the scroll behaviour
from triggering when the menu closes on mobile.
Bug: T229360
Change-Id: I1ca5c59e16a5dc6c6f473bbf3825a3e7c1e0f28e
jenkins-bot [Mon, 5 Aug 2019 15:29:16 +0000 (15:29 +0000)]
Merge "OutputPage: Remove 'html5shiv' module from RL registration"
jenkins-bot [Mon, 5 Aug 2019 15:19:01 +0000 (15:19 +0000)]
Merge "Remove old comment and unused setting"
jenkins-bot [Mon, 5 Aug 2019 14:55:11 +0000 (14:55 +0000)]
Merge "Avoid error in querypage API when there's no value field"
jenkins-bot [Mon, 5 Aug 2019 14:55:05 +0000 (14:55 +0000)]
Merge "rdbms: update ILBFactory comments and simplify LoadBalancer "load" code a bit"
jenkins-bot [Mon, 5 Aug 2019 14:43:08 +0000 (14:43 +0000)]
Merge "rdbms: In the query log, show the server name in the message"
Adam Wight [Mon, 5 Aug 2019 14:29:51 +0000 (16:29 +0200)]
Remove old comment and unused setting
Change-Id: I813c90197ba0fc76d493a47f83107ba4bb8dff2a
jenkins-bot [Mon, 5 Aug 2019 14:23:09 +0000 (14:23 +0000)]
Merge "selenium: stop running extensions/skins specs"
Aaron Schulz [Tue, 23 Jul 2019 00:05:40 +0000 (17:05 -0700)]
rdbms: update ILBFactory comments and simplify LoadBalancer "load" code a bit
Change-Id: I391a2f873c623b3086703a9b078def40363d9520
Jan Drewniak [Thu, 1 Aug 2019 15:31:35 +0000 (17:31 +0200)]
rcfilters mobile cleanup
- ensure the advanced filters are hidden when clicking the "hide/show" button
- prevent horizontal scrolling of the "saved filters" and
"other review tools" buttons on small screens.
Bug: T229360
Change-Id: I445df9124a6bb520dcf49b245f0a8392bf723c08
Translation updater bot [Mon, 5 Aug 2019 06:20:20 +0000 (08:20 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I8dfd153ca5be10f42e616ed11039f8e3fc8b7e46
jenkins-bot [Sat, 3 Aug 2019 23:07:46 +0000 (23:07 +0000)]
Merge "changes: Avoid use of deprecated method Revision::userCanBitfield()"
Derick Alangi [Thu, 25 Jul 2019 12:47:57 +0000 (13:47 +0100)]
changes: Avoid use of deprecated method Revision::userCanBitfield()
Revision::userCanBitfield() is deprecated and RevisionRecord should
be used instead.
Change-Id: I0d6ad6863be520d3264809be69532dfb2e3dab9a
Timo Tijhof [Fri, 2 Aug 2019 19:30:11 +0000 (20:30 +0100)]
resourceloader: Merge mediawiki.legacy.wikibits into mediawiki.base
Still executed under the same conditional, but no longer exposed
as its own public module bundle.
Change-Id: Ifba3a73b184ce02eeeeb2ccce6d4aece732dea13
Timo Tijhof [Sat, 3 Aug 2019 21:45:48 +0000 (22:45 +0100)]
OutputPage: Remove 'html5shiv' module from RL registration
Follows-up
66a011797d8e2fd, which changed the reference to this
JS file to be without the indirection of ResourceLoader.
It's been deployed well over the needed 7 days, so this can be
removed now.
Change-Id: I823c0b31c4478e5e34f4191d851b6a9c83a6019b
jenkins-bot [Sat, 3 Aug 2019 02:28:10 +0000 (02:28 +0000)]
Merge "resourceloader: Remove unused 'getBaseModulesInternal' internal method"
jenkins-bot [Fri, 2 Aug 2019 23:10:50 +0000 (23:10 +0000)]
Merge "Use `text` element for current content model on Special:ChangeContentModel"
jenkins-bot [Fri, 2 Aug 2019 22:52:23 +0000 (22:52 +0000)]
Merge "Convert maintenance scripts to LoadBalancer::getMaintenanceConnectionRef()"
Aaron Schulz [Sun, 21 Jul 2019 08:08:11 +0000 (01:08 -0700)]
Convert maintenance scripts to LoadBalancer::getMaintenanceConnectionRef()
Change-Id: I8944a052f51a1941ad3b76a40fc9c46d1363c426
DannyS712 [Fri, 2 Aug 2019 22:16:54 +0000 (22:16 +0000)]
Use `text` element for current content model on Special:ChangeContentModel
Change-Id: I6881154fa5baf4d55634c691c45596f49e2cd4b0
Aaron Schulz [Fri, 2 Aug 2019 22:01:53 +0000 (18:01 -0400)]
Move WANObjectCache to wancache/ instead of WinCache
Follow up
6ca3de5fa0.
Change-Id: I7021dfe5c900f810ab3b6dc701a04e2c3e1c4c66
jenkins-bot [Fri, 2 Aug 2019 20:38:49 +0000 (20:38 +0000)]
Merge "Show current content model on Special:ChangeContentModel"
DannyS712 [Fri, 19 Jul 2019 13:23:09 +0000 (13:23 +0000)]
Show current content model on Special:ChangeContentModel
Bug: T226914
Change-Id: I60c7075751cb180cb86cde0b9caea1a4bcf9b2a3
jenkins-bot [Fri, 2 Aug 2019 20:06:10 +0000 (20:06 +0000)]
Merge "Move WAN cache classes under a new wancache/ directory"
Timo Tijhof [Fri, 2 Aug 2019 19:33:08 +0000 (20:33 +0100)]
resourceloader: Remove unused 'getBaseModulesInternal' internal method
I added this as wrapper for the private 'getBaseModules' method
in commit
dec800968eb6 for "use by SpecialJavaScriptTest", but
I never did. And it doesn't need it so.. let's remove that.
Change-Id: Ia301bd1c1f3a15098b9e6cd2934dd8e80879dd50
Aaron Schulz [Thu, 1 Aug 2019 19:53:31 +0000 (15:53 -0400)]
Reorganize ResourceLoader fields
Change-Id: I9c9aece69b869165b8d9037336c8a2e7d7189c1e
Aaron Schulz [Thu, 1 Aug 2019 19:49:38 +0000 (15:49 -0400)]
resourceloader: reorganize ResourceLoaderModule fields
Also use AtEase for error suppression to avoid phpstorm warnings
Change-Id: Iaa8ca107f4e7c923e894416b40b4fadd2b3d162e
Aaron Schulz [Fri, 2 Aug 2019 03:06:27 +0000 (23:06 -0400)]
Move WAN cache classes under a new wancache/ directory
Change-Id: I6837761ebca7557e029e1f65beca738266e48efb
Timo Tijhof [Fri, 2 Aug 2019 14:41:21 +0000 (15:41 +0100)]
resourceloader: Minor optims in startup JS
Change-Id: I3bb6e77e3572c212ea32838f7668940b5abc99d8
Timo Tijhof [Fri, 2 Aug 2019 14:39:49 +0000 (15:39 +0100)]
resourceloader: Move mw.libs and mw.widgets from startup to mediawiki.base
These are not needed to help define mw.loader or to process RLQ,
as such, it does not need to be in the critical path. This can
instead download as part of mediawiki.base which loads concurrently
with regular modules (but will execute first).
Change-Id: I43f21706206aa7cb6fb779c68325623e07724125
Gergő Tisza [Fri, 2 Aug 2019 13:41:36 +0000 (15:41 +0200)]
Avoid error in querypage API when there's no value field
QueryPage does not require a value field, and post I8b67268e omitting
it might even be useful, so the API should not error out when it's
not present.
Change-Id: I83b49d4451ba71bb2161459bddf17b9ac00088d2
jenkins-bot [Fri, 2 Aug 2019 08:45:12 +0000 (08:45 +0000)]
Merge "Make Special:MovePage note about redirects dependent on content model"
jenkins-bot [Fri, 2 Aug 2019 06:40:17 +0000 (06:40 +0000)]
Merge "Deprecate SearchEngine:getTextFromContent() and SearchEngine::textAlreadyUpdatedForIndex()"
jenkins-bot [Thu, 1 Aug 2019 22:14:13 +0000 (22:14 +0000)]
Merge "Simplify SearchUpdate constructor and hard deprecate some param types"
jenkins-bot [Thu, 1 Aug 2019 21:52:48 +0000 (21:52 +0000)]
Merge "resourceloader: Merge $fileCache conditional blocks"
jenkins-bot [Thu, 1 Aug 2019 21:51:36 +0000 (21:51 +0000)]
Merge "Document SearchDatabase::doSearchTextInDB to return null"
jenkins-bot [Thu, 1 Aug 2019 21:36:37 +0000 (21:36 +0000)]
Merge "Deprecate SearchEngine::userHighlightPrefs()"
jenkins-bot [Thu, 1 Aug 2019 20:59:05 +0000 (20:59 +0000)]
Merge "Fix bogus field use in RevisionRenderer::getSpeculativePageId"
Aaron Schulz [Thu, 1 Aug 2019 18:54:30 +0000 (14:54 -0400)]
Code style cleanups to FileBackendGroup
Set domainId in register() instead of on every config() call.
Use array_merge() to make the override precedence clearer.
Change-Id: I8792281cd9f1a4018255f9a9b87126c909095e68
Aaron Schulz [Thu, 1 Aug 2019 19:57:22 +0000 (15:57 -0400)]
Fix bogus field use in RevisionRenderer::getSpeculativePageId
This field was renamed, causing a functional merge conflict
Follow-up
5099ee9f7273
Bug: T229589
Change-Id: I7a6bb68ff1fe320313276dc5a67c70de6715ccb6
Aaron Schulz [Thu, 1 Aug 2019 18:25:27 +0000 (14:25 -0400)]
Clean up $wgFileBackends/$wgLockManagers comments
Change-Id: Ib9692176f0e100f3b0c39544109ef2d8a8c8cd92
jenkins-bot [Thu, 1 Aug 2019 17:40:05 +0000 (17:40 +0000)]
Merge "Add missing title info in RenderedRevision::outputVariesOnRevisionMetaData()"
jenkins-bot [Thu, 1 Aug 2019 17:39:12 +0000 (17:39 +0000)]
Merge "Cleanup UserGroupMembership::insert() and make it more atomic"
Aaron Schulz [Wed, 31 Jul 2019 02:02:55 +0000 (22:02 -0400)]
Cleanup UserGroupMembership::insert() and make it more atomic
Bug: T229456
Change-Id: Ibf7900dd9273d3befb5c7f0c4ed46b65bd3b0ae4
jenkins-bot [Thu, 1 Aug 2019 17:01:27 +0000 (17:01 +0000)]
Merge "API: Create a module bundle for 'apipretty' and 'apihelp'"
jenkins-bot [Thu, 1 Aug 2019 16:58:26 +0000 (16:58 +0000)]
Merge "filebackend: avoid use of IDatabase::clearFlags() in DBLockManager"
jenkins-bot [Thu, 1 Aug 2019 16:58:17 +0000 (16:58 +0000)]
Merge "resourceloader: Remove getters for private constants in mw.loader.store"
jenkins-bot [Thu, 1 Aug 2019 16:31:57 +0000 (16:31 +0000)]
Merge "Suppress notice from ParserOutput::__sleep()"
jenkins-bot [Thu, 1 Aug 2019 16:28:09 +0000 (16:28 +0000)]
Merge "resourceloader: Remove slow structure test for checking getVersionHash"
David Causse [Thu, 1 Aug 2019 14:58:33 +0000 (16:58 +0200)]
Deprecate SearchEngine:getTextFromContent() and SearchEngine::textAlreadyUpdatedForIndex()
It was just a wrapper to Content::getTextForSearchIndex(), simply use
this method rather than depending on (and sometimes constructing) a
SearchEngine.
Change-Id: I8541248ffdca303f0af3b959cf2f051dcb497925
Timo Tijhof [Thu, 1 Aug 2019 00:19:45 +0000 (01:19 +0100)]
resourceloader: Remove slow structure test for checking getVersionHash
This isn't needed because the startup module validates this already.
The vast majority of modules are FileModule instances which can't be invalid,
because a separate test asserts that class already. This test existed for
validating the format of version hashes returned by a theoretical Module
sub class in an extension that (badly) overrides the getVersionHash method.
As of writing, no extension overrides that method. And more importantly,
the startup module already validates this at run-time, and logs a warning.
This commit turns that into an exception, which would get logged in a way
that Jenkins will fail the build if encountered.
This structure test, which computed the response for all registered modules,
previously took 3-5 seconds in CI.
Bug: T225730
Change-Id: Id2e37434b0ccd95dd2279f04e2230e9c06b09ccb
David Causse [Thu, 1 Aug 2019 10:13:45 +0000 (12:13 +0200)]
Simplify SearchUpdate constructor and hard deprecate some param types
Change-Id: I5677041169402014f1afc1a9012460c760ca24b6
David Causse [Thu, 1 Aug 2019 09:46:24 +0000 (11:46 +0200)]
Deprecate SearchEngine::userHighlightPrefs()
was only returning two constants and forced a cyclic dep bewteen
SearchEngine and its SearchResult instance.
Simple make these values a constant in SearchHighlighter and use
them as default values for the highlight methods.
Change-Id: Ia78408d5266d0a305006027fe6265a2a1d68b0b9
jenkins-bot [Thu, 1 Aug 2019 11:42:11 +0000 (11:42 +0000)]
Merge "resourceloader: Avoid escaping of UTF-8 characters in messages"
Aaron Schulz [Thu, 1 Aug 2019 08:11:49 +0000 (04:11 -0400)]
Add missing title info in RenderedRevision::outputVariesOnRevisionMetaData()
Follows
3a044ca51ce9b.
Bug: T226785
Change-Id: I03cf35ee2773cfeb887edec8bc447c834bab5a2a
Fomafix [Tue, 30 Jul 2019 04:52:59 +0000 (06:52 +0200)]
resourceloader: Avoid escaping of UTF-8 characters in messages
It's not needed to escape UTF-8 characters in messages.
The characters '&', '<' and '>' are still escaped. For the output in
load.php this escaping is not necessary but messages can also embedded
into <script> tags and here are the characters '<' and '>' problematic.
Bug: T229301
Change-Id: If424a21df4a813ba6cb79b939f0857d96f162a17
Bartosz Dziewoński [Thu, 1 Aug 2019 02:32:02 +0000 (04:32 +0200)]
mediawiki.Upload.BookletLayout: Add missing message
Bug: T203058
Change-Id: If1274da9b9dca5595201c298ffd35576ef7b7e52
Timo Tijhof [Thu, 1 Aug 2019 00:40:19 +0000 (01:40 +0100)]
resourceloader: Remove getters for private constants in mw.loader.store
Turn the private getter methods into private properties.
Shorter, simpler, faster.
Change-Id: I8c7a7c566983ba6ac78cd2feb5d0ec6debb3773c
Tim Starling [Thu, 1 Aug 2019 00:08:38 +0000 (10:08 +1000)]
Suppress notice from ParserOutput::__sleep()
Bug: T229366
Change-Id: I8f0a537f0b6b76aac0c52e691ec4653c51c49940
jenkins-bot [Thu, 1 Aug 2019 00:01:08 +0000 (00:01 +0000)]
Merge "Make CliInstaller control the processing logic of the error"
jenkins-bot [Wed, 31 Jul 2019 23:07:22 +0000 (23:07 +0000)]
Merge "context: Use getRawVal instead of getVal for 'uselang' and 'useskin'"
jenkins-bot [Wed, 31 Jul 2019 20:42:59 +0000 (20:42 +0000)]
Merge "Localisation updates from https://translatewiki.net."
jenkins-bot [Wed, 31 Jul 2019 20:11:03 +0000 (20:11 +0000)]
Merge "Fix documentation of languageinfo name prop"
Translation updater bot [Wed, 31 Jul 2019 20:07:56 +0000 (22:07 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: Ie2a14a24bf788729b75ce23b7fec1b0bf5d9c02e
jenkins-bot [Wed, 31 Jul 2019 17:34:55 +0000 (17:34 +0000)]
Merge "resourceloader: Remove deprecated ResourceLoaderContext::expandModuleNames"
jenkins-bot [Wed, 31 Jul 2019 16:58:32 +0000 (16:58 +0000)]
Merge "resourceloader: Only register 'jquery.qunit' in test context"
jenkins-bot [Wed, 31 Jul 2019 16:58:26 +0000 (16:58 +0000)]
Merge "resourceloader: Don't explicitly enqueue test libs on SpecialJavaScriptTest"
jenkins-bot [Wed, 31 Jul 2019 16:52:13 +0000 (16:52 +0000)]
Merge "resourceloader: Hard-deprecate ResourceLoaderContext::getConfig"
Umherirrender [Fri, 5 Jul 2019 20:14:51 +0000 (22:14 +0200)]
Document SearchDatabase::doSearchTextInDB to return null
The function calling this abstract function allows to return null,
so it should be okay to return null here
The null for empty result in SearchOracle
Change-Id: I66a8fb3a4190bf5506f358a47f6f4833b1715c7f
jenkins-bot [Wed, 31 Jul 2019 15:06:33 +0000 (15:06 +0000)]
Merge "preferences: Fix skinname msg check in generateSkinOptions"
jenkins-bot [Wed, 31 Jul 2019 14:15:14 +0000 (14:15 +0000)]
Merge "Add QueryPage::delete method"
Timo Tijhof [Tue, 30 Jul 2019 14:25:23 +0000 (15:25 +0100)]
resourceloader: Hard-deprecate ResourceLoaderContext::getConfig
Already in 1.34 release notes from when it was soft-deprecated, earlier
this release cycle.
Depends-On: I949b91daabb0cf16519ef02e718ad97c827c4eec
Depends-On: Icf1ead8829268505709c71f46dede5cdfc4471a8
Change-Id: I471088b322848a779d0dd58651dc1bd0d49067f1
jenkins-bot [Wed, 31 Jul 2019 13:28:54 +0000 (13:28 +0000)]
Merge "Allow SelectWithInput to be marked as required and handle that dynamically"
jenkins-bot [Wed, 31 Jul 2019 12:36:45 +0000 (12:36 +0000)]
Merge "Fix SpecialBlock validation for ipb_allow_usertalk"
Tim Starling [Wed, 31 Jul 2019 02:16:07 +0000 (12:16 +1000)]
Revert rename of mSpeculativeRevId to speculativeRevIdUsed
And add a test which is confirmed to fail on HHVM prior to this change
with the error message "serialize(): "" returned as member variable from
__sleep() but does not exist".
Bug: T229366
Change-Id: I236bb4d64bc2e9f7756885e8c418399804eac5e1
jdlrobson [Tue, 30 Jul 2019 21:18:05 +0000 (14:18 -0700)]
preferences: Fix skinname msg check in generateSkinOptions
Fixes a bug introduced in
b2b204eeafc.
$useSkin is not the appropriate variable to check here - we want
to check the skin set in preferences.
Bug: T223824
Change-Id: I666e30dd9ff396fd39c47b362d66670dfaa92ca9
jenkins-bot [Tue, 30 Jul 2019 21:44:56 +0000 (21:44 +0000)]
Merge "context: Make the getSkin() fallback logic more explicit"
jenkins-bot [Tue, 30 Jul 2019 21:44:49 +0000 (21:44 +0000)]
Merge "Fix recent changes and watchlist separator whitespace"
David Barratt [Mon, 22 Jul 2019 22:53:14 +0000 (18:53 -0400)]
Allow SelectWithInput to be marked as required and handle that dynamically
Alters the SelectWithInput to allow a required config to be passed from a
parent widget. Also handles the required state dynamically. If the widget is
an OR widget, then only the select dropdown is required. The text input will
be required when the other option is selected. If the widget is an AND widget
then both the select dropdown and the text input will be required.
Bug: T220533
Change-Id: I8479743126756f2b1bd7bcd53b100a0134f34d07
jenkins-bot [Tue, 30 Jul 2019 20:26:36 +0000 (20:26 +0000)]
Merge "Fix return type hints in media related classes"