* Removed ./tests/qunit/index.html from core. It wasn't actively maintained and
has been made obsolete when [[Special:JavaScriptTest/qunit]] was introduced,
which actually uses ResourceLoader, LocalSettings and the Skin.
+* Removed $wgDBtransactions global. This was only checked in one class
+ and only applies to MyISAM or similar DBs. Those should only be used
+ for archived sites anyway. We can't get edit conflicts on such sites,
+ so the WikiPage code wasn't useful there either.
== Compatibility ==
*/
$wgDBAvgStatusPoll = 2000;
-/** Set to true if using InnoDB tables */
-$wgDBtransactions = false;
-
/**
* Set to true to engage MySQL 4.1/5.0 charset-related features;
* for now will just cause sending of 'SET NAMES=utf8' on connect.
* Compatibility note: this function previously returned a boolean value indicating success/failure
*/
public function doEdit( $text, $summary, $flags = 0, $baseRevId = false, $user = null ) {
- global $wgUser, $wgDBtransactions, $wgUseAutomaticEditSummaries;
+ global $wgUser, $wgUseAutomaticEditSummaries;
# Low-level sanity check
if ( $this->mTitle->getText() === '' ) {
return $status;
}
- # Make sure the revision is either completely inserted or not inserted at all
- if ( !$wgDBtransactions ) {
- $userAbort = ignore_user_abort( true );
- }
-
$revision = new Revision( array(
'page' => $this->getId(),
'comment' => $summary,
/* Belated edit conflict! Run away!! */
$status->fatal( 'edit-conflict' );
- # Delete the invalid revision if the DB is not transactional
- if ( !$wgDBtransactions ) {
- $dbw->delete( 'revision', array( 'rev_id' => $revisionId ), __METHOD__ );
- }
-
$revisionId = 0;
$dbw->rollback( __METHOD__ );
} else {
$revision->setId( $this->getLatest() );
}
- if ( !$wgDBtransactions ) {
- ignore_user_abort( $userAbort );
- }
-
// Now that ignore_user_abort is restored, we can respond to fatal errors
if ( !$status->isOK() ) {
wfProfileOut( __METHOD__ );