From: Domas Mituzas <midom@users.mediawiki.org>
Date: Tue, 27 Oct 2009 09:57:49 +0000 (+0000)
Subject: with all due respect, locking here doesn't seem to be needed :)
X-Git-Tag: 1.31.0-rc.0~39083
X-Git-Url: https://git.cyclocoop.org/%7B%24admin_url%7Dcompta/operations/modifier.php?a=commitdiff_plain;h=1218c6463fecc4df5bdc28249d867d0402af1f0b;p=lhc%2Fweb%2Fwiklou.git

with all due respect, locking here doesn't seem to be needed :)
---

diff --git a/languages/LanguageConverter.php b/languages/LanguageConverter.php
index a1f6681de1..4ef1e9e7df 100644
--- a/languages/LanguageConverter.php
+++ b/languages/LanguageConverter.php
@@ -639,33 +639,6 @@ class LanguageConverter {
 		return $this->mTitleDisplay;
 	}
 
-	/**
-	 * a write lock to the cache
-	 *
-	 * @private
-	 */
-	function lockCache() {
-		global $wgMemc;
-		$success = false;
-		for($i=0; $i<30; $i++) {
-			if($success = $wgMemc->add($this->mCacheKey . "lock", 1, 10))
-				break;
-			sleep(1);
-		}
-		return $success;
-	}
-
-	/**
-	 * unlock cache
-	 *
-	 * @private
-	 */
-	function unlockCache() {
-		global $wgMemc;
-		$wgMemc->delete($this->mCacheKey . "lock");
-	}
-
-
 	/**
 	 * Load default conversion tables
 	 * This method must be implemented in derived class
@@ -706,11 +679,8 @@ class LanguageConverter {
 
 			$this->postLoadTables();
 			$this->mTables[self::CACHE_VERSION_KEY] = true;
-
-			if($this->lockCache()) {
-				$wgMemc->set($this->mCacheKey, $this->mTables, 43200);
-				$this->unlockCache();
-			}
+			
+			$wgMemc->set($this->mCacheKey, $this->mTables, 43200);
 			wfProfileOut( __METHOD__.'-recache' );
 		}
 		wfProfileOut( __METHOD__ );