jenkins-bot [Thu, 2 Apr 2015 15:30:07 +0000 (15:30 +0000)]
Merge "Remove redundant NS_MAIN from translations"
jenkins-bot [Thu, 2 Apr 2015 14:17:54 +0000 (14:17 +0000)]
Merge "Change labels of paging links in Category page"
jenkins-bot [Thu, 2 Apr 2015 13:25:28 +0000 (13:25 +0000)]
Merge "Message: Clean up unit tests and improve code coverage"
Timo Tijhof [Thu, 2 Apr 2015 07:01:38 +0000 (08:01 +0100)]
Message: Clean up unit tests and improve code coverage
* Remove unnecessary use of ReflectionClass. It was testing
internal properties that aren't part of the API. Using the
getters instead.
* Remove need for func_get_args that was making the test more
complex and the data provider hard to read. Simply maintain
it as array of expected params and array of variadic arguments.
* Rename tests to more closely match tested methods.
* Rename data providers to provide*, and make them static.
* Reorder tests to more closely match logical order of the class.
* Improve line coverage from 31% to 67%.
Also:
* Remove testParams (dupes testConstructorParams).
* Add tests for RawMessage class.
* Add tests for transformation and parsing.
* Add tests for wfMessage().
* Add tests for Message::newFrom*.
* Add tests for "$*" replacement.
* Add tests for __toString.
Change-Id: I2b183a66f9e9f51bd800088e174b1ae4d3284d8d
Timo Tijhof [Thu, 2 Apr 2015 01:15:50 +0000 (02:15 +0100)]
User: Add unit tests for getId, isAnon and isLoggedIn
Change-Id: Ie007d9da47df871f99ca19c4d7364f46f71c255b
Ori Livneh [Thu, 2 Apr 2015 04:09:20 +0000 (21:09 -0700)]
Follow-up to Icf644ad34: Introduce ProfilerOutputStats
Change-Id: Ib3585303b75899c4cd7c9c88fb3473b441e52c23
Ori Livneh [Wed, 1 Apr 2015 23:30:16 +0000 (16:30 -0700)]
Introduce ProfilerOutputStats
* Associate Profiler objects with a request context by adding a $context
property with a getter and a setter.
* Introduce ProfilerOutputStats, which writes profiling data to the stats
buffer associated with the current request context.
* Make it the Profiler class's responsibility to enforce $wgProfilerLimit.
* Deprecate $wgProfilerLimit in favor of the (more aptly named, IMO)
$wgProfiler['threshold'] config setting.
* Tidy up Profiler instance creation code in Profiler::instance().
* Add Profiler::getOutputs, which returns an array of ProfilerOutput instances
which are configured for the current profiler and whose canUse() method
returns true.
* Make ProfilerStub not log by creating a stub ProfilerStub::logData() method
which does not call the parent. Previously the parent class checked if $this
was an instance of ProfilerStub and returned early if so.
Task: T90623
Task: T85641
Change-Id: Icf644ad3435c1f30d0a49957a97b481808a3153d
Ori Livneh [Wed, 1 Apr 2015 23:16:09 +0000 (16:16 -0700)]
Make WebRequest objects time-aware
* Deprecate $wgRequestTime in favor of $_SERVER['REQUEST_TIME_FLOAT'], which is
more accurate. Because $_SERVER['REQUEST_TIME_FLOAT'] is only set for PHP
5.4+, set it to microtime( true ) in WebStart.php for back-compatibility.
* Add a 'requestTime' property to WebRequest objects, set to
$_SERVER['REQUEST_TIME_FLOAT'] for WebRequest or the instance creation time
for FauxRequest instances.
* Use that to provide WebRequest::getElapsedTime(), which gets the time since
the request was initiated.
* In wfLogProfilingData(), get the user and request objects from the context
object rather than from global scope.
Opportunistic clean-up: move the magic quotes check to WebStart.php and make
the error message more helpful.
Change-Id: I7e07e22eaf16b5141b80ad9f843285c542a127b7
jenkins-bot [Wed, 1 Apr 2015 22:27:33 +0000 (22:27 +0000)]
Merge "tests: Clean up file headers"
jenkins-bot [Wed, 1 Apr 2015 22:27:27 +0000 (22:27 +0000)]
Merge "installer: Use wfLoadExtension/Skin in LocalSettingsGenerator"
jenkins-bot [Wed, 1 Apr 2015 20:48:50 +0000 (20:48 +0000)]
Merge "Sync up with Parsoid parserTests."
jenkins-bot [Wed, 1 Apr 2015 20:18:28 +0000 (20:18 +0000)]
Merge "ResourceLoaderImageModule: Remove stupid TODO"
Subramanya Sastry [Wed, 1 Apr 2015 20:07:44 +0000 (15:07 -0500)]
Sync up with Parsoid parserTests.
This now aligns with Parsoid commit
ea9c04956577c35ec15609a966bf5a4d5541ab45
Change-Id: I310a0c652eb41a9845cfaa3c90262762b6ee4cc8
jenkins-bot [Wed, 1 Apr 2015 19:46:19 +0000 (19:46 +0000)]
Merge "Make all QUnit tests pass for languages other than English"
Translation updater bot [Wed, 1 Apr 2015 19:37:35 +0000 (19:37 +0000)]
Merge "Localisation updates from https://translatewiki.net."
Bartosz Dziewoński [Wed, 1 Apr 2015 19:35:43 +0000 (21:35 +0200)]
ResourceLoaderImageModule: Remove stupid TODO
Change-Id: I36ade1713b593504a34b1ec92bc4d9e536aa262a
Schnark [Tue, 24 Mar 2015 10:33:47 +0000 (10:33 +0000)]
Make all QUnit tests pass for languages other than English
Some tablesorter tests were failing for a content language different from
English, and the test for two functions from mw.language for a different
UI language.
This patch provides a mocked environment for all these tests, simulating
English language.
Bug: T59776
Change-Id: Ibfc83c34a896dc5fb5e892fb0ffd60e618880781
Translation updater bot [Wed, 1 Apr 2015 19:31:59 +0000 (21:31 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I32d1c7cf05c4981322f4111c8d997f08b79b05bf
Bartosz Dziewoński [Mon, 30 Mar 2015 17:27:31 +0000 (19:27 +0200)]
ResourceLoaderImageModule: Remove bogus CSSJanus call
We explicitly do not want to use CSSJanus flipping here, as
ResourceLoaderImage has a separate and more sophisticated mechanism
for choosing the right image for given language. This was a no-op,
since there were no flippable paths in the output at this point.
Change-Id: Ieff5f21653504a28afe3d4c110a52d8b06fc6a07
jenkins-bot [Wed, 1 Apr 2015 19:05:30 +0000 (19:05 +0000)]
Merge "Use "string|false" as @return instead of "string|bool" where appropiate"
Bartosz Dziewoński [Wed, 1 Apr 2015 17:45:26 +0000 (19:45 +0200)]
Resources.php: Remove duplicate copy of 'oojs-ui.styles' module
derp
Change-Id: Id7cd440888818e387f5cae68a5a63d73d3e11876
jenkins-bot [Wed, 1 Apr 2015 17:40:17 +0000 (17:40 +0000)]
Merge "SECURITY: Don't allow entities in XMP with HHVM"
jenkins-bot [Wed, 1 Apr 2015 17:40:13 +0000 (17:40 +0000)]
Merge "SECURITY: Don't allow directly calling Xml::isWellFormed"
jenkins-bot [Wed, 1 Apr 2015 17:40:10 +0000 (17:40 +0000)]
Merge "SECURITY: Always expand xml entities when checking SVG's"
jenkins-bot [Wed, 1 Apr 2015 17:32:01 +0000 (17:32 +0000)]
Merge "SECURITY: Escape > in Html::expandAttributes"
jenkins-bot [Wed, 1 Apr 2015 17:31:57 +0000 (17:31 +0000)]
Merge "SECURITY: Don't execute another user's CSS or JS on preview"
jenkins-bot [Wed, 1 Apr 2015 17:31:54 +0000 (17:31 +0000)]
Merge "SECURITY: Set maximal password length for DoS"
jenkins-bot [Wed, 1 Apr 2015 17:18:23 +0000 (17:18 +0000)]
Merge "OutputPage: Tiny tweak to jQuery.ready inline script"
Ori Livneh [Wed, 1 Apr 2015 08:48:29 +0000 (01:48 -0700)]
OutputPage: Tiny tweak to jQuery.ready inline script
Changing 'window.jQuery && jQuery.ready()' to 'if ( window.jQuery )
jQuery.ready()' means no *<![CDATA[*/ /*]]>* is required (because we
got rid of the ampersands). It's also more readable and more consistent
with if(window.mw).
Change-Id: I28262efb978c085e732b40f9dc5ddb1bda5c4376
csteipp [Thu, 12 Mar 2015 22:49:22 +0000 (15:49 -0700)]
SECURITY: Don't allow entities in XMP with HHVM
Test for, and refuse to parse, XMP chunks with a doctype declaration
when parsing XMP under HHVM.
Bug: T85848
Change-Id: Iea4feb077ee85a35509a920153daaa9321ee69f3
csteipp [Fri, 13 Mar 2015 23:52:18 +0000 (16:52 -0700)]
SECURITY: Don't allow directly calling Xml::isWellFormed
Changing Xml::isWellFormed to private. In WMF hosted repos, there are
no callers to isWellFormed directly.
Bug: T85848
Change-Id: I104427989b89c386de571b8e60642095331a1132
csteipp [Wed, 4 Feb 2015 01:45:05 +0000 (17:45 -0800)]
SECURITY: Always expand xml entities when checking SVG's
XmlTypeCheck's use of xml_parse for filtering SVG's sometimes left xml
entities unexpanded, which can lead to false-negatives when the
callback was used for filtering. Update XmlTypeCheck to use XMLReader
instead, tell the library to fully expand entities, and rely on the
library to error out if it encounters XML that is likely to cause a DoS
if parsed.
Bug: T88310
Change-Id: I77c77a2d6d22f549e7ef969811f7edd77a45dbba
csteipp [Thu, 19 Feb 2015 23:05:40 +0000 (15:05 -0800)]
SECURITY: Escape > in Html::expandAttributes
Escape > characters in attributes, so we don't confuse post-processing,
like LanguageConverter.
Bug: T73394
Change-Id: I768e2a12c7b6ba635e6c8571676b8c776b16bf72
Brad Jorsch [Mon, 5 Jan 2015 21:31:26 +0000 (16:31 -0500)]
SECURITY: Don't execute another user's CSS or JS on preview
Someone could theoretically try to hide malicious code in their user
common.js and then trick an admin into previewing it by asking for help.
Bug: T85855
Change-Id: I5a7a75306695859df5d848f6105b81bea0098f0a
Tyler Romeo [Fri, 26 Dec 2014 16:29:15 +0000 (11:29 -0500)]
SECURITY: Set maximal password length for DoS
Prevent DoS attacks caused by the amount of time
it takes to hash long passwords by setting a limit
on password length.
Slightly restructures the behavior of User::checkPasswordValidity
in order to accommodate for the difference between
passwords the user should be able to log in with and
passwords they should not.
Bug: T64685
Change-Id: I24f33474c6f934fb8d94bb054dc23093abfebd5e
csteipp [Wed, 14 Jan 2015 00:48:01 +0000 (16:48 -0800)]
SECURITY: Fix animate blacklist
The blacklist should prevent animating any element's xlink:href to a
javascript url.
Bug: T86711
Change-Id: Ia9e9192165fdfe1701f22605eee0b0e5c9137d5a
csteipp [Tue, 13 Jan 2015 01:00:45 +0000 (17:00 -0800)]
SECURITY: Don't allow embedded application/xml in SVG's
Fix for iSEC-WMF1214-11 and issue reported by Cure 53, which got
around our blacklist on embedded href targets. Use a whitelist instead.
Bug: T85850
Change-Id: I17b7ed65935b818695a83fd901fcaf90fffecf28
Tyler Romeo [Tue, 30 Dec 2014 20:24:04 +0000 (15:24 -0500)]
SECURITY: Make SVG @import checking case insensitive
@import in embedded CSS is case-insensitive, meaning
an attacker can put "@iMpOrT" and it should still
work.
This uses stripos instead of strpos to make the check
case insensitive.
Bug: T85349
Change-Id: I31db9d81f46460af2d8d3f161ba46c2ab7a170d1
jenkins-bot [Wed, 1 Apr 2015 14:49:25 +0000 (14:49 +0000)]
Merge "API: Reduce volume of "continue format is changing" warning"
jenkins-bot [Wed, 1 Apr 2015 14:41:02 +0000 (14:41 +0000)]
Merge "New hook: OpportunisticLinksUpdate"
Brad Jorsch [Wed, 1 Apr 2015 12:23:20 +0000 (08:23 -0400)]
API: Reduce volume of "continue format is changing" warning
It's excessively difficult to determine if the logs of people hitting
this warning are really going to be affected by the change or if they're
making queries where it won't actually matter.
Since 1.26 is coming soon, and with it the decision as to whether to
pull the switch on I984e6358, let's retarget the warnings to those cases
where it's possible it would actually break someone's code.
Change-Id: I91f170fd7d4c791ca8f5d3592c888700f4d5aa97
jenkins-bot [Wed, 1 Apr 2015 12:08:05 +0000 (12:08 +0000)]
Merge "Special:LinkSearch: display links to pages in content language"
daniel [Wed, 18 Mar 2015 17:21:25 +0000 (18:21 +0100)]
New hook: OpportunisticLinksUpdate
Change-Id: I8b9238cd6b0010ad91fae24d4eb1e7cd0c201931
Timo Tijhof [Wed, 1 Apr 2015 08:48:30 +0000 (09:48 +0100)]
Use "string|false" as @return instead of "string|bool" where appropiate
This makes sure static analyzers don't warn for supposedly unsafe
code accessing variables as strings when they could be boolean after
having only checked against false.
https://github.com/scrutinizer-ci/php-analyzer/issues/605
Change-Id: Idb676de7587f1eccb46c12de0131bea4489a0785
Niklas Laxström [Wed, 1 Apr 2015 08:17:10 +0000 (10:17 +0200)]
Remove redundant NS_MAIN from translations
Change-Id: Ia01549310909281e48260950f97a8f6fa12ae230
Kunal Mehta [Wed, 1 Apr 2015 07:07:44 +0000 (00:07 -0700)]
installer: Use wfLoadExtension/Skin in LocalSettingsGenerator
Bug: T87791
Change-Id: I37cede7396d9677466ec68289702a3a73f1a1f8a
Kunal Mehta [Wed, 1 Apr 2015 07:01:41 +0000 (00:01 -0700)]
installer: Reduce some code duplication in LocalSettingsGenerator
Change-Id: Ie3c2e56ac4d20d6d547e89a4d6c6331f4222409b
ayush_garg [Tue, 31 Mar 2015 10:51:36 +0000 (16:21 +0530)]
Special:LinkSearch: display links to pages in content language
Bug: T66064
Change-Id: Ib2af28bec7b9c6ec01c5628be07e1280cbbd2f83
jenkins-bot [Wed, 1 Apr 2015 00:19:04 +0000 (00:19 +0000)]
Merge "Made InfoAction::invalidateCache() use READ_LATEST"
Aaron Schulz [Mon, 30 Mar 2015 22:50:39 +0000 (15:50 -0700)]
Made InfoAction::invalidateCache() use READ_LATEST
Change-Id: I794c443b9d65d924366eff9baaf4460ce196a967
Aaron Schulz [Thu, 26 Mar 2015 00:29:31 +0000 (17:29 -0700)]
Added slave/master fallback logic in Revision
* This is a more specific form of the logic removed in
3c2bc32ae1.
It does not suffer the problem of causing constant master DB
queries due to a bad template reference or such.
* It will use the master if writes from the current thread
are pending or were recently committed. This deals with the
common problem of code that needs to read things it just wrote,
such as diffs on rollback or edit hooks.
* This commit reverts
8624e261f by making the hack obsolete.
Bug: T93866
Bug: T94407
Change-Id: Ib9ecb75e1236e767bdc86d124d5e22a03ae0fb5f
Timo Tijhof [Tue, 31 Mar 2015 22:52:31 +0000 (23:52 +0100)]
tests: Clean up file headers
* Remove redundant @licence/@license from test suite files.
They already have full licence headers. And @licence raises a
warning in Doxygen.
* Fix weird messes of comments inside comments and other things.
Change-Id: I38da8ca76330f72b8dc22b0ecf1ea69d5ea55ede
jenkins-bot [Tue, 31 Mar 2015 22:38:38 +0000 (22:38 +0000)]
Merge "mw.track: Add test suite"
Timo Tijhof [Fri, 27 Mar 2015 23:54:45 +0000 (23:54 +0000)]
mw.track: Add test suite
Change-Id: I3ad2c0b5b993e3a0c67b420ff1768131e8f3b3b6
Timo Tijhof [Tue, 31 Mar 2015 18:17:11 +0000 (19:17 +0100)]
resourceloader: Simplify getHashMtime() to merely a timestamp
Similar to what getDefinitionMtime() does already. No need to
repeat the hash. No need for an array that needs serialising and
unserialising internally.
Change the hash key to avoid using old cache values.
Also moved the comment about hashes being included in the key to
this method. getDefinitionMtime() is a later method that performs
the same logic but doesn't need the entire story again.
Follows-up
044713c4,
d3bdda32.
Change-Id: Idd83de5ac27138a2dbf2ec49d81ea9188bd6ad57
jenkins-bot [Tue, 31 Mar 2015 19:06:41 +0000 (19:06 +0000)]
Merge "ResourceLoaderImage: Some cleanup, typo fixes and tweaks"
jenkins-bot [Tue, 31 Mar 2015 19:06:39 +0000 (19:06 +0000)]
Merge "ResourceLoaderImage: Throw exception if files don't exist"
Translation updater bot [Tue, 31 Mar 2015 18:55:19 +0000 (18:55 +0000)]
Merge "Localisation updates from https://translatewiki.net."
jenkins-bot [Tue, 31 Mar 2015 18:52:30 +0000 (18:52 +0000)]
Merge "Fix capitaliation of UtfNormal namespace"
Translation updater bot [Tue, 31 Mar 2015 18:51:49 +0000 (20:51 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I96ad4039d7c301dd444197040a6de86b6221ccea
jenkins-bot [Tue, 31 Mar 2015 18:51:41 +0000 (18:51 +0000)]
Merge "Add SpecialLog::getLogTypesOnUser()"
jenkins-bot [Tue, 31 Mar 2015 18:42:12 +0000 (18:42 +0000)]
Merge "resourceloader: De-duplicate $files in ResourceLoaderFileModule::getModifiedTime()"
Kunal Mehta [Tue, 31 Mar 2015 18:41:43 +0000 (11:41 -0700)]
Fix capitaliation of UtfNormal namespace
Change-Id: I18f68da0e36ef148a8235516f2ed72b4b3190208
Timo Tijhof [Tue, 31 Mar 2015 18:01:15 +0000 (19:01 +0100)]
resourceloader: De-duplicate $files in ResourceLoaderFileModule::getModifiedTime()
lessc::allParsedFiles() always includes the main file we already
know about. As such needlessly causing it to be queried multiple
times.
Change-Id: Icd2c11d93d6491664fcf58a18bfe6e2932689774
Timo Tijhof [Tue, 31 Mar 2015 18:23:58 +0000 (19:23 +0100)]
profiler: Consolidate duplicate branches in ProfilerOutputText
Follows-up
3ca6ab103166c.
Change-Id: I342c68990301a303425c83847406dcf3b308bd27
jenkins-bot [Tue, 31 Mar 2015 18:08:19 +0000 (18:08 +0000)]
Merge "Made text profiling actually work with load.php"
jenkins-bot [Tue, 31 Mar 2015 18:00:30 +0000 (18:00 +0000)]
Merge "Fixed {{REVISION(TIMESTAMP|USER|SIZE)}} on new revisions"
Aaron Schulz [Tue, 31 Mar 2015 07:44:08 +0000 (00:44 -0700)]
Made text profiling actually work with load.php
Change-Id: I8d28ad8669e8c2f5d7025fe67fb75d0551975e07
Aaron Schulz [Tue, 31 Mar 2015 08:15:57 +0000 (01:15 -0700)]
Rely less on file stat cache in FileDependency
Change-Id: Ica16ddb7db00a56a16332c4dbb9a04e7b40a1844
Aaron Schulz [Tue, 31 Mar 2015 07:59:40 +0000 (00:59 -0700)]
resourceloader: Cut down on file stat time in safeFilemtime()
* If stat cache is not enabled, this used to do two queries.
Change-Id: Icfed675b27f952ec13b9d0af3e345b1486ea7c8f
jenkins-bot [Tue, 31 Mar 2015 06:47:02 +0000 (06:47 +0000)]
Merge "Use HTMLForm for Special:FileDuplicateSearch"
Kunal Mehta [Sun, 29 Mar 2015 09:14:08 +0000 (02:14 -0700)]
exception: Log fatal errors to a new 'fatal' log group
'error' is currently disabled in Wikimedia production, but we still need
to log stack traces for fatals.
Bug: T89169
Change-Id: Id0255651f228037152b87022f5eb696c1050b9ec
Aaron Schulz [Tue, 31 Mar 2015 04:00:13 +0000 (21:00 -0700)]
Fixed {{REVISION(TIMESTAMP|USER|SIZE)}} on new revisions
* This makes use of the injected new revision object used elsewhere
in Parser to solve this problem.
Bug: T94407
Change-Id: I7881583cf7cb2bc799c89ffaa2a344a2d4ca3a4e
jenkins-bot [Tue, 31 Mar 2015 00:55:05 +0000 (00:55 +0000)]
Merge "registration: Have wfLoadExtension() (and similar) use the queue"
jenkins-bot [Tue, 31 Mar 2015 00:53:17 +0000 (00:53 +0000)]
Merge "registration: Use array_merge() rather than array plus when merging"
jenkins-bot [Tue, 31 Mar 2015 00:51:20 +0000 (00:51 +0000)]
Merge "Adding mobile target to mediawiki.template.mustache"
jenkins-bot [Tue, 31 Mar 2015 00:51:16 +0000 (00:51 +0000)]
Merge "Use wikimedia/utfnormal library, add backwards-compatability layer"
jenkins-bot [Tue, 31 Mar 2015 00:51:08 +0000 (00:51 +0000)]
Merge "Category view modified to use column width"
Kunal Mehta [Mon, 30 Mar 2015 21:35:45 +0000 (14:35 -0700)]
registration: Have wfLoadExtension() (and similar) use the queue
Right now wfLoadExtension() and related functions explicitly load
extensions immediately, bypassing the queue. This was done to be
extremely backwards-compatible with the old require_once style of
loading which does the same.
However, for a future configuration database to work, we need to be able
to reliably load extensions after configuration (LocalSettings.php) is
loaded, which is currently at the top of Setup.php. Rather than doing
this later, we should do this now to make sure the registration system
will be able to handle it.
In Wikimedia production, excentions are currently being loaded with
direct calls to:
ExtensionRegistry::getInstance()->queue(...);
so we know that this should work, but that is not a nice API for sysadmins
and developers to be entering into LocalSettings.php.
If for some reason an extension really needs to be loaded immediately,
they can still call:
ExtensionRegistry::getInstance()->loadFromQueue();
But that should be the exception, not the norm.
Change-Id: I72672e5c9541ede02d09f548c39ef6c8df0ec78a
Roan Kattouw [Tue, 31 Mar 2015 00:39:36 +0000 (17:39 -0700)]
registration: Use array_merge() rather than array plus when merging
Because plus doesn't deal with numerical keys well. We do need old values
to win, because LocalSettings.php runs before extension.json files.
Change-Id: I56318fe586776940f7e28ca038dad49d24f24f2e
kaldari [Tue, 31 Mar 2015 00:10:49 +0000 (17:10 -0700)]
Adding mobile target to mediawiki.template.mustache
Otherwise we can't use the mustache compiler from MobileFrontend.
Change-Id: I36ac5478493af32673f2849c122efc24336b7f51
jenkins-bot [Mon, 30 Mar 2015 20:42:21 +0000 (20:42 +0000)]
Merge "EditPage: Remove remnants of pre-1.16 live preview"
jenkins-bot [Mon, 30 Mar 2015 20:26:00 +0000 (20:26 +0000)]
Merge "Let extensions add entries to Special:DeletedContributions"
Kunal Mehta [Mon, 30 Mar 2015 20:20:05 +0000 (13:20 -0700)]
Add SpecialLog::getLogTypesOnUser()
So extensions like Renameuser can get the list without having to re-implement
the core list and hook.
Bug: T78575
Change-Id: I47a814ff1ba0b50c8ff891fe7f69d18bd46661a6
This, that and the other [Sun, 29 Mar 2015 09:30:15 +0000 (20:30 +1100)]
Add null check in WikiImporter
This is my code, and it caused fatals in production whenever anyone tried
to import anything :(
This should get rid of the fatals, but obviously this won't fix the
underlying issue of WikiPage::getContent() sometimes returning null. See
the task for more info on that issue.
Bug: T94325
Change-Id: I68ce2288d7d209733bceffe42e1876c7afcd73d3
Kevin Israel [Sun, 1 Mar 2015 12:28:36 +0000 (07:28 -0500)]
EditPage: Remove remnants of pre-1.16 live preview
Change-Id: I6cd0c56f7e934ce43f9bd101bfb5d4ca3d7bdbad
Translation updater bot [Mon, 30 Mar 2015 19:11:00 +0000 (21:11 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: Ifae391b6bf64c3661b1fbf67446de2a15cd2685d
Sumit Asthana [Thu, 5 Mar 2015 10:08:26 +0000 (15:38 +0530)]
Category view modified to use column width
Category view used css media queries to set column count to 3 beyond 768px and
reduces the count to 1 below it. This behaviour has been changed by setting the
column width to 25em and allowing the column number to adjust automatically.
As a result, media queries have been removed.
See https://css-tricks.com/almanac/properties/c/column-width/
Follow up on https://gerrit.wikimedia.org/r/#/c/187952/
Bug: T55130
Change-Id: I20b68dea8f64b2d07866f4aa20ef83941c879697
jenkins-bot [Mon, 30 Mar 2015 18:46:22 +0000 (18:46 +0000)]
Merge "Fix ORDER BY in fixUserRegistration.php"
jenkins-bot [Mon, 30 Mar 2015 18:31:55 +0000 (18:31 +0000)]
Merge "Removed unused parameter from User::checkNewtalk"
jenkins-bot [Mon, 30 Mar 2015 18:31:51 +0000 (18:31 +0000)]
Merge "Made User::getFormerGroups load properly"
Aaron Schulz [Mon, 30 Mar 2015 18:15:01 +0000 (11:15 -0700)]
Removed unused parameter from User::checkNewtalk
Change-Id: I112fc32d9985664ab5edea842f52f62554c082ea
Aaron Schulz [Mon, 30 Mar 2015 18:13:46 +0000 (11:13 -0700)]
Made User::getFormerGroups load properly
Change-Id: I5c752f9446ef78f08c457e9758ebf9e0b79a0c37
jenkins-bot [Mon, 30 Mar 2015 18:13:37 +0000 (18:13 +0000)]
Merge "resourceloader: Throw InvalidArgumentException for invalid constructor arguments"
jenkins-bot [Mon, 30 Mar 2015 18:09:59 +0000 (18:09 +0000)]
Merge "ResourceLoaderImage: Add basic tests"
Bartosz Dziewoński [Mon, 30 Mar 2015 17:09:24 +0000 (19:09 +0200)]
ResourceLoaderImage: Some cleanup, typo fixes and tweaks
Change-Id: If46a15d09c3792758735dedb5e7f89984797a892
Bartosz Dziewoński [Mon, 30 Mar 2015 17:08:55 +0000 (19:08 +0200)]
ResourceLoaderImage: Throw exception if files don't exist
Change-Id: I67eb795f7fc4d35d15feb0717b1b781cbc45f78a
Bartosz Dziewoński [Mon, 30 Mar 2015 16:51:10 +0000 (18:51 +0200)]
resourceloader: Throw InvalidArgumentException for invalid constructor arguments
(But not for exceptions about missing files.)
Per Legoktm's comments on
8edbfb5feb708f80d63f118f9b00eb341278f68a.
Change-Id: I725f846476d2d97d3d820bc22674f7b5aab812bb
Bartosz Dziewoński [Sun, 29 Mar 2015 17:53:47 +0000 (19:53 +0200)]
ResourceLoaderImage: Add basic tests
Also remove some wrappers from ResourceLoaderImageModule tests that
are no longer necessary, since the files they were mocking now exist.
Bug: T86334
Change-Id: If02e58716ce8e6c8327c8939c6c6425bd48bb560
Aaron Schulz [Mon, 30 Mar 2015 16:36:49 +0000 (09:36 -0700)]
Made User::validateCache account for mQuickTouched
Change-Id: I3b733a0221462350f3a24d54ffe814357f379512