From ed776e618ba1f9829329e70133ef07eeceff8072 Mon Sep 17 00:00:00 2001 From: Daniel Friesen Date: Sun, 3 Apr 2011 11:33:10 +0000 Subject: [PATCH] Followup r85229; Drop this unnecessary reference on the user from ChangesList::newFromUser. --- docs/hooks.txt | 2 +- includes/ChangesList.php | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/docs/hooks.txt b/docs/hooks.txt index dc0d8c2fac..3ab877f98a 100644 --- a/docs/hooks.txt +++ b/docs/hooks.txt @@ -803,7 +803,7 @@ $editToken: The user's edit token. 'FetchChangesList': When fetching the ChangesList derivative for a particular user -&$user: User the list is being fetched for +$user: User the list is being fetched for &$skin: Skin object to be used with the list &$list: List object (defaults to NULL, change it to an object instance and return false override the list derivative used) diff --git a/includes/ChangesList.php b/includes/ChangesList.php index ec592ab83c..76005697a5 100644 --- a/includes/ChangesList.php +++ b/includes/ChangesList.php @@ -47,12 +47,12 @@ class ChangesList { * @param $user User to fetch the list class for * @return ChangesList derivative */ - public static function newFromUser( &$user ) { + public static function newFromUser( $user ) { global $wgRequest; $sk = $user->getSkin(); $list = null; - if( wfRunHooks( 'FetchChangesList', array( &$user, &$sk, &$list ) ) ) { + if( wfRunHooks( 'FetchChangesList', array( $user, &$sk, &$list ) ) ) { $new = $wgRequest->getBool( 'enhanced', $user->getOption( 'usenewrc' ) ); return $new ? new EnhancedChangesList( $sk ) : new OldChangesList( $sk ); } else { -- 2.20.1