From dbc51d4a9412774338c55e8d47722c76f3e29d8c Mon Sep 17 00:00:00 2001 From: Fomafix Date: Fri, 8 Sep 2017 11:32:04 +0200 Subject: [PATCH] postEdit: Move MonoBook style to separate file This avoids loading the MonoBook specific style on other skins. The !important is not necessary because the skin sepecific styles are at the end of the file and have a higher priority. Change-Id: I4ba6c8f63b0082ac82260b20202d31d85328aa40 --- resources/Resources.php | 3 +++ .../src/mediawiki.action/mediawiki.action.view.postEdit.less | 5 ----- .../mediawiki.action.view.postEdit.monobook.css | 3 +++ 3 files changed, 6 insertions(+), 5 deletions(-) create mode 100644 resources/src/mediawiki.action/mediawiki.action.view.postEdit.monobook.css diff --git a/resources/Resources.php b/resources/Resources.php index 3a5de66371..f0aa9ecbca 100644 --- a/resources/Resources.php +++ b/resources/Resources.php @@ -1506,6 +1506,9 @@ return [ 'mediawiki.action.view.postEdit' => [ 'scripts' => 'resources/src/mediawiki.action/mediawiki.action.view.postEdit.js', 'styles' => 'resources/src/mediawiki.action/mediawiki.action.view.postEdit.less', + 'skinStyles' => [ + 'monobook' => 'resources/src/mediawiki.action/mediawiki.action.view.postEdit.monobook.css', + ], 'dependencies' => [ 'mediawiki.jqueryMsg', 'mediawiki.notification' diff --git a/resources/src/mediawiki.action/mediawiki.action.view.postEdit.less b/resources/src/mediawiki.action/mediawiki.action.view.postEdit.less index 467928d7e8..e1fa925823 100644 --- a/resources/src/mediawiki.action/mediawiki.action.view.postEdit.less +++ b/resources/src/mediawiki.action/mediawiki.action.view.postEdit.less @@ -24,11 +24,6 @@ } } -// TODO: Move to monobook skin -.skin-monobook .postedit { - top: 6em !important; /* stylelint-disable-line declaration-no-important */ -} - .postedit-faded { opacity: 0; } diff --git a/resources/src/mediawiki.action/mediawiki.action.view.postEdit.monobook.css b/resources/src/mediawiki.action/mediawiki.action.view.postEdit.monobook.css new file mode 100644 index 0000000000..50f0c8a6e0 --- /dev/null +++ b/resources/src/mediawiki.action/mediawiki.action.view.postEdit.monobook.css @@ -0,0 +1,3 @@ +.postedit { + top: 6em; +} -- 2.20.1