From 740b3ac49d529e8154ceb1f25f69f84dbadf4c43 Mon Sep 17 00:00:00 2001 From: River Tarnell Date: Sun, 3 Jul 2005 07:48:04 +0000 Subject: [PATCH] tc_url -> varchar, limit url length --- includes/Parser.php | 2 ++ languages/Language.php | 1 + maintenance/archives/patch-transcache.sql | 8 ++++---- 3 files changed, 7 insertions(+), 4 deletions(-) diff --git a/includes/Parser.php b/includes/Parser.php index 43db09a789..599c10425f 100644 --- a/includes/Parser.php +++ b/includes/Parser.php @@ -2357,6 +2357,8 @@ class Parser $articlename = "Template:" . $title->getDBkey(); $url = str_replace('$1', urlencode($articlename), $interwiki); + if (strlen($url) > 255) + return wfMsg('scarytranscludetoolong'); $text = $this->fetchScaryTemplateMaybeFromCache($url); $this->mIWTransData[] = $text; return ""; diff --git a/languages/Language.php b/languages/Language.php index 1cde939295..d4bc01b23d 100644 --- a/languages/Language.php +++ b/languages/Language.php @@ -2122,6 +2122,7 @@ will expire at $4. # Scary transclusion 'scarytranscludedisabled' => '[Interwiki transcluding is disabled]', 'scarytranscludefailed' => '[Template fetch failed; sorry]', +'scarytranscludetoolong' => '[URL is too long; sorry]', ); diff --git a/maintenance/archives/patch-transcache.sql b/maintenance/archives/patch-transcache.sql index fcc1adadcc..2bdc10cbc4 100644 --- a/maintenance/archives/patch-transcache.sql +++ b/maintenance/archives/patch-transcache.sql @@ -1,7 +1,7 @@ CREATE TABLE /*$wgDBprefix*/transcache ( - tc_url TEXT NOT NULL, - tc_contents TEXT, - tc_time INT NOT NULL, - UNIQUE INDEX tc_url_idx(tc_url(512)) + tc_url VARCHAR(255) NOT NULL, + tc_contents TEXT, + tc_time INT NOT NULL, + UNIQUE INDEX tc_url_idx(tc_url) ); -- 2.20.1