From 73412f53fe8113eebe56818a9cdae7ceaf8f9387 Mon Sep 17 00:00:00 2001 From: Yuriy Shnitkovskiy Date: Tue, 10 Jan 2017 13:02:31 +0200 Subject: [PATCH] Removed deprecated unused method in RedisConnectionPool.php There are no usages of RedisConnectionPool::handleException() in core or extensions so it can safely be removed. Bug: T61113 Change-Id: Icd9ceb394625e9610f5071d13fbfd2760c464870 --- RELEASE-NOTES-1.29 | 2 +- includes/libs/redis/RedisConnectionPool.php | 15 --------------- 2 files changed, 1 insertion(+), 16 deletions(-) diff --git a/RELEASE-NOTES-1.29 b/RELEASE-NOTES-1.29 index 5824909357..e66b9ce579 100644 --- a/RELEASE-NOTES-1.29 +++ b/RELEASE-NOTES-1.29 @@ -168,7 +168,7 @@ changes to languages because of Phabricator reports. * Linker::getInternalLinkAttributes() (deprecated since 1.25) was removed. * Linker::getInternalLinkAttributesObj() (deprecated since 1.25) was removed. * Linker::getLinkAttributesInternal() (deprecated since 1.25) was removed. - +* RedisConnectionPool::handleException (deprecated since 1.23) was removed. == Compatibility == MediaWiki 1.29 requires PHP 5.5.9 or later. There is experimental support for diff --git a/includes/libs/redis/RedisConnectionPool.php b/includes/libs/redis/RedisConnectionPool.php index 49d09a9f6a..7f43436c78 100644 --- a/includes/libs/redis/RedisConnectionPool.php +++ b/includes/libs/redis/RedisConnectionPool.php @@ -319,21 +319,6 @@ class RedisConnectionPool implements LoggerAwareInterface { } } - /** - * The redis extension throws an exception in response to various read, write - * and protocol errors. Sometimes it also closes the connection, sometimes - * not. The safest response for us is to explicitly destroy the connection - * object and let it be reopened during the next request. - * - * @param string $server - * @param RedisConnRef $cref - * @param RedisException $e - * @deprecated since 1.23 - */ - public function handleException( $server, RedisConnRef $cref, RedisException $e ) { - $this->handleError( $cref, $e ); - } - /** * The redis extension throws an exception in response to various read, write * and protocol errors. Sometimes it also closes the connection, sometimes -- 2.20.1