From 6aed4cefdc4ac02672fc5c0ebe64c089354d5050 Mon Sep 17 00:00:00 2001 From: Derick Alangi Date: Thu, 4 Apr 2019 11:27:22 +0100 Subject: [PATCH] resourceloader: Fix return type doc for getSelectors() method So I've checked and this method should return an array and this array specifically is an array of strings (string[]). In addition, remove an irrelevant semicolon after foreach(). Change-Id: Id7dffe882583a7555d87a5b9c409584478c30a8c --- includes/resourceloader/ResourceLoaderImageModule.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/includes/resourceloader/ResourceLoaderImageModule.php b/includes/resourceloader/ResourceLoaderImageModule.php index d06e8ac4c7..9b50d80f69 100644 --- a/includes/resourceloader/ResourceLoaderImageModule.php +++ b/includes/resourceloader/ResourceLoaderImageModule.php @@ -220,7 +220,7 @@ class ResourceLoaderImageModule extends ResourceLoaderModule { /** * Get CSS selector templates used by this module. - * @return string + * @return string[] */ public function getSelectors() { $this->loadFromDefinition(); @@ -428,7 +428,7 @@ class ResourceLoaderImageModule extends ResourceLoaderModule { 'selectorWithVariant', ] as $member ) { $options[$member] = $this->{$member}; - }; + } $summary[] = [ 'options' => $options, -- 2.20.1